coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: soc/intel/mtl: Set HDA subsystem ID during FSP-M
by Paul Menzel (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tim Crawford. Paul Menzel has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82731?usp=email ) Change subject: soc/intel/mtl: Set HDA subsystem ID during FSP-M ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82731/comment/bf1147f3_2b3225a2?us… : PS2, Line 9: Intel introduced a new UPD If you know the FSP(?) version, please add it, or document, what version you used. https://review.coreboot.org/c/coreboot/+/82731/comment/cb29ba5a_065c9474?us… : PS2, Line 12: Please add TEST=. -- To view, visit https://review.coreboot.org/c/coreboot/+/82731?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e668747d99b955b0a3946524c5918d328b8e1d3 Gerrit-Change-Number: 82731 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jun 2024 16:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: acpi/acpi.c: fix XSDT handling on QEMU
by Paul Menzel (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Arthur Heymans, Cliff Huang, Krystian Hebel, Lance Zhao. Paul Menzel has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82698?usp=email ) Change subject: acpi/acpi.c: fix XSDT handling on QEMU ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82698/comment/2caa69f2_e68da849?us… : PS1, Line 9: c2830c9 Should you amend the commit message, please use > Commit c2830c96616c ("acpi.c: Add XSDT on QEMU") … https://review.coreboot.org/c/coreboot/+/82698/comment/3421a950_985d0708?us… : PS1, Line 17: For ease, please add the command line you used for testing. -- To view, visit https://review.coreboot.org/c/coreboot/+/82698?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f38467b7de3f35fc3ec3854a840de8345cd0fe5 Gerrit-Change-Number: 82698 Gerrit-PatchSet: 1 Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Sat, 01 Jun 2024 16:14:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: [test]Makefile.mk: Use Wbad-function-cast command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Julius Werner. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82735?usp=email ) Change subject: [test]Makefile.mk: Use Wbad-function-cast command option ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: maybe this needs some changes: in src/include/console/uart.h: `static inline void *uart_platform_baseptr(unsigned int idx)` to `static inline uintptr_t uart_platform_baseptr(unsigned int idx)` same for cbmem_top in 'src/include/cbmem.h to `uintptr_t cbmem_top(void);` -- To view, visit https://review.coreboot.org/c/coreboot/+/82735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Gerrit-Change-Number: 82735 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 01 Jun 2024 15:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: [test]Makefile.mk: Use Wbad-function-cast command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Julius Werner. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82735?usp=email ) Change subject: [test]Makefile.mk: Use Wbad-function-cast command option ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/82735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Gerrit-Change-Number: 82735 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 01 Jun 2024 15:00:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: intelvbtupgrader: New tool to upgrade VBT files to newer versions
by Vladimir Serbinenko (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Nicholas Chin. Vladimir Serbinenko has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/82722?usp=email ) Change subject: intelvbtupgrader: New tool to upgrade VBT files to newer versions ...................................................................... Patch Set 7: (1 comment) Patchset: PS4: > Could you also add a `description. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie677403898b7b8ab9f57ad77668155bb55188769 Gerrit-Change-Number: 82722 Gerrit-PatchSet: 7 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jun 2024 14:47:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)
by Angel Pons (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Máté Kukri, Nicholas Chin. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email ) Change subject: mb/asrock: Add Z87E-ITX (Haswell) ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81022/comment/ea261532_4bad34f4?us… : PS3, Line 23: DVI Connector is DVI-I, i.e. supports both DVI and VGA. Was this tested with a DVI-to-VGA passive adapter too? File src/mainboard/asrock/z87e-itx/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/81022/comment/ace526ad_9204246e?us… : PS3, Line 12: DP1, : DP2, : DP3, Only one of these is actually needed. Would be easy to tell which one from a coreboot log, with libgfxinit debug enabled, while the DP connector is plugged in. If possible, adding comments about which port is which would be nice. -- To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586 Gerrit-Change-Number: 81022 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jun 2024 14:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: [test]Makefile.mk: Use Wbad-function-cast command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82735?usp=email ) Change subject: [test]Makefile.mk: Use Wbad-function-cast command option ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/82735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Gerrit-Change-Number: 82735 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jun 2024 14:17:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)
by Nicholas Chin (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Angel Pons, Máté Kukri. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email ) Change subject: mb/asrock: Add Z87E-ITX (Haswell) ...................................................................... Patch Set 3: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81022/comment/25230d2b_06564cfc?us… : PS2, Line 14: socketted > nit: socketed (one t) Done File src/mainboard/asrock/z87e-itx/data.vbt: PS2: > How was this file obtained? Dump under Linux? Updated the commit message. File src/mainboard/asrock/z87e-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/81022/comment/06d547a6_b672576b?us… : PS2, Line 4: register "ec_present" = "false" > Any zero/false options can be omitted Done https://review.coreboot.org/c/coreboot/+/81022/comment/0c2eb8f5_89f22fb6?us… : PS2, Line 10: register "panel_cfg" = "{ : .up_delay_ms = 0, : .down_delay_ms = 0, : .cycle_delay_ms = 500, : .backlight_on_delay_ms = 0, : .backlight_off_delay_ms = 0, : .backlight_pwm_hz = 0, : }" > There's no panel on this board Done File src/mainboard/asrock/z87e-itx/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/81022/comment/3ad70cac_ba581b36?us… : PS2, Line 20: LVDS, : eDP > Replace these two with `others => Disabled` Done File src/mainboard/asrock/z87e-itx/romstage.c: https://review.coreboot.org/c/coreboot/+/81022/comment/f13c33cf_87a853ac?us… : PS2, Line 12: /* FIXME: called after romstage_common, remove it if not used */ > I guess try removing this? Done https://review.coreboot.org/c/coreboot/+/81022/comment/192d1196_cd87d7a1?us… : PS2, Line 19: /* FIXME: check this */ > It's most likely 0x50 and 0x52, the first slot of each channel. Done https://review.coreboot.org/c/coreboot/+/81022/comment/a0627ab0_7331d30e?us… : PS2, Line 27: /* FIXME: Length and Location are computed from IOBP values, may be inaccurate */ > If all USB ports work, remove the FIXME? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586 Gerrit-Change-Number: 81022 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jun 2024 13:40:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)
by Nicholas Chin (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Angel Pons, Máté Kukri, Nicholas Chin. Hello Angel Pons, Máté Kukri, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81022?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Angel Pons, Code-Review+1 by Máté Kukri, Verified-1 by build bot (Jenkins) Change subject: mb/asrock: Add Z87E-ITX (Haswell) ...................................................................... mb/asrock: Add Z87E-ITX (Haswell) This was done using Haswell autoport, with manual fixes to get the output to build against current main. I do not physically have this board; I was sent the output of autoport with some fixes on top of which I added additional changes. The VBT was copied from /sys/kernel/debug/dri/0/i915_vbt on version 2.70 of the vendor firmware. The flash chip is 8MiB in a socketed DIP8 package, making it easy to externally flash to recover from a brick. Working: - Haswell MRC.bin - S3 suspend and resume - Libgfxinit - HDMI - DVI - DisplayPort - SATA ports - mSATA SSD - mPCIe WiFi slot - Rear USB ports - USB 3.0 header - Audio header - Ethernet - x16 PCIe slot - EHCI debug with the CH347 (top USB 2.0 port by the PS/2 connector) - edk2 (MrChromebox uefipayload_202309) Not Tested: - PS/2 keyboard/mouse - eSATA - USB 2.0 header Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- A src/mainboard/asrock/z87e-itx/Kconfig A src/mainboard/asrock/z87e-itx/Kconfig.name A src/mainboard/asrock/z87e-itx/Makefile.mk A src/mainboard/asrock/z87e-itx/acpi/ec.asl A src/mainboard/asrock/z87e-itx/acpi/platform.asl A src/mainboard/asrock/z87e-itx/acpi/superio.asl A src/mainboard/asrock/z87e-itx/board_info.txt A src/mainboard/asrock/z87e-itx/bootblock.c A src/mainboard/asrock/z87e-itx/data.vbt A src/mainboard/asrock/z87e-itx/devicetree.cb A src/mainboard/asrock/z87e-itx/dsdt.asl A src/mainboard/asrock/z87e-itx/gma-mainboard.ads A src/mainboard/asrock/z87e-itx/gpio.c A src/mainboard/asrock/z87e-itx/hda_verb.c A src/mainboard/asrock/z87e-itx/romstage.c 15 files changed, 512 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/81022/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586 Gerrit-Change-Number: 81022 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/razer/blade_stealth_kbl: add panel_cfg
by Reagan (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Nico Huber, Paul Menzel. Reagan has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82458?usp=email ) Change subject: mb/razer/blade_stealth_kbl: add panel_cfg ...................................................................... Patch Set 18: (1 comment) File src/mainboard/razer/blade_stealth_kbl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/82458/comment/feb950c2_e1e23aa8?us… : PS13, Line 163: .backlight_off_delay_ms = 5000, /* T12 */ > Well, that's what I meant with the mapping being wrong. `down_delay_ms` *is* T10 […] Right, I understand now - apologies for the silly mistake! -- To view, visit https://review.coreboot.org/c/coreboot/+/82458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c8b26ffb7a70d08655986084a714206d9d0c96a Gerrit-Change-Number: 82458 Gerrit-PatchSet: 18 Gerrit-Owner: Reagan <xbjfk.github(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 01 Jun 2024 12:12:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Reagan <xbjfk.github(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024