coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[S] Change in coreboot[main]: mb/razer/blade_stealth_kbl: add panel_cfg
by Reagan (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Paul Menzel, Reagan. Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82458?usp=email to look at the new patch set (#18). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/razer/blade_stealth_kbl: add panel_cfg ...................................................................... mb/razer/blade_stealth_kbl: add panel_cfg This commit defines the panel_cfg register for the Razer Blade Stealth (Kaby Lake). This enables libgfxinit support. These values are derived from the stock firmware. First, VBIOSes were extracted from the stock firmware. Then, intelvbtool was used to extract the VBT from each of the VBIOS tables. Finally, intel_vbt_decode from igt-gpu-tools was used to extract the register values. Although there were multiple VBIOSes present in the firmware, all VBIOSes across both firmwares (on version 1.50 for the H2U and 8.02 for the H3Q) had the same register values. Change-Id: I4c8b26ffb7a70d08655986084a714206d9d0c96a Signed-off-by: Reagan Bohan <xbjfk.github(a)gmail.com> --- M src/mainboard/razer/blade_stealth_kbl/devicetree.cb 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/82458/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/82458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c8b26ffb7a70d08655986084a714206d9d0c96a Gerrit-Change-Number: 82458 Gerrit-PatchSet: 18 Gerrit-Owner: Reagan <xbjfk.github(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reagan <xbjfk.github(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/razer/blade_stealth_kbl: Add H3Q variant
by Reagan (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Felix Singer, Paul Menzel. Reagan has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82506?usp=email ) Change subject: mb/razer/blade_stealth_kbl: Add H3Q variant ...................................................................... Patch Set 10: (1 comment) File src/mainboard/razer/blade_stealth_kbl/variants/h3q/include/variant/gpio.h: https://review.coreboot.org/c/coreboot/+/82506/comment/20a83a26_e01c4a36?us… : PS10, Line 8: /* Pad configuration was generated automatically using intelp2m utility */ > There's a suspiciously huge amount of GPO's. Just wondering, did you confirm […] Yes, I used intelp2m and inteltool -g. Also the number of NC pads is the same as the other variant. I have no idea why there are so many enabled. -- To view, visit https://review.coreboot.org/c/coreboot/+/82506?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I493a651e52c2eb938daa67a05e9caaa784020fa4 Gerrit-Change-Number: 82506 Gerrit-PatchSet: 10 Gerrit-Owner: Reagan <xbjfk.github(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sat, 01 Jun 2024 11:59:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>

1 0

[S] Change in coreboot[main]: it8728f: Support setting power state after power failure
by Vladimir Serbinenko (Code Review) 01 Jun '24

01 Jun '24

Vladimir Serbinenko has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82737?usp=email ) Change subject: it8728f: Support setting power state after power failure ...................................................................... it8728f: Support setting power state after power failure Tested on GA-H61M-S2PV Change-Id: I3dcc4f032bc5f629fb916c4122beb8dc096bab20 Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- M src/superio/ite/it8728f/superio.c 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/82737/1 diff --git a/src/superio/ite/it8728f/superio.c b/src/superio/ite/it8728f/superio.c index 5e4c2fd..b5aed23 100644 --- a/src/superio/ite/it8728f/superio.c +++ b/src/superio/ite/it8728f/superio.c @@ -5,14 +5,21 @@ #include <superio/conf_mode.h> #include <pc80/keyboard.h> #include <superio/ite/common/env_ctrl.h> +#include <option.h> #include "chip.h" #include "it8728f.h" +#define MAINBOARD_POWER_OFF 0 +#define MAINBOARD_POWER_ON 1 +#define MAINBOARD_POWER_KEEP 2 + static void it8728f_init(struct device *dev) { const struct superio_ite_it8728f_config *conf = dev->chip_info; const struct resource *res; + uint8_t power_status; + uint8_t byte_f2, byte_f4; if (!dev->enabled) return; @@ -24,6 +31,28 @@ if (!conf || !res) break; ite_ec_init(res->base, &conf->ec); + + /* Set power state after power fail */ + power_status = get_uint_option("power_on_after_fail", + CONFIG_MAINBOARD_POWER_FAILURE_STATE); + pnp_enter_conf_mode(dev); + pnp_set_logical_device(dev); + byte_f4 = pnp_read_config(dev, 0xf4); + byte_f2 = pnp_read_config(dev, 0xf2); + if (power_status == MAINBOARD_POWER_ON) + byte_f4 |= 0x20; + else if (power_status == MAINBOARD_POWER_KEEP) { + byte_f4 &= ~0x20; + byte_f2 |= 0x20; + } else { + byte_f4 &= ~0x20; + byte_f2 &= ~0x20; + } + pnp_write_config(dev, 0xf4, byte_f4); + pnp_write_config(dev, 0xf2, byte_f2); + pnp_exit_conf_mode(dev); + printk(BIOS_INFO, "set power %d after power fail\n", power_status); + break; case IT8728F_KBCK: set_kbc_ps2_mode(); -- To view, visit https://review.coreboot.org/c/coreboot/+/82737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3dcc4f032bc5f629fb916c4122beb8dc096bab20 Gerrit-Change-Number: 82737 Gerrit-PatchSet: 1 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com>

1 0

[XS] Change in coreboot[main]: [test]Makefile.mk: Use Wbad-function-cast command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82735?usp=email to look at the new patch set (#3). Change subject: [test]Makefile.mk: Use Wbad-function-cast command option ...................................................................... [test]Makefile.mk: Use Wbad-function-cast command option Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk M src/include/console/uart.h 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/82735/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Gerrit-Change-Number: 82735 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Wbad-function-cast command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82735?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Makefile.mk: Use Wbad-function-cast command option ...................................................................... Makefile.mk: Use Wbad-function-cast command option Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk M src/include/console/uart.h 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/82735/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Gerrit-Change-Number: 82735 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)
by Angel Pons (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Máté Kukri, Nicholas Chin. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email ) Change subject: mb/asrock: Add Z87E-ITX (Haswell) ...................................................................... Patch Set 2: (1 comment) File src/mainboard/asrock/z87e-itx/hda_verb.c: https://review.coreboot.org/c/coreboot/+/81022/comment/e328788e_3c841b85?us… : PS2, Line 20: > I thought Haswell already incorporates HDA verbs for the Mini-HD in chipset code It does, so no need to add the Mini-HD verbs here. I don't think any of the Haswell boards have them (and if they do, it's probably an oversight while porting). https://github.com/coreboot/coreboot/blob/f38c9407549b70bf813248c1958d38923… -- To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586 Gerrit-Change-Number: 81022 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jun 2024 08:36:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Wcast-function-type command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82736?usp=email ) Change subject: Makefile.mk: Use Wcast-function-type command option ...................................................................... Makefile.mk: Use Wcast-function-type command option Change-Id: I25415d7fd82879889ffaa1bb534ad5d0b174854e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/82736/1 diff --git a/Makefile.mk b/Makefile.mk index 04e58ab..6c7a5d0 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -499,7 +499,7 @@ CFLAGS_common += -Wdangling-else -Wmissing-include-dirs -Wbad-function-cast CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie -CFLAGS_common += -Wstring-compare +CFLAGS_common += -Wstring-compare -Wcast-function-type ifeq ($(CONFIG_COMPILER_GCC),y) CFLAGS_common += -Wold-style-declaration -Wflex-array-member-not-at-end CFLAGS_common += -Wcalloc-transposed-args -Walloc-size -- To view, visit https://review.coreboot.org/c/coreboot/+/82736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25415d7fd82879889ffaa1bb534ad5d0b174854e Gerrit-Change-Number: 82736 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Wbad-function-cast command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82735?usp=email ) Change subject: Makefile.mk: Use Wbad-function-cast command option ...................................................................... Makefile.mk: Use Wbad-function-cast command option Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/82735/1 diff --git a/Makefile.mk b/Makefile.mk index 947fb8a..04e58ab 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -496,7 +496,7 @@ CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla -Wold-style-definition -CFLAGS_common += -Wdangling-else -Wmissing-include-dirs +CFLAGS_common += -Wdangling-else -Wmissing-include-dirs -Wbad-function-cast CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie CFLAGS_common += -Wstring-compare -- To view, visit https://review.coreboot.org/c/coreboot/+/82735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7981230009ac93aa42911eab923dbcffeac25232 Gerrit-Change-Number: 82735 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Enable USB2 port reset message on Type-C ports
by Subrata Banik (Code Review) 01 Jun '24

01 Jun '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeremy Soller, Kapil Porwal, Tarun, Tim Crawford. Subrata Banik has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82730?usp=email ) Change subject: soc/intel/meteorlake: Enable USB2 port reset message on Type-C ports ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82730?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iac702a8d8edd2b3b7e03abcac020be7e45335821 Gerrit-Change-Number: 82730 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 01 Jun 2024 08:11:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Walloc-size command option
by Elyes Haouas (Code Review) 01 Jun '24

01 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email ) Change subject: Makefile.mk: Use Walloc-size command option ...................................................................... Makefile.mk: Use Walloc-size command option Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/82734/1 diff --git a/Makefile.mk b/Makefile.mk index e406702..947fb8a 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -502,7 +502,7 @@ CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) CFLAGS_common += -Wold-style-declaration -Wflex-array-member-not-at-end -CFLAGS_common += -Wcalloc-transposed-args +CFLAGS_common += -Wcalloc-transposed-args -Walloc-size # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned -- To view, visit https://review.coreboot.org/c/coreboot/+/82734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Gerrit-Change-Number: 82734 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024