Attention is currently required from: Martin L Roth, Maximilian Brune.
Felix Singer has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83124?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Makefile: update clean-symlink target
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83124/comment/de7391e5_1ad1ecd4?us… :
PS1, Line 9: ued
used?
https://review.coreboot.org/c/coreboot/+/83124/comment/4a808618_a559b9b8?us… :
PS1, Line 14: fies
files
--
To view, visit https://review.coreboot.org/c/coreboot/+/83124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife0e7cf1b856b7394cd5e1de9b35856bd984663c
Gerrit-Change-Number: 83124
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Thu, 27 Jun 2024 18:02:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass, Simon Glass.
Felix Held has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )
Change subject: Introduce a coreboot Control Block (CCB)
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
> when using fmap, you'll have the start and size of all sections as defines in a generated header fil […]
and yes, i do see value in having the ccb as an optional mechanism; my concerns are about how the data is stored/retrieved
--
To view, visit https://review.coreboot.org/c/coreboot/+/77712?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613
Gerrit-Change-Number: 77712
Gerrit-PatchSet: 10
Gerrit-Owner: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 27 Jun 2024 17:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Simon Glass <sjg(a)chromium.org>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass, Simon Glass.
Felix Held has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )
Change subject: Introduce a coreboot Control Block (CCB)
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
> We did discuss the various configuration mechanisms available... […]
when using fmap, you'll have the start and size of all sections as defines in a generated header file, so those are a fixed locations. with using this you have the ease of use of a fixed flash offset in the code and not need to walk some data structure while using already existing and proven coreboot infrastructure instead of adding some hack.
have a look at build/fmap_config.h after running a build; i'm rather sure that that should exactly provide what you need. only thing to make sure is that the corresponding fmap partition is inside of the part of the flash that gets mmio-mapped without much additional setup.
when there's some infrastructure that can easily do what's needed, i'm rather strongly opposed to reinventing the wheel
--
To view, visit https://review.coreboot.org/c/coreboot/+/77712?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613
Gerrit-Change-Number: 77712
Gerrit-PatchSet: 10
Gerrit-Owner: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 27 Jun 2024 17:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Simon Glass <sjg(a)chromium.org>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Jian Tong, Kun Liu, Paul Menzel, Subrata Banik.
Felix Held has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
Change subject: drivers/spi/acpi: Add generic property list
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/spi/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/83139/comment/70443b2a_472c1bfe?us… :
PS8, Line 152: acpi_dp_add_property_list(dsd, config->property_list,
> That function handles property_count of 0 […]
you're right; seems that i looked at the wrong function
--
To view, visit https://review.coreboot.org/c/coreboot/+/83139?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8
Gerrit-Change-Number: 83139
Gerrit-PatchSet: 8
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 27 Jun 2024 16:46:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Dinesh Gehlot, Felix Held, Nick Vaccaro, Paul Menzel, Poornima Tom, V Sowmya.
Subrata Banik has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83138?usp=email )
Change subject: mb/google/nissa/var/nivviks: Update config for CNVi
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83138/comment/dad4d52a_d353c4f8?us… :
PS3, Line 9: Also, set 'add_acpi_dma_property' to
: true.
:
> see https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie…
> not sure if this needs more explanation in the commit message. maybe "set 'add_acpi_dma_property' to true to tell the OS to enforce DMA protection for this device"
@poornima.tom@intel.com, can you please add "set 'add_acpi_dma_property' to true to tell the OS to enforce DMA protection for this device" as suggested by Felix?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83138?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If04539fe8dceb5c2edfc06a324ede11147b78b6d
Gerrit-Change-Number: 83138
Gerrit-PatchSet: 4
Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com>
Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 27 Jun 2024 16:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Paul Menzel, Poornima Tom, V Sowmya.
Felix Held has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83138?usp=email )
Change subject: mb/google/nissa/var/nivviks: Update config for CNVi
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83138/comment/d6333bc2_afaac5ab?us… :
PS3, Line 9: Added
> Add
Done
https://review.coreboot.org/c/coreboot/+/83138/comment/7551ae6e_394a3109?us… :
PS3, Line 9: Also, set 'add_acpi_dma_property' to
: true.
:
> Why?
see https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie…
not sure if this needs more explanation in the commit message. maybe "set 'add_acpi_dma_property' to true to tell the OS to enforce DMA protection for this device"
--
To view, visit https://review.coreboot.org/c/coreboot/+/83138?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If04539fe8dceb5c2edfc06a324ede11147b78b6d
Gerrit-Change-Number: 83138
Gerrit-PatchSet: 4
Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com>
Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 Jun 2024 16:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Julius Werner, Martin L Roth.
Hello Jakub Czapiga, Julius Werner, Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83157?usp=email
to look at the new patch set (#7).
Change subject: Documentation: Use pkgconf over pkg-config
......................................................................
Documentation: Use pkgconf over pkg-config
Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Documentation/tutorial/part1.md
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/83157/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/83157?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8
Gerrit-Change-Number: 83157
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Julius Werner, Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email )
Change subject: tree: Use pkgconf over pkg-config
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83157/comment/28bdaac7_24ce94ae?us… :
PS5, Line 7: tree: Use pkgconf over pkg-config
> pkgconf is supposed to be fully backwards-compatible to pkg-config. […]
indeed to /usr/local/bin/pkg-config
let keep using the old one, but probably the documentation needs an update
--
To view, visit https://review.coreboot.org/c/coreboot/+/83157?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8
Gerrit-Change-Number: 83157
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 Jun 2024 15:55:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Felix Held, Jian Tong, Kun Liu, Paul Menzel, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
Change subject: drivers/spi/acpi: Add generic property list
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/spi/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/83139/comment/774c8186_fd2b8ece?us… :
PS8, Line 152: acpi_dp_add_property_list(dsd, config->property_list,
> shouldn't this function only be called when config->property_count is 0 or is it intended that this […]
That function handles property_count of 0
```
for (i = 0; i < property_count; i++) {
...
}
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83139?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8
Gerrit-Change-Number: 83139
Gerrit-PatchSet: 8
Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 27 Jun 2024 15:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>