coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[XS] Change in coreboot[main]: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
by Felix Held (Code Review) 27 May '24

27 May '24

Attention is currently required from: Cliff Huang, Elyes Haouas, Eric Lai, Jérémy Compostella, Lance Zhao, Nico Huber, Tim Wawrzynczak. Hello Cliff Huang, Elyes Haouas, Eric Lai, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82642?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Elyes Haouas, Code-Review+2 by Eric Lai, Verified+1 by build bot (Jenkins) Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option ...................................................................... acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option Apollo Lake SoC is the only SoC that selects ACPI_NO_PCAT_8259 and ACPI_HAVE_PCAT_8259 was automatically selected when ACPI_NO_PCAT_8259 wasn't selected, so drop the ACPI_HAVE_PCAT_8259 Kconfig option and use ACPI_NO_PCAT_8259 in the code instead. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2 --- M src/acpi/Kconfig M src/acpi/acpi_apic.c M src/arch/x86/acpi.c 3 files changed, 3 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/82642/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2 Gerrit-Change-Number: 82642 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: acpi/acpi_apic: use generic MADT IRQ override function for SCI override
by Felix Held (Code Review) 27 May '24

27 May '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82644?usp=email ) Change subject: acpi/acpi_apic: use generic MADT IRQ override function for SCI override ...................................................................... acpi/acpi_apic: use generic MADT IRQ override function for SCI override Call acpi_create_madt_irqoverride from acpi_create_madt_sci_override with the correct parameters instead or re-implementing the same functionality. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I7e6ee0eed837c2d46da62092b7cc5669dc177d8d Reviewed-on: https://review.coreboot.org/c/coreboot/+/82644 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/acpi/acpi_apic.c 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index ebff44f..b47586d 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -130,14 +130,7 @@ if (!CONFIG(ACPI_HAVE_PCAT_8259)) irq = gsi; - irqoverride->type = IRQ_SOURCE_OVERRIDE; /* Interrupt source override */ - irqoverride->length = sizeof(acpi_madt_irqoverride_t); - irqoverride->bus = MP_BUS_ISA; - irqoverride->source = irq; - irqoverride->gsirq = gsi; - irqoverride->flags = flags; - - return irqoverride->length; + return acpi_create_madt_irqoverride(irqoverride, MP_BUS_ISA, irq, gsi, flags); } static unsigned long acpi_create_madt_ioapic_gsi0_default(unsigned long current) -- To view, visit https://review.coreboot.org/c/coreboot/+/82644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e6ee0eed837c2d46da62092b7cc5669dc177d8d Gerrit-Change-Number: 82644 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
by Felix Held (Code Review) 27 May '24

27 May '24

Attention is currently required from: Cliff Huang, Jérémy Compostella, Lance Zhao, Nico Huber, Tim Wawrzynczak. Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email ) Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82642/comment/6fc3031d_d2803336?us… : PS1, Line 7: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option > Why? […] hmm, that's a good point that i didn't think about. since only one soc selects ACPI_NO_PCAT_8259, removing that one and having all other socs select ACPI_HAVE_PCAT_8259 isn't a good option either, so maybe it would be best to just keep some slight duplication in the kconfig. i'll rebase this one on top of the other two patches to land those two; don't have a super strong opinion on whether to drop this one or not -- To view, visit https://review.coreboot.org/c/coreboot/+/82642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2 Gerrit-Change-Number: 82642 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 27 May 2024 12:37:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 27 May '24

27 May '24

Attention is currently required from: Maciej Pijanowski, Michał Żygowski. Hello Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82672?usp=email to look at the new patch set (#7). Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... ec/dasharo/ec: add Dasharo features - EC firmware update in ramstage - Setting battery thresholds - PEP hooks for S0ix - Remove unused keyboard backlight, OLED, FCMD, ACPI power button device Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/ec/dasharo/ec/Kconfig M src/ec/dasharo/ec/Makefile.mk A src/ec/dasharo/ec/acpi.h M src/ec/dasharo/ec/acpi/buttons.asl A src/ec/dasharo/ec/acpi/dasharo.asl M src/ec/dasharo/ec/acpi/ec.asl M src/ec/dasharo/ec/acpi/ec_ram.asl M src/ec/dasharo/ec/acpi/lid.asl D src/ec/dasharo/ec/acpi/s76.asl A src/ec/dasharo/ec/buttons.c A src/ec/dasharo/ec/commands.h M src/ec/dasharo/ec/dasharo_ec.c M src/ec/dasharo/ec/dasharo_ec.h D src/ec/dasharo/ec/smbios.c 14 files changed, 899 insertions(+), 314 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/82672/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 27 May '24

27 May '24

Attention is currently required from: Maciej Pijanowski, Michał Żygowski. Hello Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82672?usp=email to look at the new patch set (#6). Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... ec/dasharo/ec: add Dasharo features - EC firmware update in ramstage - Setting battery thresholds - PEP hooks for S0ix - Remove unused keyboard backlight, OLED, FCMD, ACPI power button device Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/ec/dasharo/ec/Kconfig M src/ec/dasharo/ec/Makefile.mk A src/ec/dasharo/ec/acpi.h M src/ec/dasharo/ec/acpi/buttons.asl A src/ec/dasharo/ec/acpi/dasharo.asl M src/ec/dasharo/ec/acpi/ec.asl M src/ec/dasharo/ec/acpi/ec_ram.asl M src/ec/dasharo/ec/acpi/lid.asl D src/ec/dasharo/ec/acpi/s76.asl A src/ec/dasharo/ec/buttons.c A src/ec/dasharo/ec/commands.h M src/ec/dasharo/ec/dasharo_ec.c M src/ec/dasharo/ec/dasharo_ec.h D src/ec/dasharo/ec/smbios.c 14 files changed, 899 insertions(+), 314 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/82672/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>

1 0

[XL] Change in coreboot[main]: mb/novacustom: add V5x0TU board (Meteor Lake)
by Michał Kopeć (Code Review) 27 May '24

27 May '24

Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Michał Żygowski. Hello Maciej Pijanowski, Michał Żygowski, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82673?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/novacustom: add V5x0TU board (Meteor Lake) ...................................................................... mb/novacustom: add V5x0TU board (Meteor Lake) NovaCustom (Clevo) V5x0TU are two boards with Intel Core Ultra (Meteor Lake) series processors. Two variants (V540TU and V560TU) are supported. Their EC firmware is different due to keyboard layout changes. On coreboot's side, the only difference are SMBIOS strings. Working: - DDR5 SODIMM in slot RAM2 - M.2 2280 PCIe slots - Thunderbolt, USB ports - Onboard audio - Video outputs in OS and firmware - I2C touchpad, webcam, SD Card reader - S0ix - Booting Ubuntu 24.04 with edk2 UefiPayload - Vboot, TPM measured boot Not working: - DDR5 SODIMM in slot RAM1 - PS/2 keyboard in edk2 Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771 Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- A src/mainboard/novacustom/Kconfig A src/mainboard/novacustom/Kconfig.name A src/mainboard/novacustom/mtl-h/Kconfig A src/mainboard/novacustom/mtl-h/Kconfig.name A src/mainboard/novacustom/mtl-h/Makefile.mk A src/mainboard/novacustom/mtl-h/acpi/backlight.asl A src/mainboard/novacustom/mtl-h/acpi/mainboard.asl A src/mainboard/novacustom/mtl-h/board_info.txt A src/mainboard/novacustom/mtl-h/bootblock.c A src/mainboard/novacustom/mtl-h/cmos.default A src/mainboard/novacustom/mtl-h/cmos.layout A src/mainboard/novacustom/mtl-h/data.vbt A src/mainboard/novacustom/mtl-h/devicetree.cb A src/mainboard/novacustom/mtl-h/dsdt.asl A src/mainboard/novacustom/mtl-h/fadt.c A src/mainboard/novacustom/mtl-h/gpio.c A src/mainboard/novacustom/mtl-h/gpio_early.c A src/mainboard/novacustom/mtl-h/hda_verb.c A src/mainboard/novacustom/mtl-h/include/mainboard/gpio.h A src/mainboard/novacustom/mtl-h/ramstage.c A src/mainboard/novacustom/mtl-h/romstage.c A src/mainboard/novacustom/mtl-h/vboot-rwab.fmd 22 files changed, 1,401 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/82673/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/82673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I82c73ddb1e76a9baf9b97e13124aa249ae1c2771 Gerrit-Change-Number: 82673 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>

1 0

[L] Change in coreboot[main]: mb/cwwk: Add CWWK CW-ADL-4L-V1.0 board
by Paul Menzel (Code Review) 27 May '24

27 May '24

Paul Menzel has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email ) Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V1.0 board ...................................................................... Patch Set 13: (1 comment) File src/mainboard/cwwk/adl/Kconfig: https://review.coreboot.org/c/coreboot/+/81595/comment/de1fb58d_f3b5f2dc?us… : PS10, Line 9: select HAVE_ACPI_RESUME > Ack Just a note, that `/sys/kernel/debug/pmc_core/slp_s0_residency_usec` stays 0 on my Dell XPS 13 9360 with Intel Kaby Lake (i7-7500U). It changes on a Dell XPS 9370 with Intel Kaby Lake R (i5-8350U). But as you use Alder Lake, it might be unrelated. -- To view, visit https://review.coreboot.org/c/coreboot/+/81595?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice9174d95c10afc6a22ddd15fb3be4fa38d329be Gerrit-Change-Number: 81595 Gerrit-PatchSet: 13 Gerrit-Owner: Brandon Weeks <bweeks(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Federico Amedeo Izzo <federico(a)izzo.pro> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-CC: Matthew Garrett <mjgarrett59(a)googlemail.com> Gerrit-Comment-Date: Mon, 27 May 2024 12:22:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Brandon Weeks <bweeks(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 27 May '24

27 May '24

Attention is currently required from: Maciej Pijanowski, Michał Żygowski. Hello Maciej Pijanowski, Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82672?usp=email to look at the new patch set (#5). Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... ec/dasharo/ec: add Dasharo features - EC firmware update in ramstage - Setting battery thresholds - PEP hooks for S0ix - Remove unused keyboard backlight, OLED, FCMD, ACPI power button device Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/ec/dasharo/ec/Kconfig M src/ec/dasharo/ec/Makefile.mk A src/ec/dasharo/ec/acpi.h M src/ec/dasharo/ec/acpi/buttons.asl A src/ec/dasharo/ec/acpi/dasharo.asl M src/ec/dasharo/ec/acpi/ec.asl M src/ec/dasharo/ec/acpi/ec_ram.asl M src/ec/dasharo/ec/acpi/lid.asl D src/ec/dasharo/ec/acpi/s76.asl A src/ec/dasharo/ec/buttons.c A src/ec/dasharo/ec/commands.h M src/ec/dasharo/ec/dasharo_ec.c M src/ec/dasharo/ec/dasharo_ec.h D src/ec/dasharo/ec/smbios.c 14 files changed, 899 insertions(+), 313 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/82672/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 27 May '24

27 May '24

Attention is currently required from: Jeremy Soller, Maciej Pijanowski, Michał Żygowski, Tim Crawford. Hello Jeremy Soller, Maciej Pijanowski, Michał Żygowski, Tim Crawford, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82672?usp=email to look at the new patch set (#4). Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... ec/dasharo/ec: add Dasharo features - EC firmware update in ramstage - Setting battery thresholds - PEP hooks for S0ix - Remove unused keyboard backlight, OLED, FCMD, ACPI power button device Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/ec/dasharo/ec/Kconfig M src/ec/dasharo/ec/Makefile.mk A src/ec/dasharo/ec/acpi.h M src/ec/dasharo/ec/acpi/buttons.asl A src/ec/dasharo/ec/acpi/dasharo.asl M src/ec/dasharo/ec/acpi/ec.asl M src/ec/dasharo/ec/acpi/ec_ram.asl M src/ec/dasharo/ec/acpi/lid.asl D src/ec/dasharo/ec/acpi/s76.asl A src/ec/dasharo/ec/buttons.c A src/ec/dasharo/ec/commands.h M src/ec/dasharo/ec/dasharo_ec.c M src/ec/dasharo/ec/dasharo_ec.h D src/ec/dasharo/ec/smbios.c 14 files changed, 899 insertions(+), 313 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/82672/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add Dasharo features
by Michał Kopeć (Code Review) 27 May '24

27 May '24

Attention is currently required from: Maciej Pijanowski, Michał Żygowski. Hello Maciej Pijanowski, Michał Żygowski, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82672?usp=email to look at the new patch set (#3). Change subject: ec/dasharo/ec: add Dasharo features ...................................................................... ec/dasharo/ec: add Dasharo features - EC firmware update in ramstage - Setting battery thresholds - PEP hooks for S0ix - Remove unused keyboard backlight, OLED, FCMD, ACPI power button device Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- M src/ec/dasharo/ec/Kconfig M src/ec/dasharo/ec/Makefile.mk A src/ec/dasharo/ec/acpi.h A src/ec/dasharo/ec/acpi/dasharo.asl M src/ec/dasharo/ec/acpi/ec.asl M src/ec/dasharo/ec/acpi/ec_ram.asl M src/ec/dasharo/ec/acpi/lid.asl D src/ec/dasharo/ec/acpi/s76.asl A src/ec/dasharo/ec/buttons.c A src/ec/dasharo/ec/commands.h M src/ec/dasharo/ec/dasharo_ec.c M src/ec/dasharo/ec/dasharo_ec.h D src/ec/dasharo/ec/smbios.c M src/ec/system76/ec/acpi/buttons.asl 14 files changed, 899 insertions(+), 313 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/82672/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d Gerrit-Change-Number: 82672 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024