coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[S] Change in coreboot[main]: util/lint: Warn when <stddef.h> is included but not used
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Attention is currently required from: Martin L Roth. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82670?usp=email ) Change subject: util/lint: Warn when <stddef.h> is included but not used ...................................................................... util/lint: Warn when <stddef.h> is included but not used Change-Id: I49bca3406290a9c3667b54eaa4fb1ffa581302ef Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- A util/lint/lint-stable-033-stddef-h 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/82670/1 diff --git a/util/lint/lint-stable-033-stddef-h b/util/lint/lint-stable-033-stddef-h new file mode 100755 index 0000000..46d1ed2 --- /dev/null +++ b/util/lint/lint-stable-033-stddef-h @@ -0,0 +1,41 @@ +#!/usr/bin/env sh +# SPDX-License-Identifier: GPL-2.0-or-later +# +# DESCR: Verify if <stddef.h> is needed in modified files +# + +# Get the list of modified files +MODIFIED_FILES=$(git diff --cached --name-only --diff-filter=ACM | grep -E '\.c$|\.h$') +if [ -z "$MODIFIED_FILES" ]; then + exit 0 +fi + +# Create temporary files to hold the lists +TMP_INCLUDE=$(mktemp) +TMP_FUNCTIONS=$(mktemp) + +# Find files including <stddef.h> +for file in $MODIFIED_FILES; do + if grep -q '#include <stddef.h>' "$file"; then + echo "$file" >> "$TMP_INCLUDE" + fi +done + +# Find files using stddef.h functions +for file in $MODIFIED_FILES; do + if grep -q 'ptrdiff_t\|size_t\|SIZE_MAX\|ssize_t\|wchar_t\|wint_t\|NULL\|DEVTREE_EARLY\|zeroptr' "$file"; then + echo "$file" >> "$TMP_FUNCTIONS" + fi +done + +# Compare the two lists +UNNEEDED_INCLUDE=$(comm -23 "$TMP_INCLUDE" "$TMP_FUNCTIONS") + +# Output warnings for unneeded includes +if [ -n "$UNNEEDED_INCLUDE" ]; then + echo "Warning: The following files include <stddef.h> but do not use its functions:" + echo "$UNNEEDED_INCLUDE" +fi + +# Clean up temporary files +rm -f "$TMP_INCLUDE" "$TMP_FUNCTIONS" -- To view, visit https://review.coreboot.org/c/coreboot/+/82670?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49bca3406290a9c3667b54eaa4fb1ffa581302ef Gerrit-Change-Number: 82670 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[S] Change in coreboot[main]: tree: Remove unuse <stddef.h>
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82669?usp=email ) Change subject: tree: Remove unuse <stddef.h> ...................................................................... tree: Remove unuse <stddef.h> Change-Id: I7d7ad562eeff7247b7377b6570d489faee0aeda0 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/drivers/uart/oxpcie_early.c M src/ec/google/chromeec/ec_skuid.c M src/ec/google/chromeec/ec_smbios.c M src/ec/purism/librem-ec/librem_ec.c M src/mainboard/intel/glkrvp/boardid.c M src/mainboard/intel/kblrvp/board_id.c M src/soc/amd/cezanne/psp_verstage/svc.c M src/soc/amd/glinda/psp_verstage/svc.c M src/soc/amd/mendocino/psp_verstage/svc.c M src/soc/amd/phoenix/psp_verstage/svc.c M src/soc/amd/picasso/psp_verstage/svc.c M src/soc/mediatek/mt8186/pll.c M src/soc/mediatek/mt8188/pll.c M src/soc/mediatek/mt8195/pll.c 14 files changed, 0 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/82669/1 diff --git a/src/drivers/uart/oxpcie_early.c b/src/drivers/uart/oxpcie_early.c index 206f54d..7cc908c 100644 --- a/src/drivers/uart/oxpcie_early.c +++ b/src/drivers/uart/oxpcie_early.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <stdint.h> -#include <stddef.h> #include <device/pci_ops.h> #include <console/uart.h> #include <device/pci.h> diff --git a/src/ec/google/chromeec/ec_skuid.c b/src/ec/google/chromeec/ec_skuid.c index 259ce44..c0e079c 100644 --- a/src/ec/google/chromeec/ec_skuid.c +++ b/src/ec/google/chromeec/ec_skuid.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <stddef.h> #include <ec/google/chromeec/ec.h> uint32_t google_chromeec_get_board_sku(void) diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c index e175c09..5205ed3 100644 --- a/src/ec/google/chromeec/ec_smbios.c +++ b/src/ec/google/chromeec/ec_smbios.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <stddef.h> #include <ec/google/chromeec/ec.h> #include <console/console.h> #include <stdio.h> diff --git a/src/ec/purism/librem-ec/librem_ec.c b/src/ec/purism/librem-ec/librem_ec.c index 8298b73..69d8c9d 100644 --- a/src/ec/purism/librem-ec/librem_ec.c +++ b/src/ec/purism/librem-ec/librem_ec.c @@ -2,7 +2,6 @@ #include "librem_ec.h" #include "../../system76/ec/system76_ec.h" -#include <stddef.h> #define CMD_PROBE 1 diff --git a/src/mainboard/intel/glkrvp/boardid.c b/src/mainboard/intel/glkrvp/boardid.c index 35dcc4b..ba2f879 100644 --- a/src/mainboard/intel/glkrvp/boardid.c +++ b/src/mainboard/intel/glkrvp/boardid.c @@ -2,7 +2,6 @@ #include <baseboard/variants.h> #include <boardid.h> -#include <stddef.h> #include <ec/acpi/ec.h> #define BOARD_ID_GLK_RVP1_DDR4 0x5 /* RVP1 - DDR4 */ diff --git a/src/mainboard/intel/kblrvp/board_id.c b/src/mainboard/intel/kblrvp/board_id.c index 4305295..23c9335 100644 --- a/src/mainboard/intel/kblrvp/board_id.c +++ b/src/mainboard/intel/kblrvp/board_id.c @@ -2,7 +2,6 @@ #include "board_id.h" #include <ec/acpi/ec.h> #include <stdint.h> -#include <stddef.h> /* * Get Board info via EC I/O port write/read diff --git a/src/soc/amd/cezanne/psp_verstage/svc.c b/src/soc/amd/cezanne/psp_verstage/svc.c index 17f9d51..b59b86f 100644 --- a/src/soc/amd/cezanne/psp_verstage/svc.c +++ b/src/soc/amd/cezanne/psp_verstage/svc.c @@ -3,7 +3,6 @@ #include <assert.h> #include <bl_uapp/bl_syscall_public.h> #include <psp_verstage.h> -#include <stddef.h> #include <svc_call.h> void svc_exit(uint32_t status) diff --git a/src/soc/amd/glinda/psp_verstage/svc.c b/src/soc/amd/glinda/psp_verstage/svc.c index d533d8f..531e3d5 100644 --- a/src/soc/amd/glinda/psp_verstage/svc.c +++ b/src/soc/amd/glinda/psp_verstage/svc.c @@ -7,7 +7,6 @@ #include <assert.h> #include <bl_uapp/bl_syscall_public.h> #include <psp_verstage.h> -#include <stddef.h> #include <string.h> #include <svc_call.h> diff --git a/src/soc/amd/mendocino/psp_verstage/svc.c b/src/soc/amd/mendocino/psp_verstage/svc.c index 0c6fb5e..ba35fa7 100644 --- a/src/soc/amd/mendocino/psp_verstage/svc.c +++ b/src/soc/amd/mendocino/psp_verstage/svc.c @@ -5,7 +5,6 @@ #include <assert.h> #include <bl_uapp/bl_syscall_public.h> #include <psp_verstage.h> -#include <stddef.h> #include <string.h> #include <svc_call.h> diff --git a/src/soc/amd/phoenix/psp_verstage/svc.c b/src/soc/amd/phoenix/psp_verstage/svc.c index 6f08678..1bea8fc 100644 --- a/src/soc/amd/phoenix/psp_verstage/svc.c +++ b/src/soc/amd/phoenix/psp_verstage/svc.c @@ -5,7 +5,6 @@ #include <assert.h> #include <bl_uapp/bl_syscall_public.h> #include <psp_verstage.h> -#include <stddef.h> #include <string.h> #include <svc_call.h> diff --git a/src/soc/amd/picasso/psp_verstage/svc.c b/src/soc/amd/picasso/psp_verstage/svc.c index c1af525..d23ea3b 100644 --- a/src/soc/amd/picasso/psp_verstage/svc.c +++ b/src/soc/amd/picasso/psp_verstage/svc.c @@ -3,7 +3,6 @@ #include <assert.h> #include <bl_uapp/bl_syscall_public.h> #include <psp_verstage.h> -#include <stddef.h> #include <svc_call.h> void svc_exit(uint32_t status) diff --git a/src/soc/mediatek/mt8186/pll.c b/src/soc/mediatek/mt8186/pll.c index a6165ef..6b9eae6 100644 --- a/src/soc/mediatek/mt8186/pll.c +++ b/src/soc/mediatek/mt8186/pll.c @@ -8,7 +8,6 @@ #include <console/console.h> #include <device/mmio.h> #include <delay.h> -#include <stddef.h> #include <timer.h> #include <soc/addressmap.h> diff --git a/src/soc/mediatek/mt8188/pll.c b/src/soc/mediatek/mt8188/pll.c index d892e1c..3dfaac9 100644 --- a/src/soc/mediatek/mt8188/pll.c +++ b/src/soc/mediatek/mt8188/pll.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/mmio.h> #include <delay.h> -#include <stddef.h> #include <timer.h> #include <soc/addressmap.h> diff --git a/src/soc/mediatek/mt8195/pll.c b/src/soc/mediatek/mt8195/pll.c index 69b9c1e..397ff21 100644 --- a/src/soc/mediatek/mt8195/pll.c +++ b/src/soc/mediatek/mt8195/pll.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/mmio.h> #include <delay.h> -#include <stddef.h> #include <timer.h> #include <soc/addressmap.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/82669?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d7ad562eeff7247b7377b6570d489faee0aeda0 Gerrit-Change-Number: 82669 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: mb/google/brya/variants/trulo: Support OCP fault on A0/1 ports
by Subrata Banik (Code Review) 27 May '24

27 May '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Pranava Y N. Subrata Banik has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/82637?usp=email ) Change subject: mb/google/brya/variants/trulo: Support OCP fault on A0/1 ports ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82637/comment/778d330d_e0e5620a?us… : PS3, Line 9: The devicetree entry and gpio.c updated as per the schematics of Trulo to map the OC fault signals from A0/A1 USB ports. wrap up text. try to use <72 char/line https://review.coreboot.org/c/coreboot/+/82637/comment/004031f0_c6ba442d?us… : PS3, Line 11: 335838378 bug id seems not correct ? https://review.coreboot.org/c/coreboot/+/82637/comment/d8f46558_c5db7f06?us… : PS3, Line 12: TEST= NA we need a test tag -- To view, visit https://review.coreboot.org/c/coreboot/+/82637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic17debc5eecebca8c000c43a660e1b52d2932f2a Gerrit-Change-Number: 82637 Gerrit-PatchSet: 3 Gerrit-Owner: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 27 May 2024 10:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: tree: Use <stdio.h> for snprintf
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Attention is currently required from: Alexander Couzens, Andrey Petrov, Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Forest Mittelberg, Hung-Te Lin, Jakub Czapiga, Jason Nien, Johnny Lin, Jonathan Zhang, Julius Werner, Jérémy Compostella, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Martin Roth, Michał Żygowski, Nick Vaccaro, Patrick Rudolph, Piotr Król, Ronak Kanabar, Shuo Liu, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu. Hello Alexander Couzens, Andrey Petrov, Angel Pons, Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Forest Mittelberg, Hung-Te Lin, Jakub Czapiga, Jason Nien, Johnny Lin, Jonathan Zhang, Julius Werner, Jérémy Compostella, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Martin Roth, Michał Żygowski, Nick Vaccaro, Patrick Rudolph, Piotr Król, Ronak Kanabar, Shuo Liu, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82665?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: tree: Use <stdio.h> for snprintf ...................................................................... tree: Use <stdio.h> for snprintf <stdio.h> header is used for input/output operations (such as printf, scanf, fopen, etc.). Although some input/output functions can manipulate strings, they do not need to directly include <string.h> because they are declared independently. Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/acpigen.c M src/acpi/acpigen_dptf.c M src/acpi/acpigen_usb.c M src/acpi/device.c M src/arch/arm64/smbios.c M src/arch/x86/smbios.c M src/console/vsprintf.c M src/cpu/x86/smm/smm_module_loader.c M src/device/device_util.c M src/device/dram/ddr2.c M src/device/pci_rom.c M src/drivers/acpi/thermal_zone/thermal_zone.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5645/rt5645.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp2_0/util.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/pmc_mux/conn/conn.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/hub/acpi.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/wifi/generic/acpi.c M src/ec/clevo/it5570e/ssdt.c M src/ec/google/chromeec/audio_codec/audio_codec.c M src/ec/google/chromeec/ec_dptf_helpers.c M src/ec/google/chromeec/ec_smbios.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/ec/google/chromeec/mux/conn/conn.c M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/ssdt.c M src/include/stdio.h M src/include/string.h M src/lib/device_tree.c M src/lib/fit.c M src/lib/smbios.c M src/lib/smbios_defaults.c M src/lib/ux_locales.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/rex/mainboard.c M src/mainboard/google/volteer/mainboard.c M src/mainboard/ibm/sbp1/ramstage.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/atlas/vpd.c M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/smbios.c M src/security/tpm/tspi/crtm.c M src/soc/cavium/cn81xx/soc.c M src/soc/intel/common/block/acpi/cpu_hybrid.c M src/soc/intel/xeon_sp/acpi.c M src/soc/mediatek/common/display.c M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/lynxpoint/acpi.c M src/superio/common/ssdt.c M src/vendorcode/google/smbios.c M tests/stubs/die.c M util/cbfstool/flashmap/kv_pair.c 87 files changed, 87 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/82665/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa Gerrit-Change-Number: 82665 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>

1 0

[S] Change in coreboot[main]: util/lint: Warn when <string.h> is included but not used
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82668?usp=email ) Change subject: util/lint: Warn when <string.h> is included but not used ...................................................................... util/lint: Warn when <string.h> is included but not used Change-Id: Ifb8f68fe5e3249cc075273b5c2249d80a0b6410e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- A util/lint/lint-stable-032-string-h 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/82668/1 diff --git a/util/lint/lint-stable-032-string-h b/util/lint/lint-stable-032-string-h new file mode 100755 index 0000000..bf497c7 --- /dev/null +++ b/util/lint/lint-stable-032-string-h @@ -0,0 +1,41 @@ +#!/usr/bin/env sh +# SPDX-License-Identifier: GPL-2.0-or-later +# +# DESCR: Verify if <string.h> is needed in modified files +# + +# Get the list of modified files +MODIFIED_FILES=$(git diff --cached --name-only --diff-filter=ACM | grep -E '\.c$|\.h$') +if [ -z "$MODIFIED_FILES" ]; then + exit 0 +fi + +# Create temporary files to hold the lists +TMP_INCLUDE=$(mktemp) +TMP_FUNCTIONS=$(mktemp) + +# Find files including <string.h> +for file in $MODIFIED_FILES; do + if grep -q '#include <string.h>' "$file"; then + echo "$file" >> "$TMP_INCLUDE" + fi +done + +# Find files using string.h functions +for file in $MODIFIED_FILES; do + if grep -q 'memcpy\|memmove\|memset\|memcmp\|memchr\|strdup\|strconcat\|strnlen\|strlen\|strchr\|strncpy\|strcpy\|strcmp\|strncmp\|strspn\|strcspn\|strstr\|strtok_r\|strtok\|atol\|strrchr\|skip_atoi' "$file"; then + echo "$file" >> "$TMP_FUNCTIONS" + fi +done + +# Compare the two lists +UNNEEDED_INCLUDE=$(comm -23 "$TMP_INCLUDE" "$TMP_FUNCTIONS") + +# Output warnings for unneeded includes +if [ -n "$UNNEEDED_INCLUDE" ]; then + echo "Warning: The following files include <string.h> but do not use its functions:" + echo "$UNNEEDED_INCLUDE" +fi + +# Clean up temporary files +rm -f "$TMP_INCLUDE" "$TMP_FUNCTIONS" -- To view, visit https://review.coreboot.org/c/coreboot/+/82668?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb8f68fe5e3249cc075273b5c2249d80a0b6410e Gerrit-Change-Number: 82668 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: tree: Use <stdio.h> for snprintf
by Angel Pons (Code Review) 27 May '24

27 May '24

1 0

[XS] Change in coreboot[main]: drivers/i2c/hid/hid: Reorder headers
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82667?usp=email ) Change subject: drivers/i2c/hid/hid: Reorder headers ...................................................................... drivers/i2c/hid/hid: Reorder headers Change-Id: Ia0bf35c0b38f0c445a12c36c760c2d410649abbe Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/drivers/i2c/hid/hid.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/82667/1 diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index c91b04a..2d6882a 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -3,12 +3,12 @@ #include <acpi/acpigen_dsm.h> #include <acpi/acpi_device.h> #include <assert.h> +#include <console/console.h> #include <device/device.h> +#include <gpio.h> #include <stdio.h> #include "chip.h" -#include <gpio.h> -#include <console/console.h> #if CONFIG(HAVE_ACPI_TABLES) static void i2c_hid_fill_dsm(const struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/82667?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia0bf35c0b38f0c445a12c36c760c2d410649abbe Gerrit-Change-Number: 82667 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: tree: Remove unused <string.h>
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Attention is currently required from: Angel Pons, Caveh Jalali, Christian Walter, Forest Mittelberg, Hung-Te Lin, Jason Nien, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Martin Roth, Michał Żygowski, Patrick Rudolph, Philipp Hug, Piotr Król, Ron Minnich, Yidi Lin, Yu-Ping Wu. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82666?usp=email ) Change subject: tree: Remove unused <string.h> ...................................................................... tree: Remove unused <string.h> Change-Id: I9ed1a82fcd3fc29124ddc406592bd45dc84d4628 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/arm64/smbios.c M src/arch/riscv/include/vm.h M src/arch/x86/smbios.c M src/console/vsprintf.c M src/drivers/acpi/thermal_zone/thermal_zone.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/include/bootstate.h M src/include/rmodule.h M src/lib/smbios_defaults.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/avenuecity_crb/romstage.c M src/mainboard/intel/beechnutcity_crb/romstage.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/hermes/smbios.c M src/soc/mediatek/common/display.c 41 files changed, 12 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/82666/1 diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index 520c287..8d5f6c8 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <smbios.h> #include <stdio.h> -#include <string.h> static void smbios_processor_id(u32 *processor_id) { diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h index c1894c7..9219f10 100644 --- a/src/arch/riscv/include/vm.h +++ b/src/arch/riscv/include/vm.h @@ -3,7 +3,6 @@ #ifndef _VM_H #define _VM_H -#include <string.h> #include <stdint.h> #include <arch/encoding.h> diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index b5175c8..cb0adb2 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <string.h> #include <smbios.h> #include <console/console.h> #include <arch/cpu.h> diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 4ffc677..086ed7c 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -2,7 +2,6 @@ #include <console/vtxprintf.h> #include <stdio.h> -#include <string.h> struct vsnprintf_context { char *str_buf; diff --git a/src/drivers/acpi/thermal_zone/thermal_zone.c b/src/drivers/acpi/thermal_zone/thermal_zone.c index b1016cd..e491f75 100644 --- a/src/drivers/acpi/thermal_zone/thermal_zone.c +++ b/src/drivers/acpi/thermal_zone/thermal_zone.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <stdio.h> #include <stdlib.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 28377a1..5f43e4f 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -4,7 +4,7 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include <console/console.h> diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 97a4e05..f5df0c4 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <stdio.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index a3d8ef2..98c59e6 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -8,7 +8,7 @@ #include <device/device.h> #include <gpio.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 8efcf21..2e2d685 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <stdio.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index a7dcd64..1e1ea45 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <stdio.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index 06b31d1..c91b04a 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -5,7 +5,7 @@ #include <assert.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include <gpio.h> #include <console/console.h> diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index a4bdb15..19eda30 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define I2C_SX9310_ACPI_ID "STH9310" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 041991e..f2753ea 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define I2C_SX9324_ACPI_ID "STH9324" diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index d72f28d..63180c7 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define I2C_SX9360_ACPI_ID "STH9360" diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 534c0d8..9211100 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -2,7 +2,7 @@ #include <acpi/acpigen.h> #include <stdio.h> -#include <string.h> + #include "i915.h" void diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 3c867d4..3769fc9 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -8,7 +8,7 @@ #include <drivers/usb/acpi/chip.h> #include <gpio.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include "retimer.h" diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index 3c4fac1..8a451c4 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -7,7 +7,7 @@ #include <device/spi.h> #include <spi-generic.h> #include <stdio.h> -#include <string.h> + #include "chip.h" static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index 75d6dc9..6d92776 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -7,7 +7,7 @@ #include <device/spi.h> #include <spi-generic.h> #include <stdio.h> -#include <string.h> + #include "chip.h" static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index 716d522..bfa50c6 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -4,7 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <stdio.h> -#include <string.h> + #include "chip.h" static bool uart_acpi_add_gpios_to_crs(struct drivers_uart_acpi_config *config) diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index fc6b759..4fa32e6 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -6,7 +6,7 @@ #include <device/device.h> #include <device/path.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define CROS_EC_I2C_TUNNEL_HID "GOOG0012" diff --git a/src/include/bootstate.h b/src/include/bootstate.h index 30231ce..ab055af 100644 --- a/src/include/bootstate.h +++ b/src/include/bootstate.h @@ -3,7 +3,6 @@ #define BOOTSTATE_H #include <assert.h> -#include <string.h> #include <stddef.h> /* Only declare main() when in ramstage. */ #if ENV_RAMSTAGE diff --git a/src/include/rmodule.h b/src/include/rmodule.h index bf26ad0..72faecc 100644 --- a/src/include/rmodule.h +++ b/src/include/rmodule.h @@ -4,7 +4,6 @@ #include <stdint.h> #include <stddef.h> -#include <string.h> #include <commonlib/rmodule-defs.h> enum { diff --git a/src/lib/smbios_defaults.c b/src/lib/smbios_defaults.c index 56bddab..0ad6442 100644 --- a/src/lib/smbios_defaults.c +++ b/src/lib/smbios_defaults.c @@ -4,7 +4,6 @@ #include <smbios.h> #include <stdint.h> #include <stdio.h> -#include <string.h> /* this function will fill the corresponding locator */ __weak void smbios_fill_dimm_locator(const struct dimm_info *dimm, struct smbios_type17 *t) diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 257a27f..795d96e 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -15,7 +15,6 @@ #include <soc/pci_devs.h> #include <soc/nhlt.h> #include <stdio.h> -#include <string.h> #include <timer.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 971b671..02790b0 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -6,7 +6,6 @@ #include <gpio.h> #include <soc/sdram.h> #include <stdio.h> -#include <string.h> #include <types.h> static const char *sdram_configs[] = { diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 1290b97..685414e 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <amdblocks/acpi.h> -#include <string.h> #include <console/console.h> #include <device/device.h> #include <device/mmio.h> diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index bc70db5..22f8150 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -20,7 +20,6 @@ #include <soc/spm.h> #include <soc/usb.h> #include <stdio.h> -#include <string.h> #include "gpio.h" #include "panel.h" diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 172581f..7bdfb5e 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -14,7 +14,6 @@ #include <smbios.h> #include <soc/ramstage.h> #include <stdio.h> -#include <string.h> #include <variant/sku.h> #include <gpio.h> #include <delay.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index d21acd6..b77513b 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -7,7 +7,6 @@ #include <device/pci_ops.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <variant/sku.h> #define R_PCH_OC_WDT_CTL 0x54 diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index e8c7e69..7eafebc 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -4,7 +4,6 @@ #include <ec/google/chromeec/ec.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <sar.h> #define SKU_UNKNOWN 0xFFFFFFFF diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index 4b1b32d..964fc1c 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -11,7 +11,6 @@ #include <smbios.h> #include <soc/nhlt.h> #include <stdio.h> -#include <string.h> #include <variant/ec.h> #include <variant/gpio.h> diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index f6321e8..c02cbf9 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -12,7 +12,6 @@ #include <soc/gpio.h> #include <stdint.h> #include <stdio.h> -#include <string.h> #include "board_id.h" diff --git a/src/mainboard/intel/avenuecity_crb/romstage.c b/src/mainboard/intel/avenuecity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/avenuecity_crb/romstage.c +++ b/src/mainboard/intel/avenuecity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h> #include "chip.h" diff --git a/src/mainboard/intel/beechnutcity_crb/romstage.c b/src/mainboard/intel/beechnutcity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/beechnutcity_crb/romstage.c +++ b/src/mainboard/intel/beechnutcity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h> #include "chip.h" diff --git a/src/mainboard/intel/mtlrvp/mainboard.c b/src/mainboard/intel/mtlrvp/mainboard.c index 85c2dd4..93cec47 100644 --- a/src/mainboard/intel/mtlrvp/mainboard.c +++ b/src/mainboard/intel/mtlrvp/mainboard.c @@ -9,7 +9,6 @@ #include <smbios.h> #include <stdint.h> #include <stdio.h> -#include <string.h> const char *smbios_system_sku(void) { diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index 8f38ca2..b15f2c1 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -7,7 +7,6 @@ #include <soc/gpio.h> #include <smbios.h> #include <stdio.h> -#include <string.h> const char *smbios_system_sku(void) { diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index 01815ed..bd50fc3 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <string.h> #include <types.h> #include <device/device.h> #include <console/console.h> diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index b21c7ed..242ad9d 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -17,7 +17,6 @@ #include <superio/nuvoton/nct5104d/nct5104d.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <AGESA.h> #include "gpio_ftns.h" diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c index a70bbae..8488836 100644 --- a/src/mainboard/prodrive/atlas/mainboard.c +++ b/src/mainboard/prodrive/atlas/mainboard.c @@ -6,7 +6,6 @@ #include <gpio.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <types.h> #include "gpio.h" diff --git a/src/mainboard/prodrive/hermes/smbios.c b/src/mainboard/prodrive/hermes/smbios.c index 9671555..2f2869a 100644 --- a/src/mainboard/prodrive/hermes/smbios.c +++ b/src/mainboard/prodrive/hermes/smbios.c @@ -2,7 +2,6 @@ #include <smbios.h> #include <stdio.h> -#include <string.h> #include <types.h> #include "eeprom.h" diff --git a/src/soc/mediatek/common/display.c b/src/soc/mediatek/common/display.c index 0c23e49..a212805 100644 --- a/src/soc/mediatek/common/display.c +++ b/src/soc/mediatek/common/display.c @@ -11,7 +11,6 @@ #include <soc/dsi.h> #include <soc/mtcmos.h> #include <stdio.h> -#include <string.h> static struct panel_serializable_data *get_mipi_cmd_from_cbfs(struct panel_description *desc) { -- To view, visit https://review.coreboot.org/c/coreboot/+/82666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ed1a82fcd3fc29124ddc406592bd45dc84d4628 Gerrit-Change-Number: 82666 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>

1 0

[M] Change in coreboot[main]: tree: Use <stdio.h> for snprintf
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Attention is currently required from: Alexander Couzens, Andrey Petrov, Angel Pons, Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Dinesh Gehlot, Eran Mitrani, Forest Mittelberg, Hung-Te Lin, Jakub Czapiga, Jason Nien, Johnny Lin, Jonathan Zhang, Julius Werner, Jérémy Compostella, Kapil Porwal, Lance Zhao, Lean Sheng Tan, Martin Roth, Michał Żygowski, Nick Vaccaro, Patrick Rudolph, Piotr Król, Ronak Kanabar, Shuo Liu, Subrata Banik, Tarun, Tim Chu, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82665?usp=email ) Change subject: tree: Use <stdio.h> for snprintf ...................................................................... tree: Use <stdio.h> for snprintf <stdio.h> header is used for input/output operations (such as printf, scanf, fopen, etc.). Although some input/output functions can manipulate strings, they do not need to directly include <string.h> because they are declared independently. Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/acpigen.c M src/acpi/acpigen_dptf.c M src/acpi/acpigen_usb.c M src/acpi/device.c M src/arch/arm64/smbios.c M src/arch/x86/smbios.c M src/console/vsprintf.c M src/cpu/x86/smm/smm_module_loader.c M src/device/device_util.c M src/device/dram/ddr2.c M src/device/pci_rom.c M src/drivers/acpi/thermal_zone/thermal_zone.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5645/rt5645.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp2_0/util.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/pmc_mux/conn/conn.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/hub/acpi.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/wifi/generic/acpi.c M src/ec/clevo/it5570e/ssdt.c M src/ec/google/chromeec/audio_codec/audio_codec.c M src/ec/google/chromeec/ec_dptf_helpers.c M src/ec/google/chromeec/ec_smbios.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/ec/google/chromeec/mux/conn/conn.c M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/ssdt.c M src/include/stdio.h M src/include/string.h M src/lib/device_tree.c M src/lib/fit.c M src/lib/smbios.c M src/lib/smbios_defaults.c M src/lib/ux_locales.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/rex/mainboard.c M src/mainboard/google/volteer/mainboard.c M src/mainboard/ibm/sbp1/ramstage.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/atlas/vpd.c M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/smbios.c M src/security/tpm/tspi/crtm.c M src/soc/cavium/cn81xx/soc.c M src/soc/intel/common/block/acpi/cpu_hybrid.c M src/soc/intel/xeon_sp/acpi.c M src/soc/mediatek/common/display.c M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/lynxpoint/acpi.c M src/superio/common/ssdt.c M tests/stubs/die.c M util/cbfstool/flashmap/kv_pair.c 86 files changed, 86 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/82665/1 diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 9c04e84..4049df0 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -14,6 +14,7 @@ #include <console/console.h> #include <device/device.h> #include <device/soundwire.h> +#include <stdio.h> #include <types.h> static char *gencurrent; diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index aa8de1e..b28dcc6 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -4,6 +4,7 @@ #include <acpi/acpigen_dptf.h> #include <stdbool.h> #include <stdint.h> +#include <stdio.h> /* Defaults */ #define DEFAULT_RAW_UNIT "ma" diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c index 221a215..c285360 100644 --- a/src/acpi/acpigen_usb.c +++ b/src/acpi/acpigen_usb.c @@ -5,6 +5,7 @@ #include <acpi/acpigen.h> #include <acpi/acpigen_usb.h> #include <device/device.h> +#include <stdio.h> static const char *power_role_to_str(enum usb_typec_power_role power_role) { diff --git a/src/acpi/device.c b/src/acpi/device.c index 7313639..af3d262 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -8,6 +8,7 @@ #include <acpi/acpigen_pci.h> #include <device/device.h> #include <stdlib.h> +#include <stdio.h> #include <types.h> #include <crc_byte.h> diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index ede48e6..520c287 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -5,6 +5,7 @@ #include <arch/smc.h> #include <console/console.h> #include <smbios.h> +#include <stdio.h> #include <string.h> static void smbios_processor_id(u32 *processor_id) diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index a2038b6..b5175c8 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <arch/cpu.h> #include <cpu/x86/name.h> +#include <stdio.h> static int smbios_cpu_vendor(u8 *start) { diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 06b9e49..4ffc677 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/vtxprintf.h> +#include <stdio.h> #include <string.h> struct vsnprintf_context { diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 02debfc..646f3bb 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -11,6 +11,7 @@ #include <device/mmio.h> #include <rmodule.h> #include <smmstore.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/device/device_util.c b/src/device/device_util.c index d91df76..056aa51 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pci_def.h> +#include <stdio.h> #include <stdlib.h> #include <string.h> #include <types.h> diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index ce7a3bf..332bb12 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -10,6 +10,7 @@ #include <device/device.h> #include <device/dram/ddr2.h> #include <lib.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 7679552..d60720e 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -6,6 +6,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> +#include <stdio.h> #include <string.h> #include <cbfs.h> #include <cbmem.h> diff --git a/src/drivers/acpi/thermal_zone/thermal_zone.c b/src/drivers/acpi/thermal_zone/thermal_zone.c index ef95bed..b1016cd 100644 --- a/src/drivers/acpi/thermal_zone/thermal_zone.c +++ b/src/drivers/acpi/thermal_zone/thermal_zone.c @@ -5,6 +5,7 @@ #include <commonlib/bsd/helpers.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <stdlib.h> #include <string.h> diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 16ae48d..28377a1 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include <console/console.h> diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 37b90ca..97a4e05 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/cs35l53/cs35l53.c b/src/drivers/i2c/cs35l53/cs35l53.c index 479ef7f..974a647 100644 --- a/src/drivers/i2c/cs35l53/cs35l53.c +++ b/src/drivers/i2c/cs35l53/cs35l53.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index a2d510b..a3d8ef2 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -7,6 +7,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <gpio.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 5487f6d..8efcf21 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index 91d4ebf..a7dcd64 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index fb3a439..06b31d1 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -4,6 +4,7 @@ #include <acpi/acpi_device.h> #include <assert.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include <gpio.h> diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index f4912c1..dced120 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -7,6 +7,7 @@ #include <device/device.h> #include <identity.h> #include <stdint.h> +#include <stdio.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h" diff --git a/src/drivers/i2c/max98396/max98396.c b/src/drivers/i2c/max98396/max98396.c index ca07dbd..f71873a 100644 --- a/src/drivers/i2c/max98396/max98396.c +++ b/src/drivers/i2c/max98396/max98396.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/i2c/rt1011/rt1011.c b/src/drivers/i2c/rt1011/rt1011.c index e8ee8df..08a0fac 100644 --- a/src/drivers/i2c/rt1011/rt1011.c +++ b/src/drivers/i2c/rt1011/rt1011.c @@ -6,6 +6,7 @@ #include <device/i2c.h> #include <device/device.h> #include <stdint.h> +#include <stdio.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h" diff --git a/src/drivers/i2c/rt5645/rt5645.c b/src/drivers/i2c/rt5645/rt5645.c index 28434ee..ea3837f 100644 --- a/src/drivers/i2c/rt5645/rt5645.c +++ b/src/drivers/i2c/rt5645/rt5645.c @@ -4,6 +4,8 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> + #include "chip.h" #define RT5645_ACPI_NAME "RT58" diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index e5142bc..a4bdb15 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 966726f..041991e 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index df154f4..d72f28d 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 5bbbc1b..b6f5005 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/device.h> #include <intelblocks/pmc_ipc.h> +#include <stdio.h> #include <soc/dptf.h> #include <soc/pci_devs.h> #include "chip.h" diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index 47dc3e8..d09b39b 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -8,6 +8,7 @@ #include <commonlib/fsp.h> #include <console/console.h> #include <fsp/util.h> +#include <stdio.h> #include <string.h> #include <types.h> #include <assert.h> diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 2ee1d63..534c0d8 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include "i915.h" diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 190adc7..63a409a 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -9,6 +9,8 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <device/pci_def.h> +#include <stdio.h> + #include "chip.h" #define CSI2_DATA_STREAM_INTERFACE_GUID \ diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c index 4b1b08c..dda1fe0 100644 --- a/src/drivers/intel/pmc_mux/conn/conn.c +++ b/src/drivers/intel/pmc_mux/conn/conn.c @@ -7,6 +7,7 @@ #include <console/console.h> #include <drivers/usb/acpi/chip.h> #include <intelblocks/acpi.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 9e627de..3c867d4 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -7,6 +7,7 @@ #include <device/device.h> #include <drivers/usb/acpi/chip.h> #include <gpio.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include "retimer.h" diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index 590b3f5..3c4fac1 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index ead9b4d..0ac3334 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -6,6 +6,7 @@ #include <delay.h> #include <cpu/x86/mp.h> #include <timer.h> +#include <stdio.h> #include <string.h> #include <soc/soc_util.h> #include <soc/util.h> diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index e87946f..75d6dc9 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index a245f2c..716d522 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/usb/hub/acpi.c b/src/drivers/usb/hub/acpi.c index ebbe4b2..15732a8 100644 --- a/src/drivers/usb/hub/acpi.c +++ b/src/drivers/usb/hub/acpi.c @@ -2,6 +2,7 @@ #include <acpi/acpigen.h> #include <acpi/acpi_device.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index 47f69c0..b898642 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -7,6 +7,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/xhci.h> +#include <stdio.h> #include <stdlib.h> #define PCI_XHCI_CLASSCODE 0x0c0330 /* USB3.0 xHCI controller */ diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 9e2936d..fd1da06 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -7,6 +7,7 @@ #include <device/pci_ids.h> #include <mtcl.h> #include <sar.h> +#include <stdio.h> #include <stdlib.h> #include <wrdd.h> diff --git a/src/ec/clevo/it5570e/ssdt.c b/src/ec/clevo/it5570e/ssdt.c index a0d746a..b5a5774 100644 --- a/src/ec/clevo/it5570e/ssdt.c +++ b/src/ec/clevo/it5570e/ssdt.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/mmio.h> +#include <stdio.h> #include "chip.h" #include "ec.h" diff --git a/src/ec/google/chromeec/audio_codec/audio_codec.c b/src/ec/google/chromeec/audio_codec/audio_codec.c index a8def98..fe2a459 100644 --- a/src/ec/google/chromeec/audio_codec/audio_codec.c +++ b/src/ec/google/chromeec/audio_codec/audio_codec.c @@ -5,6 +5,8 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdio.h> + #include "chip.h" #define CROS_EC_AUDIO_CODEC_HID "GOOG0013" diff --git a/src/ec/google/chromeec/ec_dptf_helpers.c b/src/ec/google/chromeec/ec_dptf_helpers.c index c44138f..3034010 100644 --- a/src/ec/google/chromeec/ec_dptf_helpers.c +++ b/src/ec/google/chromeec/ec_dptf_helpers.c @@ -4,6 +4,7 @@ #include <acpi/acpigen_dptf.h> #include <ec/google/common/dptf.h> #include <drivers/intel/dptf/chip.h> +#include <stdio.h> #include "chip.h" /* diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c index d804f64..e175c09 100644 --- a/src/ec/google/chromeec/ec_smbios.c +++ b/src/ec/google/chromeec/ec_smbios.c @@ -3,6 +3,7 @@ #include <stddef.h> #include <ec/google/chromeec/ec.h> #include <console/console.h> +#include <stdio.h> #include <string.h> #include <smbios.h> diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index 64812d4..fc6b759 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/ec/google/chromeec/mux/conn/conn.c b/src/ec/google/chromeec/mux/conn/conn.c index bb3129b..1200b5c 100644 --- a/src/ec/google/chromeec/mux/conn/conn.c +++ b/src/ec/google/chromeec/mux/conn/conn.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <acpi/acpigen.h> +#include <stdio.h> #include "chip.h" diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 35ca1d9..155a013 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pnp.h> #include <ec/acpi/ec.h> +#include <stdio.h> #include <string.h> #include <smbios.h> #include <option.h> diff --git a/src/ec/lenovo/h8/ssdt.c b/src/ec/lenovo/h8/ssdt.c index 5dc334f..7d7bfac 100644 --- a/src/ec/lenovo/h8/ssdt.c +++ b/src/ec/lenovo/h8/ssdt.c @@ -2,6 +2,7 @@ #include <console/console.h> #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include "h8.h" diff --git a/src/include/stdio.h b/src/include/stdio.h index d59b941..fe7cb58 100644 --- a/src/include/stdio.h +++ b/src/include/stdio.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /** - * Note: This file is only for POSIX compatibility, and is meant to be - * chain-included via string.h. + * Note: This file is only for POSIX compatibility. */ #ifndef STDIO_H diff --git a/src/include/string.h b/src/include/string.h index 4a06556..33f0dfe 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -4,7 +4,6 @@ #define STRING_H #include <stddef.h> -#include <stdio.h> /* IWYU pragma: export */ void *memcpy(void *dest, const void *src, size_t n); void *memmove(void *dest, const void *src, size_t n); diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index 2bfd5dd..aff9e15 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -8,6 +8,7 @@ #include <endian.h> #include <stdbool.h> #include <stdint.h> +#include <stdio.h> #include <string.h> #include <stddef.h> #include <stdlib.h> diff --git a/src/lib/fit.c b/src/lib/fit.c index 46ac972..7f0fe67 100644 --- a/src/lib/fit.c +++ b/src/lib/fit.c @@ -12,6 +12,7 @@ #include <memrange.h> #include <fit.h> #include <boardid.h> +#include <stdio.h> #include <stdlib.h> #include <types.h> diff --git a/src/lib/smbios.c b/src/lib/smbios.c index dcf12bf..ca71e3b 100644 --- a/src/lib/smbios.c +++ b/src/lib/smbios.c @@ -16,6 +16,7 @@ #include <device/pci_ids.h> #include <device/pci.h> #include <drivers/vpd/vpd.h> +#include <stdio.h> #include <stdlib.h> static u8 smbios_checksum(u8 *p, u32 length) diff --git a/src/lib/smbios_defaults.c b/src/lib/smbios_defaults.c index 8b62ebb..56bddab 100644 --- a/src/lib/smbios_defaults.c +++ b/src/lib/smbios_defaults.c @@ -3,6 +3,7 @@ #include <memory_info.h> #include <smbios.h> #include <stdint.h> +#include <stdio.h> #include <string.h> /* this function will fill the corresponding locator */ diff --git a/src/lib/ux_locales.c b/src/lib/ux_locales.c index 0a285d9..b389548 100644 --- a/src/lib/ux_locales.c +++ b/src/lib/ux_locales.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <security/vboot/misc.h> #include <stddef.h> +#include <stdio.h> #include <string.h> #include <ux_locales.h> #include <vb2_api.h> diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 0d631cc..257a27f 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -14,6 +14,7 @@ #include <smbios.h> #include <soc/pci_devs.h> #include <soc/nhlt.h> +#include <stdio.h> #include <string.h> #include <timer.h> diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 64f45de..971b671 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <gpio.h> #include <soc/sdram.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 427f094..1290b97 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -16,6 +16,7 @@ #include <soc/acpi.h> #include <soc/pci_devs.h> #include <soc/southbridge.h> +#include <stdio.h> #include <amdblocks/acpimmio.h> #include <variant/ec.h> #include <variant/thermal.h> diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 69047fa..bc70db5 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -19,6 +19,7 @@ #include <soc/mtcmos.h> #include <soc/spm.h> #include <soc/usb.h> +#include <stdio.h> #include <string.h> #include "gpio.h" diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index aaa51dd..172581f 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -13,6 +13,7 @@ #include <intelblocks/power_limit.h> #include <smbios.h> #include <soc/ramstage.h> +#include <stdio.h> #include <string.h> #include <variant/sku.h> #include <gpio.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index 7350fb0..d21acd6 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/pci_ops.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <variant/sku.h> diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index 90cf7ce..e8c7e69 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -3,6 +3,7 @@ #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <sar.h> diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index ff3bb36..4b1b32d 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -10,6 +10,7 @@ #include <nhlt.h> #include <smbios.h> #include <soc/nhlt.h> +#include <stdio.h> #include <string.h> #include <variant/ec.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/rex/mainboard.c b/src/mainboard/google/rex/mainboard.c index bf489ff..9157abb 100644 --- a/src/mainboard/google/rex/mainboard.c +++ b/src/mainboard/google/rex/mainboard.c @@ -9,6 +9,7 @@ #include <ec/ec.h> #include <fw_config.h> #include <soc/ramstage.h> +#include <stdio.h> #include <stdlib.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c index fba9664..ae7519e 100644 --- a/src/mainboard/google/volteer/mainboard.c +++ b/src/mainboard/google/volteer/mainboard.c @@ -12,6 +12,7 @@ #include <intelblocks/tcss.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> +#include <stdio.h> #include <variant/gpio.h> #include <vb2_api.h> diff --git a/src/mainboard/ibm/sbp1/ramstage.c b/src/mainboard/ibm/sbp1/ramstage.c index d748b1b..98aa999 100644 --- a/src/mainboard/ibm/sbp1/ramstage.c +++ b/src/mainboard/ibm/sbp1/ramstage.c @@ -2,6 +2,7 @@ #include <cpu/x86/smm.h> #include <soc/ramstage.h> #include <soc/smmrelocate.h> +#include <stdio.h> #include "include/spr_sbp1_gpio.h" #include <bootstate.h> diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index 9ac480d..f6321e8 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -11,6 +11,7 @@ #include <smbios.h> #include <soc/gpio.h> #include <stdint.h> +#include <stdio.h> #include <string.h> #include "board_id.h" diff --git a/src/mainboard/intel/mtlrvp/mainboard.c b/src/mainboard/intel/mtlrvp/mainboard.c index 2e515f7..85c2dd4 100644 --- a/src/mainboard/intel/mtlrvp/mainboard.c +++ b/src/mainboard/intel/mtlrvp/mainboard.c @@ -8,6 +8,7 @@ #include <soc/ramstage.h> #include <smbios.h> #include <stdint.h> +#include <stdio.h> #include <string.h> const char *smbios_system_sku(void) diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index bbce927..8f38ca2 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -6,6 +6,7 @@ #include <ec/ec.h> #include <soc/gpio.h> #include <smbios.h> +#include <stdio.h> #include <string.h> const char *smbios_system_sku(void) diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index dbdd059..01815ed 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <drivers/intel/gma/int15.h> #include <option.h> +#include <stdio.h> #include <superio/hwm5_conf.h> #include <superio/nuvoton/common/hwm.h> diff --git a/src/mainboard/lenovo/s230u/mainboard.c b/src/mainboard/lenovo/s230u/mainboard.c index b5e3b87..f51ec67 100644 --- a/src/mainboard/lenovo/s230u/mainboard.c +++ b/src/mainboard/lenovo/s230u/mainboard.c @@ -5,6 +5,7 @@ #include <drivers/intel/gma/int15.h> #include <ec/acpi/ec.h> #include <southbridge/intel/common/gpio.h> +#include <stdio.h> #include <string.h> #include <smbios.h> #include "ec.h" diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 6dd7c10..55a10ad 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -20,6 +20,7 @@ #include <soc/smmrelocate.h> #include <soc/soc_util.h> #include <soc/util.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index ac5c928..b21c7ed 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -16,6 +16,7 @@ #include <southbridge/amd/common/amd_pci_util.h> #include <superio/nuvoton/nct5104d/nct5104d.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <AGESA.h> #include "gpio_ftns.h" diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c index 0128670..a70bbae 100644 --- a/src/mainboard/prodrive/atlas/mainboard.c +++ b/src/mainboard/prodrive/atlas/mainboard.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <gpio.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/prodrive/atlas/vpd.c b/src/mainboard/prodrive/atlas/vpd.c index ba249a9..badbc6e 100644 --- a/src/mainboard/prodrive/atlas/vpd.c +++ b/src/mainboard/prodrive/atlas/vpd.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/console.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index b0bf0dd..6d0da8d 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -16,6 +16,7 @@ #include <intelblocks/pmclib.h> #include <smbios.h> #include <soc/pm.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/prodrive/hermes/smbios.c b/src/mainboard/prodrive/hermes/smbios.c index 923ce81..9671555 100644 --- a/src/mainboard/prodrive/hermes/smbios.c +++ b/src/mainboard/prodrive/hermes/smbios.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <smbios.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c index 621d7cd..4e0a9b7 100644 --- a/src/security/tpm/tspi/crtm.c +++ b/src/security/tpm/tspi/crtm.c @@ -6,6 +6,7 @@ #include <cbfs.h> #include <symbols.h> #include "crtm.h" +#include <stdio.h> #include <string.h> static int tpm_log_initialized; diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index 5e606d3..81c9a64 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -13,6 +13,7 @@ #include <soc/uart.h> #include <stddef.h> #include <stdlib.h> +#include <stdio.h> #include <string.h> #include <symbols.h> #include <libbdk-boot/bdk-boot.h> diff --git a/src/soc/intel/common/block/acpi/cpu_hybrid.c b/src/soc/intel/common/block/acpi/cpu_hybrid.c index f52b68f..7659310 100644 --- a/src/soc/intel/common/block/acpi/cpu_hybrid.c +++ b/src/soc/intel/common/block/acpi/cpu_hybrid.c @@ -10,6 +10,7 @@ #include <intelblocks/acpi.h> #include <soc/cpu.h> #include <types.h> +#include <stdio.h> #define CPPC_NOM_FREQ_IDX 22 #define CPPC_NOM_PERF_IDX 3 diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 0d66aec..1c493af 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -6,6 +6,7 @@ #include <soc/pci_devs.h> #include <soc/util.h> #include <stdint.h> +#include <stdio.h> #include <stdlib.h> #include "chip.h" diff --git a/src/soc/mediatek/common/display.c b/src/soc/mediatek/common/display.c index 0dea58c..0c23e49 100644 --- a/src/soc/mediatek/common/display.c +++ b/src/soc/mediatek/common/display.c @@ -10,6 +10,7 @@ #include <soc/dptx.h> #include <soc/dsi.h> #include <soc/mtcmos.h> +#include <stdio.h> #include <string.h> static struct panel_serializable_data *get_mipi_cmd_from_cbfs(struct panel_description *desc) diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c index c9f1518..c9ab140 100644 --- a/src/southbridge/intel/common/rcba_pirq.c +++ b/src/southbridge/intel/common/rcba_pirq.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> +#include <stdio.h> #include <stdlib.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c index aa6e650..c3aee1f 100644 --- a/src/southbridge/intel/lynxpoint/acpi.c +++ b/src/southbridge/intel/lynxpoint/acpi.c @@ -3,6 +3,7 @@ #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include <version.h> #include <soc/nvs.h> diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c index 4fd1eed..a63ca9c 100644 --- a/src/superio/common/ssdt.c +++ b/src/superio/common/ssdt.c @@ -8,6 +8,7 @@ #include <acpi/acpi.h> #include <console/console.h> #include <types.h> +#include <stdio.h> #include <string.h> struct superio_dev { diff --git a/tests/stubs/die.c b/tests/stubs/die.c index 84bb401..86e5056 100644 --- a/tests/stubs/die.c +++ b/tests/stubs/die.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <stdarg.h> -#include <stdio.h> #include <tests/test.h> void die(const char *msg, ...) diff --git a/util/cbfstool/flashmap/kv_pair.c b/util/cbfstool/flashmap/kv_pair.c index b711302..5d033b3 100644 --- a/util/cbfstool/flashmap/kv_pair.c +++ b/util/cbfstool/flashmap/kv_pair.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause or GPL-2.0-only */ -#include <stdio.h> #include <stdlib.h> #include <stdarg.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/82665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa Gerrit-Change-Number: 82665 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>

1 0

[XS] Change in coreboot[main]: tree: Remove unused <stdarg.h>
by Elyes Haouas (Code Review) 27 May '24

27 May '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82664?usp=email ) Change subject: tree: Remove unused <stdarg.h> ...................................................................... tree: Remove unused <stdarg.h> <stdarg.h> header is used to define macros for handling variable argument lists in functions like printf. It does not depend on the string or memory manipulation functions provided by <string.h>. So let follow conventions and include only the necessary headers in each header file. Change-Id: I07ffc65b7feefb8ec4ab8dd268113f9ed8d24685 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/stdarg.h M src/include/string.h M src/soc/amd/common/psp_verstage/psp_verstage.c 3 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/82664/1 diff --git a/src/include/stdarg.h b/src/include/stdarg.h index c5a8cd8..f55fcc3 100644 --- a/src/include/stdarg.h +++ b/src/include/stdarg.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /** - * Note: This file is only for POSIX compatibility, and is meant to be - * chain-included via string.h. + * Note: This file is only for POSIX compatibility. */ #ifndef STDARG_H diff --git a/src/include/string.h b/src/include/string.h index 92ea5e5..4a06556 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -3,7 +3,6 @@ #ifndef STRING_H #define STRING_H -#include <stdarg.h> /* IWYU pragma: export */ #include <stddef.h> #include <stdio.h> /* IWYU pragma: export */ diff --git a/src/soc/amd/common/psp_verstage/psp_verstage.c b/src/soc/amd/common/psp_verstage/psp_verstage.c index e71d75a..54945b9 100644 --- a/src/soc/amd/common/psp_verstage/psp_verstage.c +++ b/src/soc/amd/common/psp_verstage/psp_verstage.c @@ -21,7 +21,6 @@ #include <security/vboot/symbols.h> #include <security/vboot/vboot_common.h> #include <arch/stages.h> -#include <stdarg.h> #include <timestamp.h> extern char _bss_start, _bss_end; -- To view, visit https://review.coreboot.org/c/coreboot/+/82664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07ffc65b7feefb8ec4ab8dd268113f9ed8d24685 Gerrit-Change-Number: 82664 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024