coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3266 discussions

[XS] Change in coreboot[main]: mainboard/google/rex: Enable Rex64 build configuration
by Subrata Banik (Code Review) 31 May '24

31 May '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Subrata Banik, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82625?usp=email to look at the new patch set (#3). Change subject: mainboard/google/rex: Enable Rex64 build configuration ...................................................................... mainboard/google/rex: Enable Rex64 build configuration * Add Rex64 board to Kconfig menu * Enable building for Rex64 with x86_64 support Change-Id: I02e2c49b4aeb2cb98d9d0cb66717db18c3f96d45 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/Kconfig.name 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/82625/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02e2c49b4aeb2cb98d9d0cb66717db18c3f96d45 Gerrit-Change-Number: 82625 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[S] Change in coreboot[main]: libpayload/arm64: Support FEAT_CCIDX
by Yu-Ping Wu (Code Review) 31 May '24

31 May '24

Attention is currently required from: Julius Werner, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/82636?usp=email ) Change subject: libpayload/arm64: Support FEAT_CCIDX ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/82636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I892009890f6ae889e87c877ffffd76a33d1dc789 Gerrit-Change-Number: 82636 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 31 May 2024 03:00:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: arch/arm64: Support FEAT_CCIDX
by Yu-Ping Wu (Code Review) 31 May '24

31 May '24

Attention is currently required from: Julius Werner, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/82635?usp=email ) Change subject: arch/arm64: Support FEAT_CCIDX ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/82635?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieadd0d9dfb8911039b3d36c9419af4ae04ed814c Gerrit-Change-Number: 82635 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 31 May 2024 03:00:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: arch/io.h: Add port I/O functions to other architectures
by Julius Werner (Code Review) 31 May '24

31 May '24

Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Jianjun Wang, Nico Huber, Ron Minnich, Shelley Chen, Yu-Ping Wu. Julius Werner has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80372?usp=email ) Change subject: arch/io.h: Add port I/O functions to other architectures ...................................................................... Patch Set 5: (1 comment) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/80372/comment/d18f54b1_92d81a2e?us… : PS5, Line 532: CPU communicate with peripheral devices over PCI I/O space. > `resource_t` is a mere integer. `struct resource` is used to describe resources, […] Okay, sorry, I guess I meant `struct resource`. I was thinking of stuff like what `src/drivers/emulation/qemu/bochs.c` seems to do, where it gets a `struct resource` from the platform to represent its base address and whenever it wants to write to some register it uses a little helper that checks whether `res->flags & IORESOURCE_IO`, and uses that to decide whether to use I/O or MMIO accessors. I was kinda assuming that that's how that whole coreboot device framework (which I don't really have any experience with because the non-PCI Arm drivers I usually worked on don't use it) works... that you have your `devicetree.cb` thing which says the platform has an instance of device X which is mapped at MMIO address Y (or I/O address Y), and then that somehow gets translated into a `struct resource` and passed to the X driver which can then use the address and flags in that struct to figure out how to talk to it. And if you're on an x86 device you can write your `devicetree.cb` such that it represents an I/O address, and if you're on an Arm device you write it such that it represents an MMIO address (and I guess you need to do the math to see where in your SoC's PCI MMIO window that thing falls by hand then when writing `devicetree.cb`, or maybe build some magic into sconfig that allows you to define the different PCI roots and have it do that math for you). Is that not how it works? -- To view, visit https://review.coreboot.org/c/coreboot/+/80372?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7d9177283e8c692088ba8e30d6dfe52623c8cb9 Gerrit-Change-Number: 80372 Gerrit-PatchSet: 5 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 31 May 2024 01:12:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: util/cbfstool: Disable paging for linux payload
by Julius Werner (Code Review) 31 May '24

31 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan, Patrick Rudolph, Shuo Liu. Julius Werner has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82705?usp=email ) Change subject: util/cbfstool: Disable paging for linux payload ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > So, as I understand it, is the issue that FSP doesn't properly restore the execution environment? If […] Sounds like the appropriate fix for this would be to have a workaround hack in coreboot's FSP driver that disables paging again right after the FSP exits, and not during payload handoff? -- To view, visit https://review.coreboot.org/c/coreboot/+/82705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I50a4ab2664910e5772b90b3dade8866f28361d87 Gerrit-Change-Number: 82705 Gerrit-PatchSet: 2 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 30 May 2024 23:39:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: Makefile: Warn if flexible array members are not at the end
by Felix Singer (Code Review) 31 May '24

31 May '24

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77147?usp=email ) Change subject: Makefile: Warn if flexible array members are not at the end ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > Yes, this is an option that isn't generally supported by all compilers. […] I agree. We should use version checks for stuff like this. Thanks for pointing it out. -- To view, visit https://review.coreboot.org/c/coreboot/+/77147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib704f7659d3b431ce7eebb4432c5b1a4272de3d2 Gerrit-Change-Number: 77147 Gerrit-PatchSet: 10 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jan Samek <samekh(a)email.cz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 May 2024 23:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: tree: Use Wcalloc-transposed-args command option
by Nico Huber (Code Review) 31 May '24

31 May '24

Attention is currently required from: Elyes Haouas. Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82658?usp=email ) Change subject: tree: Use Wcalloc-transposed-args command option ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > This breaks building with GCC 13.2. The commit message does not mention this at all. […] Same here, such things belong into xcompile. And it's part of `-Wextra` btw. which is a far more portable option (I just tried, it even adds important warnings that we haven't enabled atm. e.g. `-Wsign-compare`). Why do we bother with warnings about cosmetics that break compatibility when we don't use the imortant ones??? This is pretty pointless, please revert. Once we can enable -Wextra (some of the options we would want to discuss / opt-out), we'll get this for free. -- To view, visit https://review.coreboot.org/c/coreboot/+/82658?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77b6f4d2eda487b087ba5665b588999633c33e8d Gerrit-Change-Number: 82658 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 May 2024 23:09:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: Makefile: Warn if flexible array members are not at the end
by Nico Huber (Code Review) 31 May '24

31 May '24

Attention is currently required from: Elyes Haouas. Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77147?usp=email ) Change subject: Makefile: Warn if flexible array members are not at the end ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > This breaks building with GCC 13.2. The commit message does not mention this at all. […] Yes, this is an option that isn't generally supported by all compilers. Such things belong into xcompile (if anywhere). -- To view, visit https://review.coreboot.org/c/coreboot/+/77147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib704f7659d3b431ce7eebb4432c5b1a4272de3d2 Gerrit-Change-Number: 77147 Gerrit-PatchSet: 10 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jan Samek <samekh(a)email.cz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 30 May 2024 23:02:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: tree: Use Wcalloc-transposed-args command option
by Paul Menzel (Code Review) 30 May '24

30 May '24

Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82658?usp=email ) Change subject: tree: Use Wcalloc-transposed-args command option ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: This breaks building with GCC 13.2. The commit message does not mention this at all. I do not think, people should put through the burden to have to upgrade crossgcc to build latest coreboot right away. Please revert or add a version check. CC ramstage/cpu/x86/64bit/mode_switch.o x86_64-linux-gnu-gcc: error: unrecognized command-line option '-Wflex-array-member-not-at-end' x86_64-linux-gnu-gcc: error: unrecognized command-line option '-Wcalloc-transposed-args'; did you mean '-Wmemset-transposed-args'? make: *** [Makefile:419: build/ramstage/cpu/x86/64bit/mode_switch.o] Fehler 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/82658?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77b6f4d2eda487b087ba5665b588999633c33e8d Gerrit-Change-Number: 82658 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 30 May 2024 21:24:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Makefile: Warn if flexible array members are not at the end
by Paul Menzel (Code Review) 30 May '24

30 May '24

Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77147?usp=email ) Change subject: Makefile: Warn if flexible array members are not at the end ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: This breaks building with GCC 13.2. The commit message does not mention this at all. I do not think, people should put through the burden to have to upgrade crossgcc to build latest coreboot right away. Please revert or add a version check. -- To view, visit https://review.coreboot.org/c/coreboot/+/77147?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib704f7659d3b431ce7eebb4432c5b1a4272de3d2 Gerrit-Change-Number: 77147 Gerrit-PatchSet: 10 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jan Samek <samekh(a)email.cz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 30 May 2024 21:21:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
327
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024