Attention is currently required from: Brandon Weeks, Federico Amedeo Izzo, Felix Singer, Joel Linn, Paul Menzel.
Angel Pons has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V1.0 board
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/cwwk/adl/Kconfig:
https://review.coreboot.org/c/coreboot/+/81595/comment/…
[View More]027541dc_b2249a75?us… :
PS10, Line 9: select HAVE_ACPI_RESUME
If S3 isn't working, it might be a good idea to temporarily comment this out:
```suggestion
#select HAVE_ACPI_RESUME # TODO: Uncomment once it works
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/81595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice9174d95c10afc6a22ddd15fb3be4fa38d329be
Gerrit-Change-Number: 81595
Gerrit-PatchSet: 10
Gerrit-Owner: Brandon Weeks <bweeks(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Federico Amedeo Izzo <federico(a)izzo.pro>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-CC: Matthew Garrett <mjgarrett59(a)googlemail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Brandon Weeks <bweeks(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Federico Amedeo Izzo <federico(a)izzo.pro>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Comment-Date: Tue, 21 May 2024 23:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
[View Less]
Attention is currently required from: Brandon Weeks, Federico Amedeo Izzo, Felix Singer, Joel Linn, Paul Menzel.
Angel Pons has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V1.0 board
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81595/comment/…
[View More]a1d6f5e9_681dac85?us… :
PS9, Line 10: Memory: DDR5-4800 SODIMM (max 16 GB)
> It only has 1 DIMM slot, however I get an error during complication when DIMM_MAX is set to 1: https […]
OK, I wouldn't worry about the Kconfig. But at least SPD mapping should be updated.
File src/mainboard/cwwk/adl/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81595/comment/7d09a524_d0c3544b?us… :
PS10, Line 23: [1] = { .addr_dimm[0] = 0x52, },
If the board only has one DIMM slot, then only one of these lines is needed. As to which, To figure out which, I'd suggest `i2cdetect -y $SMBUS_INDEX` where `SMBUS_INDEX` is the number that appears in `i2cdetect -l`
--
To view, visit https://review.coreboot.org/c/coreboot/+/81595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice9174d95c10afc6a22ddd15fb3be4fa38d329be
Gerrit-Change-Number: 81595
Gerrit-PatchSet: 10
Gerrit-Owner: Brandon Weeks <bweeks(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Federico Amedeo Izzo <federico(a)izzo.pro>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-CC: Matthew Garrett <mjgarrett59(a)googlemail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Brandon Weeks <bweeks(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Federico Amedeo Izzo <federico(a)izzo.pro>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Comment-Date: Tue, 21 May 2024 23:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Brandon Weeks <bweeks(a)google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
[View Less]
Attention is currently required from: Arthur Heymans, Kapil Porwal, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81968?usp=email )
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
Patch Set 68:
(5 comments)
File payloads/libpayload/arch/x86/head_64.S:
https://review.coreboot.org/c/coreboot/+/81968/comment/921c370b_cd0a8907?us… :
…
[View More]PS64, Line 100: movq %rax, %cr3
Which section are you quoting? I'm looking at 4.10.4.1 "Operations that Invalidate TLBs and Paging-Structure Caches":
> • MOV to CR3. The behavior of the instruction depends on the value of CR4.PCIDE:
>
> — If CR4.PCIDE = 0, the instruction invalidates all TLB entries associated with PCID 000H except those for global pages. It also invalidates all entries in all paging-structure caches associated with PCID 000H.
Doesn't say anything about it making a difference what value was in there before?
https://review.coreboot.org/c/coreboot/+/81968/comment/029ec02b_f1251b94?us… :
PS64, Line 118:
> > Do we not need the `fninit` and `OSFXSR, OSXMMEXCPT` stuff in 64-bit mode? […]
Remember that this payload can be booted from either 32-bit or 64-bit coreboot, so if 64-bit coreboot does something we cannot rely on that. In general, this handoff API seems to be written such that we should try to not rely on stuff as much as possible (e.g. a non-coreboot firmware could try to boot this through the multiboot API). So if 32-bit libpayload used to turn these on explicitly, we should probably continue to do that. (I don't think we need the CPUID checks if we're sure that there are no 64-bit CPUs that don't support those features, though, we can just turn them on unconditionally.)
File payloads/libpayload/arch/x86/pt.S:
https://review.coreboot.org/c/coreboot/+/81968/comment/2247c1c4_cd37c1c9?us… :
PS64, Line 71: +
> > Doesn't this still need a _PS bit? Otherwise, it points to a 4KB page table. […]
_PS is (according to my understanding from quickly looking through the manual, so let me know if I got it wrong) the bit that tells it at each level whether this is the final (leaf) level and pointing directly to the physical page frame address, or this is a directory that points to another lower level of page tables. So for 1GB paging, 1GB is the lowest level of page tables we have and we have to set the _PS bit at the 1GB level (PDPTE). For the 2MB case, we must *not* set _PS at the PDPTE level (because there's still the 2MB level below it), but we *must* set it at the PDE level (because that's the final (leaf) level, there's no 4KB level below it).
https://review.coreboot.org/c/coreboot/+/81968/comment/3a106a32_cd4e4343?us… :
PS64, Line 82: incl %ebx
> > These may be the other reason... […]
Can you tell which instruction gives you an exception when you try that?
File payloads/libpayload/include/x86/arch/exception.h:
https://review.coreboot.org/c/coreboot/+/81968/comment/b046ea52_eaaa765b?us… :
PS64, Line 74: #else
> > > > I think it would be good to write this as a single struct definition where you only have an `i […]
Sorry, no, you were absolutely right earlier, I didn't pay close enough attention to the order. The order is important and needs to be the same that GDB uses, so you can't change the order for the 32-bit structure. Please revert to the state where you had two separate struct definitions.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 68
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 21 May 2024 23:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
[View Less]
Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82598?usp=email )
Change subject: [UNTESTED, WIP] device: drop unnecessary CHECK_REV_IN_OPROM_NAME option
......................................................................
[UNTESTED, WIP] device: drop unnecessary CHECK_REV_IN_OPROM_NAME option
The CHECK_REV_IN_OPROM_NAME Kconfig option was once introduced to …
[View More]solve
the problem of the PCI VID/DID combination of the iGPU not being
sufficient information to know which VGA BIOS file to run, so a new
function that also check the PCI revision of that device was introduces.
Later it turned out that there might be a case where even that isn't
sufficient, so the soc_is_raven2() function was used in the remap
function to always use the correct VBIOS file.
Now that we use the VBIOS images with only the PCI VID and DID in the
CBFS file name, SaeaBIOS will find the VBIOS with the same ID as the
iGPU in CBFS and we don't need the workaround to add a third VBIOS image
via VGA_BIOS_DGPU_* that has the name that SeaBIOS expects. This will
result in SeaBIOS now running the VBIOS that has the same PCI VID/DID as
the hardware which will be the wrong one in the RV2 silicon showing the
PCO silicon PCI VID/DID, but that was also the case with the
VGA_BIOS_DGPU_* workaround where the board's Kconfig just selected one
of the two possible images during build time and hoped that it was the
correct one for that actual hardware.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ia6de533c536044698d85404427719b8f534870fa
---
M src/device/Kconfig
M src/device/pci_rom.c
M src/mainboard/amd/bilby/Kconfig
M src/mainboard/amd/mandolin/Kconfig
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/graphics.c
6 files changed, 11 insertions(+), 70 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/82598/1
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 404c73d..f78f3fd 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -890,12 +890,6 @@
Under GNU/Linux you can run `lspci -nn` to list the IDs of your PCI devices.
-config CHECK_REV_IN_OPROM_NAME
- def_bool n
- help
- Select this in the platform BIOS or chipset if the option rom has a revision
- that needs to be checked when searching CBFS.
-
config VGA_BIOS_DGPU
bool "Add a discrete VGA BIOS image"
depends on VGA_BIOS
diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index aca55d6..b9210b0 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -12,7 +12,6 @@
#include <acpi/acpigen.h>
/* Rmodules don't like weak symbols. */
-void __weak map_oprom_vendev_rev(u32 *vendev, u8 *rev) { return; }
u32 __weak map_oprom_vendev(u32 vendev) { return vendev; }
void vga_oprom_preload(void)
@@ -39,35 +38,16 @@
return cbfs_map(name, NULL);
}
-static void *cbfs_boot_map_optionrom_revision(uint16_t vendor, uint16_t device, uint8_t rev)
-{
- char name[20] = "pciXXXX,XXXX,XX.rom";
-
- snprintf(name, sizeof(name), "pci%04hx,%04hx,%02hhx.rom", vendor, device, rev);
-
- return cbfs_map(name, NULL);
-}
-
struct rom_header *pci_rom_probe(const struct device *dev)
{
struct rom_header *rom_header = NULL;
struct pci_data *rom_data;
- u8 rev = pci_read_config8(dev, PCI_REVISION_ID);
- u8 mapped_rev = rev;
u32 vendev = (dev->vendor << 16) | dev->device;
u32 mapped_vendev = vendev;
/* If the ROM is in flash, then don't check the PCI device for it. */
- if (CONFIG(CHECK_REV_IN_OPROM_NAME)) {
- map_oprom_vendev_rev(&mapped_vendev, &mapped_rev);
- rom_header = cbfs_boot_map_optionrom_revision(mapped_vendev >> 16,
- mapped_vendev & 0xffff,
- mapped_rev);
- } else {
- mapped_vendev = map_oprom_vendev(vendev);
- rom_header = cbfs_boot_map_optionrom(mapped_vendev >> 16,
- mapped_vendev & 0xffff);
- }
+ mapped_vendev = map_oprom_vendev(vendev);
+ rom_header = cbfs_boot_map_optionrom(mapped_vendev >> 16, mapped_vendev & 0xffff);
if (rom_header) {
printk(BIOS_DEBUG, "In CBFS, ROM address for %s = %p\n",
diff --git a/src/mainboard/amd/bilby/Kconfig b/src/mainboard/amd/bilby/Kconfig
index 19fcbe5..9573204 100644
--- a/src/mainboard/amd/bilby/Kconfig
+++ b/src/mainboard/amd/bilby/Kconfig
@@ -80,18 +80,6 @@
Picasso's LPC bus signals are MUXed with some of the EMMC signals.
Select this option if LPC signals are required.
-#TODO: remove this hack to not break graphics in combination with SeaBIOS
-config VGA_BIOS_DGPU_ID
- string
- default "1002,15d8"
- help
- The default VGA BIOS PCI vendor/device ID should be set to the
- result of the map_oprom_vendev() function in northbridge.c.
-
-config VGA_BIOS_DGPU_FILE
- string
- default "3rdparty/amd_blobs/picasso/PicassoGenericVbios.bin"
-
if !EM100 # EM100 defaults in soc/amd/common/blocks/spi/Kconfig
config EFS_SPI_READ_MODE
default 3 # Quad IO (1-1-4)
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig
index 252404b..ce3af3b 100644
--- a/src/mainboard/amd/mandolin/Kconfig
+++ b/src/mainboard/amd/mandolin/Kconfig
@@ -106,19 +106,6 @@
Picasso's LPC bus signals are MUXed with some of the EMMC signals.
Select this option if LPC signals are required.
-#TODO: remove this hack to not break graphics in combination with SeaBIOS
-config VGA_BIOS_DGPU_ID
- string
- default "1002,15d8"
- help
- The default VGA BIOS PCI vendor/device ID should be set to the
- result of the map_oprom_vendev() function in northbridge.c.
-
-config VGA_BIOS_DGPU_FILE
- string
- default "3rdparty/amd_blobs/picasso/PicassoGenericVbios.bin" if BOARD_AMD_MANDOLIN
- default "3rdparty/amd_blobs/picasso/Raven2GenericVbios.bin" if BOARD_AMD_CEREME
-
if !EM100 # EM100 defaults in soc/amd/common/blocks/spi/Kconfig
config EFS_SPI_READ_MODE
default 3 # Quad IO (1-1-4)
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index d6c3fbd..9e70953 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -230,7 +230,7 @@
config VGA_BIOS_ID
string
- default "1002,15d8,c1"
+ default "1002,15d8"
help
The default VGA BIOS PCI vendor/device ID should be set to the
result of the map_oprom_vendev_rev() function in graphics.c.
@@ -244,25 +244,18 @@
config VGA_BIOS_SECOND_ID
string
- default "1002,15dd,c4"
+ default "1002,15dd"
help
Some Dali and all Pollock APUs need a different VBIOS than some other
Dali and all Picasso APUs, but don't always have a different PCI
vendor/device IDs, so we need an alternate method to determine the
- correct video BIOS. In map_oprom_vendev_rev(), we look at the return
+ correct video BIOS. In map_oprom_vendev(), we look at the return
value of soc_is_raven2() and decide which rom to load.
config VGA_BIOS_SECOND_FILE
string
default "3rdparty/amd_blobs/picasso/Raven2GenericVbios.bin"
-config CHECK_REV_IN_OPROM_NAME
- bool
- default y
- help
- Select this in the platform BIOS or chipset if the option rom has a
- revision that needs to be checked when searching CBFS.
-
config S3_VGA_ROM_RUN
bool
default n
diff --git a/src/soc/amd/picasso/graphics.c b/src/soc/amd/picasso/graphics.c
index 3c2e0f8..bd7ec77 100644
--- a/src/soc/amd/picasso/graphics.c
+++ b/src/soc/amd/picasso/graphics.c
@@ -6,20 +6,19 @@
#include <soc/soc_util.h>
#include <stdint.h>
-void map_oprom_vendev_rev(u32 *vendev, u8 *rev)
+u32 map_oprom_vendev(u32 vendev)
{
- if (*vendev == PICASSO_VBIOS_VID_DID) {
+ if (vendev == PICASSO_VBIOS_VID_DID) {
/* Check if the RV2 video bios needs to be used instead of the RV1/PCO one */
if (soc_is_raven2()) {
printk(BIOS_NOTICE, "Using RV2 VBIOS.\n");
- *vendev = RAVEN2_VBIOS_VID_DID;
- *rev = RAVEN2_VBIOS_REV;
+ return RAVEN2_VBIOS_VID_DID;
} else {
printk(BIOS_NOTICE, "Using RV1/PCO VBIOS.\n");
- *rev = PICASSO_VBIOS_REV;
}
- } else if (*vendev == RAVEN2_VBIOS_VID_DID) {
+ } else if (vendev == RAVEN2_VBIOS_VID_DID) {
printk(BIOS_NOTICE, "Using RV2 VBIOS.\n");
- *rev = RAVEN2_VBIOS_REV;
}
+
+ return vendev;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/82598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6de533c536044698d85404427719b8f534870fa
Gerrit-Change-Number: 82598
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
[View Less]
Attention is currently required from: Matt DeVillier, Nico Huber.
Hello Matt DeVillier, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82592?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: [UNTESTED, WIP] device/pci_rom: handle non-remapped VGA_BIOS_ID
.........................................................…
[View More].............
[UNTESTED, WIP] device/pci_rom: handle non-remapped VGA_BIOS_ID
While the SoC-level defaults for VGA_BIOS_ID are the expected correctly
remapped PCI ID of the GPU, some mainboards override the VGA_BIOS_ID
setting to the non-remapped PCI ID. This resulted in coreboot not
finding the VBIOS file. The proper solution would be to not override
this SoC-level config in neither the mainboard code nor some external
config file. This however requires adding some mechanism to be able to
tell SeaBIOS which VBIOS image to use for the GPU device.
This sort-of reverts parts of commit 42f0396a1028 ("device/pci_rom:
rework PCI ID remapping in pci_rom_probe"), but it still tries to find
the VBIOS image with the expected remapped PCI ID and only adds trying
the non-remapped PCI ID as a fallback when the file with the remapped
PCI ID doesn't exist and prints a warning in that case.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I7cd8e2036250f4ca2239b04cd070bbf0778b13aa
---
M src/device/pci_rom.c
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/82592/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/82592?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7cd8e2036250f4ca2239b04cd070bbf0778b13aa
Gerrit-Change-Number: 82592
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
[View Less]
Attention is currently required from: Jeremy Soller.
Hello Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82595?usp=email
to look at the new patch set (#3).
Change subject: mb/system76/rpl: Add Adder WS 4 as a variant
......................................................................
mb/system76/rpl: Add Adder WS 4 as a variant
The Adder WS 4 (addw4) is a Raptor Lake-HX board.
Tested with a custom edk2 UefiPayloadPkg.
…
[View More]Working:
- PS/2 keyboard
- I2C HID touchpad
- Both DIMM slots (with Crucial CT8G48C40S5)
- M.2 NVMe SSDs
- All USB ports
- MicroSD card reader
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- Backlight controls on Linux 6.8
- DisplayPort output over USB-C
- Internal microphone
- Internal speakers
- Combined headset + mic 3.5mm audio
- 3.5mm microphone input
- S3 suspend/resume
- Booting Pop!_OS Linux 22.04 with kernel 6.8.0
- TPM 2.0 device
Not working:
- Discrete/Hybrid graphics
- Detection of devices in TBT slot on boot
Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/rpl/Kconfig
M src/mainboard/system76/rpl/Kconfig.name
M src/mainboard/system76/rpl/devicetree.cb
A src/mainboard/system76/rpl/variants/addw4/board.fmd
A src/mainboard/system76/rpl/variants/addw4/board_info.txt
A src/mainboard/system76/rpl/variants/addw4/data.vbt
A src/mainboard/system76/rpl/variants/addw4/gpio.c
A src/mainboard/system76/rpl/variants/addw4/gpio_early.c
A src/mainboard/system76/rpl/variants/addw4/hda_verb.c
A src/mainboard/system76/rpl/variants/addw4/overridetree.cb
A src/mainboard/system76/rpl/variants/addw4/romstage.c
11 files changed, 523 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/82595/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/82595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Gerrit-Change-Number: 82595
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
[View Less]
Attention is currently required from: Jeremy Soller.
Hello Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82595?usp=email
to look at the new patch set (#2).
Change subject: mb/system76/rpl: Add Adder WS 4 as a variant
......................................................................
mb/system76/rpl: Add Adder WS 4 as a variant
The Adder WS 4 (addw4) is a Raptor Lake-HX board.
Tested with a custom edk2 UefiPayloadPkg.
…
[View More]Working:
- PS/2 keyboard
- I2C HID touchpad
- Both DIMM slots (with Crucial CT8G48C40S5)
- M.2 NVMe SSDs
- All USB ports
- MicroSD card reader
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- Backlight controls on Linux 6.8
- DisplayPort output over USB-C
- Internal microphone
- Internal speakers
- Combined headset + mic 3.5mm audio
- 3.5mm microphone input
- S3 suspend/resume
- Booting Pop!_OS Linux 22.04 with kernel 6.8.0
Not working:
- Discrete/Hybrid graphics
- Detection of devices in TBT slot on boot
Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/rpl/Kconfig
M src/mainboard/system76/rpl/Kconfig.name
M src/mainboard/system76/rpl/devicetree.cb
A src/mainboard/system76/rpl/variants/addw4/board.fmd
A src/mainboard/system76/rpl/variants/addw4/board_info.txt
A src/mainboard/system76/rpl/variants/addw4/data.vbt
A src/mainboard/system76/rpl/variants/addw4/gpio.c
A src/mainboard/system76/rpl/variants/addw4/gpio_early.c
A src/mainboard/system76/rpl/variants/addw4/hda_verb.c
A src/mainboard/system76/rpl/variants/addw4/overridetree.cb
A src/mainboard/system76/rpl/variants/addw4/romstage.c
11 files changed, 523 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/82595/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82595?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a6819cbcf64f68237008adebdd7eb196336514c
Gerrit-Change-Number: 82595
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
[View Less]
Attention is currently required from: Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/82533?usp=email )
Change subject: libpayload: x86: Move Multiboot header to include file
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
Patchset:
PS7:
LGTM after one issue
File payloads/libpayload/arch/x86/multiboot_header.inc:
https://review.coreboot.org/c/…
[View More]coreboot/+/82533/comment/b3ad0f4b_a7d1e9f2?us… :
PS7, Line 34: .align 4
This should not be here since this is included directly into the instruction stream of another function.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82533?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I59a22dfe36044b4dd64a5b028a134be7a7d02a48
Gerrit-Change-Number: 82533
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Tue, 21 May 2024 21:17:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
[View Less]