coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[M] Change in coreboot[main]: soc/mediatek/mt8188: devapc: set devapc permission for MFG
by Fei Yan (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Fei Yan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82076?usp=email ) Change subject: soc/mediatek/mt8188: devapc: set devapc permission for MFG ...................................................................... Patch Set 3: (3 comments) File src/soc/mediatek/mt8188/devapc.c: https://review.coreboot.org/c/coreboot/+/82076/comment/025c95d3_5dc9b70f : PS2, Line 1788: // infra > /* infra */ Done https://review.coreboot.org/c/coreboot/+/82076/comment/6d240e05_c02e9933 : PS2, Line 1807: { SUB_INFRACFG_AO_BASE + INFRA_AO_SEC_MFG_HYP2, infra_sec_mfg_hyp_init, dump_sec_mfg_hyp }, > Line too long. Done File src/soc/mediatek/mt8188/include/soc/devapc.h: https://review.coreboot.org/c/coreboot/+/82076/comment/7a2595fd_41f3a091 : PS2, Line 31: > one space Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic6fb7d85bf9d4d92946a045a274b274abc440e1d Gerrit-Change-Number: 82076 Gerrit-PatchSet: 3 Gerrit-Owner: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 03:09:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_ER88576 panel
by Haikun Zhou (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Paul Menzel, Xuxin Xiong, Yang Wu. Haikun Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82054?usp=email ) Change subject: drivers/mipi: Add support for STA_ER88576 panel ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82054/comment/f6e00706_db2058dc : PS7, Line 11: about > About Done https://review.coreboot.org/c/coreboot/+/82054/comment/74e3382e_e58c47f2 : PS7, Line 11: about the init code, we communicated with the vendor : through the datasheet to confirm the writing method : of each register value. > 72 characters per line for the commit message. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82054?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I210b23b67fbc102c9926171f1c78f6824820e4b7 Gerrit-Change-Number: 82054 Gerrit-PatchSet: 8 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 01:10:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/mtl: use different names per mtlrvp variants
by YH Lin (Code Review) 25 Apr '24

25 Apr '24

YH Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82084?usp=email ) Change subject: soc/intel/mtl: use different names per mtlrvp variants ...................................................................... soc/intel/mtl: use different names per mtlrvp variants This patch sets different names with different mtlrvp variants so they can be matched properly with frid. BUG=None BRANCH=firmware-rex-15709.B TEST=Verified boot functionality on google/rex. Change-Id: I5292a0ffcd7524c55cd7aef37c2f59432b2af06a --- M src/mainboard/intel/mtlrvp/Kconfig 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/82084/1 diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index 36842b5..bbff4aa 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -79,7 +79,9 @@ config MAINBOARD_PART_NUMBER string - default "mtlrvp" + default "Mtlrvp_P_Ext_Ec" if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP4ES_P_EXT_EC + default "Mtlrvp_P_Mchp" if BOARD_INTEL_MTLRVP_P_MCHP + default "Mtlrvp" if BOARD_INTEL_MTLRVP_P config FMDFILE default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-debug-fsp.fmd" if CHROMEOS && BUILDING_WITH_DEBUG_FSP -- To view, visit https://review.coreboot.org/c/coreboot/+/82084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5292a0ffcd7524c55cd7aef37c2f59432b2af06a Gerrit-Change-Number: 82084 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: arch/io.h: Add port I/O functions to other architectures
by Julius Werner (Code Review) 25 Apr '24

25 Apr '24

1 0

[L] Change in coreboot[main]: arch/io.h: Add port I/O functions to other architectures
by Julius Werner (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Nico Huber, ron minnich. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80372?usp=email ) Change subject: arch/io.h: Add port I/O functions to other architectures ...................................................................... Patch Set 5: (2 comments) File src/arch/arm/include/armv7/arch/io.h: https://review.coreboot.org/c/coreboot/+/80372/comment/8ca1309c_831c536c : PS3, Line 17: printk(BIOS_ERR, "arch/io.h: %s() not implemented\n", __func__); > Done for this patch, if I correctly understood the "no implementation" part. […] I'm not really convinced of this "translator" approach tbh, I doesn't feel right. Arm CPUs do not have an IN or OUT instruction, pretending like there was one anyway feels like a hack. If the same kind of device can be accessed via MMIO or port I/O, then the driver needs to be written to allow for both (e.g. like we do for 8250 UART), not expect one architecture to emulate stuff that only exists for another. File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/80372/comment/2c946820_4a175460 : PS5, Line 532: CPU communicate with peripheral devices over PCI I/O space. Sorry but I don't think this makes sense. Port I/O is a concept completely specific to the x86 architecture, it doesn't make sense on Arm. Arm processors do not have a separate "I/O bus" coming out of the chip that they can address independently. If a device can be accessed over both port I/O or MMIO then the driver needs to be able to handle both cases, and the resource API already provides parts of an abstraction for that (looks like the bochs driver is already written for that). If the VGA driver doesn't allow that then it needs to be expanded (at least it looks like it has accessor wrappers for everything it does already so it hopefully shouldn't be too complicated to add). -- To view, visit https://review.coreboot.org/c/coreboot/+/80372?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7d9177283e8c692088ba8e30d6dfe52623c8cb9 Gerrit-Change-Number: 80372 Gerrit-PatchSet: 5 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 23:11:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: Fill PCI SSID parameters
by Tim Crawford (Code Review) 25 Apr '24

25 Apr '24

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71643?usp=email ) Change subject: soc/intel/meteorlake: Fill PCI SSID parameters ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: HDA must be programmed during FSP-M using `PchHdaSubSystemIds`. Using `SiSsidTablePtr` apparently no longer works. -- To view, visit https://review.coreboot.org/c/coreboot/+/71643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I364c2052984b6f562bffe8f5ad7035c8b659d369 Gerrit-Change-Number: 71643 Gerrit-PatchSet: 8 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 22:33:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mainboard/qemu-aarch64: Set CONFIG_PCI_IOBASE to 0x3eff0000
by Alper Nebi Yasak (Code Review) 25 Apr '24

25 Apr '24

Alper Nebi Yasak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82059?usp=email ) Change subject: mainboard/qemu-aarch64: Set CONFIG_PCI_IOBASE to 0x3eff0000 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82059/comment/5012c9d1_facf915b : PS1, Line 15: [1] https://gitlab.com/qemu-project/qemu/-/blob/v8.2.3/hw/arm/virt.c#L164 Forgot to use archive.org, but it doesn't appear to work at all with GitLab. It doesn't jump to desired line with GitHub but at least shows the archived file, so I might use that next time I push. -- To view, visit https://review.coreboot.org/c/coreboot/+/82059?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I85439ba68740d64f789983b37d9c95f849ce4f72 Gerrit-Change-Number: 82059 Gerrit-PatchSet: 1 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 24 Apr 2024 22:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/qemu/bochs: Clean up #if directives
by Alper Nebi Yasak (Code Review) 24 Apr '24

24 Apr '24

Alper Nebi Yasak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80377?usp=email ) Change subject: drivers/qemu/bochs: Clean up #if directives ...................................................................... Abandoned Squashed into CB:80376 v2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80377?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I783e12f3d60bf8ac872123dd63632020bf88918c Gerrit-Change-Number: 80377 Gerrit-PatchSet: 1 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: drivers/pc80/vga/vga: Move big buffer for vga_write_text out of stack
by Alper Nebi Yasak (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Jérémy Compostella. Alper Nebi Yasak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82063?usp=email ) Change subject: drivers/pc80/vga/vga: Move big buffer for vga_write_text out of stack ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82063/comment/441e8934_29700846 : PS1, Line 28: as static and clear it each time it's called. Tested on QEMU (x86, ARM64, RISC-V), but I don't have hardware I can test on. -- To view, visit https://review.coreboot.org/c/coreboot/+/82063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icbc6da144988060532d686d199afd7f26cbc6679 Gerrit-Change-Number: 82063 Gerrit-PatchSet: 1 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Wed, 24 Apr 2024 21:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/qemu/bochs: Allow building for non-x86 architectures
by Alper Nebi Yasak (Code Review) 24 Apr '24

24 Apr '24

Attention is currently required from: Arthur Heymans, Patrick Rudolph. Alper Nebi Yasak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80376?usp=email ) Change subject: drivers/qemu/bochs: Allow building for non-x86 architectures ...................................................................... Patch Set 2: (2 comments) File src/drivers/emulation/qemu/bochs.c: https://review.coreboot.org/c/coreboot/+/80376/comment/088bfec5_90b9cb81 : PS1, Line 52: #if CONFIG(CPU_QEMU_X86) > I saw on your qemu riscv PCI code that you add IO resources to the PCI domain. To be fair that was mostly verbatim from qemu-aarch64, without me thoroughly understanding it... > In qemu I see that reading and writing to VIRT_PCIE_PIO should be translated to IO read/writes This was the key I needed to understand things better and implement those functions, thanks! Now we can use working port I/O instead. https://review.coreboot.org/c/coreboot/+/80376/comment/3cc9719c_32ae7dcd : PS1, Line 118: VGA > When using the legacy BOCHS VGA, which identifies as PCI_CLASS_DISPLAY_VGA, it must use the legacy V […] I've implemented port I/O functions and removed this config check here. Not exactly sure what you mean with "legacy VGA resources", but I could manage to configure `-device VGA` into text mode. Writing to `0xB8000` doesn't put anything on the display though, so I kept `HAVE_VGA_TEXT_FRAMEBUFFER` still dependent on x86. -- To view, visit https://review.coreboot.org/c/coreboot/+/80376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f72d7ea13e54ecf89d067394c02b572c5f92d24 Gerrit-Change-Number: 80376 Gerrit-PatchSet: 2 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 24 Apr 2024 21:43:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024