coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: arch/arm/eabi_compat.c: fix warnings of macros
by Arthur Heymans (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Integral. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82072?usp=email ) Change subject: arch/arm/eabi_compat.c: fix warnings of macros ...................................................................... Patch Set 1: (1 comment) File src/arch/arm/eabi_compat.c: https://review.coreboot.org/c/coreboot/+/82072/comment/58c76a86_de4eea51 : PS1, Line 8: __used > > lint-007-checkpatch said Fair enough, but it really does not exist. So add it first? -- To view, visit https://review.coreboot.org/c/coreboot/+/82072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I232f011ba0567af78c69eb8f73366b03d29c2839 Gerrit-Change-Number: 82072 Gerrit-PatchSet: 1 Gerrit-Owner: Integral <integral(a)member.fsf.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Integral <integral(a)member.fsf.org> Gerrit-Comment-Date: Thu, 25 Apr 2024 11:29:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Integral <integral(a)member.fsf.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/crb,pc80/tpm: Add crb and pc80 prefixes to chip configs
by Sergii Dmytruk (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Christian Walter, Jérémy Compostella, Michał Żygowski. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82057?usp=email ) Change subject: drivers/crb,pc80/tpm: Add crb and pc80 prefixes to chip configs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82057?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id41717e265362303a17745303a907c9c8f4f4e12 Gerrit-Change-Number: 82057 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 11:29:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/pc80/tpm: Disable device if TPM not present
by Sergii Dmytruk (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Christian Walter, Jérémy Compostella, Michał Żygowski, Patrick Rudolph. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80455?usp=email ) Change subject: drivers/pc80/tpm: Disable device if TPM not present ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80455?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05972ad74a36abaafa2f17a16f09710550a3a3f3 Gerrit-Change-Number: 80455 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 11:29:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/crb: Disable device if CRB TPM not present
by Sergii Dmytruk (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Christian Walter, Michał Żygowski. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80454?usp=email ) Change subject: drivers/crb: Disable device if CRB TPM not present ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80454?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0928536d9042b1f680d585e1ca9ad2cadf0c8ef Gerrit-Change-Number: 80454 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 11:29:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/x86: Enable long mode entry into payload for x86_64 support
by Werner Zeh (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Patrick Rudolph, Subrata Banik. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email ) Change subject: arch/x86: Enable long mode entry into payload for x86_64 support ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: I can understand Subrata's rational to transfer control to the payload in 64 bit seamlessly without the need to fall back to 32 bit mode. And given Intel's plans to transfer to x86S for new generations, we have to do something anyway. Let us please find a good, stable and most compatible solution for this issue. The mentioned arguments by Arthur and Julius are valuable, IMO. Subrata made the first step and the remaining comments should be worked on. Beside this let's try to find a good way to get this feature in time. -- To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b Gerrit-Change-Number: 81960 Gerrit-PatchSet: 14 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 25 Apr 2024 11:15:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: drivers/self_test: Add a self test infrastructure
by Kapil Porwal (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Paul Menzel. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82045?usp=email ) Change subject: drivers/self_test: Add a self test infrastructure ...................................................................... Patch Set 7: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82045/comment/31a6dbf2_6eaf3a88 : PS6, Line 7: coreboot self test : > Please make it a statement. Acknowledged https://review.coreboot.org/c/coreboot/+/82045/comment/79da5be2_3572bd55 : PS6, Line 12: - Where results can be dumped during payload or the OS. > Please elaborate. […] Acknowledged File src/drivers/self_test/Kconfig: https://review.coreboot.org/c/coreboot/+/82045/comment/b9fc8f86_19d78c12 : PS6, Line 22: in a CBMEM region. > Please also document the command how to read it. unused option. removed. https://review.coreboot.org/c/coreboot/+/82045/comment/a76421f8_eb7d492f : PS6, Line 29: Size of the buffer. > … in bytes. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/82045?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d7813d972167592b8dc9e9e7e9b0eb1f50c3da6 Gerrit-Change-Number: 82045 Gerrit-PatchSet: 7 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 25 Apr 2024 10:58:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi: Modify the order of increment operations
by Kapil Porwal (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Cliff Huang, Jianeng Ceng, Lance Zhao, Tim Wawrzynczak. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email ) Change subject: acpi: Modify the order of increment operations ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Gerrit-Change-Number: 82088 Gerrit-PatchSet: 2 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 10:55:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi: Modify the order of increment operations
by Eric Lai (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Cliff Huang, Jianeng Ceng, Lance Zhao, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email ) Change subject: acpi: Modify the order of increment operations ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Gerrit-Change-Number: 82088 Gerrit-PatchSet: 2 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 10:30:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/crb: Check for PTT before attempting to initialize CRB TPM
by Lean Sheng Tan (Code Review) 25 Apr '24

25 Apr '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80453?usp=email ) Change subject: drivers/crb: Check for PTT before attempting to initialize CRB TPM ...................................................................... drivers/crb: Check for PTT before attempting to initialize CRB TPM We can assume that platforms, which select HAVE_INTEL_PTT, will not have any other CRB TPM than PTT. Check whether PTT is available before forcefully initializing the TPM and selecting the CRB interface in the TPM configuration registers. Change-Id: If0ec6217b0e321b7d7a9410b70defde3c3195fc3 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80453 Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> --- M src/drivers/crb/tis.c 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Sean Rhodes: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, but someone else must approve build bot (Jenkins): Verified Michał Kopeć: Looks good to me, approved diff --git a/src/drivers/crb/tis.c b/src/drivers/crb/tis.c index 3893917..5e81935 100644 --- a/src/drivers/crb/tis.c +++ b/src/drivers/crb/tis.c @@ -50,6 +50,14 @@ { struct crb_tpm_info info; + if (CONFIG(HAVE_INTEL_PTT)) { + if (!ptt_active()) { + printk(BIOS_ERR, "%s: Intel PTT is not active.\n", __func__); + return NULL; + } + printk(BIOS_DEBUG, "%s: Intel PTT is active.\n", __func__); + } + /* Wake TPM up (if necessary) */ if (crb_tpm_init()) return NULL; @@ -63,14 +71,6 @@ printk(BIOS_INFO, "Initialized TPM device %s revision %d\n", tis_get_dev_name(&info), info.revision); - if (CONFIG(HAVE_INTEL_PTT)) { - if (!ptt_active()) { - printk(BIOS_ERR, "%s: Intel PTT is not active.\n", __func__); - return NULL; - } - printk(BIOS_DEBUG, "%s: Intel PTT is active.\n", __func__); - } - return &crb_tpm_sendrecv; } -- To view, visit https://review.coreboot.org/c/coreboot/+/80453?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0ec6217b0e321b7d7a9410b70defde3c3195fc3 Gerrit-Change-Number: 80453 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: drivers/crb: Check for PTT before attempting to initialize CRB TPM
by Lean Sheng Tan (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Christian Walter, Michał Żygowski. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80453?usp=email ) Change subject: drivers/crb: Check for PTT before attempting to initialize CRB TPM ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80453?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0ec6217b0e321b7d7a9410b70defde3c3195fc3 Gerrit-Change-Number: 80453 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 10:12:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024