coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned
by Appukuttan V K (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Arthur Heymans, Subrata Banik. Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81661?usp=email ) Change subject: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned ...................................................................... Patch Set 12: (1 comment) File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/c/coreboot/+/81661/comment/0625ec23_05b78953 : PS10, Line 38: sizeof(uint64_t) > Yes. Tried x32 with bot 4 and 8 alignment in rex system. […] Updated to 4 for x86_32 as it is the optimum value. -- To view, visit https://review.coreboot.org/c/coreboot/+/81661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c Gerrit-Change-Number: 81661 Gerrit-PatchSet: 12 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 25 Apr 2024 04:52:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned
by Appukuttan V K (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Appukuttan V K, Arthur Heymans, Subrata Banik. Hello Andrey Petrov, Ronak Kanabar, Subrata Banik, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81661?usp=email to look at the new patch set (#12). Change subject: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned ...................................................................... drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned - Stack alignment: 1. FSP functions must be called with the stack 16-bytes aligned in x86_64 mode.This is already setup properly with the default value of the `mpreferred-stack-boundary' compiler option (4). Similarly for x86_32 it is set to 2 through compiler option. 2. The FSP heap buffer supplied by coreboot through the `StackBase' UPD must be 16-bytes aligned for x86_64 and 4-bytes aligned for x86_32. BUG=b:329034258 TEST=Verified on Meteor Lake board (Rex) Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c Signed-off-by: Appukuttan V K <appukuttan.vk(a)intel.com> --- M src/drivers/intel/fsp2_0/memory_init.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/81661/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/81661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c Gerrit-Change-Number: 81661 Gerrit-PatchSet: 12 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned
by Wonkyu Kim (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Appukuttan V K, Arthur Heymans, Subrata Banik. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81661?usp=email ) Change subject: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c Gerrit-Change-Number: 81661 Gerrit-PatchSet: 11 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 25 Apr 2024 04:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned
by Appukuttan V K (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Arthur Heymans, Subrata Banik. Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81661?usp=email ) Change subject: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned ...................................................................... Patch Set 11: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81661/comment/e437b26b_82936a17 : PS10, Line 15: stack > It's a heap really... Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c Gerrit-Change-Number: 81661 Gerrit-PatchSet: 11 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 25 Apr 2024 04:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned
by Appukuttan V K (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Appukuttan V K, Subrata Banik. Hello Andrey Petrov, Ronak Kanabar, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81661?usp=email to look at the new patch set (#11). Change subject: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned ...................................................................... drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned - Stack alignment: 1. FSP functions must be called with the stack 16-bytes aligned. This is already setup properly with the default value of the `mpreferred-stack-boundary' compiler option (4). 2. The FSP heap buffer supplied by coreboot through the `StackBase' UPD must be 16-bytes aligned. BUG=b:329034258 TEST=Verified on Meteor Lake board (Rex) Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c Signed-off-by: Appukuttan V K <appukuttan.vk(a)intel.com> --- M src/drivers/intel/fsp2_0/memory_init.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/81661/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/81661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c Gerrit-Change-Number: 81661 Gerrit-PatchSet: 11 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8188: devapc: set devapc permission for MFG
by Yu-Ping Wu (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Fei Yan, Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82076?usp=email ) Change subject: soc/mediatek/mt8188: devapc: set devapc permission for MFG ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/82076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic6fb7d85bf9d4d92946a045a274b274abc440e1d Gerrit-Change-Number: 82076 Gerrit-PatchSet: 4 Gerrit-Owner: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 03:53:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola/var/wugtrio: Add STA_ER88577 MIPI panel
by Yu-Ping Wu (Code Review) 25 Apr '24

25 Apr '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82055?usp=email ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/corsola/var/wugtrio: Add STA_ER88577 MIPI panel ...................................................................... mb/google/corsola/var/wugtrio: Add STA_ER88577 MIPI panel Add STA_ER88577 MIPI panel for Wugtrio. Datasheet: 2081101BH8028073-50E_Pre Spec_240424.pdf BUG=b:331870701 TEST=emerge-staryu coreboot chromeos-bootimage BRANCH=corsola Change-Id: I279d431d80ca0770540d88e213d4aeafe77038ce Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82055 Reviewed-by: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/panel_wugtrio.c 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Xuxin Xiong: Looks good to me, but someone else must approve build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Yidi Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 402f4cc..8c291ce 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -68,6 +68,7 @@ select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI select MIPI_PANEL_KD_KD101NE3_40TI if BOARD_GOOGLE_WUGTRIO + select MIPI_PANEL_STA_ER88577 if BOARD_GOOGLE_WUGTRIO select MIPI_PANEL_STA_HIMAX83102_J02 if BOARD_GOOGLE_STARMIE select MIPI_PANEL_STA_ILI9882T if BOARD_GOOGLE_STARMIE diff --git a/src/mainboard/google/corsola/panel_wugtrio.c b/src/mainboard/google/corsola/panel_wugtrio.c index 0f7c778..c8a8971 100644 --- a/src/mainboard/google/corsola/panel_wugtrio.c +++ b/src/mainboard/google/corsola/panel_wugtrio.c @@ -25,6 +25,14 @@ } static struct panel_description wugtrio_panels[] = { + /* STA Technology panel with bias IC on it */ + [0] = { + .configure_backlight = backlight_control, + .power_on = mipi_panel_power_on, + .name = "STA_ER88577", + .disp_path = DISP_PATH_MIPI, + .orientation = LB_FB_ORIENTATION_RIGHT_UP, + }, /* K&D Technology panel with bias IC on it */ [4] = { .configure_backlight = backlight_control, -- To view, visit https://review.coreboot.org/c/coreboot/+/82055?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I279d431d80ca0770540d88e213d4aeafe77038ce Gerrit-Change-Number: 82055 Gerrit-PatchSet: 7 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_ER88576 panel
by Yu-Ping Wu (Code Review) 25 Apr '24

25 Apr '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82054?usp=email ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/mipi: Add support for STA_ER88576 panel ...................................................................... drivers/mipi: Add support for STA_ER88576 panel Add STA panel STA_ER88577 serializable data to CBFS. Datasheet: 2081101BH8028073-50E_Pre Spec_240424.pdf About the init code, we communicated with the vendor through the datasheet to confirm the writing method of each register value. BUG=b:331870701 TEST=build and check the CBFS includes the panel BRANCH=None Change-Id: I210b23b67fbc102c9926171f1c78f6824820e4b7 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82054 Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-STA_ER88577.c 3 files changed, 66 insertions(+), 0 deletions(-) Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index 8ecb0f6..4f3257f 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -51,6 +51,9 @@ config MIPI_PANEL_STA_2081101QFH032011_53G bool +config MIPI_PANEL_STA_ER88577 + bool + config MIPI_PANEL_STA_HIMAX83102_J02 bool diff --git a/src/drivers/mipi/Makefile.mk b/src/drivers/mipi/Makefile.mk index 74e1ed7..3890917 100644 --- a/src/drivers/mipi/Makefile.mk +++ b/src/drivers/mipi/Makefile.mk @@ -26,6 +26,7 @@ panel-params-$(CONFIG_MIPI_PANEL_KD_KD101NE3_40TI) += panel-KD_KD101NE3_40TI panel-params-$(CONFIG_MIPI_PANEL_STA_2081101QFH032011_53G) += panel-STA_2081101QFH032011_53G +panel-params-$(CONFIG_MIPI_PANEL_STA_ER88577) += panel-STA_ER88577 panel-params-$(CONFIG_MIPI_PANEL_STA_HIMAX83102_J02) += panel-STA_HIMAX83102_J02 panel-params-$(CONFIG_MIPI_PANEL_STA_ILI9882T) += panel-STA_ILI9882T diff --git a/src/drivers/mipi/panel-STA_ER88577.c b/src/drivers/mipi/panel-STA_ER88577.c new file mode 100644 index 0000000..6529596 --- /dev/null +++ b/src/drivers/mipi/panel-STA_ER88577.c @@ -0,0 +1,62 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data STA_ER88577 = { + .edid = { + .ascii_string = "ER88577", + .manufacturer_name = "STA", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 77380, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 800, .hbl = 90, .hso = 30, .hspw = 30, + .va = 1280, .vbl = 42, .vso = 30, .vspw = 4, + .phsync = '-', .pvsync = '-', + .x_mm = 135, .y_mm = 216, + }, + }, + .init = { + PANEL_DELAY(50), + PANEL_DCS(0xE0, 0xAB, 0xBA), + PANEL_DCS(0xE1, 0xBA, 0xAB), + PANEL_DCS(0xB1, 0x10, 0x01, 0x47, 0xFF), + PANEL_DCS(0xB2, 0x0C, 0x14, 0x04, 0x50, 0x50, 0x14), + PANEL_DCS(0xB3, 0x56, 0x53, 0x00), + PANEL_DCS(0xB4, 0x33, 0x30, 0x04), + PANEL_DCS(0xB6, 0xB0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00), + PANEL_DCS(0xB8, 0x05, 0x12, 0x29, 0x49, 0x48), + PANEL_DCS(0xB9, 0x7C, 0x59, 0x53, 0x45, 0x43, 0x32, 0x37, 0x1F, 0x37, + 0x39, 0x3A, 0x5A, 0x48, 0x50, 0x43, 0x40, 0x30, 0x20, 0x06, 0x7C, + 0x59, 0x53, 0x45, 0x43, 0x32, 0x37, 0x1F, 0x37, 0x39, 0x3A, 0x5A, + 0x48, 0x50, 0x43, 0x40, 0x30, 0x20, 0x06), + PANEL_DCS(0xC0, 0xFF, 0x87, 0x12, 0x34, 0x44, 0x44, 0x44, 0x44, 0x98, + 0x04, 0x98, 0x04, 0x0F, 0x00, 0x00, 0xC1), + PANEL_DCS(0xC1, 0x54, 0x94, 0x02, 0x85, 0x9F, 0x00, 0x6F, 0x00, 0x54, + 0x00), + PANEL_DCS(0xC2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22, 0x20, 0x44, + 0xFF, 0x18, 0x00), + PANEL_DCS(0xC3, 0x86, 0x46, 0x05, 0x05, 0x1C, 0x1C, 0x1D, 0x1D, 0x02, + 0x1F, 0x1F, 0x1E, 0x1E, 0x0F, 0x0F, 0x0D, 0x0D, 0x13, 0x13, 0x11, + 0x11, 0x00), + PANEL_DCS(0xC4, 0x07, 0x07, 0x04, 0x04, 0x1C, 0x1C, 0x1D, 0x1D, 0x02, + 0x1F, 0x1F, 0x1E, 0x1E, 0x0E, 0x0E, 0x0C, 0x0C, 0x12, 0x12, 0x10, + 0x10, 0x00), + PANEL_DCS(0xC8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16), + PANEL_DCS(0xCA, 0xCB, 0x43), + PANEL_DCS(0xCD, 0x0E, 0x4B, 0x4B, 0x20, 0x19, 0x6B, 0x06, 0xB3), + PANEL_DCS(0xD2, 0xE3, 0x2B, 0x38, 0x08), + PANEL_DCS(0xD4, 0x00, 0x01, 0x00, 0x0E, 0x04, 0x44, 0x08, 0x10, 0x00, + 0x00, 0x00), + PANEL_DCS(0xE6, 0x00, 0x01, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF), + PANEL_DCS(0xF0, 0x12, 0x03, 0x20, 0x00, 0xFF), + PANEL_DCS(0xF3, 0x00), + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + PANEL_DELAY(20), + PANEL_END, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/82054?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I210b23b67fbc102c9926171f1c78f6824820e4b7 Gerrit-Change-Number: 82054 Gerrit-PatchSet: 9 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Haikun Zhou <zhouhaikun5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8188: devapc: set devapc permission for MFG
by Fei Yan (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Fei Yan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82076?usp=email ) Change subject: soc/mediatek/mt8188: devapc: set devapc permission for MFG ...................................................................... Patch Set 4: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82076/comment/2706c4e9_6774de19 : PS2, Line 7: UPSTREAM > Remove `UPSTREAM:`. Done https://review.coreboot.org/c/coreboot/+/82076/comment/84205b63_c82dfe74 : PS2, Line 9: Set MFG to domain 6. > No need to start a new line for each sentence. Done https://review.coreboot.org/c/coreboot/+/82076/comment/cf0dc02b_7a63b20a : PS2, Line 14: So that only AP in secure mode can access MFG_S_S-2 and MFG_S_S-5 > Missing `.` at the end. Done https://review.coreboot.org/c/coreboot/+/82076/comment/fea6bab4_86c00134 : PS2, Line 13: . : So > , so Done Commit Message: https://review.coreboot.org/c/coreboot/+/82076/comment/a2a68f36_6975a458 : PS3, Line 9: Set MFG to domain 6. : Set MFG remap in infra and sub infra, so that MFG can switch to protect mode by MFG register. : Set MFG slave MFG_S_S-2 and MFG_S_S-5 permission from NO_PROTECTION to SEC_RW_ONLY for domain 0, : so that only AP in secure mode can access MFG_S_S-2 and MFG_S_S-5. > 72 characters per line for the commit message. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic6fb7d85bf9d4d92946a045a274b274abc440e1d Gerrit-Change-Number: 82076 Gerrit-PatchSet: 4 Gerrit-Owner: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 25 Apr 2024 03:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8188: devapc: set devapc permission for MFG
by Fei Yan (Code Review) 25 Apr '24

25 Apr '24

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82076?usp=email to look at the new patch set (#4). Change subject: soc/mediatek/mt8188: devapc: set devapc permission for MFG ...................................................................... soc/mediatek/mt8188: devapc: set devapc permission for MFG Set MFG to domain 6. Set MFG remap, so that MFG can switch to protect mode by MFG register. Change MFG slave permission NO_PROTECTION -> SEC_RW_ONLY for domain 0, so that only AP in secure mode can access MFG_S_S-2 and MFG_S_S-5. BUG=b:313855815 TEST=emerge-geralt coreboot Change-Id: Ic6fb7d85bf9d4d92946a045a274b274abc440e1d Signed-off-by: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8188/devapc.c M src/soc/mediatek/mt8188/include/soc/addressmap.h M src/soc/mediatek/mt8188/include/soc/devapc.h 3 files changed, 55 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/82076/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/82076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic6fb7d85bf9d4d92946a045a274b274abc440e1d Gerrit-Change-Number: 82076 Gerrit-PatchSet: 4 Gerrit-Owner: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Fei Yan <fei.yan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024