Attention is currently required from: Kapil Porwal, Paul Menzel, Subrata Banik.
Hello Kapil Porwal, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82084?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/mtl: use different names per mtlrvp variants
......................................................................
soc/intel/mtl: use different names per mtlrvp variants
This patch sets different names for different mtlrvp
variants so they can be matched properly at runtime against
unique frids (i.e. firmware read-only identifiers).
BRANCH=firmware-rex-15709.B
TEST=Verified boot functionality on google/rex.
Change-Id: I5292a0ffcd7524c55cd7aef37c2f59432b2af06a
Signed-off-by: YH Lin <yueherngl(a)google.com>
---
M src/mainboard/intel/mtlrvp/Kconfig
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/82084/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/82084?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5292a0ffcd7524c55cd7aef37c2f59432b2af06a
Gerrit-Change-Number: 82084
Gerrit-PatchSet: 4
Gerrit-Owner: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal, Paul Menzel, Subrata Banik.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82084?usp=email )
Change subject: soc/intel/mtl: use different names per mtlrvp variants
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82084/comment/da5ac567_dc17b340 :
PS3, Line 10: frid
> What is frid?
I have updated the commit comment in the patchset.
Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82084?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5292a0ffcd7524c55cd7aef37c2f59432b2af06a
Gerrit-Change-Number: 82084
Gerrit-PatchSet: 3
Gerrit-Owner: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 16:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Daniel Schaefer, Felix Singer, Jean Lucas, Kieran Levin, Nicholas Chin, Paul Menzel.
Hello Daniel Schaefer, Felix Singer, Kieran Levin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81978?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: mb/framework: Push initial port of azalea (Framework 13 AMD 7040)
......................................................................
mb/framework: Push initial port of azalea (Framework 13 AMD 7040)
This is a minimal framework that allows the build to compile.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ief4b5c75471a2ef5bedaaee9b4737510c2826b6e
---
A src/mainboard/framework/Kconfig
A src/mainboard/framework/Kconfig.name
A src/mainboard/framework/azalea/Kconfig
A src/mainboard/framework/azalea/Kconfig.name
A src/mainboard/framework/azalea/Makefile.mk
A src/mainboard/framework/azalea/board_info.txt
A src/mainboard/framework/azalea/bootblock.c
A src/mainboard/framework/azalea/coreboot.fmd
A src/mainboard/framework/azalea/devicetree.cb
A src/mainboard/framework/azalea/dsdt.asl
A src/mainboard/framework/azalea/mainboard.c
A src/mainboard/framework/azalea/port_descriptors.c
A src/mainboard/framework/azalea/romstage.c
A src/mainboard/framework/azalea/smihandler.c
14 files changed, 140 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/81978/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/81978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief4b5c75471a2ef5bedaaee9b4737510c2826b6e
Gerrit-Change-Number: 81978
Gerrit-PatchSet: 6
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kieran Levin <ktl(a)frame.work>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jean Lucas
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jean Lucas
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Attention: Kieran Levin <ktl(a)frame.work>
Gerrit-MessageType: newpatchset
Attention is currently required from: Daniel Schaefer, Jean Lucas, Kieran Levin, Nicholas Chin, Paul Menzel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81978?usp=email )
Change subject: mb/framework: Initial push of azalea (Framework 13 AMD 7040)
......................................................................
Patch Set 5:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81978/comment/844875fe_94b0443e :
PS5, Line 7: Initial push of azalea
> Make it a statement? […]
Done.
File src/mainboard/framework/azalea/Kconfig:
https://review.coreboot.org/c/coreboot/+/81978/comment/57975f9c_ba2aa42c :
PS5, Line 6: if BOARD_FRAMEWORK_AZALEA
> Add a blank line above (as in the abandoned CB:81992)
Done
https://review.coreboot.org/c/coreboot/+/81978/comment/639a203c_26542924 :
PS5, Line 16: endif
> Nit: Add a blank line above
Done
File src/mainboard/framework/azalea/Kconfig.name:
PS5:
> Missing SPDX header
Done
File src/mainboard/framework/azalea/Makefile.inc:
PS5:
> Should be Makefile. […]
Bah!
Thanks. I've had this on my machine for a while, so missed that change.
File src/mainboard/framework/azalea/board_info.txt:
https://review.coreboot.org/c/coreboot/+/81978/comment/8b96cdfd_eabaffd6 :
PS5, Line 2: Board name: Azalea (13" AMD Ryzen 4070)
> Typo, 7040*
Heh. Done, thanks.
File src/mainboard/framework/azalea/bootblock.c:
https://review.coreboot.org/c/coreboot/+/81978/comment/9696902a_e1fa05df :
PS5, Line 3: #include <bootblock_common.h>
> nit: add blank line
Done
File src/mainboard/framework/azalea/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/81978/comment/3e8b8c9e_ed02fdfa :
PS5, Line 12: )
> nit: remove that tab
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief4b5c75471a2ef5bedaaee9b4737510c2826b6e
Gerrit-Change-Number: 81978
Gerrit-PatchSet: 5
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kieran Levin <ktl(a)frame.work>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jean Lucas
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jean Lucas
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Attention: Kieran Levin <ktl(a)frame.work>
Gerrit-Comment-Date: Fri, 26 Apr 2024 15:13:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Jean Lucas
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Matt Delco, Paul Menzel, Sugnan Prabhu S.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82068?usp=email )
Change subject: src/drivers/intel/mipi_camera: Add CSI2 Data Stream Interface GUID
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82068?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id6089f6bd841333882e28de9307fe5e48e368d02
Gerrit-Change-Number: 82068
Gerrit-PatchSet: 1
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Matt Delco <delco(a)chromium.org>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt Delco <delco(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 14:36:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Krystian Hebel, Michał Żygowski, Piotr Król, Piotr Kubaj.
Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81963?usp=email )
Change subject: mb/protectli/vault_cml: use combo v1/v2 FSP
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81963?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a6f6e873e4ec35b9777dc17c0495151348d1d88
Gerrit-Change-Number: 81963
Gerrit-PatchSet: 8
Gerrit-Owner: Piotr Kubaj <pkubaj(a)anongoth.pl>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Piotr Kubaj <pkubaj(a)anongoth.pl>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 13:42:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Filip Lewiński, Martin L Roth, Stefan Reinauer.
Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79684?usp=email )
Change subject: payloads/iPXE: add TRUST_CMD switch
......................................................................
Patch Set 5:
(1 comment)
File payloads/external/iPXE/Kconfig:
https://review.coreboot.org/c/coreboot/+/79684/comment/1ed0790d_3a00850d :
PS5, Line 112: config PXE_CUSTOM_BUILD_ID
This probably belongs to another patch?
--
To view, visit https://review.coreboot.org/c/coreboot/+/79684?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4f5d4140eeb8625c5ee41e38f048658db28a199
Gerrit-Change-Number: 79684
Gerrit-PatchSet: 5
Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Fri, 26 Apr 2024 12:53:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Stefan Reinauer.
Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79684?usp=email )
Change subject: payloads/iPXE: add TRUST_CMD switch
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79684?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4f5d4140eeb8625c5ee41e38f048658db28a199
Gerrit-Change-Number: 79684
Gerrit-PatchSet: 5
Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Fri, 26 Apr 2024 12:52:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Felix Held, Jincheng Li, Johnny Lin, Jonathan Zhang, Nico Huber, Paul Menzel, Shuo Liu, TangYiwei, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81316?usp=email )
Change subject: soc/intel/xeon_sp: Add Granite Rapids initial codes
......................................................................
Patch Set 56:
(4 comments)
File src/soc/intel/xeon_sp/gnr/Kconfig:
https://review.coreboot.org/c/coreboot/+/81316/comment/3ab27ef5_fde1abd7 :
PS56, Line 17: select FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND
> I don't remember if I mentioned this, but it would be great to fix FSP
Intel said this issue is not present on GNR, so this is wrong.
File src/soc/intel/xeon_sp/gnr/chip.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/22926c4c_b20adf3d :
PS56, Line 13: intelblocks
do you need all those headers?
File src/soc/intel/xeon_sp/gnr/cpu.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/38a56b44_816103cb :
PS56, Line 9: common
do you need all those headers?
File src/soc/intel/xeon_sp/gnr/romstage.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/fd504f6a_3c6f6baa :
PS56, Line 5: #include <console/console.h>
do you need all those headers?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81316?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3084e1b5abf25d8d9504bebeaed2a15b916ed56b
Gerrit-Change-Number: 81316
Gerrit-PatchSet: 56
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: TangYiwei
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 12:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment