coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[M] Change in coreboot[main]: arch/x86: Enable long mode entry into payload for x86_64 support
by David Hendricks (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella, Kapil Porwal, Nico Huber, Patrick Rudolph, Subrata Banik, Werner Zeh. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email ) Change subject: arch/x86: Enable long mode entry into payload for x86_64 support ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: > I can understand Subrata's rational to transfer control to the payload in 64 bit seamlessly without the need to fall back to 32 bit mode. And given Intel's plans to transfer to x86S for new generations, we have to do something anyway. > Let us please find a good, stable and most compatible solution for this issue. The mentioned arguments by Arthur and Julius are valuable, IMO. Subrata made the first step and the remaining comments should be worked on. Beside this let's try to find a good way to get this feature in time. Should 32-bit payloads generally be expected to work on X86S? I'm wondering if emulation is the right solution to this problem since there may be enough architectural differences that 32-bit payloads might not function they way they're supposed to anyway. -- To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b Gerrit-Change-Number: 81960 Gerrit-PatchSet: 14 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sat, 27 Apr 2024 05:02:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/arm/eabi_compat.c: fix warnings of macros
by Integral (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Arthur Heymans. Integral has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82072?usp=email ) Change subject: arch/arm/eabi_compat.c: fix warnings of macros ...................................................................... Patch Set 1: (1 comment) File src/arch/arm/eabi_compat.c: https://review.coreboot.org/c/coreboot/+/82072/comment/81746780_fd9fe0e0 : PS1, Line 8: __used > > lint-007-checkpatch said Maybe add it first. -- To view, visit https://review.coreboot.org/c/coreboot/+/82072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I232f011ba0567af78c69eb8f73366b03d29c2839 Gerrit-Change-Number: 82072 Gerrit-PatchSet: 1 Gerrit-Owner: Integral <integral(a)member.fsf.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 27 Apr 2024 03:49:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Integral <integral(a)member.fsf.org> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: lib/device_tree: Add some FDT helper functions
by Julius Werner (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Jakub Czapiga, Martin L Roth, Maximilian Brune. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email ) Change subject: lib/device_tree: Add some FDT helper functions ...................................................................... Patch Set 20: (25 comments) Patchset: PS20: Phew... okay, I think we're getting very close, thanks for bearing with me. Mostly small nits about comments left now. File src/include/device_tree.h: https://review.coreboot.org/c/coreboot/+/81081/comment/c2c15697_e55dfb49 : PS20, Line 117: /* Find multiple nodes matching a given pattern relative to a parent node */ nit: "Returns number of nodes found." https://review.coreboot.org/c/coreboot/+/81081/comment/cc0a41ca_32840596 : PS20, Line 123: /* Read the node name into 'name' of the node behind 'node_offset' */ "and return total bytes used for name" File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/81081/comment/fac55114_2bee51bb : PS20, Line 92: nit: This should probably also start with skip_nops (instead or in addition to at the end). https://review.coreboot.org/c/coreboot/+/81081/comment/5c3496a3_6a9eec8b : PS20, Line 165: printk(BIOS_ERR, "reg property at node_offset: %x has more entries (%zd)" \ Prefer to exceed the line limit rather than breaking strings. (Also, you're actually swallowing a space in the continuation here.) https://review.coreboot.org/c/coreboot/+/81081/comment/bf774dfe_5788ac46 : PS20, Line 166: addrs Should this be `'regions'` (or `input array` or something)? https://review.coreboot.org/c/coreboot/+/81081/comment/2489fe26_1b680eab : PS20, Line 214: * the search we are. These are not updated to current implementation. https://review.coreboot.org/c/coreboot/+/81081/comment/8266df5b_090ff027 : PS20, Line 233: // intentionally follow the Linux implementation here and treat them as inheritable. nit: multi-line comments should not use C99 style (https://doc.coreboot.org/contributing/coding_style.html#commenting). https://review.coreboot.org/c/coreboot/+/81081/comment/737be0be_35690b98 : PS20, Line 244: = node_offset + nit: elsewhere you use `+=` https://review.coreboot.org/c/coreboot/+/81081/comment/a51f6be1_e9e7f34f : PS20, Line 252: * fdt_read_reg_prop reads the reg property inside a node Wrong function https://review.coreboot.org/c/coreboot/+/81081/comment/77d3dc02_2c54044b : PS20, Line 305: * Find a node in the tree from a string device tree path. Wrong description https://review.coreboot.org/c/coreboot/+/81081/comment/b7c8550e_ddcf743c : PS20, Line 349: // we have to set them to a default value if we can't find them This is not consistent with the decision in `fdt_find_node()` to inherit them. You should be leaving the values the way they were passed in and then just do one `fdt_read_cell_props()` to possibly update them. (The general idea should be that one calls `fdt_find_node_by_path()` to find the parent node, then call `fdt_find_subnodes_by_prefix()` on the result of that with the same `addrcp` and `sizecp` that fell out of `fdt_find_node_by_path()`.) https://review.coreboot.org/c/coreboot/+/81081/comment/23cbc610_443295c3 : PS20, Line 365: if (count_results >= results_len) nit: could just move below warning here to avoid writing the check twice. https://review.coreboot.org/c/coreboot/+/81081/comment/933ccb20_5cfa1b51 : PS20, Line 374: = nit: `+=`? https://review.coreboot.org/c/coreboot/+/81081/comment/b1dafcf2_46375940 : PS20, Line 375: } while (be32dec(blob + offset) != FDT_TOKEN_END_NODE); I think you can also write this as a `while ((size = fdt_next_node_name(blob, offset, &node_name)))` to be a bit shorter and more consistent with `fdt_find_node()`. https://review.coreboot.org/c/coreboot/+/81081/comment/029d9129_30b17549 : PS20, Line 399: return node_offset + prop_offset; This makes no sense, `node_offset + prop_offset` is meaningless (`prop_offset` on its own is already an absolute offset in `blob`. Also, is there really any point in making this return that offset? Why not just make it return a `const char *`? https://review.coreboot.org/c/coreboot/+/81081/comment/a4f464cd_92e80164 : PS20, Line 406: * @params alias_name offset to the node of which the children should be searched Wrong comment https://review.coreboot.org/c/coreboot/+/81081/comment/64e90d39_08b9c9b4 : PS20, Line 589: static bool fdt_is_valid(const void *blob) nit: It seems a bit odd to factor this function out now if you're not using it anywhere. Did you mean to make it non-static so that API callers could call it before accessing an FDT blob? File tests/lib/device_tree-test.c: https://review.coreboot.org/c/coreboot/+/81081/comment/d967ba94_895e38c5 : PS7, Line 13: // regular FDT from RISC-V QEMU virt target > I will add separate commit to create the common code. The current patch is already big enough. Is this still plan-of-record? When you said "separate commit" I had assumed you would put the commit before this one in the patch series so that this commit could then immediately use the new test file loading API. File tests/lib/device_tree-test.c: https://review.coreboot.org/c/coreboot/+/81081/comment/d597cc9b_dbf318aa : PS20, Line 13: // regular FDT from RISC-V QEMU virt target Would be good to add links to git.kernel.org here (with the exact commit SHA) to identify the source file exactly. https://review.coreboot.org/c/coreboot/+/81081/comment/e93d71ca_04bca950 : PS20, Line 46: // code coverage confirmed fdt_find_node_by_path was called recursively 4 times (as expected) This comment seems out of date? `fdt_find_node_by_path()` shouldn't be called recursively, only `fdt_find_node()`, and I'd be surprised if it took that much stack space. https://review.coreboot.org/c/coreboot/+/81081/comment/4e67a679_f7fb2d35 : PS20, Line 54: uint32_t results[3] = { 0 }; Would also be good to test both cases (array big enough and array not big enough) here, and ensure in the not-big-enough case that it didn't write too far (by putting a sentinel value in the latter fields and passing a smaller size). https://review.coreboot.org/c/coreboot/+/81081/comment/52430a2f_a595ab9b : PS20, Line 74: nit: test a path that doesn't exist? https://review.coreboot.org/c/coreboot/+/81081/comment/2357389d_a0ff6e0e : PS20, Line 79: } ...and a property that doesn't exist https://review.coreboot.org/c/coreboot/+/81081/comment/635f2c79_32f5f761 : PS20, Line 86: struct device_tree_region regions[1]; nit: would be nice to test this with at least two regions (and also would be nice to test the case where the array isn't big enough, and ensure that no data gets written beyond its end). -- To view, visit https://review.coreboot.org/c/coreboot/+/81081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8 Gerrit-Change-Number: 81081 Gerrit-PatchSet: 20 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sat, 27 Apr 2024 02:02:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/x86: Enable long mode entry into payload for x86_64 support
by Julius Werner (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella, Kapil Porwal, Nico Huber, Patrick Rudolph, Subrata Banik. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email ) Change subject: arch/x86: Enable long mode entry into payload for x86_64 support ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: > Can you give an example where something like this hit x86 payloads in general? Well, okay, most of these are probably somewhat platform- or payload-specific due to the simple fact that libpayload doesn't really do that much on its own. The most recent one I can find that would break something universal is the FMAP cache in CBMEM from 2019 (which is nowadays required by libcbfs). But I don't think people think about that direction of compatibility much when they add code (at least I don't, to be honest). Anyway, I'm not trying to invalidate your use case if you say you have one. But I still think there's a practical problem here in terms of getting this supported in a truly backwards-compatible manner. We need to have a purely 64-bit handoff flow for X86S eventually (so might as well design that right now rather than kicking that can down the road), but in order to make that compatible with old 32-bit coreboot the payload would need two entry points. It's impossible to do that cleanly with the existing SELF segment structures because old coreboots will reject any segment type they don't recognize. We could say "take the 32-bit entry point + 0x200" but that's pretty hacky and then we still need to be able to mark the payload as 64-bit supporting somehow. We can't use a CBFS type for that either without breaking backwards-compatibility, so the only options I see would be using a CBFS attribute (which seems much less suitable than the type for this) or putting some kind of parseable header into the payload. Both of them (and the "second entry point at hardcoded offset" thing) seem like really hacky and roundabout solutions for things that our data structures could represent in a much cleaner and more natural way (e.g. 64-bit payload as different CBFS type, or second entry point as SELF segment), that we'd only pick in the name of backwards-compatibility. I'd really prefer if we didn't need to make our handoff API so weird and unintuitive forever after only to avoid this one break in old-coreboot-new-libpayload compatibility (like we had FMAP cache in 2019, or boot_media_params in 2015). I'd rather we do another one clean break now, pick the most natural and intuitive option to represent things, try to anticipate future needs (e.g. X86S) in that decision as best as possible, and maybe think about what else we can change in order to allow future API additions to go over smoother (e.g. rethink the decision to make selfload() abort on every segment it doesn't recognize). -- To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b Gerrit-Change-Number: 81960 Gerrit-PatchSet: 14 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 27 Apr 2024 01:00:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/intel/fsp/mtl: Add Intel Touch Controller UPD in Partial Header
by Cliff Huang (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Paul Menzel, Shaunak Saha, srinivas.kulkarni(a)intel.com. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81674?usp=email ) Change subject: vc/intel/fsp/mtl: Add Intel Touch Controller UPD in Partial Header ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81674?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9a18b83fbb2d7760bd58027a4203919489b01580 Gerrit-Change-Number: 81674 Gerrit-PatchSet: 5 Gerrit-Owner: srinivas.kulkarni(a)intel.com Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: srinivas.kulkarni(a)intel.com Gerrit-Comment-Date: Fri, 26 Apr 2024 23:36:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Add 20K pulldown to GPP_D14
by Shelley Chen (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82096?usp=email ) Change subject: mb/google/brox: Add 20K pulldown to GPP_D14 ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brox/variants/baseboard/brox/gpio.c: https://review.coreboot.org/c/coreboot/+/82096/comment/320a93c5_7bda43c5 : PS1, Line 169: NONE) > How about this one? Eric says that the RX is driven by the board already so isn't floating. -- To view, visit https://review.coreboot.org/c/coreboot/+/82096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4e19e98fa31022ece66a47402a2a4461b430ef70 Gerrit-Change-Number: 82096 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 23:06:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/docker/coreboot-sdk: Remove libcurl4 from the package list
by Felix Held (Code Review) 27 Apr '24

27 Apr '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82066?usp=email ) Change subject: util/docker/coreboot-sdk: Remove libcurl4 from the package list ...................................................................... util/docker/coreboot-sdk: Remove libcurl4 from the package list When installing the packages, apt-get returns an error about holding broken packages. It occurs the diffutils depends on libcurl4t64 which breaks the libcurl4. As a solution, remove the libcurl4 from the list, and let the package manager resolve the dependencies. TEST=Build coreboot-sdk Change-Id: Iabc4f74619d4462317d8adb4068e50135d89d80e Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82066 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index ecada14..e19fc4d 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -42,7 +42,6 @@ less \ libcapture-tiny-perl \ libcrypto++-dev \ - libcurl4 \ libcurl4-openssl-dev \ libdatetime-perl \ libelf-dev \ -- To view, visit https://review.coreboot.org/c/coreboot/+/82066?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabc4f74619d4462317d8adb4068e50135d89d80e Gerrit-Change-Number: 82066 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: drivers/intel/mipi_camera: Add CSI2 Data Stream Interface GUID
by CoolStar (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Felix Singer, Matt Delco, Paul Menzel, Sugnan Prabhu S. CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82068?usp=email ) Change subject: drivers/intel/mipi_camera: Add CSI2 Data Stream Interface GUID ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82068/comment/8c1acfc6_01c398fe : PS1, Line 7: src/ > We don't add src when we do changes there. Please remove. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82068?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6089f6bd841333882e28de9307fe5e48e368d02 Gerrit-Change-Number: 82068 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Matt Delco <delco(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 22:58:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/intel/mipi_camera: Add CSI2 Data Stream Interface GUID
by CoolStar (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: CoolStar, Matt Delco, Paul Menzel, Sugnan Prabhu S. Hello Matt DeVillier, Matt Delco, Sugnan Prabhu S, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82068?usp=email to look at the new patch set (#2). Change subject: drivers/intel/mipi_camera: Add CSI2 Data Stream Interface GUID ...................................................................... drivers/intel/mipi_camera: Add CSI2 Data Stream Interface GUID Required in SSDB for Windows drivers. Tested on google/brya (kano) Change-Id: Id6089f6bd841333882e28de9307fe5e48e368d02 Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> --- M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/mipi_camera/chip.h 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/82068/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82068?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6089f6bd841333882e28de9307fe5e48e368d02 Gerrit-Change-Number: 82068 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt Delco <delco(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/brox: Add 20K pulldown to GPP_D14
by Karthik Ramasubramanian (Code Review) 27 Apr '24

27 Apr '24

Attention is currently required from: Nick Vaccaro, Shelley Chen. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82096?usp=email ) Change subject: mb/google/brox: Add 20K pulldown to GPP_D14 ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brox/variants/baseboard/brox/gpio.c: https://review.coreboot.org/c/coreboot/+/82096/comment/e17cb850_665e8072 : PS1, Line 169: NONE) How about this one? -- To view, visit https://review.coreboot.org/c/coreboot/+/82096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4e19e98fa31022ece66a47402a2a4461b430ef70 Gerrit-Change-Number: 82096 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Fri, 26 Apr 2024 22:43:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024