Attention is currently required from: Joel Linn, Matt DeVillier, Nicholas Chin.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/hp/pro_3500_series/Makefile.mk:
PS5:
Add a blank line between each stage for better distinction.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Gerrit-Change-Number: 81368
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 20:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Joel Linn, Matt DeVillier, Nicholas Chin.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
......................................................................
Patch Set 5: Code-Review+2
(6 comments)
Patchset:
PS5:
A few small cleanups. Otherwise looks good.
File src/mainboard/hp/pro_3500_series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81368/comment/19125743_feabcdd2 :
PS5, Line 11: device ref host_bridge on end
Enabled in chipset devicetree
https://review.coreboot.org/c/coreboot/+/81368/comment/adfaa846_cc0744e5 :
PS5, Line 16: register "docking_supported" = "0"
Doesn't have any effect, set to 0 anyway.
https://review.coreboot.org/c/coreboot/+/81368/comment/38add2e1_dc5df95b :
PS5, Line 27: device ref mei1 on end
Enabled in chipset devicetree
https://review.coreboot.org/c/coreboot/+/81368/comment/0d3c6369_4f8d2d62 :
PS5, Line 36: # LPC bridge
Remove superfluous comment
https://review.coreboot.org/c/coreboot/+/81368/comment/07738d1c_fff47e10 :
PS5, Line 96: device ref smbus on end
Enabled in chipset devicetree
--
To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Gerrit-Change-Number: 81368
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 20:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Felix Singer, Patrick Rudolph.
Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77046?usp=email )
Change subject: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H
......................................................................
Patch Set 7:
(4 comments)
File src/mainboard/gigabyte/ga-h77m-d3h/acpi/pci.asl:
https://review.coreboot.org/c/coreboot/+/77046/comment/c2ed380c_2ebf718c :
PS7, Line 7: Name (_ADR, 0x001E0000)
> This can't be correct because the board uses a dedicated PCIe-to-PCI bridge chip instead of the sout […]
I admit copying this from ga-b75m-d3h. I have that board too, and assumed this would be ok/correct.
I have no idea what do to different here.
File src/mainboard/gigabyte/ga-h77m-d3h/acpi/thermal.asl:
PS7:
> Has this been tested?
no, it's from the b75m variant with identical superio
File src/mainboard/gigabyte/ga-h77m-d3h/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/77046/comment/e9852a7d_d2b8d0fe :
PS7, Line 5: subsystemid 0x1458 0x5000
> Same ID already gets inherited, you can omit this line
if you don't mind my asking, where is this inherited from? A git grep shows dozens of occurrences, but nothing that looks like something that would be included by this port.
File src/mainboard/gigabyte/ga-h77m-d3h/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/77046/comment/61c55c2b_7694dbac :
PS7, Line 10: // OEM revision
> I think autoport hardcodes this value, as well as the comment. […]
I created this port by adapting ga-b75m-d3h.
--
To view, visit https://review.coreboot.org/c/coreboot/+/77046?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb3e74326a0a7aaf770d1917a2a0931feadd7eab
Gerrit-Change-Number: 77046
Gerrit-PatchSet: 7
Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Keith Hui <buurin(a)gmail.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 19:38:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes.
Hello Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81894?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: payloads/edk2/Makefile: Drop duplicated build string option
......................................................................
payloads/edk2/Makefile: Drop duplicated build string option
The `PRIORITIZE_INTERNAL` option was somehow duplicated, so remove the
extra copy, leaving the one under the MrChromebox repo specific
settings.
TEST=build qemu w/edk2 payload, check build log that the
'PRIORITIZE_INTERNAL' option is only added once to the build string.
Change-Id: I4c4c433184d93337c926e256e77054afc00a2566
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M payloads/external/edk2/Makefile
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/81894/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81894?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4c4c433184d93337c926e256e77054afc00a2566
Gerrit-Change-Number: 81894
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81894?usp=email )
Change subject: payloads/edk2/Makefile: Drop duplicated build string option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Didn't get merged - https://edk2.groups. […]
ok, well we still don't need two copies of the same option. I'll rework this
--
To view, visit https://review.coreboot.org/c/coreboot/+/81894?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4c4c433184d93337c926e256e77054afc00a2566
Gerrit-Change-Number: 81894
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 19:16:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81870?usp=email )
Change subject: payloads/edk2: Add Kconfig to enable UFS support
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81870?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b54d21dc87abf6938c03948830f92ce5097ef7d
Gerrit-Change-Number: 81870
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 19:16:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81892?usp=email )
Change subject: payloads/edk2: Add Kconfig to enable AMD Picasso eMMC driver
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81892?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6536a6f243f6766b913e295afebcf5b965e4e969
Gerrit-Change-Number: 81892
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 19:16:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81892?usp=email )
Change subject: payloads/edk2: Add Kconfig to enable AMD Picasso eMMC driver
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> as in, adding `depends on EDK2_REPO_MRCHROMEBOX` ? I can add that to these
Yup
--
To view, visit https://review.coreboot.org/c/coreboot/+/81892?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6536a6f243f6766b913e295afebcf5b965e4e969
Gerrit-Change-Number: 81892
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 19:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81892?usp=email )
Change subject: payloads/edk2: Add Kconfig to enable AMD Picasso eMMC driver
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Might be worth a follow up for some off these to depend on your fork, as they're very specific
as in, adding `depends on EDK2_REPO_MRCHROMEBOX` ? I can add that to these
--
To view, visit https://review.coreboot.org/c/coreboot/+/81892?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6536a6f243f6766b913e295afebcf5b965e4e969
Gerrit-Change-Number: 81892
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 19:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-MessageType: comment