coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[L] Change in coreboot[main]: treewide: Move stdlib.h to commonlib
by Maximilian Brune (Code Review) 14 Apr '24

14 Apr '24

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77969?usp=email ) Change subject: treewide: Move stdlib.h to commonlib ...................................................................... Patch Set 32: (1 comment) Patchset: PS32: > This should fix it: CB:81361 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/77969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3a7ab0d1ddcc7ce9af121a61b4d4eafc9e563a8a Gerrit-Change-Number: 77969 Gerrit-PatchSet: 32 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 13 Apr 2024 23:39:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: superio/nuvoton/nct6779d: Add power_on_after_fail support
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Attention is currently required from: Nico Huber. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81883?usp=email ) Change subject: superio/nuvoton/nct6779d: Add power_on_after_fail support ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > We could also make it a common function for Nuvoton SIOs? Yes, this as far as I can see can be shared among at least 3 nuvoton SIOs. Will investigate. May even expand this patch as such. File src/superio/nuvoton/nct6779d/superio.c: https://review.coreboot.org/c/coreboot/+/81883/comment/38848d20_a46a7620 : PS1, Line 37: */ > Same for the `cmos.layout` in case it's used. Not sure if it's worth that […] Heh, I tend to optimize for runtime code size. However, this is defined at src/mainboard/Kconfig and hopefully no one is going to change it. Not sure if gcc can pick up on code like: int b; switch (a) { case 0: b=0; break; case 1: b=1; break; case 2: b=2; break; default: } (which is essentially what nct5572d does) and optimize it to something more reasonable, such as my code. -- To view, visit https://review.coreboot.org/c/coreboot/+/81883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia08cf8daac971397e832996ed364d41e9e7b1c5d Gerrit-Change-Number: 81883 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 13 Apr 2024 22:53:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Drop GPIO by I/O
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Attention is currently required from: Fabian Groffen, Keith Hui. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75145?usp=email ) Change subject: mb/asus/p8z77-m: Drop GPIO by I/O ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75145?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22654f3c77082bf163ab7000ec467ab7085a0534 Gerrit-Change-Number: 75145 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Sat, 13 Apr 2024 22:42:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Disable WDT1
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Attention is currently required from: Fabian Groffen, Keith Hui. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75144?usp=email ) Change subject: mb/asus/p8z77-m: Disable WDT1 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie33c219eae60f55d272b261480283a02c2d502e5 Gerrit-Change-Number: 75144 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Sat, 13 Apr 2024 22:41:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Squelch PNP error about 2e.b irq 70
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Attention is currently required from: Fabian Groffen, Keith Hui, Paul Menzel. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75142?usp=email ) Change subject: mb/asus/p8z77-m: Squelch PNP error about 2e.b irq 70 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75142?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2231afd67031c963045b6e7930d239368c723aa5 Gerrit-Change-Number: 75142 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Sat, 13 Apr 2024 22:41:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Disable deep sleep
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Attention is currently required from: Fabian Groffen, Keith Hui. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75139?usp=email ) Change subject: mb/asus/p8z77-m: Disable deep sleep ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75139?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I660f2efebf197df055ee7b9c349e4c2b64bda6cf Gerrit-Change-Number: 75139 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Sat, 13 Apr 2024 22:41:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Enable Port 80 UART
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Attention is currently required from: Fabian Groffen, Keith Hui, Paul Menzel. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75138?usp=email ) Change subject: mb/asus/p8z77-m: Enable Port 80 UART ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75138?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebd433e2762a69241257e1b4f859319536a8d8f5 Gerrit-Change-Number: 75138 Gerrit-PatchSet: 4 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Sat, 13 Apr 2024 22:40:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: sb/intel/ibexpeak: Sever bd82x6x source dependency
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81889?usp=email ) Change subject: sb/intel/ibexpeak: Sever bd82x6x source dependency ...................................................................... sb/intel/ibexpeak: Sever bd82x6x source dependency It shares southbridge devicetree definition with bd82x6x, causing changes made there to break builds for boards with this PCH. Give ibexpeak its own copy. TEST=Timeless binary did not change. Change-Id: I08229ca658bd9c360b6be6137d882d319041b730 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/southbridge/intel/ibexpeak/chip.h M src/southbridge/intel/ibexpeak/pch.h 2 files changed, 77 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/81889/1 diff --git a/src/southbridge/intel/ibexpeak/chip.h b/src/southbridge/intel/ibexpeak/chip.h index cf79703..aba27cc 100644 --- a/src/southbridge/intel/ibexpeak/chip.h +++ b/src/southbridge/intel/ibexpeak/chip.h @@ -3,8 +3,80 @@ #ifndef SOUTHBRIDGE_INTEL_IBEXPEAK_CHIP_H #define SOUTHBRIDGE_INTEL_IBEXPEAK_CHIP_H -#define southbridge_intel_bd82x6x_config southbridge_intel_ibexpeak_config +#include <southbridge/intel/common/spi.h> +#include <types.h> +#include "pch.h" -#include "../bd82x6x/chip.h" +struct southbridge_intel_ibexpeak_config { + /** + * GPI Routing configuration + * + * Only the lower two bits have a meaning: + * 00: No effect + * 01: SMI# (if corresponding ALT_GPI_SMI_EN bit is also set) + * 10: SCI (if corresponding GPIO_EN bit is also set) + * 11: reserved + */ + uint8_t gpi0_routing; + uint8_t gpi1_routing; + uint8_t gpi2_routing; + uint8_t gpi3_routing; + uint8_t gpi4_routing; + uint8_t gpi5_routing; + uint8_t gpi6_routing; + uint8_t gpi7_routing; + uint8_t gpi8_routing; + uint8_t gpi9_routing; + uint8_t gpi10_routing; + uint8_t gpi11_routing; + uint8_t gpi12_routing; + uint8_t gpi13_routing; + uint8_t gpi14_routing; + uint8_t gpi15_routing; -#endif + uint32_t gpe0_en; + uint16_t alt_gp_smi_en; + + /* IDE configuration */ + uint8_t sata_port_map; + uint32_t sata_port0_gen3_tx; + uint32_t sata_port1_gen3_tx; + + /** + * SATA Interface Speed Support Configuration + * + * Only the lower two bits have a meaning: + * 00 - No effect (leave as chip default) + * 01 - 1.5 Gb/s maximum speed + * 10 - 3.0 Gb/s maximum speed + * 11 - 6.0 Gb/s maximum speed + */ + uint8_t sata_interface_speed_support; + + uint32_t gen1_dec; + uint32_t gen2_dec; + uint32_t gen3_dec; + uint32_t gen4_dec; + + /* Enable linear PCIe Root Port function numbers starting at zero */ + bool pcie_port_coalesce; + + /* Override PCIe ASPM */ + uint8_t pcie_aspm[8]; + + int docking_supported; + + bool pcie_hotplug_map[8]; + + /* These USB3 fields, copied from bd82x6x, don't apply here, + * as Ibex Peak doesn't have USB3. */ + uint32_t xhci_switchable_ports; + uint32_t superspeed_capable_ports; + uint32_t xhci_overcurrent_mapping; + + uint32_t spi_uvscc; + uint32_t spi_lvscc; + struct intel_swseq_spi_config spi; +}; + +#endif /* SOUTHBRIDGE_INTEL_IBEXPEAK_CHIP_H */ diff --git a/src/southbridge/intel/ibexpeak/pch.h b/src/southbridge/intel/ibexpeak/pch.h index c447746..9724761 100644 --- a/src/southbridge/intel/ibexpeak/pch.h +++ b/src/southbridge/intel/ibexpeak/pch.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#ifndef SOUTHBRIDGE_INTEL_BD82X6X_PCH_H -#define SOUTHBRIDGE_INTEL_BD82X6X_PCH_H +#ifndef SOUTHBRIDGE_INTEL_IBEXPEAK_PCH_H +#define SOUTHBRIDGE_INTEL_IBEXPEAK_PCH_H #include <acpi/acpi.h> #include <southbridge/intel/common/rcba.h> /* IWYU pragma: export */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I08229ca658bd9c360b6be6137d882d319041b730 Gerrit-Change-Number: 81889 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/packardbell/ms2290: Correct header included
by Keith Hui (Code Review) 14 Apr '24

14 Apr '24

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81888?usp=email ) Change subject: mb/packardbell/ms2290: Correct header included ...................................................................... mb/packardbell/ms2290: Correct header included It uses ibexpeak southbridge and should include its pch.h, not bd82x6x's. TEST=Timeless binary did not change. Change-Id: Iafa83b7f3c1cd2d8ab9af51aa331ca673d9a66df Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/packardbell/ms2290/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81888/1 diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index 855bbb3..07297aa 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -2,7 +2,7 @@ #include <device/device.h> #include <northbridge/intel/ironlake/ironlake.h> -#include <southbridge/intel/bd82x6x/pch.h> +#include <southbridge/intel/ibexpeak/pch.h> #include <ec/acpi/ec.h> #include <drivers/intel/gma/int15.h> #include <pc80/keyboard.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/81888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iafa83b7f3c1cd2d8ab9af51aa331ca673d9a66df Gerrit-Change-Number: 81888 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H
by Felix Singer (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Fabian Groffen, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77046?usp=email ) Change subject: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H ...................................................................... Patch Set 7: (5 comments) File src/mainboard/gigabyte/ga-h77m-d3h/Kconfig: PS7: Missing license header File src/mainboard/gigabyte/ga-h77m-d3h/Kconfig.name: PS7: Missing license header File src/mainboard/gigabyte/ga-h77m-d3h/devicetree.cb: PS7: Missing license header File src/mainboard/gigabyte/ga-h77m-d3h/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/77046/comment/4531e083_36d5af58 : PS7, Line 1: GPL-2.0-only GPL-2.0-or-later File src/mainboard/gigabyte/ga-h77m-d3h/thermal.h: https://review.coreboot.org/c/coreboot/+/77046/comment/feb8c610_ddc25095 : PS7, Line 9: /* Temperature which OS will throttle CPU */ We usually don't indent defines. Please remove. -- To view, visit https://review.coreboot.org/c/coreboot/+/77046?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb3e74326a0a7aaf770d1917a2a0931feadd7eab Gerrit-Change-Number: 77046 Gerrit-PatchSet: 7 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Keith Hui <buurin(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Sat, 13 Apr 2024 21:48:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024