coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3292 discussions

[XS] Change in coreboot[main]: superio/fintek/f81866d: Fix UART numbers
by Felix Singer (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Felix Held, Maxim. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81915?usp=email ) Change subject: superio/fintek/f81866d: Fix UART numbers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81915?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I996b8e56d943e26ab426f1802ada07cde805286d Gerrit-Change-Number: 81915 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 14:49:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/intelp2m: MTL support WIP
by Filip Lewiński (Code Review) 15 Apr '24

15 Apr '24

Filip Lewiński has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81916?usp=email ) Change subject: util/intelp2m: MTL support WIP ...................................................................... util/intelp2m: MTL support WIP Change-Id: Iaebd51d587507e68c6f263b92dc61cb6c0411bf8 Signed-off-by: Filip Lewiński <filip.lewinski(a)3mdeb.com> --- M util/intelp2m/config/config.go M util/intelp2m/main.go M util/intelp2m/parser/parser.go A util/intelp2m/platforms/mtl/macro.go A util/intelp2m/platforms/mtl/template.go 5 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/81916/1 diff --git a/util/intelp2m/config/config.go b/util/intelp2m/config/config.go index 62242b9..051c580 100644 --- a/util/intelp2m/config/config.go +++ b/util/intelp2m/config/config.go @@ -31,6 +31,7 @@ TigerType uint8 = 4 AlderType uint8 = 5 JasperType uint8 = 6 + MeteorType uint8 = 7 ) var key uint8 = SunriseType @@ -43,6 +44,7 @@ "tgl": TigerType, "adl": AlderType, "jsl": JasperType, + "mtl": MeteorType, } func PlatformSet(name string) int { if platformType, valid := platform[name]; valid { @@ -75,6 +77,9 @@ func IsPlatformAlderLakeH() bool { return IsPlatform(AlderType) } +func IsPlatformMeteorLake() bool { + return IsPlatform(MeteorType) +} var InputRegDumpFile *os.File = nil var OutputGenFile *os.File = nil diff --git a/util/intelp2m/main.go b/util/intelp2m/main.go index 64db9fee..dc78778 100644 --- a/util/intelp2m/main.go +++ b/util/intelp2m/main.go @@ -72,7 +72,8 @@ "\tcnl - CannonLake-LP or Whiskeylake/Coffeelake/Cometlake-U SoC\n"+ "\ttgl - TigerLake-H SoC\n"+ "\tadl - AlderLake PCH\n"+ - "\tjsl - Jasper Lake SoC\n") + "\tjsl - Jasper Lake SoC\n"+ + "\tmtl - MeteorLake SoC\n") fieldstyle := flag.String("fld", "none", "set fields macros style:\n"+ "\tcb - use coreboot style for bit fields macros\n"+ diff --git a/util/intelp2m/parser/parser.go b/util/intelp2m/parser/parser.go index a6fa315..b7b4141 100644 --- a/util/intelp2m/parser/parser.go +++ b/util/intelp2m/parser/parser.go @@ -14,6 +14,7 @@ "review.coreboot.org/coreboot.git/util/intelp2m/platforms/tgl" "review.coreboot.org/coreboot.git/util/intelp2m/platforms/adl" "review.coreboot.org/coreboot.git/util/intelp2m/platforms/jsl" + "review.coreboot.org/coreboot.git/util/intelp2m/platforms/mtl" "review.coreboot.org/coreboot.git/util/intelp2m/config" ) @@ -154,6 +155,7 @@ config.TigerType : tgl.PlatformSpecific{}, config.AlderType : adl.PlatformSpecific{}, config.JasperType : jsl.PlatformSpecific{}, + config.MeteorType : mtl.PlatformSpecific{}, } parser.platform = platform[config.PlatformGet()] } diff --git a/util/intelp2m/platforms/mtl/macro.go b/util/intelp2m/platforms/mtl/macro.go new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/util/intelp2m/platforms/mtl/macro.go diff --git a/util/intelp2m/platforms/mtl/template.go b/util/intelp2m/platforms/mtl/template.go new file mode 100644 index 0000000..5963f28 --- /dev/null +++ b/util/intelp2m/platforms/mtl/template.go @@ -0,0 +1,24 @@ +package tgl + +import "review.coreboot.org/coreboot.git/util/intelp2m/platforms/common" + +// GroupNameExtract - This function extracts the group ID, if it exists in a row +// line : string from the configuration file +// return +// bool : true if the string contains a group identifier +// string : group identifier +func (PlatformSpecific) GroupNameExtract(line string) (bool, string) { + return common.KeywordsCheck(line, + "GPP_V", "GPP_C", "GPP_A", "GPP_E", "GPP_H", "GPP_F", "GPP_S", + "GPP_B", "GPP_D", "GPD", + ) + +} + +// KeywordCheck - This function is used to filter parsed lines of the configuration file and +// returns true if the keyword is contained in the line. +// line : string from the configuration file +func (PlatformSpecific) KeywordCheck(line string) bool { + isIncluded, _ := common.KeywordsCheck(line, "GPP_", "GPD", "VGPIO") + return isIncluded +} -- To view, visit https://review.coreboot.org/c/coreboot/+/81916?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaebd51d587507e68c6f263b92dc61cb6c0411bf8 Gerrit-Change-Number: 81916 Gerrit-PatchSet: 1 Gerrit-Owner: Filip Lewiński Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/intel/lunarlake: Support stepping A0_2
by Paul Menzel (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Saurabh Mishra, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81847?usp=email ) Change subject: soc/intel/lunarlake: Support stepping A0_2 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81847?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I976d7f269485633d835d204afa224736d71baaa8 Gerrit-Change-Number: 81847 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Mon, 15 Apr 2024 14:21:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: SNB/BD82x6x boards: Remove old USB configurations
by Paul Menzel (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Alexander Couzens, Angel Pons, Evgeny Zinoviev, Keith Hui, Kevin Keijzer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81882?usp=email ) Change subject: SNB/BD82x6x boards: Remove old USB configurations ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81882/comment/b6e704b8_63af6248 : PS2, Line 7: SNB/BD82x6x boards: Maybe (to start with lowercase letter): > mb: SNB/BD82x6x: … https://review.coreboot.org/c/coreboot/+/81882/comment/306eb605_4914a61d : PS2, Line 13: It’d be great if you documented the boards, the tested boards. Patchset: PS2: Great work. Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/81882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie1cd21077136998a6e90050c95263f2efed68a67 Gerrit-Change-Number: 81882 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Mon, 15 Apr 2024 14:18:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpigen_ps2_keybd: Add support for dictation key
by Paul Menzel (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Aseda Aboagye. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81863?usp=email ) Change subject: acpigen_ps2_keybd: Add support for dictation key ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81863/comment/d4ccee89_c108e16f : PS2, Line 14: Flash DUT that emits a scancode for a dictation key, verify that it : is mapped to KEY_DICTATE in the Linux kernel. Next time, it’d be great if you also documented your comments, so it’s easier for people to reproduce. (I guess `evtest` or `libinput` was used.) -- To view, visit https://review.coreboot.org/c/coreboot/+/81863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabc56662a9d6b29e84ab81ed93cb46d2e8372de9 Gerrit-Change-Number: 81863 Gerrit-PatchSet: 2 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Comment-Date: Mon, 15 Apr 2024 14:16:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpigen_ps2_keybd: Add support for dictation key
by Paul Menzel (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Aseda Aboagye. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81863?usp=email ) Change subject: acpigen_ps2_keybd: Add support for dictation key ...................................................................... Patch Set 2: (1 comment) File src/acpi/acpigen_ps2_keybd.c: https://review.coreboot.org/c/coreboot/+/81863/comment/d6ce0a07_79b2b9e5 : PS2, Line 59: [PS2_KEY_DICTATE] = KEYMAP(0xa7, KEY_DICTATE), /* e027*/ Please sort the entry. -- To view, visit https://review.coreboot.org/c/coreboot/+/81863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabc56662a9d6b29e84ab81ed93cb46d2e8372de9 Gerrit-Change-Number: 81863 Gerrit-PatchSet: 2 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Comment-Date: Mon, 15 Apr 2024 14:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/lunarlake: Support stepping A0_2
by Saurabh Mishra (Code Review) 15 Apr '24

15 Apr '24

1 0

[XS] Change in coreboot[main]: soc/intel/common: Add Lunar Lake CNVI device IDs
by Saurabh Mishra (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Paul Menzel, Subrata Banik. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81846?usp=email ) Change subject: soc/intel/common: Add Lunar Lake CNVI device IDs ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/common/block/cnvi/cnvi.c: https://review.coreboot.org/c/coreboot/+/81846/comment/dbac843f_8291cf3f : PS2, Line 27: PCI_DID_INTEL_LNL_CNVI_WIFI_3, > > `please, no spaces at the start of a line` […] ACK. -- To view, visit https://review.coreboot.org/c/coreboot/+/81846?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5a0a3fbc9f43a6a573e33fcf3901055e10faaed1 Gerrit-Change-Number: 81846 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 15 Apr 2024 13:54:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/lunarlake: Support stepping A0_2
by Saurabh Mishra (Code Review) 15 Apr '24

15 Apr '24

1 0

[XS] Change in coreboot[main]: soc/intel/lunarlake: Support stepping A0_2
by Saurabh Mishra (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Paul Menzel, Subrata Banik. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81847?usp=email ) Change subject: soc/intel/lunarlake: Support stepping A0_2 ...................................................................... Patch Set 3: (7 comments) Commit Message: PS2: > Just reading the commit message, I would have thought the diff to be different. […] ACK. https://review.coreboot.org/c/coreboot/+/81847/comment/65f610c2_13ccac2a : PS2, Line 7: soc/intel/{common, lunarlake}: Add support for new MCH > The prefix does not need to be the path. Maybe: […] ACK. https://review.coreboot.org/c/coreboot/+/81847/comment/e5d58c9b_8d3c6883 : PS2, Line 10: (ID:0x6410) > I’d write: … with id 0x640 […] Done https://review.coreboot.org/c/coreboot/+/81847/comment/8cb5fe71_10f971db : PS2, Line 10: The patch adds > “The patch” is redundant [1]. Just use the imperative mood: […] ACK. https://review.coreboot.org/c/coreboot/+/81847/comment/f233c9b8_1a1eb884 : PS2, Line 11: Add new CPU ID (ID:0xb06d1) > Add new CPU id 0xb06d1 ACK. https://review.coreboot.org/c/coreboot/+/81847/comment/97d6153c_7d410f6e : PS2, Line 16: TEST=Build and boot the system having MCH ID:0x6410. > Which log line is that? Updated. File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/81847/comment/bf42278b_611aded1 : PS2, Line 4292: #define PCI_DID_INTEL_LNL_M_ID_1 0x6410 > Name the above …1, and this one _2 for alignment reasons? ACK. -- To view, visit https://review.coreboot.org/c/coreboot/+/81847?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I976d7f269485633d835d204afa224736d71baaa8 Gerrit-Change-Number: 81847 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 15 Apr 2024 13:53:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024