Attention is currently required from: Caveh Jalali, Forest Mittelberg.
Hello Caveh Jalali, Forest Mittelberg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81932?usp=email
to look at the new patch set (#3).
Change subject: ec/google/chromeec: Update EC headers
......................................................................
ec/google/chromeec: Update EC headers
Generated using update_ec_headers.sh [EC-DIR].
The original include/ec_commands.h version in the EC repo is:
9fdd96bfc6 keyboard: Add support for a "Dictation" key
The original include/ec_cmd_api.h version in the EC repo is:
562316a71e include: Add fingerprint host commands to ec_cmd_api.h
Change-Id: I7ec965d07aa4cb1fe54916845780f342ea3debb9
Signed-off-by: Aseda Aboagye <aaboagye(a)google.com>
---
M src/ec/google/chromeec/ec_cmd_api.h
M src/ec/google/chromeec/ec_commands.h
2 files changed, 154 insertions(+), 79 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/81932/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ec965d07aa4cb1fe54916845780f342ea3debb9
Gerrit-Change-Number: 81932
Gerrit-PatchSet: 3
Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Caveh Jalali, Forest Mittelberg.
Hello Caveh Jalali, Forest Mittelberg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81932?usp=email
to look at the new patch set (#2).
Change subject: Generated using update_ec_headers.sh [EC-DIR]
......................................................................
Generated using update_ec_headers.sh [EC-DIR]
The original include/ec_commands.h version in the EC repo is:
9fdd96bfc6 keyboard: Add support for a "Dictation" key
The original include/ec_cmd_api.h version in the EC repo is:
562316a71e include: Add fingerprint host commands to ec_cmd_api.h
Change-Id: I7ec965d07aa4cb1fe54916845780f342ea3debb9
Signed-off-by: Aseda Aboagye <aaboagye(a)google.com>
---
M src/ec/google/chromeec/ec_cmd_api.h
M src/ec/google/chromeec/ec_commands.h
2 files changed, 154 insertions(+), 79 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/81932/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ec965d07aa4cb1fe54916845780f342ea3debb9
Gerrit-Change-Number: 81932
Gerrit-PatchSet: 2
Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Joel Linn, Matt DeVillier, Nicholas Chin, Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Gerrit-Change-Number: 81368
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Apr 2024 20:43:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Joel Linn, Matt DeVillier, Nicholas Chin, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Gerrit-Change-Number: 81368
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Apr 2024 20:06:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Felix Singer, Matt DeVillier, Nicholas Chin, Nico Huber.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
......................................................................
Patch Set 6:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81368/comment/8bbfc85a_5c986163 :
PS5, Line 12: All peripherals should work.
: Automatic fan control as well as S3 are working.
: The board was tested to boot Linux and Windows. EHCI debug is untested.
: When using MrChromebox edk2 with secure boot build in, the board will
: hang on each boot for about 20 seconds before continuing.
> Should probably prefix these with bullet points, e.g. `* `.
Done
File src/mainboard/hp/pro_3500_series/Makefile.mk:
PS5:
> Add a blank line between each stage for better distinction.
Done
File src/mainboard/hp/pro_3500_series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81368/comment/9103c5eb_c6969dd0 :
PS5, Line 11: device ref host_bridge on end
> Enabled in chipset devicetree
Done
https://review.coreboot.org/c/coreboot/+/81368/comment/088df9f1_c5293d57 :
PS5, Line 16: register "docking_supported" = "0"
> Doesn't have any effect, set to 0 anyway.
Done
https://review.coreboot.org/c/coreboot/+/81368/comment/b779d368_9619434e :
PS5, Line 27: device ref mei1 on end
> Enabled in chipset devicetree
Done
https://review.coreboot.org/c/coreboot/+/81368/comment/71218bbc_ad3b8271 :
PS5, Line 36: # LPC bridge
> Remove superfluous comment
Done
https://review.coreboot.org/c/coreboot/+/81368/comment/46934328_9cb4ecb2 :
PS5, Line 96: device ref smbus on end
> Enabled in chipset devicetree
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Gerrit-Change-Number: 81368
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Apr 2024 19:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Felix Singer, Joel Linn, Matt DeVillier, Nicholas Chin, Nico Huber.
Hello Angel Pons, Felix Singer, Matt DeVillier, Nicholas Chin, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81368?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Code-Review+2 by Felix Singer, Code-Review+2 by Nico Huber, Verified+1 by build bot (Jenkins)
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
......................................................................
mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
This is another readily available (used market) system.
Based on autoport.
* All peripherals should work.
* Automatic fan control as well as S3 are working.
* The board was tested to boot Linux and Windows. EHCI debug is
untested.
* When using MrChromebox edk2 with secure boot build in, the board will
hang on each boot for about 20 seconds before continuing.
There are some quirks for doing the first flash, see the documentation.
Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Signed-off-by: Joel Linn <jl(a)conductive.de>
---
A Documentation/mainboard/hp/pro_3500_series.md
A Documentation/mainboard/hp/pro_3500_series_flash.avif
A Documentation/mainboard/hp/pro_3500_series_jumper.avif
M Documentation/mainboard/index.md
A src/mainboard/hp/pro_3500_series/Kconfig
A src/mainboard/hp/pro_3500_series/Kconfig.name
A src/mainboard/hp/pro_3500_series/Makefile.mk
A src/mainboard/hp/pro_3500_series/acpi/ec.asl
A src/mainboard/hp/pro_3500_series/acpi/platform.asl
A src/mainboard/hp/pro_3500_series/acpi/superio.asl
A src/mainboard/hp/pro_3500_series/acpi_tables.c
A src/mainboard/hp/pro_3500_series/board_info.txt
A src/mainboard/hp/pro_3500_series/common_defines.h
A src/mainboard/hp/pro_3500_series/data.vbt
A src/mainboard/hp/pro_3500_series/devicetree.cb
A src/mainboard/hp/pro_3500_series/dsdt.asl
A src/mainboard/hp/pro_3500_series/early_init.c
A src/mainboard/hp/pro_3500_series/gma-mainboard.ads
A src/mainboard/hp/pro_3500_series/gpio.c
A src/mainboard/hp/pro_3500_series/hda_verb.c
A src/mainboard/hp/pro_3500_series/led.c
A src/mainboard/hp/pro_3500_series/led.h
A src/mainboard/hp/pro_3500_series/mainboard.c
A src/mainboard/hp/pro_3500_series/smihandler.c
24 files changed, 709 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81368/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a
Gerrit-Change-Number: 81368
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: newpatchset