November 2018 - coreboot-gerrit

Change in ...coreboot[master]: arch/x86/Kconfig: move MAX_REBOOT_CNT option
by Nico Huber (Code Review) Nov. 30, 2018

Nov. 30, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29979 ) Change subject: arch/x86/Kconfig: move MAX_REBOOT_CNT option ...................................................................... Patch Set 2: (1 comment) Currently, you can't set wrong values. That's a feature I'd like to have maintained. Everything below the currently defined defaults is wrong. In other words, this option was hidden on purpose. You can add another option for instance and take the minimum of both or something like that. But you mustn't lower it. https://review.coreboot.org/#/c/29979/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29979/1//COMMIT_MSG@11 PS1, Line 11: > It only adds the entry, so you don't have to change it in the config file by hand. […] It's not about complete reboots. If you'd set it to 2 you might get false fallbacks (because a single reboot can result in coreboot resetting again, without anything failing). -- To view, visit https://review.coreboot.org/c/coreboot/+/29979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice26e2ef349f1172b564edc14f1012c33546a93c Gerrit-Change-Number: 29979 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Reviewer: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 30 Nov 2018 23:59:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID
by Lijian Zhao (Code Review) Nov. 30, 2018

Nov. 30, 2018

Hello Jairaj Arava, Patrick Rudolph, Pratikkumar V Prajapati, Subrata Banik, Sathyanarayana Nujella, build bot (Jenkins), Krzysztof M Sywula, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29651 to look at the new patch set (#5). Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID ...................................................................... soc/intel/cannonlake: Program HD Audio SVID/SSID Realtek Codec kernel driver requires PCH HD Audio controller to have subystem vendor id and subsystem device id matched with verb table. So program same values to make it working. BUG=b:119058355,b:119054586 TEST=Boot up on Sarien board and check with kernel driver dmesg to see ALC3204 or ALC3254. Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/fsp_params.c A src/soc/intel/cannonlake/include/soc/hda_ssid.h 3 files changed, 65 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/29651/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/29651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Gerrit-Change-Number: 29651 Gerrit-PatchSet: 5 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID
by Nico Huber (Code Review) Nov. 30, 2018

Nov. 30, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 ) Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID ...................................................................... Patch Set 3: Is this just setting subsystem ids of a PCI device? These should be set in the devicetree and no blob needed. If yes, this seems backwards. Shouldn't we set the id of the PCI device first and when configuring the codec take the id of the PCI device? -- To view, visit https://review.coreboot.org/c/coreboot/+/29651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Gerrit-Change-Number: 29651 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 30 Nov 2018 23:49:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID
by Lijian Zhao (Code Review) Nov. 30, 2018

Nov. 30, 2018

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 ) Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID ...................................................................... Patch Set 4: > Patch Set 1: > > Could we do this at the SOC level? > > If we had a Kconfig entry in the SOC that allowed the mainboard to define an HDA codec device ID then the SOC level code could have this structure (filled with CONFIG_SUBSYSTEM_VENDOR_ID and something like CONFIG_HDA_CODEC_ID) and pass it to FSP if HDA is enabled. Done, moved to SOC level and add HDA_CODEC_ID -- To view, visit https://review.coreboot.org/c/coreboot/+/29651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Gerrit-Change-Number: 29651 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Comment-Date: Fri, 30 Nov 2018 23:49:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID
by Lijian Zhao (Code Review) Nov. 30, 2018

Nov. 30, 2018

Hello Jairaj Arava, Patrick Rudolph, Pratikkumar V Prajapati, Subrata Banik, Sathyanarayana Nujella, build bot (Jenkins), Krzysztof M Sywula, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29651 to look at the new patch set (#4). Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID ...................................................................... soc/intel/cannonlake: Program HD Audio SVID/SSID Realtek Codec kernel driver requires PCH HD Audio controller to have subystem vendor id and subsystem device id matched with verb table. So program same values to make it working. BUG=b:119058355,b:119054586 TEST=Boot up on Sarien board and check with kernel driver dmesg to see ALC3204 or ALC3254. Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/fsp_params.c A src/soc/intel/cannonlake/include/soc/hda_ssid.h 3 files changed, 65 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/29651/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/29651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Gerrit-Change-Number: 29651 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID
by Lijian Zhao (Code Review) Nov. 30, 2018

Nov. 30, 2018

Hello Jairaj Arava, Patrick Rudolph, Pratikkumar V Prajapati, Subrata Banik, Sathyanarayana Nujella, build bot (Jenkins), Krzysztof M Sywula, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29651 to look at the new patch set (#3). Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID ...................................................................... soc/intel/cannonlake: Program HD Audio SVID/SSID Realtek Codec kernel driver requires PCH HD Audio controller to have subystem vendor id and subsystem device id matched with verb table. So program same values to make it working. BUG=b:119058355,b:119054586 TEST=Boot up on Sarien board and check with kernel driver dmesg to see ALC3204 or ALC3254. Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/fsp_params.c A src/soc/intel/cannonlake/include/soc/hda_ssid.h 3 files changed, 62 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/29651/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Gerrit-Change-Number: 29651 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID
by Lijian Zhao (Code Review) Nov. 30, 2018

Nov. 30, 2018

Hello Jairaj Arava, Pratikkumar V Prajapati, Subrata Banik, Sathyanarayana Nujella, build bot (Jenkins), Krzysztof M Sywula, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29651 to look at the new patch set (#2). Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID ...................................................................... soc/intel/cannonlake: Program HD Audio SVID/SSID Realtek Codec kernel driver requires PCH HD Audio controller to have subystem vendor id and subsystem device id matched with verb table. So program same values to make it working. BUG=b:119058355,b:119054586 TEST=Boot up on Sarien board and check with kernel driver dmesg to see ALC3204 or ALC3254. Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/mainboard/google/sarien/ramstage.c M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/fsp_params.c A src/soc/intel/cannonlake/include/soc/hda_ssid.h 4 files changed, 63 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/29651/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29651 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 Gerrit-Change-Number: 29651 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/{zoombini, sarien}: Use common CPU ACPI code
by Duncan Laurie (Code Review) Nov. 30, 2018

Nov. 30, 2018

Duncan Laurie has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29755 ) Change subject: mb/google/{zoombini,sarien}: Use common CPU ACPI code ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/29755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief3de0c8061fd1a985fecbc355062eb23d046d6d Gerrit-Change-Number: 29755 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Remove CPU ACPI code
by Duncan Laurie (Code Review) Nov. 30, 2018

Nov. 30, 2018

Duncan Laurie has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29756 ) Change subject: soc/intel/cannonlake: Remove CPU ACPI code ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/29756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id526dc503f278b5cf3a8ce5ccec6f751aa777df0 Gerrit-Change-Number: 29756 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: ec/google/wilco: Turn camera power on
by Duncan Laurie (Code Review) Nov. 30, 2018

Nov. 30, 2018

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29987 Change subject: ec/google/wilco: Turn camera power on ...................................................................... ec/google/wilco: Turn camera power on Send the EC command required to turn the camera power on and verify that it shows up on the USB bus. Change-Id: I9e9ba712a11cef85cde91ac21a4b6b5090ef58dc Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/ec/google/wilco/chip.c M src/ec/google/wilco/commands.h 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/29987/1 diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c index e1f468d..a9caaec 100644 --- a/src/ec/google/wilco/chip.c +++ b/src/ec/google/wilco/chip.c @@ -69,6 +69,9 @@ /* Enable WiFi radio */ wilco_ec_radio_control(RADIO_WIFI, 1); + + /* Turn on camera power */ + wilco_ec_send(KB_CAMERA, CAMERA_ON); } static void wilco_ec_resource(struct device *dev, int index, diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h index 0989b20..752e19b 100644 --- a/src/ec/google/wilco/commands.h +++ b/src/ec/google/wilco/commands.h @@ -32,6 +32,8 @@ KB_SAVE = 0x2f, /* Restore PS/2 data after S3 resume */ KB_RESTORE = 0x30, + /* Manage the EC control of camera power */ + KB_CAMERA = 0x33, /* Retrieve information about the EC */ KB_EC_INFO = 0x38, /* Set ACPI mode on or off */ @@ -67,6 +69,11 @@ RADIO_WIFI = 0x02, }; +enum ec_camera { + CAMERA_ON = 0, + CAMERA_OFF +}; + /** * wilco_ec_radio_control() - Control wireless radios. * @ec_radio: Wireless radio type. -- To view, visit https://review.coreboot.org/c/coreboot/+/29987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e9ba712a11cef85cde91ac21a4b6b5090ef58dc Gerrit-Change-Number: 29987 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-MessageType: newchange

1 0