July 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: fsp driver: Call cbmem_init_top
by John Zhao (Code Review) Aug. 1, 2017

Aug. 1, 2017

Hello John Zhao, I'd like you to do a code review. Please visit https://review.coreboot.org/20833 to review the following change. Change subject: fsp driver: Call cbmem_init_top ...................................................................... fsp driver: Call cbmem_init_top Initialize cbmem_top Change-Id: I82ffe35980ee3896bf58867830e128fe6767ab53 Signed-off-by: zhaojohn <john.zhao(a)intel.com> --- M src/drivers/intel/fsp2_0/memory_init.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/20833/1 diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c index e982576..859b045 100644 --- a/src/drivers/intel/fsp2_0/memory_init.c +++ b/src/drivers/intel/fsp2_0/memory_init.c @@ -125,6 +125,8 @@ if (fsp_find_reserved_memory(&fsp_mem)) die("Failed to find FSP_RESERVED_MEMORY_RESOURCE_HOB!\n"); + cbmem_init_top(); + /* initialize cbmem by adding FSP reserved memory first thing */ if (!s3wake) { cbmem_initialize_empty_id_size(CBMEM_ID_FSP_RESERVED_MEMORY, -- To view, visit https://review.coreboot.org/20833 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I82ffe35980ee3896bf58867830e128fe6767ab53 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add memory map support
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20533 ) Change subject: soc/intel/cannonlake: Add memory map support ...................................................................... Patch Set 14: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58080/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13513/ : SUCCESS -- To view, visit https://review.coreboot.org/20533 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dcc8f737c5811c9010cc4a20ea0126ab3f90f14 Gerrit-Change-Number: 20533 Gerrit-PatchSet: 14 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 23:25:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add memory map support
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20533 ) Change subject: soc/intel/cannonlake: Add memory map support ...................................................................... Patch Set 13: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58079/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13512/ : SUCCESS -- To view, visit https://review.coreboot.org/20533 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dcc8f737c5811c9010cc4a20ea0126ab3f90f14 Gerrit-Change-Number: 20533 Gerrit-PatchSet: 13 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 22:07:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Documentation: Add binary extraction documentation
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20753 ) Change subject: Documentation: Add binary extraction documentation ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58078/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13511/ : SUCCESS -- To view, visit https://review.coreboot.org/20753 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia31b01afc66789f95c7d21a0d41b532bc19a6430 Gerrit-Change-Number: 20753 Gerrit-PatchSet: 6 Gerrit-Owner: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 21:36:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/northbridge: Add guards on all header files
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20747 ) Change subject: src/northbridge: Add guards on all header files ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58076/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13509/ : SUCCESS -- To view, visit https://review.coreboot.org/20747 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93b939478615f22f2c078b1efb7999ad4f3a4c28 Gerrit-Change-Number: 20747 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 20:49:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: depthcharge: Fix ominous warning on make clean
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20724 ) Change subject: depthcharge: Fix ominous warning on make clean ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58077/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13510/ : SUCCESS -- To view, visit https://review.coreboot.org/20724 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d4bb0fbdbdefecd87336ea0c12ba0df7f5e7425 Gerrit-Change-Number: 20724 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 20:35:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/include: Add guards on all header files
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20734 ) Change subject: src/include: Add guards on all header files ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58074/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13507/ : SUCCESS -- To view, visit https://review.coreboot.org/20734 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d7d4e0b25f2cf3eef2040f89d5ebc711909cdd7 Gerrit-Change-Number: 20734 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 20:33:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/arch: Add guards on all header files
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20733 ) Change subject: src/arch: Add guards on all header files ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58075/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13508/ : SUCCESS -- To view, visit https://review.coreboot.org/20733 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ddb1ab6000016cc31ffc16be729d1245f208a3 Gerrit-Change-Number: 20733 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 20:31:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add mainboard GPIOs to ACPI
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20313 ) Change subject: google/kahlee: Add mainboard GPIOs to ACPI ...................................................................... Patch Set 18: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58073/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13506/ : SUCCESS -- To view, visit https://review.coreboot.org/20313 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b5952ed3934b938cb50650890a7b434e6306fd1 Gerrit-Change-Number: 20313 Gerrit-PatchSet: 18 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 17:38:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 2570p
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20489 ) Change subject: mainboard/hp: Add HP Elitebook 2570p ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58071/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13504/ : SUCCESS -- To view, visit https://review.coreboot.org/20489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f3cd124fc676d49add59e9f0a07f70a6bb0fff0 Gerrit-Change-Number: 20489 Gerrit-PatchSet: 12 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 31 Jul 2017 17:37:42 +0000 Gerrit-HasComments: No

1 0