December 2017 - coreboot-gerrit

Change in coreboot[master]: mainboard/asus/am1i-a: add support for board ASUS AM1I-A
by build bot (Jenkins) (Code Review) Dec. 31, 2017

Dec. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23002 ) Change subject: mainboard/asus/am1i-a: add support for board ASUS AM1I-A ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19858/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65111/ : SUCCESS -- To view, visit https://review.coreboot.org/23002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d9432849560df81536bbb2ce4c87cd265b820f7 Gerrit-Change-Number: 23002 Gerrit-PatchSet: 3 Gerrit-Owner: Gergely Kiss <mail.gery(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 31 Dec 2017 20:33:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: superio/ite/it8623e: add support for SIO chip ITE IT8623E
by build bot (Jenkins) (Code Review) Dec. 31, 2017

Dec. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23001 ) Change subject: superio/ite/it8623e: add support for SIO chip ITE IT8623E ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19857/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65110/ : SUCCESS -- To view, visit https://review.coreboot.org/23001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05832c4db7ab59541337f11200640316376e792e Gerrit-Change-Number: 23001 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Kiss <mail.gery(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 31 Dec 2017 20:22:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add decode range for Environment Controller
by Arthur Heymans (Code Review) Dec. 30, 2017

Dec. 30, 2017

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23048 ) Change subject: mb/asrock/g41c-gs: Add decode range for Environment Controller ...................................................................... Patch Set 2: I'm repeating myself: https://review.coreboot.org/#/c/coreboot/+/21464/ :p -- To view, visit https://review.coreboot.org/23048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibff3dffaf0f5c32c3b12336a23839dee501e7160 Gerrit-Change-Number: 23048 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 20:57:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by build bot (Jenkins) (Code Review) Dec. 30, 2017

Dec. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23049 ) Change subject: [util/vgabios_extract] hookup to build system ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19856/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65109/ : SUCCESS -- To view, visit https://review.coreboot.org/23049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Gerrit-Change-Number: 23049 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 20:56:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by build bot (Jenkins) (Code Review) Dec. 30, 2017

Dec. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23049 ) Change subject: [util/vgabios_extract] hookup to build system ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/65108/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/19855/ : SUCCESS -- To view, visit https://review.coreboot.org/23049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Gerrit-Change-Number: 23049 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 20:47:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by Thomas Weißschuh (Code Review) Dec. 30, 2017

Dec. 30, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23049 to look at the new patch set (#3). Change subject: [util/vgabios_extract] hookup to build system ...................................................................... [util/vgabios_extract] hookup to build system Allows the automatic extraction and usage of a VGA BIOS from an UEFI dump. Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de> --- M src/arch/x86/Makefile.inc M src/device/Kconfig 2 files changed, 29 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/23049/3 -- To view, visit https://review.coreboot.org/23049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Gerrit-Change-Number: 23049 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by Thomas Weißschuh (Code Review) Dec. 30, 2017

Dec. 30, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23049 to look at the new patch set (#2). Change subject: [util/vgabios_extract] hookup to build system ...................................................................... [util/vgabios_extract] hookup to build system Allows the automatic extraction and usage of a VGA BIOS from an UEFI dump. Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de> --- M src/arch/x86/Makefile.inc M src/device/Kconfig 2 files changed, 29 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/23049/2 -- To view, visit https://review.coreboot.org/23049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Gerrit-Change-Number: 23049 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by build bot (Jenkins) (Code Review) Dec. 30, 2017

Dec. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23049 ) Change subject: [util/vgabios_extract] hookup to build system ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19854/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65107/ : SUCCESS -- To view, visit https://review.coreboot.org/23049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Gerrit-Change-Number: 23049 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 20:01:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [util/vgabios_extract] Do intial commit
by build bot (Jenkins) (Code Review) Dec. 30, 2017

Dec. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23045 ) Change subject: [util/vgabios_extract] Do intial commit ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/19853/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/65106/ : SUCCESS -- To view, visit https://review.coreboot.org/23045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a Gerrit-Change-Number: 23045 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Weißschuh <thomas(a)t-8ch.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Dec 2017 19:58:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [util/vgabios_extract] hookup to build system
by Thomas Weißschuh (Code Review) Dec. 30, 2017

Dec. 30, 2017

Thomas Weißschuh has uploaded this change for review. ( https://review.coreboot.org/23049 Change subject: [util/vgabios_extract] hookup to build system ...................................................................... [util/vgabios_extract] hookup to build system Allows the automatic extraction and usage of a VGA BIOS from an UEFI dump. Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Signed-off-by: Thomas Weißschuh <thomas(a)t-8ch.de> --- M src/arch/x86/Makefile.inc M src/device/Kconfig 2 files changed, 30 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/23049/1 diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index cc227b3..3f2f1e4 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -38,9 +38,24 @@ $(NVRAMTOOL) -y $(top)/src/mainboard/$(MAINBOARDDIR)/cmos.layout -H $@ endif # CONFIG_HAVE_OPTION_TABLE +vgabios-rom=$(obj)/vgabios.rom + +ifeq ($(CONFIG_VGA_BIOS_EXTRACT),y) + +$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_EXTRACT_FILE)) + @printf " VGA_BIOS_EXTRACT $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom)\n" + util/vgabios_extract/vgabios_extract.py $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom) + +else + +$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE)) + $(CP) $(vgabios-rom) $(CONFIG_VGA_BIOS_FILE) + +endif + stripped_vgabios_id = $(call strip_quotes,$(CONFIG_VGA_BIOS_ID)) cbfs-files-$(CONFIG_VGA_BIOS) += pci$(stripped_vgabios_id).rom -pci$(stripped_vgabios_id).rom-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE)) +pci$(stripped_vgabios_id).rom-file := $(vgabios-rom) pci$(stripped_vgabios_id).rom-type := optionrom cbfs-files-$(CONFIG_INTEL_MBI) += mbi.bin diff --git a/src/device/Kconfig b/src/device/Kconfig index 28298d5..a6b1168 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -566,11 +566,23 @@ like to add to your ROM. You will be able to specify the location and file name of the - image later. + false + +config VGA_BIOS_EXTRACT + bool "Extract VGA BIOS from BIOS image" + depends on VGA_BIOS + default n + +config VGA_BIOS_EXTRACT_FILE + string "VGA BIOS extract path and filename" + depends on VGA_BIOS_EXTRACT + default "3rdpart/blobs/mainboard/$(MAINBOARDDIR)/bios.bin" + help + The path and filename of the file to extract the VGA BIOS from. config VGA_BIOS_FILE string "VGA BIOS path and filename" - depends on VGA_BIOS + depends on VGA_BIOS && !VGA_BIOS_EXTRACT default "vgabios.bin" help The path and filename of the file to use as VGA BIOS. -- To view, visit https://review.coreboot.org/23049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I859cbc788a31b9a3e41c13ee7faccbc422505386 Gerrit-Change-Number: 23049 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Weißschuh <thomas(a)t-8ch.de>

1 0