February 2018 - coreboot-gerrit

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: include correct SND related DT entries
by build bot (Jenkins) (Code Review) March 1, 2018

March 1, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24918 ) Change subject: mainboard/intel/cannonlake_rvp: include correct SND related DT entries ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68092/ : SUCCESS -- To view, visit https://review.coreboot.org/24918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f9487f3a81ef2d24315f75ec1d34bfab8560224 Gerrit-Change-Number: 24918 Gerrit-PatchSet: 3 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Comment-Date: Wed, 28 Feb 2018 23:15:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/intel/glkrvp: Enable ThunderPeak wifi card
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23784 ) Change subject: mb/intel/glkrvp: Enable ThunderPeak wifi card ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68091/ : SUCCESS -- To view, visit https://review.coreboot.org/23784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5608876e236a7f03d5032c6ce2c8e87a2de91e20 Gerrit-Change-Number: 23784 Gerrit-PatchSet: 3 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Roy Mingi Park <roy.mingi.park(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 21:38:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: include correct SND related DT entries
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24918 ) Change subject: mainboard/intel/cannonlake_rvp: include correct SND related DT entries ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68078/ : SUCCESS -- To view, visit https://review.coreboot.org/24918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f9487f3a81ef2d24315f75ec1d34bfab8560224 Gerrit-Change-Number: 24918 Gerrit-PatchSet: 2 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Assignee: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Comment-Date: Wed, 28 Feb 2018 20:14:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: include correct SND related DT entries
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24918 ) Change subject: mainboard/intel/cannonlake_rvp: include correct SND related DT entries ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68077/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22541/ : SUCCESS -- To view, visit https://review.coreboot.org/24918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f9487f3a81ef2d24315f75ec1d34bfab8560224 Gerrit-Change-Number: 24918 Gerrit-PatchSet: 1 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Assignee: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Comment-Date: Wed, 28 Feb 2018 20:10:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: include correct SND related DT entries
by Sathyanarayana Nujella (Code Review) Feb. 28, 2018

Feb. 28, 2018

Sathyanarayana Nujella has uploaded a new patch set (#2). ( https://review.coreboot.org/24918 ) Change subject: mainboard/intel/cannonlake_rvp: include correct SND related DT entries ...................................................................... mainboard/intel/cannonlake_rvp: include correct SND related DT entries For cannonlake_rvp, want to support two SND configurations based on relevant daughter board connected (either of these configurations: SND_MAX98373_NHLT and SND_MAX98357_DA7219_NHLT). By default SSDT included all codec entries. This patch corrects and includes relevant codec entries in SSDT BUG=None BRANCH=master TEST=Verify 'emerge-cnlrvp coreboot' compiles successfully Change-Id: I4f9487f3a81ef2d24315f75ec1d34bfab8560224 Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> --- M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb 2 files changed, 26 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/24918/2 -- To view, visit https://review.coreboot.org/24918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f9487f3a81ef2d24315f75ec1d34bfab8560224 Gerrit-Change-Number: 24918 Gerrit-PatchSet: 2 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Assignee: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: include correct SND related DT entries
by Sathyanarayana Nujella (Code Review) Feb. 28, 2018

Feb. 28, 2018

Sathyanarayana Nujella has uploaded this change for review. ( https://review.coreboot.org/24918 Change subject: mainboard/intel/cannonlake_rvp: include correct SND related DT entries ...................................................................... mainboard/intel/cannonlake_rvp: include correct SND related DT entries For cannonlake_rvp, want to support two SND configurations based on relevant daughter board connected (either of these configurations: SND_MAX98373_NHLT and SND_MAX98357_DA7219_NHLT). By default SSDT included all codec entries. This patch corrects and includes relevant codec entries in SSDT Change-Id: I4f9487f3a81ef2d24315f75ec1d34bfab8560224 Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> --- M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb 2 files changed, 26 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/24918/1 diff --git a/src/mainboard/intel/cannonlake_rvp/Kconfig b/src/mainboard/intel/cannonlake_rvp/Kconfig index fb6f9b1..3104331 100644 --- a/src/mainboard/intel/cannonlake_rvp/Kconfig +++ b/src/mainboard/intel/cannonlake_rvp/Kconfig @@ -3,9 +3,6 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_DA7219 - select DRIVERS_I2C_MAX98373 select GENERIC_SPD_BIN select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES @@ -51,6 +48,8 @@ config INCLUDE_SND_MAX98357_DA7219_NHLT bool "Include blobs for audio with MAX98357_DA7219" + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_DA7219 select NHLT_DMIC_4CH_16B select NHLT_DMIC_2CH_16B select NHLT_DA7219 @@ -58,6 +57,7 @@ config INCLUDE_SND_MAX98373_NHLT bool "Include blobs for audio with MAX98373" + select DRIVERS_I2C_MAX98373 select NHLT_DMIC_4CH_16B select NHLT_DMIC_2CH_16B select NHLT_MAX98373 diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb index 8502048..17cb2cb 100644 --- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb +++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb @@ -32,6 +32,8 @@ register "PchHdaDspEnable" = "1" register "PchHdaAudioLinkHda" = "1" + register "PchHdaAudioLinkSsp0" = "1" + register "PchHdaAudioLinkSsp1" = "1" register "PcieRpEnable[0]" = "1" register "PcieRpEnable[1]" = "1" @@ -91,6 +93,24 @@ device pci 15.1 on end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 on + #if IS_ENABLED(CONFIG_INCLUDE_SND_MAX98373_NHLT) + chip drivers/i2c/max98373 + register "vmon_slot_no" = "4" + register "imon_slot_no" = "5" + register "uid" = "0" + register "desc" = ""RIGHT SPEAKER AMP"" + register "name" = ""MAXR"" + device i2c 31 on end + end + chip drivers/i2c/max98373 + register "vmon_slot_no" = "6" + register "imon_slot_no" = "7" + register "uid" = "1" + register "desc" = ""LEFT SPEAKER AMP"" + register "name" = ""MAXL"" + device i2c 32 on end + end + #elif IS_ENABLED(CONFIG_INCLUDE_SND_MAX98357_DA7219_NHLT) chip drivers/i2c/da7219 register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A20)" register "btn_cfg" = "50" @@ -108,6 +128,7 @@ register "mic_amp_in_sel" = ""diff"" device i2c 1a on end end + #endif end # I2C #3 device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 @@ -144,6 +165,7 @@ end # LPC Interface device pci 1f.1 on end # P2SB device pci 1f.2 on end # Power Management Controller + #if IS_ENABLED(CONFIG_INCLUDE_SND_MAX98357_DA7219_NHLT) device pci 1f.3 on chip drivers/generic/max98357a register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)" @@ -151,6 +173,7 @@ device generic 0 on end end end # Intel HDA + #endif device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI device pci 1f.6 off end # GbE -- To view, visit https://review.coreboot.org/24918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4f9487f3a81ef2d24315f75ec1d34bfab8560224 Gerrit-Change-Number: 24918 Gerrit-PatchSet: 1 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable NVMe
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23208 ) Change subject: mainboard/google/zoombini/variants/meowth: enable NVMe ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68076/ : SUCCESS -- To view, visit https://review.coreboot.org/23208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I272b63b11e6b00ae5bdbef5a37ee517cc0636f6d Gerrit-Change-Number: 23208 Gerrit-PatchSet: 4 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 20:03:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/zoombini/variants/meowth: enable NVMe
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23208 ) Change subject: mainboard/google/zoombini/variants/meowth: enable NVMe ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68075/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22540/ : SUCCESS -- To view, visit https://review.coreboot.org/23208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I272b63b11e6b00ae5bdbef5a37ee517cc0636f6d Gerrit-Change-Number: 23208 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:48:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/{amd/gardenia, google/kahlee}: Initialize GPIOs earlier
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24916 ) Change subject: mb/{amd/gardenia,google/kahlee}: Initialize GPIOs earlier ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68073/ : SUCCESS -- To view, visit https://review.coreboot.org/24916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568a3240a54817ab6dcf15fe39f7f1336943852b Gerrit-Change-Number: 24916 Gerrit-PatchSet: 6 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:41:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Fizz: Check HDMI HPD and DisplayPort HPD
by build bot (Jenkins) (Code Review) Feb. 28, 2018

Feb. 28, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23816 ) Change subject: Fizz: Check HDMI HPD and DisplayPort HPD ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/68072/ : SUCCESS -- To view, visit https://review.coreboot.org/23816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e1afdffbebf4caf35bbb792e7f4637fae89fa49 Gerrit-Change-Number: 23816 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 28 Feb 2018 19:37:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0