June 2018 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: [Do Not Merge] add i945G based mainboard
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25509 ) Change subject: [Do Not Merge] add i945G based mainboard ...................................................................... Patch Set 18: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29692/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75635/ : SUCCESS -- To view, visit https://review.coreboot.org/25509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5398b990c26d087afb20e4b1028a7a1cad4b3ee3 Gerrit-Change-Number: 25509 Gerrit-PatchSet: 18 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 10:37:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/cpu/intel: Add model_f6x
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25565 ) Change subject: src/cpu/intel: Add model_f6x ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29691/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75634/ : SUCCESS -- To view, visit https://review.coreboot.org/25565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6003ec0f4d4245ce5fc9c1f38e555bfcfa1c22b5 Gerrit-Change-Number: 25565 Gerrit-PatchSet: 10 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 30 Jun 2018 10:33:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [Do Not Merge] add i945G based mainboard
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25509 ) Change subject: [Do Not Merge] add i945G based mainboard ...................................................................... Patch Set 18: (8 comments) https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… File src/mainboard/nec/945g-m4/superio_hwm.c: https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 83: //if (get_option(&cpufan_temperature, "cpufan_temperature") != CB_SUCCESS) line over 80 characters https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 90: //if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS) line over 80 characters https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 135: hwm_write(0x06, fan_speeds[cpufan_speed].fan_in); // CPUFANIN target speed line over 80 characters https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 140: temperatures[cpufan_temperature].deg_fahrenheit); line over 80 characters https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 141: hwm_write(0x06, temperatures[cpufan_temperature].deg_celsius); // CPUFANIN target temperature line over 80 characters https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 149: hwm_write(0x05, fan_speeds[sysfan_speed].fan_in); // SYSFANIN target speed line over 80 characters https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 154: temperatures[sysfan_temperature].deg_fahrenheit); line over 80 characters https://review.coreboot.org/#/c/25509/18/src/mainboard/nec/945g-m4/superio_… PS18, Line 155: hwm_write(0x05, temperatures[sysfan_temperature].deg_celsius); // SYSFANIN target temperature line over 80 characters -- To view, visit https://review.coreboot.org/25509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5398b990c26d087afb20e4b1028a7a1cad4b3ee3 Gerrit-Change-Number: 25509 Gerrit-PatchSet: 18 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 10:31:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29690/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75633/ : SUCCESS -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 10:31:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/intel/speedstep/acpi.c: Add Netburst CPUs
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22604 ) Change subject: cpu/intel/speedstep/acpi.c: Add Netburst CPUs ...................................................................... Patch Set 13: (13 comments) https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c File src/cpu/intel/speedstep/acpi.c: https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c@68 PS13, Line 68: if ( c.x86_model ==2) spaces required around that '==' (ctx:WxV) https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c@68 PS13, Line 68: if ( c.x86_model ==2) space prohibited after that open parenthesis '(' https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/acpi.c@92 PS13, Line 92: else else is not generally useful after a break or return https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.c File src/cpu/intel/speedstep/speedstep.c: https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 45: if (((rdmsr(MSR_EXTENDED_CONFIG).lo >> 27) & 3) == 3) {/*supported and line over 80 characters https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 46: enabled bits */ line over 80 characters https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 48: params->slfm = SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask); line over 80 characters https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 52: } code indent should use tabs where possible https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 52: } please, no spaces at the start of a line https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 73: if (!(((cpuid_eax(1) >> 8) & 0xf) == 0xf)) { suspect code indent for conditional statements (8, 8) https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 77: !(rdmsr(IA32_MISC_ENABLES).hi & (1 << (38 - 32)))) { line over 80 characters https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 79: params->turbo = SPEEDSTEP_STATE_FROM_MSR(msr.hi, state_mask); line over 80 characters https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 82: } code indent should use tabs where possible https://review.coreboot.org/#/c/22604/13/src/cpu/intel/speedstep/speedstep.… PS13, Line 82: } please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/22604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e162d3260dedeb3b16583460633507fbcbd52a Gerrit-Change-Number: 22604 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 10:31:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Programm proper ODT values
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18548 ) Change subject: nb/intel/i945: Programm proper ODT values ...................................................................... Patch Set 14: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29689/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75632/ : SUCCESS -- To view, visit https://review.coreboot.org/18548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c Gerrit-Change-Number: 18548 Gerrit-PatchSet: 14 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 09:04:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Programm proper ODT values
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18548 ) Change subject: nb/intel/i945: Programm proper ODT values ...................................................................... Patch Set 13: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75631/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29688/ : SUCCESS -- To view, visit https://review.coreboot.org/18548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c Gerrit-Change-Number: 18548 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 08:53:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Programm proper ODT values
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18548 ) Change subject: nb/intel/i945: Programm proper ODT values ...................................................................... Patch Set 12: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29687/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/75630/ : ABORTED -- To view, visit https://review.coreboot.org/18548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c Gerrit-Change-Number: 18548 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 08:47:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/i945/raminit: Correct C0DRAMW & C1DRAMW for 4 DIMMs
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18387 ) Change subject: nb/i945/raminit: Correct C0DRAMW & C1DRAMW for 4 DIMMs ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29686/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75629/ : SUCCESS -- To view, visit https://review.coreboot.org/18387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1f999447b37a1524d589552ea2eec640c2a2c7e Gerrit-Change-Number: 18387 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 08:46:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Programm proper ODT values
by build bot (Jenkins) (Code Review) June 30, 2018

June 30, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18548 ) Change subject: nb/intel/i945: Programm proper ODT values ...................................................................... Patch Set 11: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75628/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29685/ : SUCCESS -- To view, visit https://review.coreboot.org/18548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c Gerrit-Change-Number: 18548 Gerrit-PatchSet: 11 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Jun 2018 08:32:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0