May 2018 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan p...
by build bot (Jenkins) (Code Review) June 1, 2018

June 1, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26725 ) Change subject: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73859/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27972/ : SUCCESS -- To view, visit https://review.coreboot.org/26725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e Gerrit-Change-Number: 26725 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 22:49:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence
by build bot (Jenkins) (Code Review) June 1, 2018

June 1, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26724 ) Change subject: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73858/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27971/ : SUCCESS -- To view, visit https://review.coreboot.org/26724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifeea545fe268be249793b3e508c51f5e4c1a3460 Gerrit-Change-Number: 26724 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 22:47:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801gx: Remove unneeded includes
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26742 ) Change subject: sb/intel/i82801gx: Remove unneeded includes ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73853/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27966/ : SUCCESS -- To view, visit https://review.coreboot.org/26742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbb80cb28833131e3b02a8ff583d53c52ef2ca0f Gerrit-Change-Number: 26742 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 20:28:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: sb/intel/i82801gx: Remove unneeded includes
by Elyes HAOUAS (Code Review) May 31, 2018

May 31, 2018

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26742 Change subject: sb/intel/i82801gx: Remove unneeded includes ...................................................................... sb/intel/i82801gx: Remove unneeded includes Change-Id: Ibbb80cb28833131e3b02a8ff583d53c52ef2ca0f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/i82801gx/nic.c M src/southbridge/intel/i82801gx/smbus.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/26742/1 diff --git a/src/southbridge/intel/i82801gx/nic.c b/src/southbridge/intel/i82801gx/nic.c index d525ed4..a4c9bae 100644 --- a/src/southbridge/intel/i82801gx/nic.c +++ b/src/southbridge/intel/i82801gx/nic.c @@ -16,7 +16,6 @@ /* This code should work for all ICH* southbridges with a NIC. */ -#include <console/console.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801gx/smbus.c b/src/southbridge/intel/i82801gx/smbus.c index 72f78ea..917321c 100644 --- a/src/southbridge/intel/i82801gx/smbus.c +++ b/src/southbridge/intel/i82801gx/smbus.c @@ -14,7 +14,6 @@ * GNU General Public License for more details. */ -#include <console/console.h> #include <device/device.h> #include <device/path.h> #include <device/smbus.h> -- To view, visit https://review.coreboot.org/26742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibbb80cb28833131e3b02a8ff583d53c52ef2ca0f Gerrit-Change-Number: 26742 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: cpu/x86/mp: Update CPU name in device structure
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26740 ) Change subject: cpu/x86/mp: Update CPU name in device structure ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73852/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27965/ : SUCCESS -- To view, visit https://review.coreboot.org/26740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6af0e29bbbdb59406baeae32f7874ff9036a9c81 Gerrit-Change-Number: 26740 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 18:27:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of nextdev member in struct device
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26741 ) Change subject: util/sconfig: Get rid of nextdev member in struct device ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73851/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27964/ : SUCCESS -- To view, visit https://review.coreboot.org/26741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie50b3d769a78fe0beddba2e5551441b43cb212a2 Gerrit-Change-Number: 26741 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 18:15:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan p...
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26725 ) Change subject: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73850/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27963/ : SUCCESS -- To view, visit https://review.coreboot.org/26725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e Gerrit-Change-Number: 26725 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 18:11:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/x86/mp: Update CPU name in device structure
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26740 ) Change subject: cpu/x86/mp: Update CPU name in device structure ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73848/ : SUCCESS -- To view, visit https://review.coreboot.org/26740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6af0e29bbbdb59406baeae32f7874ff9036a9c81 Gerrit-Change-Number: 26740 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 18:08:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26724 ) Change subject: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73849/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27962/ : SUCCESS -- To view, visit https://review.coreboot.org/26724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifeea545fe268be249793b3e508c51f5e4c1a3460 Gerrit-Change-Number: 26724 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 18:07:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of nextdev member in struct device
by Furquan Shaikh (Code Review) May 31, 2018

May 31, 2018

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26741 Change subject: util/sconfig: Get rid of nextdev member in struct device ...................................................................... util/sconfig: Get rid of nextdev member in struct device Now that chips and devices are treated differently and the device tree actually contains only devices, next and nextdev are exactly the same for all devices in the tree. This change gets rid of nextdev pointer and updates all uses of nextdev to next. BUG=80081934 TEST=Verified that static.c generated for all boards built by abuild is same with and without this change. Change-Id: Ie50b3d769a78fe0beddba2e5551441b43cb212a2 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c M util/sconfig/sconfig.h 2 files changed, 10 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/26741/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 32d7aac..10e6e67 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -20,7 +20,7 @@ extern int linenum; -struct device *head, *lastdev; +struct device *head, *lastnode; static struct chip chip_header; @@ -185,9 +185,9 @@ /* skip functions of the same device in sibling chain */ while (dev->sibling && dev->sibling->used) dev->sibling = dev->sibling->sibling; - /* skip duplicate function elements in nextdev chain */ - while (dev->nextdev && dev->nextdev->used) - dev->nextdev = dev->nextdev->nextdev; + /* skip duplicate function elements in next chain */ + while (dev->next && dev->next->used) + dev->next = dev->next->next; dev = dev->next_sibling; } } @@ -304,8 +304,8 @@ if (!parent->children) parent->children = new_d; - lastdev->nextdev = new_d; - lastdev = new_d; + lastnode->next = new_d; + lastnode = new_d; switch (bustype) { case PCI: @@ -546,8 +546,8 @@ if (chip_ins->chip->chiph_exists) fprintf(fil, "\t.chip_info = &%s_info_%d,\n", chip_ins->chip->name_underscore, chip_ins->id); - if (ptr->nextdev) - fprintf(fil, "\t.next=&%s\n", ptr->nextdev->name); + if (ptr->next) + fprintf(fil, "\t.next=&%s\n", ptr->next->name); fprintf(fil, "};\n"); } if (ptr->rescnt > 0) { @@ -748,7 +748,7 @@ yyrestart(filec); - lastdev = head = &root; + lastnode = head = &root; yyparse(); @@ -769,7 +769,7 @@ walk_device_tree(autogen, &root, pass0, NULL); fprintf(autogen, "\n/* pass 1 */\n" "DEVTREE_CONST struct device * DEVTREE_CONST last_dev = &%s;\n", - lastdev->name); + lastnode->name); walk_device_tree(autogen, &root, pass1, NULL); fclose(autogen); diff --git a/util/sconfig/sconfig.h b/util/sconfig/sconfig.h index d2a3d28..d71d5ef 100644 --- a/util/sconfig/sconfig.h +++ b/util/sconfig/sconfig.h @@ -98,7 +98,6 @@ struct device *parent; struct device *next; - struct device *nextdev; struct device *children; struct device *latestchild; struct device *next_sibling; -- To view, visit https://review.coreboot.org/26741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie50b3d769a78fe0beddba2e5551441b43cb212a2 Gerrit-Change-Number: 26741 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0