coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install
by Felix Held (Code Review) 15 Apr '24

15 Apr '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81858?usp=email ) Change subject: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install ...................................................................... soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install Mark eMMC as non-removable to allow Windows 10/11 to install now that edk2 can boot from it. Change-Id: If0e14106521f99cb97d1bf421f4d82d1234c2f15 Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81858 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/soc/amd/picasso/acpi/mmio.asl 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Eric Lai: Looks good to me, but someone else must approve Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/amd/picasso/acpi/mmio.asl b/src/soc/amd/picasso/acpi/mmio.asl index 8adc87d..d8bbf06 100644 --- a/src/soc/amd/picasso/acpi/mmio.asl +++ b/src/soc/amd/picasso/acpi/mmio.asl @@ -92,6 +92,15 @@ { Return (STAT) } + + Device (CARD) + { + Name (_ADR, 0x00000008) + Method (_RMV, 0, NotSerialized) + { + Return (0) + } + } } Device (FUR0) -- To view, visit https://review.coreboot.org/c/coreboot/+/81858?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0e14106521f99cb97d1bf421f4d82d1234c2f15 Gerrit-Change-Number: 81858 Gerrit-PatchSet: 3 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: util/inteltool: add MTL DEVICE_IDs to remaining files
by Filip Lewiński (Code Review) 15 Apr '24

15 Apr '24

Filip Lewiński has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81913?usp=email ) Change subject: util/inteltool: add MTL DEVICE_IDs to remaining files ...................................................................... util/inteltool: add MTL DEVICE_IDs to remaining files Change-Id: I61c43eea1316c0c5636e34bafca1730905a2f008 Signed-off-by: Filip Lewiński <filip.lewinski(a)3mdeb.com> --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c M util/inteltool/inteltool.c 3 files changed, 43 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/81913/1 diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c index ba3439a..93fea5c 100644 --- a/util/inteltool/gpio.c +++ b/util/inteltool/gpio.c @@ -1126,6 +1126,12 @@ case PCI_DEVICE_ID_INTEL_JSL: case PCI_DEVICE_ID_INTEL_EHL: case PCI_DEVICE_ID_INTEL_EBG: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_M: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_1: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_2: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_3: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_4: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_5: print_gpio_groups(sb); return 0; case PCI_DEVICE_ID_INTEL_82371XX: diff --git a/util/inteltool/gpio_groups.c b/util/inteltool/gpio_groups.c index f7ac7ce..57089e76 100644 --- a/util/inteltool/gpio_groups.c +++ b/util/inteltool/gpio_groups.c @@ -254,6 +254,21 @@ *community_count = ARRAY_SIZE(elkhartlake_pch_communities); *pad_stepping = 16; return elkhartlake_pch_communities; + case PCI_DEVICE_ID_INTEL_MTL_M_GT2: + case PCI_DEVICE_ID_INTEL_MTL_P_GT2_1: + case PCI_DEVICE_ID_INTEL_MTL_P_GT2_2: + case PCI_DEVICE_ID_INTEL_MTL_P_GT2_3: + case PCI_DEVICE_ID_INTEL_MTL_P_GT2_4: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_M: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_1: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_2: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_3: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_4: + case PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_5: + *community_count = ARRAY_SIZE(meteorlake_pch_communities); + *pad_stepping = 16; + return meteorlake_pch_communities; + case default: return NULL; diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index d76b0b4..3a454e9 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -188,7 +188,18 @@ "12th generation (Alder Lake N family) Intel Processor"}, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_RPL_ID_H_8_6, "13th generation (Raptor Lake H family) Core Processor"}, - + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_MTL_ID_M, + "14th generation (Meteor Lake family) Core Processor"}, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_1, + "14th generation (Meteor Lake P family) Core Processor"}, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_2, + "14th generation (Meteor Lake P family) Core Processor"}, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_3, + "14th generation (Meteor Lake P family) Core Processor"}, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_4, + "14th generation (Meteor Lake P family) Core Processor"}, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CORE_MTL_ID_P_5, + "14th generation (Meteor Lake P family) Core Processor"}, /* Southbridges (LPC controllers) */ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371XX, "371AB/EB/MB" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10, "ICH10" }, @@ -588,6 +599,16 @@ "Intel(R) UHD Graphics" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_RPL_H_IRIS_XE, "Intel(R) Iris Xe Graphics [RPL-P]" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MTL_M_GT2, + "Intel(R) MeteorLake GT2" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MTL_P_GT2_1, + "Intel(R) MeteorLake GT2" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MTL_P_GT2_2, + "Intel(R) MeteorLake GT2" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MTL_P_GT2_3, + "Intel(R) MeteorLake GT2" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MTL_P_GT2_4, + "Intel(R) MeteorLake GT2" }, }; #ifndef __DARWIN__ -- To view, visit https://review.coreboot.org/c/coreboot/+/81913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61c43eea1316c0c5636e34bafca1730905a2f008 Gerrit-Change-Number: 81913 Gerrit-PatchSet: 1 Gerrit-Owner: Filip Lewiński Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: drivers/i2c/generic: Add i2c_acpi_write_gpio for public
by Jianeng Ceng (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Dolan Liu, Eric Lai, Jianeng Ceng, Kapil Porwal, Subrata Banik. Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81788?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: drivers/i2c/generic: Add i2c_acpi_write_gpio for public ...................................................................... drivers/i2c/generic: Add i2c_acpi_write_gpio for public Make sure it can be use for other driver. BUG=None TEST= Build BIOS FW pass and it can be use for other driver. Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378 Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> --- M src/drivers/i2c/generic/generic.c M src/include/acpi/acpi_device.h 2 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81788/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378 Gerrit-Change-Number: 81788 Gerrit-PatchSet: 3 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: arch/x86/car.ld: Move FSP RC heap region into car_region
by Shuo Liu (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Arthur Heymans, Nico Huber. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80810?usp=email ) Change subject: arch/x86/car.ld: Move FSP RC heap region into car_region ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80810?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44b127f8cdf5aa00e9f85a26f5abc290d0dfc11b Gerrit-Change-Number: 80810 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 15 Apr 2024 12:52:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Jianeng Ceng (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Dolan Liu, Elyes Haouas, Eric Lai, Paul Menzel, Subrata Banik. Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email ) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... Patch Set 13: (1 comment) File src/drivers/i2c/rt5645/rt5645.c: https://review.coreboot.org/c/coreboot/+/81773/comment/7995aa03_8516e6bc : PS12, Line 7: #include <device/path.h> > <device/device.h> is supposed to provide <device/path. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 13 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 15 Apr 2024 12:40:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/i2c/generic: Add i2c_acpi_write_gpio for public
by Jianeng Ceng (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Dolan Liu, Eric Lai, Kapil Porwal, Subrata Banik. Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email ) Change subject: drivers/i2c/generic: Add i2c_acpi_write_gpio for public ...................................................................... Patch Set 2: (1 comment) File src/drivers/i2c/generic/generic.c: https://review.coreboot.org/c/coreboot/+/81788/comment/326e1c05_c39ff113 : PS1, Line 31: int i2c_generic_write_gpio(struct acpi_gpio *gpio, int *curr_index) : { : int ret = -1; : : if (gpio->pin_count == 0) : return ret; : : acpi_device_write_gpio(gpio); : ret = *curr_index; : (*curr_index)++; : : return ret; : } > If you consider the name we can change it. Or move to acpi.c or somewhere else. Okay,I just rename the function.Maybe now is ready to merge. -- To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378 Gerrit-Change-Number: 81788 Gerrit-PatchSet: 2 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 15 Apr 2024 12:40:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: src/mb: Rename new Makefile.inc files to Makefile.mk
by Elyes Haouas (Code Review) 15 Apr '24

15 Apr '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81856?usp=email ) Change subject: src/mb: Rename new Makefile.inc files to Makefile.mk ...................................................................... src/mb: Rename new Makefile.inc files to Makefile.mk These files were added after the switch. Change-Id: I1986e4f921e0e56fe5255433d4b9216dc7c4dc59 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81856 Reviewed-by: Varshit Pandya <pandyavarshit(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- R src/mainboard/sifive/hifive-unmatched/Makefile.mk R src/soc/sifive/fu740/Makefile.mk 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Varshit Pandya: Looks good to me, approved diff --git a/src/mainboard/sifive/hifive-unmatched/Makefile.inc b/src/mainboard/sifive/hifive-unmatched/Makefile.mk similarity index 100% rename from src/mainboard/sifive/hifive-unmatched/Makefile.inc rename to src/mainboard/sifive/hifive-unmatched/Makefile.mk diff --git a/src/soc/sifive/fu740/Makefile.inc b/src/soc/sifive/fu740/Makefile.mk similarity index 100% rename from src/soc/sifive/fu740/Makefile.inc rename to src/soc/sifive/fu740/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/81856?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1986e4f921e0e56fe5255433d4b9216dc7c4dc59 Gerrit-Change-Number: 81856 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Jianeng Ceng (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Dolan Liu, Eric Lai, Jianeng Ceng, Paul Menzel, Subrata Banik. Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81773?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Code-Review+1 by Dolan Liu, Code-Review+1 by Eric Lai, Verified+1 by build bot (Jenkins) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... drivers/i2c/rt5645: Add RT5645 amp driver Add RT5645 AMP support.The kernel driver of 5650 is written in rt5645.c. Add acpi name cbj-sleeve-gpios for power gate GPIO. ALC5650 DataSheet Rev 0.93 Realtek upstream link: https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realtek.com/ BUG=None TEST=verified in anraggar and probe device rt5650 succeed ``` \_SB.PCI0.I2C3.RT58: Realtek RT5650 ``` Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> --- A src/drivers/i2c/rt5645/Kconfig A src/drivers/i2c/rt5645/Makefile.mk A src/drivers/i2c/rt5645/chip.h A src/drivers/i2c/rt5645/rt5645.c 4 files changed, 140 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81773/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 13 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: drivers/i2c/generic: Add i2c_acpi_write_gpio for public
by Jianeng Ceng (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Dolan Liu, Eric Lai, Jianeng Ceng, Kapil Porwal, Subrata Banik. Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81788?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Dolan Liu, Code-Review+1 by Eric Lai, Verified+1 by build bot (Jenkins) Change subject: drivers/i2c/generic: Add i2c_acpi_write_gpio for public ...................................................................... drivers/i2c/generic: Add i2c_acpi_write_gpio for public Make sure it can be use for other driver. BUG=None TEST= Build BIOS FW pass and it can be use for other driver. Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378 Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> --- M src/drivers/i2c/generic/generic.c M src/include/acpi/acpi_device.h 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81788/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378 Gerrit-Change-Number: 81788 Gerrit-PatchSet: 2 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Elyes Haouas (Code Review) 15 Apr '24

15 Apr '24

Attention is currently required from: Eric Lai, Jianeng Ceng, Paul Menzel, Subrata Banik. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email ) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... Patch Set 12: (1 comment) File src/drivers/i2c/rt5645/rt5645.c: https://review.coreboot.org/c/coreboot/+/81773/comment/43cff4ce_41e8a965 : PS12, Line 7: #include <device/path.h> <device/device.h> is supposed to provide <device/path.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 12 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 15 Apr 2024 12:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024