coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP-M execution from CBFS cache
by Shuo Liu (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Paul Menzel, Ronak Kanabar, Subrata Banik, Tarun. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81212?usp=email ) Change subject: drivers/intel/fsp2_0: Support FSP-M execution from CBFS cache ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Patchset: PS6: A smart design, it would be nice if adding more comments for the working mechanism, e.g. how it depends on premem CBFS cache and how it is distinguish from XIP mode. -- To view, visit https://review.coreboot.org/c/coreboot/+/81212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d42d765eb0ecf2e7a8fc6d8d15eb2df8975f6f2 Gerrit-Change-Number: 81212 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 02:31:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP-M execution from CBFS cache
by Jérémy Compostella (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Paul Menzel, Ronak Kanabar, Shuo Liu, Subrata Banik, Tarun. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81212?usp=email ) Change subject: drivers/intel/fsp2_0: Support FSP-M execution from CBFS cache ...................................................................... Patch Set 4: (1 comment) File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/81212/comment/d885d8af_c0a30274 : PS3, Line 221: FSP_EXECUTE_FROM_CBFS_CACHE > This is a good suggestion and I implemented it. […] I went with a warning instead of an error to align with other control performed during the compilation / stitching process. -- To view, visit https://review.coreboot.org/c/coreboot/+/81212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d42d765eb0ecf2e7a8fc6d8d15eb2df8975f6f2 Gerrit-Change-Number: 81212 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 01:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60 and IVO_T109NW41
by Ruihai Zhou (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Paul Menzel, Yidi Lin, cong yang. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81438?usp=email ) Change subject: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60 and IVO_T109NW41 ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81438/comment/fbd12693_d3b037a1 : PS4, Line 11: Just keep consistent with the Linux kernel panel driver : configuration. > Please reference the commit and the file. The Linux patch has not yet been fully upstreamed, so there is no commit yet. Update the file and driver name in commit msg. -- To view, visit https://review.coreboot.org/c/coreboot/+/81438?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic44c86f062d4e836f403ee97f2fc6370fff02797 Gerrit-Change-Number: 81438 Gerrit-PatchSet: 5 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 01:31:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60 and IVO_T109NW41
by Ruihai Zhou (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Ruihai Zhou, Yidi Lin, cong yang. Hello Yidi Lin, build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81438?usp=email to look at the new patch set (#5). Change subject: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60 and IVO_T109NW41 ...................................................................... drivers/mipi: Fine tune clock for BOE_NV110WUM_L60 and IVO_T109NW41 Fine tune the panel clock to prevent mipi noise from affecting wifi band. After tuning, the panel refresh rate keeps at 60Hz and wifi test passed. Just keep consistent with the Linux kernel panel driver panel-boe-tv101wum-nl6 configuration. BUG=b:330807136 TEST=fw screen display normally Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: Ic44c86f062d4e836f403ee97f2fc6370fff02797 --- M src/drivers/mipi/panel-BOE_NV110WUM_L60.c M src/drivers/mipi/panel-IVO_T109NW41.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/81438/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/81438?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic44c86f062d4e836f403ee97f2fc6370fff02797 Gerrit-Change-Number: 81438 Gerrit-PatchSet: 5 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/brox: Fix GPE_EC_WAKE configuration
by Shelley Chen (Code Review) 26 Mar '24

26 Mar '24

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81526?usp=email ) Change subject: mb/google/brox: Fix GPE_EC_WAKE configuration ...................................................................... mb/google/brox: Fix GPE_EC_WAKE configuration Wake signal from EC is routed to GPP_D1 and hence GPE_EC_WAKE corresponds to GPE0_DW1_01. Fix GPE_EC_WAKE configuration. BUG=b:329026602 TEST=Build Brox BIOS image and boot to OS. Trigger suspend and wake up using EC generated events like AC connect/disconnect. Change-Id: Ifb89bd0de7b7fc316792e801ed5a1d3f25ca5b1c Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81526 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Shelley Chen <shchen(a)google.com> Reviewed-by: Kangheui Won <khwon(a)chromium.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Keith Short <keithshort(a)chromium.org> --- M src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h M src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h 2 files changed, 4 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Kangheui Won: Looks good to me, approved Julius Werner: Looks good to me, approved Shelley Chen: Looks good to me, approved Keith Short: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h index a027b4c..d049865 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h +++ b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h @@ -74,7 +74,6 @@ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ -#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ -#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ +#define EC_ENABLE_SYNC_IRQ /* Enable EC Sync IRQ defined in baseboard/gpio.h */ #endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h index 0e69fb3..2c1fc0a 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h +++ b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/gpio.h @@ -8,13 +8,13 @@ /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI -/* EC wake is EC_PCH_INT which is routed to GPP_D0 pin */ -#define GPE_EC_WAKE GPE0_DW1_00 +/* EC wake is EC_PCH_WAKE which is routed to GPP_D1 pin */ +#define GPE_EC_WAKE GPE0_DW1_01 /* WP signal to PCH */ #define GPIO_PCH_WP GPP_E8 /* Used to gate SoC's SLP_S0# signal */ #define GPIO_SLP_S0_GATE GPP_D17 -/* GPIO IRQ for tight timestamps / wake support */ +/* GPIO IRQ for tight timestamps, MKBP interrupts */ #define EC_SYNC_IRQ GPP_D0_IRQ #endif /* __BASEBOARD_GPIO_H__ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81526?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb89bd0de7b7fc316792e801ed5a1d3f25ca5b1c Gerrit-Change-Number: 81526 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Shyam Sundar Radjacoumar <ssradjacoumar(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/brox: Fix GPE_EC_WAKE configuration
by Kangheui Won (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Shyam Sundar Radjacoumar. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81526?usp=email ) Change subject: mb/google/brox: Fix GPE_EC_WAKE configuration ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81526?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb89bd0de7b7fc316792e801ed5a1d3f25ca5b1c Gerrit-Change-Number: 81526 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Shyam Sundar Radjacoumar <ssradjacoumar(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shyam Sundar Radjacoumar <ssradjacoumar(a)google.com> Gerrit-Attention: Keith Short <keithshort(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 01:12:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Fix GPE_EC_WAKE configuration
by Julius Werner (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Shyam Sundar Radjacoumar. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81526?usp=email ) Change subject: mb/google/brox: Fix GPE_EC_WAKE configuration ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81526?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb89bd0de7b7fc316792e801ed5a1d3f25ca5b1c Gerrit-Change-Number: 81526 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Shyam Sundar Radjacoumar <ssradjacoumar(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shyam Sundar Radjacoumar <ssradjacoumar(a)google.com> Gerrit-Attention: Keith Short <keithshort(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 01:05:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/dell/optiplex_9020: Add missing HWM init sequence
by Máté Kukri (Code Review) 26 Mar '24

26 Mar '24

Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email ) Change subject: mb/dell/optiplex_9020: Add missing HWM init sequence ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: It is not yet enough, this sequence is definitely needed but there is probably more... -- To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Gerrit-Change-Number: 81529 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Mar 2024 00:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/dell/optiplex_9020: Add missing HWM init sequence
by Máté Kukri (Code Review) 26 Mar '24

26 Mar '24

Máté Kukri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email ) Change subject: mb/dell/optiplex_9020: Add missing HWM init sequence ...................................................................... mb/dell/optiplex_9020: Add missing HWM init sequence This is hopefully enough to make fan control work. Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com> --- M src/mainboard/dell/optiplex_9020/bootblock.c 1 file changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/81529/1 diff --git a/src/mainboard/dell/optiplex_9020/bootblock.c b/src/mainboard/dell/optiplex_9020/bootblock.c index 2837cf9..34f3d86 100644 --- a/src/mainboard/dell/optiplex_9020/bootblock.c +++ b/src/mainboard/dell/optiplex_9020/bootblock.c @@ -90,6 +90,39 @@ for (size_t i = 0; i < ARRAY_SIZE(hwm_init_table); ++i) ec_write(1, hwm_init_table[i].addr, hwm_init_table[i].val); + + /* + * Missing HWM init, sniffed from LPC + */ + + static const struct ec_init_entry hwm_init_table2[] = { + {0x2db,0xc5}, {0x2d0,0x01}, {0x59e,0x4c}, {0x59f,0x18}, + {0x59f,0x80}, {0x5a2,0x4c}, {0x59e,0x00}, {0x048,0x00}, + {0x048,0x00}, {0x042,0x00}, {0x048,0x00}, {0x048,0x02}, + {0x048,0x00}, {0x048,0x02}, {0x042,0x00}, {0x048,0x00}, + {0x048,0x06}, {0x081,0x00}, {0x026,0x00}, {0x2fc,0x00}, + {0x2fc,0xa0}, {0x2fd,0x32}, {0x005,0x33}, {0x018,0x2f}, + {0x019,0x2f}, {0x01a,0x2f}, {0x080,0x00}, {0x081,0x00}, + {0x083,0xbb}, {0x085,0x98}, {0x086,0x3c}, {0x08a,0x39}, + {0x08b,0x44}, {0x090,0x61}, {0x091,0x6d}, {0x092,0x86}, + {0x096,0xa4}, {0x097,0xa4}, {0x098,0x9f}, {0x09b,0xa4}, + {0x0a0,0x0e}, {0x0a1,0x0e}, {0x0ae,0x7c}, {0x0af,0x7c}, + {0x0b0,0x9b}, {0x0b3,0x9a}, {0x0b6,0x08}, {0x0b7,0x08}, + {0x0ea,0x64}, {0x0ef,0xff}, {0x0f8,0x15}, {0x0f9,0x00}, + {0x0f0,0x30}, {0x0fd,0x01}, {0x1a1,0x00}, {0x1a2,0x00}, + {0x1b1,0x08}, {0x1be,0x9a}, {0x280,0x94}, {0x281,0x11}, + {0x282,0x03}, {0x283,0x0a}, {0x284,0x80}, {0x285,0x03}, + {0x288,0x94}, {0x289,0x11}, {0x28a,0x03}, {0x28b,0x0a}, + {0x28c,0x80}, {0x28d,0x03}, {0x09e,0x30}, {0x0ea,0x00}, + {0x0eb,0x64}, {0x2fc,0x00}, {0x0b8,0x00}, {0x02c,0x00}, + {0x02d,0x00}, {0x02e,0x00}, {0x02f,0x00}, {0x049,0x00}, + {0x049,0x00}, {0x059,0x6a}, {0x041,0x00}, {0x041,0x10}, + {0x049,0x00}, {0x049,0x04}, {0x07b,0x0e}, {0x07c,0x0e}, + {0x07a,0x01}, + }; + + for (size_t i = 0; i < ARRAY_SIZE(hwm_init_table2); ++i) + ec_write(1, hwm_init_table2[i].addr, hwm_init_table2[i].val); } #define SCH555x_IOBASE 0x2e -- To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Gerrit-Change-Number: 81529 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/msi: Remove blank lines before '}' and after '{'
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81485?usp=email ) Change subject: mb/msi: Remove blank lines before '}' and after '{' ...................................................................... mb/msi: Remove blank lines before '}' and after '{' Change-Id: I4a678b433e3e1a492e2a8e679caf75f4741317cb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81485 Reviewed-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/msi/ms7d25/gpio.h M src/mainboard/msi/ms7d25/mainboard.c M src/mainboard/msi/ms7e06/gpio.h M src/mainboard/msi/ms7e06/mainboard.c 4 files changed, 0 insertions(+), 4 deletions(-) Approvals: Michał Kopeć: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/msi/ms7d25/gpio.h b/src/mainboard/msi/ms7d25/gpio.h index 62625c0..02b171a 100644 --- a/src/mainboard/msi/ms7d25/gpio.h +++ b/src/mainboard/msi/ms7d25/gpio.h @@ -4,7 +4,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_I ------- */ diff --git a/src/mainboard/msi/ms7d25/mainboard.c b/src/mainboard/msi/ms7d25/mainboard.c index f124449..b346ac7 100644 --- a/src/mainboard/msi/ms7d25/mainboard.c +++ b/src/mainboard/msi/ms7d25/mainboard.c @@ -16,7 +16,6 @@ static void mainboard_init(void *chip_info) { - } u8 smbios_mainboard_feature_flags(void) diff --git a/src/mainboard/msi/ms7e06/gpio.h b/src/mainboard/msi/ms7e06/gpio.h index bf61dcb..413ada8 100644 --- a/src/mainboard/msi/ms7e06/gpio.h +++ b/src/mainboard/msi/ms7e06/gpio.h @@ -4,7 +4,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_I ------- */ diff --git a/src/mainboard/msi/ms7e06/mainboard.c b/src/mainboard/msi/ms7e06/mainboard.c index a80b240..2645f07 100644 --- a/src/mainboard/msi/ms7e06/mainboard.c +++ b/src/mainboard/msi/ms7e06/mainboard.c @@ -17,7 +17,6 @@ static void mainboard_init(void *chip_info) { - } u8 smbios_mainboard_feature_flags(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/81485?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a678b433e3e1a492e2a8e679caf75f4741317cb Gerrit-Change-Number: 81485 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024