coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: doc/releases: Fix embedded rST syntax for MyST Parser
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81500?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: doc/releases: Fix embedded rST syntax for MyST Parser ...................................................................... doc/releases: Fix embedded rST syntax for MyST Parser After commit 35599f9a6671 (Docs: Replace Recommonmark with MyST Parser), embedded rST should use `{eval-rst}` instead of `eval_rst`. This was missed during manual rebasing of that patch before it was merged. Change-Id: I648a95488df25d70e1b581872a19272c51f33b7b Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81500 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M Documentation/releases/coreboot-24.02-relnotes.md 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/Documentation/releases/coreboot-24.02-relnotes.md b/Documentation/releases/coreboot-24.02-relnotes.md index e4e7892..f82a6a8 100644 --- a/Documentation/releases/coreboot-24.02-relnotes.md +++ b/Documentation/releases/coreboot-24.02-relnotes.md @@ -202,7 +202,7 @@ ### coreboot-wide or architecture-wide issues -```eval_rst +```{eval-rst} +-----+-----------------------------------------------------------------+ | # | Subject | +=====+=================================================================+ @@ -217,7 +217,7 @@ ### Payload-specific issues -```eval_rst +```{eval-rst} +-----+-----------------------------------------------------------------+ | # | Subject | +=====+=================================================================+ @@ -234,7 +234,7 @@ ### Platform-specific issues -```eval_rst +```{eval-rst} +-----+-----------------------------------------------------------------+ | # | Subject | +=====+=================================================================+ -- To view, visit https://review.coreboot.org/c/coreboot/+/81500?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I648a95488df25d70e1b581872a19272c51f33b7b Gerrit-Change-Number: 81500 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/butterfly: Fix compiling for 64bit mode
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81380?usp=email ) Change subject: mb/google/butterfly: Fix compiling for 64bit mode ...................................................................... mb/google/butterfly: Fix compiling for 64bit mode Change-Id: Ieaaba5b36796d97449896b8475744a21f01e93d1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81380 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/google/butterfly/mainboard.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Patrick Rudolph: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index ac0f57b..988c210 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -49,7 +49,7 @@ } static int get_mac_address(u32 *high_dword, u32 *low_dword, - u32 search_address, u32 search_length) + uintptr_t search_address, u32 search_length) { char key[] = "ethernet_mac"; unsigned int offset; @@ -118,7 +118,7 @@ } } -static void program_keyboard_type(u32 search_address, u32 search_length) +static void program_keyboard_type(uintptr_t search_address, u32 search_length) { char key[] = "keyboard_layout"; char kbd_jpn[] = "xkb:jp::jpn"; @@ -160,7 +160,7 @@ static void mainboard_init(struct device *dev) { - u32 search_address = 0x0; + uintptr_t search_address = 0x0; size_t search_length = -1; u16 io_base = 0; struct device *ethernet_dev = NULL; @@ -180,7 +180,7 @@ } else { vpd_file = cbfs_map("vpd.bin", &search_length); if (vpd_file) { - search_address = (unsigned long)vpd_file; + search_address = (uintptr_t)vpd_file; } else { search_length = -1; search_address = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/81380?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieaaba5b36796d97449896b8475744a21f01e93d1 Gerrit-Change-Number: 81380 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/razer: Remove blank lines before '}' and after '{'
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81496?usp=email ) Change subject: mb/razer: Remove blank lines before '}' and after '{' ...................................................................... mb/razer: Remove blank lines before '}' and after '{' Change-Id: I2c8cc390bed3aef901d6ada19361c35928dfdb0c Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81496 Reviewed-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/razer/blade_stealth_kbl/hda_verb.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nicholas Sudsgaard: Looks good to me, approved diff --git a/src/mainboard/razer/blade_stealth_kbl/hda_verb.c b/src/mainboard/razer/blade_stealth_kbl/hda_verb.c index 69d3bff..63641db 100644 --- a/src/mainboard/razer/blade_stealth_kbl/hda_verb.c +++ b/src/mainboard/razer/blade_stealth_kbl/hda_verb.c @@ -3,7 +3,6 @@ #include <device/azalia_device.h> const u32 cim_verb_data[] = { - /* Realtek, ALC298 */ 0x10ec0298, /* Vendor ID */ 0x1a586752, /* Subsystem ID */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81496?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2c8cc390bed3aef901d6ada19361c35928dfdb0c Gerrit-Change-Number: 81496 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/roda: Remove blank lines before '}' and after '{'
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81495?usp=email ) Change subject: mb/roda: Remove blank lines before '}' and after '{' ...................................................................... mb/roda: Remove blank lines before '}' and after '{' Change-Id: Id039ad885d2f08bc3fe09aca740a72a5820f7fcc Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81495 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> --- M src/mainboard/roda/rk886ex/acpi_tables.c M src/mainboard/roda/rk9/acpi_tables.c 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Nicholas Sudsgaard: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/roda/rk886ex/acpi_tables.c b/src/mainboard/roda/rk886ex/acpi_tables.c index cc64c30..7915d6a 100644 --- a/src/mainboard/roda/rk886ex/acpi_tables.c +++ b/src/mainboard/roda/rk886ex/acpi_tables.c @@ -8,5 +8,4 @@ /* Enable both COM ports */ gnvs->cmap = 0x01; gnvs->cmbp = 0x01; - } diff --git a/src/mainboard/roda/rk9/acpi_tables.c b/src/mainboard/roda/rk9/acpi_tables.c index 27ee7c6..7915d6a 100644 --- a/src/mainboard/roda/rk9/acpi_tables.c +++ b/src/mainboard/roda/rk9/acpi_tables.c @@ -5,7 +5,6 @@ void mainboard_fill_gnvs(struct global_nvs *gnvs) { - /* Enable both COM ports */ gnvs->cmap = 0x01; gnvs->cmbp = 0x01; -- To view, visit https://review.coreboot.org/c/coreboot/+/81495?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id039ad885d2f08bc3fe09aca740a72a5820f7fcc Gerrit-Change-Number: 81495 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/lenovo: Remove blank lines before '}' and after '{'
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81484?usp=email ) Change subject: mb/lenovo: Remove blank lines before '}' and after '{' ...................................................................... mb/lenovo: Remove blank lines before '}' and after '{' Change-Id: I6ece868184dd772fc2c3c472ae2172d1c34fb179 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81484 Reviewed-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/lenovo/m900_tiny/gpio.c M src/mainboard/lenovo/t400/romstage.c M src/mainboard/lenovo/thinkcentre_m710s/gpio.h 3 files changed, 0 insertions(+), 3 deletions(-) Approvals: Nicholas Sudsgaard: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/lenovo/m900_tiny/gpio.c b/src/mainboard/lenovo/m900_tiny/gpio.c index 65c9cbf..aecea41 100644 --- a/src/mainboard/lenovo/m900_tiny/gpio.c +++ b/src/mainboard/lenovo/m900_tiny/gpio.c @@ -5,7 +5,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_A ------- */ diff --git a/src/mainboard/lenovo/t400/romstage.c b/src/mainboard/lenovo/t400/romstage.c index aa3462a..89afaee 100644 --- a/src/mainboard/lenovo/t400/romstage.c +++ b/src/mainboard/lenovo/t400/romstage.c @@ -37,7 +37,6 @@ } else { hybrid_graphics_init(sysinfo); } - } void mb_post_raminit_setup(void) diff --git a/src/mainboard/lenovo/thinkcentre_m710s/gpio.h b/src/mainboard/lenovo/thinkcentre_m710s/gpio.h index fcb1b91..a1acba7 100644 --- a/src/mainboard/lenovo/thinkcentre_m710s/gpio.h +++ b/src/mainboard/lenovo/thinkcentre_m710s/gpio.h @@ -6,7 +6,6 @@ #include <gpio.h> static const struct pad_config gpio_table[] = { - /* ------- GPIO Community 0 ------- */ /* ------- GPIO Group GPP_A ------- */ -- To view, visit https://review.coreboot.org/c/coreboot/+/81484?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ece868184dd772fc2c3c472ae2172d1c34fb179 Gerrit-Change-Number: 81484 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: soc/amd/non_car/memlayout_x86.ld: Top align the code
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81433?usp=email ) Change subject: soc/amd/non_car/memlayout_x86.ld: Top align the code ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81433/comment/b68b1867_6b20bb45 : PS1, Line 26: bootlbock bootblock File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld: https://review.coreboot.org/c/coreboot/+/81433/comment/43d5629c_eaf522c5 : PS1, Line 128: 64K I thought the whole point of this was that we didn't know the length, and it could be up to 128K with the next patch. I'm probably overlooking something, but this confuses me. https://review.coreboot.org/c/coreboot/+/81433/comment/1f5ad78e_3171c778 : PS1, Line 132: /* Trigger an error if I have an unusable start address */ We got rid of the assert, so remove this comment? https://review.coreboot.org/c/coreboot/+/81433/comment/8dc49b85_588203ae : PS1, Line 135: . = ALIGN(4096); do we want a `. += 1` before the align? if we're already aligned, wouldn't this sequence lower the address by an additional 4K? -- To view, visit https://review.coreboot.org/c/coreboot/+/81433?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I18bdf262f9c358aa01795b11efcb863686edc79c Gerrit-Change-Number: 81433 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 26 Mar 2024 23:08:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/noncar: Increase bootblock size from 64K to 128K
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80348?usp=email ) Change subject: soc/amd/noncar: Increase bootblock size from 64K to 128K ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80348?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I23f176d63d3c303b13331a77ad5ac6c7a19073d3 Gerrit-Change-Number: 80348 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 26 Mar 2024 23:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/bootblock.ld: Align the base of bootblock downwards
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80346?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch/x86/bootblock.ld: Align the base of bootblock downwards ...................................................................... arch/x86/bootblock.ld: Align the base of bootblock downwards Instead of using some aritmetics that sometimes works, use the largest alignment necessary (page tables) and align downwards in the linker script. This fixes linking failing when linking in page tables inside the bootblock. This can result in a slight increase in bootblock size of at most 4096 - 512 bytes. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I78c6ba6e250ded3f04b12cd0c20b18cb653a1506 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80346 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/arch/x86/bootblock.ld 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Jérémy Compostella: Looks good to me, but someone else must approve build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/arch/x86/bootblock.ld b/src/arch/x86/bootblock.ld index d59eb27..6547985 100644 --- a/src/arch/x86/bootblock.ld +++ b/src/arch/x86/bootblock.ld @@ -17,19 +17,16 @@ . = _ebootblock - CONFIG_C_ENV_BOOTBLOCK_SIZE; #else . = BOOTBLOCK_TOP - PROGRAM_SZ; - . = ALIGN(64); + /* Page tables need to be at a 4K boundary so align the bootblock downwards */ + . = ALIGN(4096); + . -= 4096; #endif _bootblock = .; INCLUDE "bootblock/lib/program.ld" - /* - * Allocation reserves extra space here. Alignment requirements - * may cause the total size of a section to change when the start - * address gets applied. - */ - PROGRAM_SZ = SIZEOF(.text) + 512; + PROGRAM_SZ = SIZEOF(.text); . = MIN(_ECFW_PTR, MIN(_ID_SECTION, _FIT_POINTER)) - EARLYASM_SZ; . = CONFIG(SIPI_VECTOR_IN_ROM) ? ALIGN(4096) : ALIGN(16); -- To view, visit https://review.coreboot.org/c/coreboot/+/80346?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78c6ba6e250ded3f04b12cd0c20b18cb653a1506 Gerrit-Change-Number: 80346 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/fb/fbg1701: Move VBOOT key location
by Martin L Roth (Code Review) 26 Mar '24

26 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80347?usp=email ) Change subject: mb/fb/fbg1701: Move VBOOT key location ...................................................................... mb/fb/fbg1701: Move VBOOT key location Move it downwards allows for a larger bootblock, which comes in handy if romstage or page tables are linked inside the bootblock. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ib37846c0b039d89396839ffa6047b18bcc228e02 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80347 Reviewed-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 1218102..1ea2ae6 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -90,7 +90,7 @@ config VENDORCODE_ELTAN_VBOOT_KEY_LOCATION depends on VENDORCODE_ELTAN_VBOOT hex - default 0xFFFF9000 + default 0xFFFEA000 config DRIVERS_INTEL_WIFI bool -- To view, visit https://review.coreboot.org/c/coreboot/+/80347?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib37846c0b039d89396839ffa6047b18bcc228e02 Gerrit-Change-Number: 80347 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/brox: Fix GPE_EC_WAKE configuration
by Shelley Chen (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Shyam Sundar Radjacoumar. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81526?usp=email ) Change subject: mb/google/brox: Fix GPE_EC_WAKE configuration ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81526?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb89bd0de7b7fc316792e801ed5a1d3f25ca5b1c Gerrit-Change-Number: 81526 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Keith Short <keithshort(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Shyam Sundar Radjacoumar <ssradjacoumar(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shyam Sundar Radjacoumar <ssradjacoumar(a)google.com> Gerrit-Attention: Keith Short <keithshort(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 26 Mar 2024 22:51:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024