coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[M] Change in coreboot[main]: mb/google/{brya,hades}: use soc index for variant_update_power_limits()
by SH Kim (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Sumeet R Pawnikar. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81436?usp=email ) Change subject: mb/google/{brya,hades}: use soc index for variant_update_power_limits() ...................................................................... Patch Set 6: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81436/comment/b9b6a5dc_6c35fb09 : PS5, Line 13: override the PL4 value > Please share more details on the reason for overriding the PL4 value. […] I was just trying some tests for b/328729536 using this interface by referring to skolas code. (skolas already uses this function) And found the code doesn't work properly by accidentlly. I can find some brya boards using variant_update_power_limits() to set the default PL setting, I thought this is for override the default PL1/PL2/PL4 settings according to the board design and SKUs. https://review.coreboot.org/c/coreboot/+/81436/comment/7428546d_5b86bde3 : PS5, Line 14: ramstage.c : > Please remove the space before the colon. Done https://review.coreboot.org/c/coreboot/+/81436/comment/99e8571e_460b1e01 : PS5, Line 15: const struct cpu_power_limits limits[] = { : {PCI_DID_INTEL_RPL_P_ID3, 15, 6000, 15000, 55000, 55000, 80000}, : } > Please follow Markdown mark-up language and indent with four spaces. Done File src/mainboard/google/brya/variants/baseboard/brya/ramstage.c: https://review.coreboot.org/c/coreboot/+/81436/comment/46324108_44662a5e : PS5, Line 39: > Any reason to removal of these? It was aligned based on the previous argument. Done https://review.coreboot.org/c/coreboot/+/81436/comment/10176515_0e948001 : PS5, Line 41: > same comment as above. Done https://review.coreboot.org/c/coreboot/+/81436/comment/688a0ba7_779501c0 : PS5, Line 68: soc_config->tdp_pl4 = DIV_ROUND_UP(limits[i].pl4_power, > DPTF (user space service) overrides PL1/PL2 for MMIO registers only. SOC will use the lower PL1/PL2 value of MMIO and MSR. If user may want to override PL1/PL2 to higher value than original one which is in MSR, SOC will never take higher one since PL1/PL2 are limited by the lower values in MSR. IMO it would be better to set MSR PL1/PL2 values here, how do you think? -- To view, visit https://review.coreboot.org/c/coreboot/+/81436?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9f1ba25c2d673fda48babf773208c2f2d2386c53 Gerrit-Change-Number: 81436 Gerrit-PatchSet: 6 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 28 Mar 2024 00:03:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.mk: make the overlapped error message more informative
by ron minnich (Code Review) 27 Mar '24

27 Mar '24

ron minnich has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81544?usp=email ) Change subject: Makefile.mk: make the overlapped error message more informative ...................................................................... Makefile.mk: make the overlapped error message more informative Currently, if something is overlapped, you get this: ERROR: Ramstage region _ramstage overlapped by: fallback/payload fallback/opensbi This change prints out the start and end of the sections. Change-Id: Ica8c05b63ed9bbd28e2d3daa4dc7c2f9d8da3f55 Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/81544/1 diff --git a/Makefile.mk b/Makefile.mk index bfdb7e3..3f39a6e 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -1388,7 +1388,7 @@ if [ -z $$rstart ]; then rstart=$$(($$y)) ; continue ; fi ; \ rend=$$(($$y)) ; \ if [ $$pstart -lt $$rend -a $$rstart -lt $$pend ]; then \ - echo "ERROR: Ramstage region _$$rname overlapped by:" \ + echo "ERROR: Ramstage region _$$rname@($$rstart,$$rend) overlapped by($$pstart,$$pend):" \ $(check-ramstage-overlap-files) ; \ exit 1 ; \ fi ; \ -- To view, visit https://review.coreboot.org/c/coreboot/+/81544?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica8c05b63ed9bbd28e2d3daa4dc7c2f9d8da3f55 Gerrit-Change-Number: 81544 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: Update opensbi submodule to upstream master branch
by ron minnich (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Martin L Roth. Hello Martin L Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/81543?usp=email to review the following change. Change subject: Update opensbi submodule to upstream master branch ...................................................................... Update opensbi submodule to upstream master branch Updating from commit id 5019fd124b4c (2022-09-01): include: sbi: Reduce includes in sbi_pmu.h to commit id 5186da687deb (2024-03-20): platform: generic: allwinner: sun20i-d1: Remove duplicated CSR definitions This brings in 465 new commits. Tested on the SiFive unmatched. Change-Id: I50ce0ba3b6409247a94b49565cc04454903e88d0 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com> --- M 3rdparty/opensbi M src/arch/riscv/opensbi.c M src/soc/sifive/fu540/memlayout.ld M src/soc/sifive/fu740/memlayout.ld 4 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/81543/1 diff --git a/3rdparty/opensbi b/3rdparty/opensbi index 5019fd1..5186da6 160000 --- a/3rdparty/opensbi +++ b/3rdparty/opensbi @@ -1 +1 @@ -Subproject commit 5019fd124b4c46e1581129c5154fc2cdd3b777ed +Subproject commit 5186da687debaab5c4a81ec351e56d145d88c79c diff --git a/src/arch/riscv/opensbi.c b/src/arch/riscv/opensbi.c index bf26b22..9409f0d 100644 --- a/src/arch/riscv/opensbi.c +++ b/src/arch/riscv/opensbi.c @@ -4,6 +4,7 @@ #undef __packed #undef __noreturn #undef __aligned +#undef __always_inline #include <sbi/fw_dynamic.h> #include <arch/boot.h> diff --git a/src/soc/sifive/fu540/memlayout.ld b/src/soc/sifive/fu540/memlayout.ld index 8fc875d..404e009 100644 --- a/src/soc/sifive/fu540/memlayout.ld +++ b/src/soc/sifive/fu540/memlayout.ld @@ -21,8 +21,8 @@ L2LIM_END(FU540_L2LIM + 2M) DRAM_START(FU540_DRAM) - REGION(opensbi, FU540_DRAM, 128K, 4K) - RAMSTAGE(FU540_DRAM + 128K, 2M) - MEM_STACK(FU540_DRAM + 128K + 2M, 20K) + OPENSBI(FU540_DRAM, 512K) + RAMSTAGE(FU540_DRAM + 512K, 2M) + MEM_STACK(FU540_DRAM + 768K + 2M, 20K) POSTRAM_CBFS_CACHE(FU540_DRAM + 3M, 29M) } diff --git a/src/soc/sifive/fu740/memlayout.ld b/src/soc/sifive/fu740/memlayout.ld index 85d2b40..e69a9e7d 100644 --- a/src/soc/sifive/fu740/memlayout.ld +++ b/src/soc/sifive/fu740/memlayout.ld @@ -18,9 +18,9 @@ SRAM_END(FU740_L2LIM + 2M) DRAM_START(FU740_DRAM) - OPENSBI(FU740_DRAM, 256K) + OPENSBI(FU740_DRAM, 512K) /* The 256K size is not allocated. It's just for basic size checking. */ - RAMSTAGE(FU740_DRAM + 256K, 256K) - MEM_STACK(FU740_DRAM + 512K, 20K) - POSTRAM_CBFS_CACHE(FU740_DRAM + 532K, 32M - 532K) + RAMSTAGE(FU740_DRAM + 512K, 256K) + MEM_STACK(FU740_DRAM + 768K, 20K) + POSTRAM_CBFS_CACHE(FU740_DRAM + 788K, 32M - 788K) } -- To view, visit https://review.coreboot.org/c/coreboot/+/81543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I50ce0ba3b6409247a94b49565cc04454903e88d0 Gerrit-Change-Number: 81543 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/glassway: Update the VccIn Aux Imon IccMax
by Paul Menzel (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Frank Chu, Kapil Porwal, Nick Vaccaro, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81445?usp=email ) Change subject: mb/google/nissa/var/glassway: Update the VccIn Aux Imon IccMax ...................................................................... Patch Set 6: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81445/comment/cdf125d7_aa30297c : PS6, Line 7: Update the VccIn Aux Imon IccMax Set VccIn Aux Imon IccMax to 25 A https://review.coreboot.org/c/coreboot/+/81445/comment/952369d1_3383cf9c : PS6, Line 9: MBVR What does that mean? https://review.coreboot.org/c/coreboot/+/81445/comment/d679262c_52cea9be : PS6, Line 9: Iccmax of VccIn_Aux is 25A with MBVR design. What is the current default? File src/mainboard/google/brya/variants/glassway/ramstage.c: https://review.coreboot.org/c/coreboot/+/81445/comment/e6932586_4a5d25a7 : PS6, Line 7: 25*4 For ADL-N 25 * 4 for ADL-N https://review.coreboot.org/c/coreboot/+/81445/comment/c8c5df16_fb4890b5 : PS6, Line 7: // One space? https://review.coreboot.org/c/coreboot/+/81445/comment/6c4f3b3c_51ac8b48 : PS6, Line 10: Remove blank line, if possible (or Gerrit bug). -- To view, visit https://review.coreboot.org/c/coreboot/+/81445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I105dc9df53c624fd7fc697408a1097e023a3cd68 Gerrit-Change-Number: 81445 Gerrit-PatchSet: 6 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Mar 2024 22:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/brya: Correct _PLD values
by Paul Menzel (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik, Won Chung. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81363?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brya: Correct _PLD values ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81363/comment/a78ddf63_f5491cb7 : PS1, Line 11: Nice find. Please document if this was a change in schematics, or a copy and paste error. -- To view, visit https://review.coreboot.org/c/coreboot/+/81363?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I977c3b4081987592a1d46529eb848a07a6c4cb47 Gerrit-Change-Number: 81363 Gerrit-PatchSet: 1 Gerrit-Owner: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Emilie Roberts <hadrosaur(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Won Chung <wonchung(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Mar 2024 22:32:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa: Create sundance variant
by Paul Menzel (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Leo Chou, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81347?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa: Create sundance variant ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81347/comment/1f6b8da7_71920996 : PS7, Line 12: in : inside > The 'repo' has been removed from the inside SDK What is “inside”? Is that Insyde? -- To view, visit https://review.coreboot.org/c/coreboot/+/81347?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia8ba318f18d2cac69898687311631778e61bf2ea Gerrit-Change-Number: 81347 Gerrit-PatchSet: 9 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 22:28:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/noncar: Make sure preram CBMEM console is aligned
by Paul Menzel (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81448?usp=email ) Change subject: soc/amd/noncar: Make sure preram CBMEM console is aligned ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81448/comment/17d03fef_6b902fdb : PS1, Line 9: fixed fixe*s* Or just: Fix a build … https://review.coreboot.org/c/coreboot/+/81448/comment/9a462739_5c32ec90 : PS1, Line 13: I’d like to have the build error in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/81448?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I677c09dbdeaf8f6803f55597514c6fe6ec25ab92 Gerrit-Change-Number: 81448 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 22:27:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: include/device/pci_ids.h: Add DIDs for MTL Touch controller
by Cliff Huang (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Eran Mitrani, Jingyuan Liang. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81330?usp=email ) Change subject: include/device/pci_ids.h: Add DIDs for MTL Touch controller ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > nit: the commit message only mentions 0x7e49 and 0x7eb4, but you're adding 4 ids. 0x7e48 and 0x7ea4 are the DIDs when ThcMode is 0 (default), though we will only enable for THC-SPI in MTL. -- To view, visit https://review.coreboot.org/c/coreboot/+/81330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1b98fdbd8d8588492bcafa0f3998818dc83ff1d9 Gerrit-Change-Number: 81330 Gerrit-PatchSet: 1 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org> Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Comment-Date: Wed, 27 Mar 2024 22:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eran Mitrani <mitrani(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: ec/google/chromeec: Remove blank lines before '}' and after '{'
by Caveh Jalali (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Elyes Haouas. Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81480?usp=email ) Change subject: ec/google/chromeec: Remove blank lines before '}' and after '{' ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: right, this file is imported from chromium using `util/chromeos/update_ec_headers.sh` and should be kept in sync to the extent possible. -- To view, visit https://review.coreboot.org/c/coreboot/+/81480?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7118cc716d1ad4d7272720f316da1ee65cdc51d Gerrit-Change-Number: 81480 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 27 Mar 2024 20:11:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update opensbi submodule to upstream master branch
by Martin L Roth (Code Review) 27 Mar '24

27 Mar '24

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81540?usp=email ) Change subject: Update opensbi submodule to upstream master branch ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/81540?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9af77fe464464a23e3643bbfca0bc6f0129bcb69 Gerrit-Change-Number: 81540 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024