coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: fmap: Set maximum mapping flash size to 16M
by Bao Zheng (Code Review) 28 Mar '24

28 Mar '24

Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74073?usp=email ) Change subject: fmap: Set maximum mapping flash size to 16M ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/74073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41d1389d624c150783db20714923cdb0e1b3353f Gerrit-Change-Number: 74073 Gerrit-PatchSet: 5 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board 'Kyogre'
by Yidi Lin (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Hung-Te Lin, Kei Hiroyoshi, Kenny Pan, Knox Chiou, Paul Menzel, Varshit Pandya, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81218?usp=email ) Change subject: mb/google/corsola: Add new board 'Kyogre' ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81218/comment/b586f496_11ed6890 : PS7, Line 7: Add new board 'Kyogre' Add new board variant 'Kyogre' https://review.coreboot.org/c/coreboot/+/81218/comment/bfac944d_5dcee22d : PS7, Line 9: Add new board variant 'Kyogre' Add a new Kingler follower device 'Kyogre', -- To view, visit https://review.coreboot.org/c/coreboot/+/81218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae3857a9f8edadcc2eee3500fda2e76c0334221c Gerrit-Change-Number: 81218 Gerrit-PatchSet: 7 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kenny Pan <kennypan(a)google.com> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 28 Mar 2024 02:58:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board 'Kyogre'
by Kei Hiroyoshi (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Hung-Te Lin, Kenny Pan, Knox Chiou, Paul Menzel, Varshit Pandya, Yidi Lin, Yu-Ping Wu. Kei Hiroyoshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81218?usp=email ) Change subject: mb/google/corsola: Add new board 'Kyogre' ...................................................................... Patch Set 7: (9 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81218/comment/6267b5a6_9f1e91e5 : PS3, Line 7: mb/corsola/kyogre: > mb/google/corsola: Done https://review.coreboot.org/c/coreboot/+/81218/comment/71b075ab_7cd77e8b : PS3, Line 7: UPSTREAM: mb/corsola/kyogre: Add new board 'Kyogre' > Remove the UPSTREAM prefix since it's internal use only. Done https://review.coreboot.org/c/coreboot/+/81218/comment/ce40da37_57147ea8 : PS3, Line 9: Kinger > Kingler Done Commit Message: https://review.coreboot.org/c/coreboot/+/81218/comment/b95b0d60_e1f3fdaf : PS4, Line 7: board > board variant Done https://review.coreboot.org/c/coreboot/+/81218/comment/6baf8a45_e3990549 : PS4, Line 9: follower > What does “follower” mean? Kyogre is designed on the basis of Kingler. https://review.coreboot.org/c/coreboot/+/81218/comment/bef44cf4_ddb5ed36 : PS4, Line 12: TEST=make # select Kyogre > As I remember, we verified image on Kyogre Proto unit with local build version. […] Done https://review.coreboot.org/c/coreboot/+/81218/comment/65207bf2_815739a0 : PS4, Line 14: Change-Id: Iae3857a9f8edadcc2eee3500fda2e76c0334221c > Please add a Signed-off-by line. Done Commit Message: https://review.coreboot.org/c/coreboot/+/81218/comment/3107facf_ace7fd5b : PS6, Line 20: > I would remove this extra line, also I'd put "signed-off" line after "Change-ID" […] Done Patchset: PS7: Corrected as indicated. -- To view, visit https://review.coreboot.org/c/coreboot/+/81218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae3857a9f8edadcc2eee3500fda2e76c0334221c Gerrit-Change-Number: 81218 Gerrit-PatchSet: 7 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kenny Pan <kennypan(a)google.com> Gerrit-CC: Knox Chiou <knoxchiou(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kenny Pan <kennypan(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 28 Mar 2024 02:52:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Comment-In-Reply-To: Knox Chiou <knoxchiou(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Kenny Pan <kennypan(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad
by Frank Chu (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81552?usp=email ) Change subject: mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81552?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbb2cb750a80bc6e8f96609257dcd1e695ad1fa4 Gerrit-Change-Number: 81552 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 28 Mar 2024 02:45:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad
by Frank Chu (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81552?usp=email to look at the new patch set (#2). Change subject: mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad ...................................................................... mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad Add Synaptics touchpad for glassway. BUG=b:331677400 BRANCH=firmware-nissa-15217.B TEST=emerge-brya coreboot and check touchpad function work. Change-Id: Ifbb2cb750a80bc6e8f96609257dcd1e695ad1fa4 Signed-off-by: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/brya/variants/glassway/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81552/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81552?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbb2cb750a80bc6e8f96609257dcd1e695ad1fa4 Gerrit-Change-Number: 81552 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad
by Frank Chu (Code Review) 27 Mar '24

27 Mar '24

Frank Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81552?usp=email ) Change subject: mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad ...................................................................... mb/google/nissa/var/glassway: Add 2nd Synaptics touchpad Add Synaptics touchpad for glassway. BUG=b:328724191 BRANCH=firmware-nissa-15217.B TEST=emerge-brya coreboot and check touchpad function work. Change-Id: Ifbb2cb750a80bc6e8f96609257dcd1e695ad1fa4 Signed-off-by: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/brya/variants/glassway/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81552/1 diff --git a/src/mainboard/google/brya/variants/glassway/overridetree.cb b/src/mainboard/google/brya/variants/glassway/overridetree.cb index 29629d4..64c8ee0 100644 --- a/src/mainboard/google/brya/variants/glassway/overridetree.cb +++ b/src/mainboard/google/brya/variants/glassway/overridetree.cb @@ -384,6 +384,15 @@ register "detect" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""PIXART Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)" + register "generic.wake" = "GPE0_DW2_14" + register "generic.detect" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end end #I2C5 device ref pcie_rp4 on # Enable wlan PCIe 4 using clk 2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81552?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbb2cb750a80bc6e8f96609257dcd1e695ad1fa4 Gerrit-Change-Number: 81552 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: mainboard/intel: Add initial support for Avenue City CRB
by Shuo Liu (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Arthur Heymans, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Nicholas Chin, Patrick Rudolph, TangYiwei, Varshit Pandya. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81319?usp=email ) Change subject: mainboard/intel: Add initial support for Avenue City CRB ...................................................................... Patch Set 24: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81319/comment/33468a40_161e1d1d : PS24, Line 7: mainboard/intel > "mb/intel/avenuecity_crb" instead of "mainboard/intel" Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81319?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64fdd5388aadf7732f6d3daa600c1455d3672a46 Gerrit-Change-Number: 81319 Gerrit-PatchSet: 24 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: TangYiwei Gerrit-Comment-Date: Thu, 28 Mar 2024 02:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: acpi: Add acpigen_write_OSC_pci_domain
by Shuo Liu (Code Review) 27 Mar '24

27 Mar '24

1 0

[L] Change in coreboot[main]: acpi: Add acpigen_write_OSC_pci_domain
by Shuo Liu (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Nico Huber, Paul Menzel, Tim Chu, Tim Wawrzynczak. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81375?usp=email ) Change subject: acpi: Add acpigen_write_OSC_pci_domain ...................................................................... Patch Set 13: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81375/comment/bda711a9_d0e104e0 : PS12, Line 9: dynamic > Sure, you cannot easily do it with static DSDT only. But most of the implementation […] Yeah, I agree that the static ASL is more clear to read. For dynamic ASL, mainly we use it to generate a list of ASL device objects based on FSP outputs (indicates the SoC/SKU configurations) and the _OSC is a method inside (hence it would be straightforward to be generated altogether, plus some C codes managed boot configs could be referenced as well), this is used by xeon-sp only as of now. Will update the commit message to be more clarified. File src/acpi/acpigen_pci.c: https://review.coreboot.org/c/coreboot/+/81375/comment/962aa0e4_d98afdb0 : PS12, Line 98: With > Width Done https://review.coreboot.org/c/coreboot/+/81375/comment/67e2239f_b84afe38 : PS12, Line 98: Name - With, Source, Offset, Description : * -------------------------------- : * QSUP - DWord, Local7, 0x00, Query support : * RETE - DWord, Arg3, 0x00, Returned errors : * SUPP - Dword, Arg3, 0x04, PCIe Features that OS supported : * CTRL - Dword, Arg3, 0x08, PCIe Features that firmware grant control to OS : * OTRL - Dword, Local7, 0x08, PCIe Features that OS requests for control : * SUPC - Dword, Arg3, 0x0C, CXL Features that OS supported : * CTRC - Dword, Arg3, 0x10, CXL Features that firmware grant control to OS : * OTRC - Dword, Local7, 0x10, CXL Features that OS requests for control > If it’s a table, I wouldn’t separate the columns by a comma. Done https://review.coreboot.org/c/coreboot/+/81375/comment/276e351e_204dea08 : PS12, Line 127: : if (is_cxl_domain) { : /* : * If ((Arg0 != ToUUID (PCI_HOST_BRIDGE_OSC_UUID)) && : * (Arg0 != ToUUID (CXL_HOST_BRIDGE_OSC_UUID))) : */ : acpigen_write_if(); : acpigen_emit_byte(LAND_OP); : acpigen_emit_byte(LNOT_OP); : acpigen_emit_byte(LEQUAL_OP); : acpigen_emit_byte(ARG0_OP); : acpigen_write_uuid(PCI_HOST_BRIDGE_OSC_UUID); : acpigen_emit_byte(LNOT_OP); : acpigen_emit_byte(LEQUAL_OP); : acpigen_emit_byte(ARG0_OP); : acpigen_write_uuid(CXL_HOST_BRIDGE_OSC_UUID); : } else { : /* : * If (Arg0 != ToUUID (PCI_HOST_BRIDGE_OSC_UUID)) : */ : acpigen_write_if(); : acpigen_emit_byte(LNOT_OP); : acpigen_emit_byte(LEQUAL_OP); : acpigen_emit_byte(ARG0_OP); : acpigen_write_uuid(PCI_HOST_BRIDGE_OSC_UUID); : } : : > I don't understand. Currently this looks like: […] Thanks, the new flow is better. Updated. https://review.coreboot.org/c/coreboot/+/81375/comment/6cbff211_f65d2f62 : PS12, Line 272: |= > Yes ... I only directly assign RETE when there is an immediately return after the assignment. […] Done https://review.coreboot.org/c/coreboot/+/81375/comment/172cbddf_447e928b : PS12, Line 317: acpigen_write_create_dword_field(LOCAL7_OP, 0x10, "OTRC"); > > The current assumption is, for a CXL domain […] CXL-3.1-Specification, 9.18.2 The _OSC interface defined in this section applies only to “Host Bridge” ACPI devices that originate CXL hierarchies. As specified in Section 9.12, these ACPI devices must have an _HID of (or a _CID that includes) EISAID(“ACPI0016”). CXL _OSC is required for a CXL VH. CXL _OSC is optional for an RCD. A CXL Host Bridge also originates a PCIe hierarchy and will have a _CID of EISAID(“PNP0A08”). As such, a CXL Host Bridge device may expose both CXL _OSC and PCIe _OSC. I will update the comment block. https://review.coreboot.org/c/coreboot/+/81375/comment/5a8353e0_63262fc3 : PS12, Line 348: __weak unsigned long get_granted_pci_features(const struct device *domain) : { : return 0; : } : : __weak unsigned long get_granted_cxl_features(const struct device *domain) : { : return 0; : } > Let me rephrase: What if these are not overridden? Does a `return 0` […] refer to: PCI firmware specification, revision 3.1 If the _OSC control method is absent from the scope of a host bridge device, then the operating system must not enable or attempt to use any features defined in this section for the hierarchy originated by the host bridge. Doing so could contend with platform firmware operations or produce undesired results. I will add comments. -- To view, visit https://review.coreboot.org/c/coreboot/+/81375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711ce5350d718e47feb2912555108801ad7f918d Gerrit-Change-Number: 81375 Gerrit-PatchSet: 13 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 28 Mar 2024 02:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: soc/intel/xeon_sp: Add GraniteRapids initial codes
by Shuo Liu (Code Review) 27 Mar '24

27 Mar '24

Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, TangYiwei, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81316?usp=email ) Change subject: soc/intel/xeon_sp: Add GraniteRapids initial codes ...................................................................... Patch Set 26: (9 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81316/comment/8dac9a46_9e3308d9 : PS26, Line 7: GraniteRapids > Granite Rapids Done https://review.coreboot.org/c/coreboot/+/81316/comment/8e7024f2_7fa3f7cf : PS26, Line 9: GraniteRapids > Granite Rapids Done https://review.coreboot.org/c/coreboot/+/81316/comment/8f26e0e1_5208d636 : PS26, Line 9: FSP2.4 > FSP 2. […] Done https://review.coreboot.org/c/coreboot/+/81316/comment/0e4f3b21_f4cf0582 : PS26, Line 11: SierraForest > Sierra Forest Done https://review.coreboot.org/c/coreboot/+/81316/comment/790744cd_e342eee2 : PS26, Line 13: setups the code set > sets the code set up. Done https://review.coreboot.org/c/coreboot/+/81316/comment/9e686b18_0e1dbb39 : PS26, Line 14: SapphireRapids > Sapphire Rapids Done Patchset: PS26: > Please add an entry to MAINTAINERS. Done File src/soc/intel/xeon_sp/chip_gen6.c: PS26: > Please describe this file and generations in the commit message. Done https://review.coreboot.org/c/coreboot/+/81316/comment/cbf32787_859daa40 : PS26, Line 80: .read_resources = iio_pci_domain_read_resources, : .set_resources = pci_domain_set_resources, : .scan_bus = pci_host_bridge_scan_bus, : #if CONFIG(HAVE_ACPI_TABLES) : .acpi_name = soc_acpi_name, : .write_acpi_tables = northbridge_write_acpi_tables, : .acpi_fill_ssdt = pci_domain_fill_ssdt, > Please format the = consistently. (I’d prefer just one space. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3084e1b5abf25d8d9504bebeaed2a15b916ed56b Gerrit-Change-Number: 81316 Gerrit-PatchSet: 26 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: TangYiwei Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 28 Mar 2024 02:15:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024