Attention is currently required from: Arthur Heymans, Nick Vaccaro.
Alicja Michalska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80848?usp=email )
Change subject: soc/intel/tigerlake: Add IRQ mapping for PEG PCI-E ports
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80848/comment/c5cfa241_a2eb5f06 :
PS1, Line 16: Boot Linux
> Did you try without MSI ? Otherwise the OS might just not complain even though the IRQ routing is wr […]
Yes, pci=nomsi breaks NVME altogether.
3mdeb folks have a similar patch for AlderLake in their (downstream) tree.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80848?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If102522efa1a67b362b14d859d9e27a37bad85a4
Gerrit-Change-Number: 80848
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 01 Mar 2024 13:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Alicja Michalska has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/80852?usp=email )
Change subject: mb/erying/tgl: Add blobs necessary for platform bring-up
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/80852/comment/5f82a31f_bee1b335 :
PS1, Line 7: .
> Remove, don't end the title with a period
Acknowledged
--
To view, visit https://review.coreboot.org/c/blobs/+/80852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Gerrit-Change-Number: 80852
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Fri, 01 Mar 2024 13:44:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Alicja Michalska has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/80852?usp=email )
Change subject: mb/erying/tgl: Add blobs necessary for platform bring-up
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
ACK, period removed
--
To view, visit https://review.coreboot.org/c/blobs/+/80852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Gerrit-Change-Number: 80852
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Fri, 01 Mar 2024 13:44:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alicja Michalska.
Hello Felix Singer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/80852?usp=email
to look at the new patch set (#2).
Change subject: mb/erying/tgl: Add blobs necessary for platform bring-up
......................................................................
mb/erying/tgl: Add blobs necessary for platform bring-up
Flash Descriptor and Management Engine blobs extracted from stock.
Microcodes from public GitHub repository, as Intel doesn't carry
microcode for D0 stepping in their tree.
Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Signed-off-by: Alicja Michalska <ahplka19(a)gmail.com>
---
A mainboard/erying/tgl/cpu806D0_platC2_ver00000054_2021-05-07_PRD_B0F9E245.bin
A mainboard/erying/tgl/cpu806D1_platC2_ver00000046_2023-02-27_PRD_08E6188A.bin
A mainboard/erying/tgl/fd.bin
A mainboard/erying/tgl/me.bin
4 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/52/80852/2
--
To view, visit https://review.coreboot.org/c/blobs/+/80852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Gerrit-Change-Number: 80852
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alicja Michalska.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/80852?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/erying/tgl: Add blobs necessary for platform bring-up.
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/80852/comment/91d9848f_4b24fc07 :
PS1, Line 7: .
Remove, don't end the title with a period
--
To view, visit https://review.coreboot.org/c/blobs/+/80852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Gerrit-Change-Number: 80852
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 13:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alicja Michalska.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/80852?usp=email )
Change subject: mb/erying/tgl: Add blobs necessary for platform bring-up.
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://review.coreboot.org/c/blobs/+/80852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Gerrit-Change-Number: 80852
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 13:37:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alicja Michalska.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/80852?usp=email )
Change subject: mb/erying/tgl: Add blobs necessary for platform bring-up.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/80852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Gerrit-Change-Number: 80852
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 Mar 2024 13:37:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment