Attention is currently required from: Elyes Haouas, Martin L Roth, Nico Huber, Zebreus.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80607?usp=email )
Change subject: [test only] upgrade to gcc-14-20240225
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS1:
> Nico, could you look at the issues from the toolchain builder? There are some Ada related issues.
Done
File util/…
[View More]crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/80607/comment/e552a0e5_27dc99d0 :
PS4, Line 73: GCC_BASE_URL="https://gcc.gnu.org/pub/gcc/snapshots/LATEST-14"
> A new snapshot is available and the latest pointer changed. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80607?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib96709309e7c71b76a51d3b8600be793312d6a8f
Gerrit-Change-Number: 80607
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 02 Mar 2024 04:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
[View Less]
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80436?usp=email )
Change subject: lint: Make lint work on Darwin
......................................................................
lint: Make lint work on Darwin
Darwin's getopt does not support the same parameters as the
util-linux version and so it is not possible to commit any
changes because lint fails.
Change-Id: Ife26083d2de080af9ed3d509945720051ca14bd7
Signed-off-by: Stefan Reinauer <stefan.…
[View More]reinauer(a)coreboot.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80436
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/lint/lint
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Felix Singer: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/util/lint/lint b/util/lint/lint
index 94cd4a6..1896db1 100755
--- a/util/lint/lint
+++ b/util/lint/lint
@@ -29,7 +29,14 @@
fi
}
-if ! cmd_args="$(getopt -l help,junit,invert -o hIJ -- "$@")"; then
+# Look if we have getopt. If not, build it.
+if [ $(uname) == Darwin ]; then
+ GETOPT="getopt hIJ"
+else
+ GETOPT="getopt -l help,junit,invert -o hIJ"
+fi
+
+if ! cmd_args="$($GETOPT -- "$@")"; then
usage
exit 0
fi
--
To view, visit https://review.coreboot.org/c/coreboot/+/80436?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife26083d2de080af9ed3d509945720051ca14bd7
Gerrit-Change-Number: 80436
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
[View Less]
Attention is currently required from: Martin L Roth, Stefan Reinauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80436?usp=email )
Change subject: lint: Make lint work on Darwin
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80436?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/…
[View More]settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife26083d2de080af9ed3d509945720051ca14bd7
Gerrit-Change-Number: 80436
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 02 Mar 2024 03:54:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[View Less]
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80863?usp=email )
Change subject: Update MAINTAINERS file
......................................................................
Update MAINTAINERS file
Change-Id: Ic924b8faf44473fa4bac5c033a8e784e41581292
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80863
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-…
[View More]by: Martin L Roth <gaumless(a)gmail.com>
---
M MAINTAINERS
1 file changed, 8 insertions(+), 12 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin L Roth: Looks good to me, approved
diff --git a/MAINTAINERS b/MAINTAINERS
index a1ede9f..e7375da 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -989,7 +989,6 @@
F: payloads/coreinfo/
EXTERNAL PAYLOADS INTEGRATION
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
M: Martin Roth <gaumless(a)gmail.com>
F: payloads/external/
@@ -1058,11 +1057,9 @@
F: util/lint/
IFDTOOL
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
F: util/ifdtool/
INTELTOOL
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
M: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com>
F: util/inteltool/
@@ -1222,34 +1219,33 @@
# *** Infrastructure Owners ***
# This is intended to let people know who they should contact for issues with various infrastructure pieces.
# Hardware
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups:
# Web Server
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups:
# Website
# Owners: Martin
-# Backups: Patrick, Stefan
+# Backups: Patrick
# Documentation Website
# Owners: Patrick
# Backups:
CODE OF CONDUCT
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
M: Ronald Minnich <rminnich(a)gmail.com>
M: Martin Roth <martin(a)coreboot.org>
S: Maintained
F: Documentation/community/code_of_conduct.md
# Wiki
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups:
# Gerrit
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups: Martin
# Jenkins
@@ -1261,9 +1257,9 @@
# Backups: Martin,
# Mailing List
-# Owners: Stefan, Patrick
-# Backups: Martin,
+# Owners: Patrick
+# Backups: Martin
# Software Freedom Conservancy
# Main contact: Martin
-# “Official” contact: Stefan
+# “Official” contact: David, Matt, Werner
--
To view, visit https://review.coreboot.org/c/coreboot/+/80863?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic924b8faf44473fa4bac5c033a8e784e41581292
Gerrit-Change-Number: 80863
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: merged
[View Less]
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Nicholas Sudsgaard, Sean Rhodes, Stefan Reinauer.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80883?usp=email )
Change subject: payload/external/edk2: Explicitly define the build arch
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
what issue are you seeing with the arch not specified / what …
[View More]problem does this resolve? Does this work for both UefiPayloadPkg and UniversalPayload?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80883?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd942d0c15a99231d09f9cbdc5eb48333b6aa6e5
Gerrit-Change-Number: 80883
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Sat, 02 Mar 2024 03:07:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Name of user not set #1004951.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75129?usp=email )
Change subject: util/archive/archive.c: attempt 2 - add features to archive util Add "extract" and "list" options to the archive util
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi, It looks like you haven't contributed to the coreboot project …
[View More]before.
Welcome, and thank you for the patch. We hope that this is just the first of many.
Please let us know if there's anything we can do to help get your first sets patches merged as you get used to the contribution process.
The coreboot project has a hands-off policy regarding other people's patches so nobody here is going to update the contents without your permission. If you would you like someone to take over your patches at any point, please just post a comment to that effect on the specific patch.
You might find the coding style guide and the gerrit guidelines useful to read.
https://doc.coreboot.org/contributing/coding_style.htmlhttps://doc.coreboot.org/contributing/gerrit_guidelines.html
If you want to talk with anyone, you can talk to developers on one of the many options we have:
https://doc.coreboot.org/community/forums.html
Again, please let us know if you have any questions, or if there's anything we can do to help.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75129?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1aab9a2ae76e1126f31db53ccffc1aa5f66ae189
Gerrit-Change-Number: 75129
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1004951
Gerrit-Reviewer: Name of user not set #1004951
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Name of user not set #1004951
Gerrit-Comment-Date: Sat, 02 Mar 2024 02:31:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Patrick Georgi, Stefan Reinauer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80863?usp=email )
Change subject: Update MAINTAINERS file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80863?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings…
[View More]Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic924b8faf44473fa4bac5c033a8e784e41581292
Gerrit-Change-Number: 80863
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:46:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Felix Singer, Martin L Roth.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80436?usp=email )
Change subject: lint: Make lint work on Darwin
......................................................................
Patch Set 2:
(2 comments)
File util/lint/lint:
https://review.coreboot.org/c/coreboot/+/80436/comment/ad50cb26_403513ba :
PS1, Line 25: # Look if we have getopt. If not, build it.
> Could you …
[View More]move these lines below junit_write()? Then the functions stay in line.
Done
https://review.coreboot.org/c/coreboot/+/80436/comment/0d898f29_6e21c979 :
PS1, Line 29: --
> This seems wrong here. The double dash is still present below.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80436?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife26083d2de080af9ed3d509945720051ca14bd7
Gerrit-Change-Number: 80436
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:37:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78304?usp=email )
Change subject: amdfwtool: Remove the function's dependency to ctx
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78304/comment/e8480972_7296ff7a :
PS4, Line 9: writebody
> write_body function
Done
https://review.coreboot.…
[View More]org/c/coreboot/+/78304/comment/c80622ac_3529c7e3 :
PS4, Line 11:
> would be good to also mention that the amdfwtool_cleanup calls are removed from write_body, but sinc […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78304?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I639828498fa45911f430500735e90ddc198b6af5
Gerrit-Change-Number: 78304
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:33:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
[View Less]