Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Jincheng Li, Johnny Lin, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Ray Ni, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80632?usp=email )
Change subject: soc/intel/xeon_sp: Add memory type check utils
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/xeon_sp/spr/soc_util.c:
https://review.coreboot.org/c/coreboot/+/80632/comment/55f49e57_604a2ed2 :
PS6, Line 189: * vendorcode/intel/fsp/fsp2_0/sapphirerapids_sp/MemoryMapDataHob.h,
> It will be provided in https://github. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80632?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f5f3c0f16dc50bc739146e46afce2e5fbf4f62c
Gerrit-Change-Number: 80632
Gerrit-PatchSet: 7
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Ray Ni <ray.ni(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ray Ni <ray.ni(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-MessageType: comment
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/71529?usp=email )
Change subject: mb/hp/t620: Add new board HP T620
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/71529?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.18_branch
Gerrit-Change-Id: Ieaa724f393194f762d55263a74b04c9fde93e53f
Gerrit-Change-Number: 71529
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Jeff Daly, Johnny Lin, Lean Sheng Tan, Matt DeVillier, Tim Chu, Vanessa Eusebio.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80703?usp=email )
Change subject: cpu/x86/smm/smm_module_loader.c: Pass full SMRAM region info to SMM runtime
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80703/comment/57573be1_39bed7ca :
PS2, Line 17: integrity of the S3 resume path.
> smm_region_overlaps_handler() consumes these fields. […]
Sorry, I mean the current smm_region_overlaps_handler() only provides SMRAM, but not staging cache and chip-specific area. If we would like to provide the latter two, we need another patch to cover. Hence, for the commit message of this, we need to be specific, e.g.,
cpu/x86/smm: Pass full SMRAM region info to SMM runtime
This data is used by smm_region_overlaps_handler(). Callers use this
helper to determine if it's safe to read/write to memory buffers taken
from untrusted input. coreboot SMI handlers must not be confused into
writing over any SMRAM, not just the code subregion.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80703?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd9ed34fcfd77a4236b5cf122747a6718ce9c91f
Gerrit-Change-Number: 80703
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:24:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com>
Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Martin Roth, Nikolai Vyssotski, Zheng Bao.
Hello Martin Roth, Nikolai Vyssotski, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78274?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Code-Review+1 by Nikolai Vyssotski, Verified+1 by build bot (Jenkins)
Change subject: amdfwtool: Set the table size for L1 separately
......................................................................
amdfwtool: Set the table size for L1 separately
The space defined by size of the L1 table can not overlap with ISH
header. For other cases, the size defines the directory and its
content.
The PSP spec does not say it quite clearly. This change is partly
based on guess and can make extraction tool work so far.
Change-Id: Id4fbc6d57d7ea070a9478649a96af92be9441289
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 19 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/78274/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/78274?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4fbc6d57d7ea070a9478649a96af92be9441289
Gerrit-Change-Number: 78274
Gerrit-PatchSet: 12
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held, Martin Roth, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78274?usp=email )
Change subject: amdfwtool: Set the table size for L1 separately
......................................................................
Patch Set 11:
(3 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/78274/comment/305e92ef_c6527972 :
PS11, Line 615: 1
> this should probably be changed to TABLE_ALIGNMENT too. that would allow to drop the […]
This patch is only for family which PSP header points to ISH header.
I will put this detail in commit log.
https://review.coreboot.org/c/coreboot/+/78274/comment/9601a3a6_baad94f2 :
PS11, Line 655: if (cookie == PSP_COOKIE && cb_config->need_ish)
: table_size = TABLE_ALIGNMENT;
: else
> haven't traced the code, but from what i've seen, the actual bug seems to be that in integrate_psp_f […]
In integrate_psp_firmwares the new_ish_dir is called. We can not take the assumption that the increasing pointer is at the end of psp_dir.
We have to make sure the ISH header is at the outside of the PSP table. We
have to do that when the PSP header is created.
https://review.coreboot.org/c/coreboot/+/78274/comment/c2b89dd5_8a479337 :
PS11, Line 1221: 1
> this should probably also be changed to TABLE_ALIGNMENT
This patch is only for family which PSP header points to ISH header.
I will put this detail in commit log.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78274?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4fbc6d57d7ea070a9478649a96af92be9441289
Gerrit-Change-Number: 78274
Gerrit-PatchSet: 11
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Isaac W Oram, Nathaniel L Desimone, Nico Huber.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/57477?usp=email )
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: mb/ocp/deltalake: Add descriptor + ME ignition binary
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/57477?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I6f0a404edebf982ee56f5fa30fb0880bdf138006
Gerrit-Change-Number: 57477
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Isaac W Oram <isaac.w.oram(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Attention: Isaac W Oram <isaac.w.oram(a)intel.com>
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:04:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Martin L Roth, ron minnich.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80619?usp=email )
Change subject: Documentation: Update the code of conduct
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File Documentation/community/code_of_conduct.md:
https://review.coreboot.org/c/coreboot/+/80619/comment/ef37e1ed_ef36976c :
PS2, Line 129: * Stefan Reinauer <stefan.reinauer(a)coreboot.org> (USA)
Please remove my name from the arbitration team.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80619?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e2010a16f31f892bd1761b56b96ea773877dea0
Gerrit-Change-Number: 80619
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Sat, 02 Mar 2024 00:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80863?usp=email )
Change subject: Update MAINTAINERS file
......................................................................
Update MAINTAINERS file
Change-Id: Ic924b8faf44473fa4bac5c033a8e784e41581292
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
M MAINTAINERS
1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/80863/1
diff --git a/MAINTAINERS b/MAINTAINERS
index a1ede9f..e7375da 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -989,7 +989,6 @@
F: payloads/coreinfo/
EXTERNAL PAYLOADS INTEGRATION
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
M: Martin Roth <gaumless(a)gmail.com>
F: payloads/external/
@@ -1058,11 +1057,9 @@
F: util/lint/
IFDTOOL
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
F: util/ifdtool/
INTELTOOL
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
M: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com>
F: util/inteltool/
@@ -1222,34 +1219,33 @@
# *** Infrastructure Owners ***
# This is intended to let people know who they should contact for issues with various infrastructure pieces.
# Hardware
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups:
# Web Server
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups:
# Website
# Owners: Martin
-# Backups: Patrick, Stefan
+# Backups: Patrick
# Documentation Website
# Owners: Patrick
# Backups:
CODE OF CONDUCT
-M: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
M: Ronald Minnich <rminnich(a)gmail.com>
M: Martin Roth <martin(a)coreboot.org>
S: Maintained
F: Documentation/community/code_of_conduct.md
# Wiki
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups:
# Gerrit
-# Owners: Stefan, Patrick
+# Owners: Patrick
# Backups: Martin
# Jenkins
@@ -1261,9 +1257,9 @@
# Backups: Martin,
# Mailing List
-# Owners: Stefan, Patrick
-# Backups: Martin,
+# Owners: Patrick
+# Backups: Martin
# Software Freedom Conservancy
# Main contact: Martin
-# “Official” contact: Stefan
+# “Official” contact: David, Matt, Werner
--
To view, visit https://review.coreboot.org/c/coreboot/+/80863?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic924b8faf44473fa4bac5c033a8e784e41581292
Gerrit-Change-Number: 80863
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newchange
Attention is currently required from: Elyes Haouas, Martin L Roth, Nico Huber.
Zebreus has uploaded a new patch set (#6) to the change originally created by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/80607?usp=email )
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: [test only] upgrade to gcc-14-20240225
......................................................................
[test only] upgrade to gcc-14-20240225
Change-Id: Ib96709309e7c71b76a51d3b8600be793312d6a8f
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/gcc-14-20240225_asan_shadow_offset_callback.patch
R util/crossgcc/patches/gcc-14-20240225_gnat.patch
R util/crossgcc/patches/gcc-14-20240225_libcpp.patch
R util/crossgcc/patches/gcc-14-20240225_libgcc.patch
R util/crossgcc/patches/gcc-14-20240225_musl_poisoned_calloc.patch
R util/crossgcc/patches/gcc-14-20240225_rv32iafc.patch
D util/crossgcc/sum/gcc-13.2.0.tar.xz.cksum
A util/crossgcc/sum/gcc-14-20240225.tar.xz.cksum
9 files changed, 11 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/80607/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/80607?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib96709309e7c71b76a51d3b8600be793312d6a8f
Gerrit-Change-Number: 80607
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset