coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[L] Change in coreboot[main]: restore_agesa.sh - restores the opensource AMD AGESA boards
by Mike Banon (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Balázs Vinarz, Vlado Ilic. Hello Balázs Vinarz, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79838?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: restore_agesa.sh - restores the opensource AMD AGESA boards ...................................................................... restore_agesa.sh - restores the opensource AMD AGESA boards restore_agesa.sh reverts the opensource AGESA AMD boards removal that happened after 5e8e911b7caee021faff96c4e82a77a42544ea62 commit (0 point of history, or 0 PoH) - by git-reverting: 1) the "bad commits" (marked as "CBF" = coreboot build failure) - that either remove or break a code needed for our boards 2) the "unlucky commits" (marked as "GRF" = git revert failure) - that are a roadblock for git-reverting the "bad commits" Right now at 62407ac1979e372fdbe8a71d3dfee3f797332bbb (6034 PoH), it takes 50 CBF git reverts - just 1% of 6034 commits since the OSS AGESA removal! - making this removal look questionable and the idea of opensource AGESA AMD boards restoration viable. SUCCESSFUL BOOT TESTS for the opensource AGESA boards which I own (Lenovo G505S - fam15 laptop, ASUS A88XM-E - fam15 desktop, ASUS AM1I-A - fam16 desktop) : 62407ac1979e372fdbe8a71d3dfee3f797332bbb (6034 PoH) for Lenovo G505S 69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for ASUS A88XM-E Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- A restore_agesa.sh 1 file changed, 360 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79838/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c Gerrit-Change-Number: 79838 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com> Gerrit-CC: awokd(a)danwin1210.me Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[main]: util: add smmstoretool for editing SMMSTORE
by Sergii Dmytruk (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Arthur Heymans, Filip Lewiński, Michał Kopeć. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79080?usp=email ) Change subject: util: add smmstoretool for editing SMMSTORE ...................................................................... Patch Set 8: (1 comment) File Documentation/util/smmstoretool/index.md: https://review.coreboot.org/c/coreboot/+/79080/comment/b4afab20_80d532c9 : PS8, Line 114: cbfstool coreboot.rom read -r SMMSTORE -f SMMSTORE : smmstoretool SMMSTORE set -g dasharo -n NetworkBoot -t bool -v true : cbfstool coreboot.rom write -r SMMSTORE -f SMMSTORE > Could FMAP support be added to this tool? That would be easy to get working and remove the need for […] Added parsing of FMAP in CB:80903 to support both cases. -- To view, visit https://review.coreboot.org/c/coreboot/+/79080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c1c06f1d0c39c13b5be76a3070f09b715aca6e0 Gerrit-Change-Number: 79080 Gerrit-PatchSet: 8 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Filip Lewiński Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Filip Lewiński Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 02 Mar 2024 15:05:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: util/smmstoretool: support processing ROMs
by Sergii Dmytruk (Code Review) 02 Mar '24

02 Mar '24

Sergii Dmytruk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80903?usp=email ) Change subject: util/smmstoretool: support processing ROMs ...................................................................... util/smmstoretool: support processing ROMs Input file is parsed for FMAP and SMMSTORE region which is used if found. Otherwise, the whole file is assumed to be the region. Passing an image with FMAP that lacks SMMSTORER is an error. Change-Id: Ieab555d7bbcfa4dadf6a5070d1297acd737440fb Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M Documentation/util/smmstoretool/index.md M util/smmstoretool/Makefile M util/smmstoretool/main.c M util/smmstoretool/storage.c M util/smmstoretool/storage.h 5 files changed, 59 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/80903/1 diff --git a/Documentation/util/smmstoretool/index.md b/Documentation/util/smmstoretool/index.md index f7af605..5be6ffc 100644 --- a/Documentation/util/smmstoretool/index.md +++ b/Documentation/util/smmstoretool/index.md @@ -4,13 +4,20 @@ ## Operation +### File formats + +To discover SMMSTORE, the tool first looks for FMAP header and, if found, for +SMMSTORE region. If FMAP is found but it has no SMMSTORE region, that's an +error. If there is no FMAP, the whole file is assumed to be SMMSTORE +region (e.g., extracted via `cbfstool`). + ### Storage initialization If SMMSTORE presence isn't detected and an update operation is requested, the -store spanning the whole file is created automatically. Size of the store file -must be a multiple of 64 KiB (block size in version 2 of SMMSTORE protocol), -the variable storage itself will be 64 KiB in size. That's the way EDK2 makes -use of it. +store spanning the whole region is created automatically. Size of the store +region must be a multiple of 64 KiB (block size in version 2 of SMMSTORE +protocol), the variable storage itself will be 64 KiB in size. That's the way +EDK2 makes use of it. Unlike online editing which mostly appends new variable entries each storage update with this tool drops all deleted or incomplete entries. @@ -28,7 +35,7 @@ ``` $ smmstoretool -h -Usage: smmstoretool smm-store-file sub-command +Usage: smmstoretool smm-store-file|rom sub-command smmstoretool -h|--help Sub-commands: @@ -58,7 +65,8 @@ ## Examples -`SMMSTORE` is the name of a file containing SMMSTORE data. +`SMMSTORE` is the name of a file containing SMMSTORE data or a full ROM image +with FMAP that includes SMMSTORE region. ### Variable listing @@ -111,9 +119,13 @@ If one edits a newly generated Dasharo `coreboot.rom`: ```bash +# editing exported storage cbfstool coreboot.rom read -r SMMSTORE -f SMMSTORE smmstoretool SMMSTORE set -g dasharo -n NetworkBoot -t bool -v true cbfstool coreboot.rom write -r SMMSTORE -f SMMSTORE + +# editing in-place storage +smmstoretool coreboot.rom set -g dasharo -n NetworkBoot -t bool -v true ``` On the first boot, "Network Boot" setting will already be enabled. diff --git a/util/smmstoretool/Makefile b/util/smmstoretool/Makefile index 78b77ca..d73c251 100644 --- a/util/smmstoretool/Makefile +++ b/util/smmstoretool/Makefile @@ -14,6 +14,7 @@ HOSTCFLAGS += -Wall -Wextra -MMD -MP -O3 HOSTCFLAGS += -I $(ROOT)/commonlib/bsd/include HOSTCFLAGS += -I $(ROOT)/vendorcode/intel/edk2/ +HOSTCFLAGS += -I $(TOP)/util/cbfstool/flashmap/ HOSTCFLAGS += -I $(MDE) HOSTLDFLAGS ?= $(LDFLAGS) @@ -27,7 +28,10 @@ $(error Unsupported machine: '$(MACHINE)') endif +# there files are in this directory SRC := data.c fv.c guids.c main.c storage.c utils.c vs.c +# and these are in $(TOP)/util/cbfstool/flashmap/ +SRC += fmap.c kv_pair.c valstr.c OBJ := $(SRC:.c=.o) DEP := $(SRC:.c=.o.d) @@ -53,4 +57,7 @@ %.o: %.c $(HOSTCC) $(HOSTCFLAGS) -c -o $@ -MF $@.d $< +%.o: $(TOP)/util/cbfstool/flashmap/%.c + $(HOSTCC) $(HOSTCFLAGS) -c -o $@ -MF $@.d $< + -include $(DEP) diff --git a/util/smmstoretool/main.c b/util/smmstoretool/main.c index eff5d9c..4857b62 100644 --- a/util/smmstoretool/main.c +++ b/util/smmstoretool/main.c @@ -77,7 +77,7 @@ static const int sub_command_count = ARRAY_SIZE(sub_commands); -static const char *USAGE_FMT = "Usage: %s smm-store-file sub-command\n" +static const char *USAGE_FMT = "Usage: %s smm-store-file|rom sub-command\n" " %s -h|--help\n"; static const char *program_name; @@ -131,7 +131,7 @@ static void help_set(FILE *f, const struct subcommand_t *info) { fprintf(f, "Create or update a variable:\n"); - fprintf(f, " %s smm-store-file %s \\\n", program_name, info->name); + fprintf(f, " %s smm-store-file|rom %s \\\n", program_name, info->name); fprintf(f, " -g vendor-guid \\\n"); fprintf(f, " -n variable-name \\\n"); fprintf(f, " -t variable-type \\\n"); @@ -229,7 +229,7 @@ static void help_list(FILE *f, const struct subcommand_t *info) { fprintf(f, "List variables in the store:\n"); - fprintf(f, " %s smm-store-file %s\n", program_name, info->name); + fprintf(f, " %s smm-store-file|rom %s\n", program_name, info->name); } static int process_list(int argc, char *argv[], const char store_file[]) @@ -261,7 +261,7 @@ static void help_get(FILE *f, const struct subcommand_t *info) { fprintf(f, "Read variable's value:\n"); - fprintf(f, " %s smm-store-file %s \\\n", program_name, info->name); + fprintf(f, " %s smm-store-file|rom %s \\\n", program_name, info->name); fprintf(f, " -g vendor-guid \\\n"); fprintf(f, " -n variable-name \\\n"); fprintf(f, " -t variable-type\n"); @@ -334,10 +334,10 @@ static void help_help(FILE *f, const struct subcommand_t *info) { fprintf(f, "Display generic help:\n"); - fprintf(f, " %s smm-store-file %s\n", program_name, info->name); + fprintf(f, " %s smm-store-file|rom %s\n", program_name, info->name); fprintf(f, "\n"); fprintf(f, "Display sub-command help:\n"); - fprintf(f, " %s smm-store-file %s sub-command\n", + fprintf(f, " %s smm-store-file|rom %s sub-command\n", program_name, info->name); } @@ -375,7 +375,7 @@ static void help_remove(FILE *f, const struct subcommand_t *info) { fprintf(f, "Remove a variable:\n"); - fprintf(f, " %s smm-store-file %s \\\n", program_name, info->name); + fprintf(f, " %s smm-store-file|rom %s \\\n", program_name, info->name); fprintf(f, " -g vendor-guid \\\n"); fprintf(f, " -n variable-name\n"); } @@ -432,7 +432,7 @@ static void help_guids(FILE *f, const struct subcommand_t *info) { fprintf(f, "List recognized GUIDS:\n"); - fprintf(f, " %s smm-store-file %s\n", program_name, info->name); + fprintf(f, " %s smm-store-file|rom %s\n", program_name, info->name); } static int process_guids(int argc, char *argv[], const char store_file[]) diff --git a/util/smmstoretool/storage.c b/util/smmstoretool/storage.c index abc6840..8a02384 100644 --- a/util/smmstoretool/storage.c +++ b/util/smmstoretool/storage.c @@ -5,6 +5,9 @@ #include <assert.h> #include <stdio.h> +#include "commonlib/bsd/compiler.h" +#include "fmap.h" + #include "fv.h" #include "utils.h" @@ -19,8 +22,27 @@ return false; } + /* If we won't find FMAP with SMMSTORE, use the whole file, but fail if + * FMAP is there without SMMSTORE. */ + storage->region = storage->file; + + long fmap_offset = fmap_find(storage->file.start, storage->file.length); + if (fmap_offset >= 0) { + struct fmap *fmap = (void *)(storage->file.start + fmap_offset); + const struct fmap_area *area = fmap_find_area(fmap, "SMMSTORE"); + if (area == NULL) { + fprintf(stderr, + "Found FMAP without SMMSTORE in \"%s\"\n", + store_file); + return false; + } + + storage->region.start += area->offset; + storage->region.length = area->size; + } + bool auth_vars; - if (!fv_parse(storage->file, &storage->store_area, &auth_vars)) { + if (!fv_parse(storage->region, &storage->store_area, &auth_vars)) { if (!rw) { fprintf(stderr, "Failed to find variable store in \"%s\"\n", @@ -28,14 +50,14 @@ goto error; } - if (!fv_init(storage->file)) { + if (!fv_init(storage->region)) { fprintf(stderr, "Failed to create variable store in \"%s\"\n", store_file); goto error; } - if (!fv_parse(storage->file, &storage->store_area, &auth_vars)) { + if (!fv_parse(storage->region, &storage->store_area, &auth_vars)) { fprintf(stderr, "Failed to parse newly formatted store in \"%s\"\n", store_file); diff --git a/util/smmstoretool/storage.h b/util/smmstoretool/storage.h index eb5cb08..8b91713 100644 --- a/util/smmstoretool/storage.h +++ b/util/smmstoretool/storage.h @@ -9,6 +9,7 @@ struct storage_t { bool rw; struct mem_range_t file; + struct mem_range_t region; struct mem_range_t store_area; struct var_store_t vs; }; -- To view, visit https://review.coreboot.org/c/coreboot/+/80903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieab555d7bbcfa4dadf6a5070d1297acd737440fb Gerrit-Change-Number: 80903 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[main]: soc/sifive/fu740: Add FU740 SOC
by Maximilian Brune (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Philipp Hug, ron minnich. Hello Philipp Hug, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76689?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/sifive/fu740: Add FU740 SOC ...................................................................... soc/sifive/fu740: Add FU740 SOC Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I4a8fe02ef0adcb939aa65377a35874715c5ee58a --- A src/soc/sifive/fu740/Kconfig A src/soc/sifive/fu740/Makefile.inc A src/soc/sifive/fu740/TODO A src/soc/sifive/fu740/cbmem.c A src/soc/sifive/fu740/chip.c A src/soc/sifive/fu740/clint.c A src/soc/sifive/fu740/clock.c A src/soc/sifive/fu740/ddrregs.c A src/soc/sifive/fu740/gpio.c A src/soc/sifive/fu740/include/soc/addressmap.h A src/soc/sifive/fu740/include/soc/clock.h A src/soc/sifive/fu740/include/soc/gpio.h A src/soc/sifive/fu740/include/soc/otp.h A src/soc/sifive/fu740/include/soc/sdram.h A src/soc/sifive/fu740/include/soc/spi.h A src/soc/sifive/fu740/memlayout.ld A src/soc/sifive/fu740/otp.c A src/soc/sifive/fu740/regconfig-ctl.h A src/soc/sifive/fu740/regconfig-phy.h A src/soc/sifive/fu740/sdram.c A src/soc/sifive/fu740/spi.c A src/soc/sifive/fu740/spi_internal.h A src/soc/sifive/fu740/uart.c 23 files changed, 4,679 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/76689/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/76689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a8fe02ef0adcb939aa65377a35874715c5ee58a Gerrit-Change-Number: 76689 Gerrit-PatchSet: 12 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[main]: soc/sifive/fu740: Add FU740 SOC
by Maximilian Brune (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76689?usp=email ) Change subject: soc/sifive/fu740: Add FU740 SOC ...................................................................... Patch Set 11: (6 comments) File src/soc/sifive/fu740/Kconfig: https://review.coreboot.org/c/coreboot/+/76689/comment/ed1f3a7f_1e840330 : PS10, Line 28: # working HART uses U7 core > RISCV_WORKING_HARTID is set to 0, which is S7? Done https://review.coreboot.org/c/coreboot/+/76689/comment/89539ec6_9644bdc9 : PS10, Line 47: default 0 # use S7 core as default hart > deliberate use of S7 for coreboot? Oh that is not correct. I have to use U7, because S7 does not have supervisor mode support. Not a problem using OpenSBI, but still. Changed it. File src/soc/sifive/fu740/clint.c: https://review.coreboot.org/c/coreboot/+/76689/comment/b1423225_839877e5 : PS10, Line 17: write32((void *)(FU740_CLINT + 4 * (uintptr_t)hartid), !!val); > use write32p? I am not a fan of hiding the type casts. File src/soc/sifive/fu740/gpio.c: https://review.coreboot.org/c/coreboot/+/76689/comment/764c41bc_b6bd4aea : PS10, Line 33: uint32_t output_val = read32((void *)SIFIVE_GPIO_OUTPUT_VAL); > use read32p/write32p? same as above File src/soc/sifive/fu740/memlayout.ld: https://review.coreboot.org/c/coreboot/+/76689/comment/7d9eba60_a6ef9014 : PS10, Line 22: //REGION(opensbi, FU740_DRAM, 256K, 4K) > comment not needed? Done File src/soc/sifive/fu740/spi.c: https://review.coreboot.org/c/coreboot/+/76689/comment/0f318b08_3a5d7952 : PS10, Line 186: //sckmode.raw_bits = 0; > why is this code commented here? delete it? I cleaned it up a bit, but the SPI code needs a proper cleanup. For that I need to test all the MSEL configurations though, but I don't have time for that at the moment. -- To view, visit https://review.coreboot.org/c/coreboot/+/76689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a8fe02ef0adcb939aa65377a35874715c5ee58a Gerrit-Change-Number: 76689 Gerrit-PatchSet: 11 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 02 Mar 2024 12:29:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philipp Hug <philipp(a)hug.cx> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: soc/sifive/fu740: Add FU740 SOC
by Maximilian Brune (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich. Hello Philipp Hug, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76689?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+1 by Philipp Hug, Code-Review+2 by ron minnich, Verified+1 by build bot (Jenkins) Change subject: soc/sifive/fu740: Add FU740 SOC ...................................................................... soc/sifive/fu740: Add FU740 SOC Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I4a8fe02ef0adcb939aa65377a35874715c5ee58a --- A src/soc/sifive/fu740/Kconfig A src/soc/sifive/fu740/Makefile.inc A src/soc/sifive/fu740/TODO A src/soc/sifive/fu740/cbmem.c A src/soc/sifive/fu740/chip.c A src/soc/sifive/fu740/clint.c A src/soc/sifive/fu740/clock.c A src/soc/sifive/fu740/ddrregs.c A src/soc/sifive/fu740/gpio.c A src/soc/sifive/fu740/include/soc/addressmap.h A src/soc/sifive/fu740/include/soc/clock.h A src/soc/sifive/fu740/include/soc/gpio.h A src/soc/sifive/fu740/include/soc/otp.h A src/soc/sifive/fu740/include/soc/sdram.h A src/soc/sifive/fu740/include/soc/spi.h A src/soc/sifive/fu740/memlayout.ld A src/soc/sifive/fu740/otp.c A src/soc/sifive/fu740/regconfig-ctl.h A src/soc/sifive/fu740/regconfig-phy.h A src/soc/sifive/fu740/sdram.c A src/soc/sifive/fu740/spi.c A src/soc/sifive/fu740/spi_internal.h A src/soc/sifive/fu740/uart.c 23 files changed, 4,681 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/76689/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/76689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a8fe02ef0adcb939aa65377a35874715c5ee58a Gerrit-Change-Number: 76689 Gerrit-PatchSet: 11 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Add fsp_headers.h
by Shuo Liu (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Ronak Kanabar, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80684?usp=email ) Change subject: soc/intel/xeon_sp: Add fsp_headers.h ...................................................................... Patch Set 11: Code-Review+1 (1 comment) This change is ready for review. Patchset: PS11: > Increases complexity and decreases maintainability and is based on non-existing specifications. […] For SKX to SPR, there are 2 class of FSP headers. One class is common headers, like <IioUniversalDataHob.h> which is commonly used for all bootloaders, include UEFI and SlimBoot. Another class is coreboot extended FSP headers, like <hob_iiouds.h>. These extended headers are used in coreboot only and maintained in coreboot repo (actually they are not released with initial FSP, but added during coreboot dev cycles). In GNR and future generations, the generality of FSP headers is improved and these extended headers are not needed. Hence files like <hob_iiouds.h> will not be used. Accordingly, we need to remove the references of these headers from Xeon-SP common codes, otherwise, compilation cannot pass for GNR. The solution this patch is not the only solution to deal with the problem. We have alternatives, e.g., 1) to still keep <hob_iiouds.h> for GNR, but leave them empty so that could have coreboot pass compilation, or, 2) use macro/Kconfig, e.g. (USE_COREBOOT_SPECIFIC_FSP_HEADERS) to include these references only for SoCs that need this, e.g. SKX to SPR. My preference is either that we use this solution, where the FSP header reference is centralized in a clean way for Xeon-SP codes (fsp_upd.h already provides a centralized place to handle similar stuffs). Either we choose 2) to use a macro to explicitly to control this. Please let me know your opinion. -- To view, visit https://review.coreboot.org/c/coreboot/+/80684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I89a87ec72933484326cb594b83bb3ed39d06b85c Gerrit-Change-Number: 80684 Gerrit-PatchSet: 11 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sat, 02 Mar 2024 12:05:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brya/var/dochi: Add wifi sar table
by Eric Lai (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: David Wu, Kapil Porwal, Morris Hsu, Nick Vaccaro, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80809?usp=email ) Change subject: mb/google/brya/var/dochi: Add wifi sar table ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/mainboard/google/brya/variants/dochi/variant.c: https://review.coreboot.org/c/coreboot/+/80809/comment/81699c62_bf7bea2d : PS1, Line 3: #include <chip.h> could you update a patch to reorder the header file? -- To view, visit https://review.coreboot.org/c/coreboot/+/80809?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf90756eb318bef1ffcda9368a976c0ca209a100 Gerrit-Change-Number: 80809 Gerrit-PatchSet: 1 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 02 Mar 2024 06:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for touchpanel
by Eric Lai (Code Review) 02 Mar '24

02 Mar '24

Attention is currently required from: Kapil Porwal, Nick Vaccaro, Subrata Banik, Yunlong Jia. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80850?usp=email ) Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for touchpanel ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/gothrax/gpio.c: https://review.coreboot.org/c/coreboot/+/80850/comment/d245feeb_a067cca0 : PS1, Line 104: if (fw_config_probe(FW_CONFIG(TOUCH_PANEL, TOUCH_PANEL_DISABLE))) { if () *num = ARRAY_SIZE(romstage_gpio_table_nontp); else *num = ARRAY_SIZE(romstage_gpio_table); return romstage_gpio_table; -- To view, visit https://review.coreboot.org/c/coreboot/+/80850?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I23c62406a932815ff1cfafe05b70468b1f9cca54 Gerrit-Change-Number: 80850 Gerrit-PatchSet: 1 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sat, 02 Mar 2024 06:36:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Select drivers for gpio-keys and GL9750
by Eric Lai (Code Review) 02 Mar '24

02 Mar '24

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80766?usp=email ) Change subject: mb/google/nissa/var/glassway: Select drivers for gpio-keys and GL9750 ...................................................................... mb/google/nissa/var/glassway: Select drivers for gpio-keys and GL9750 Add 2 configuration on Kconfig for glassway. - DRIVERS_GENERIC_GPIO_KEYS - DRIVERS_GENESYSLOGIC_GL9750 BUG=b:319071869 BRANCH=firmware-nissa-15217.B TEST=Local build successfully and boot to OOBE normally. Change-Id: Id7e358d2f472cd435d2828f6256f5ee91dfb8ef6 Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80766 Reviewed-by: Shawn Ku <shawnku(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified Shawn Ku: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index eb937523..90b8f7d 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -236,6 +236,8 @@ config BOARD_GOOGLE_GLASSWAY select BOARD_GOOGLE_BASEBOARD_NISSA + select DRIVERS_GENERIC_GPIO_KEYS + select DRIVERS_GENESYSLOGIC_GL9750 config BOARD_GOOGLE_GOTHRAX select BOARD_GOOGLE_BASEBOARD_NISSA -- To view, visit https://review.coreboot.org/c/coreboot/+/80766?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id7e358d2f472cd435d2828f6256f5ee91dfb8ef6 Gerrit-Change-Number: 80766 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024