coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3667 discussions

[XS] Change in coreboot[main]: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION
by Werner Zeh (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Subrata Banik. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80924?usp=email ) Change subject: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/80924/comment/f1a991cf_85fa281d : PS1, Line 236: enabling automatic detection Is there an option which lets the user to enable it explicitly or is it available implicit with Meteor Lake and newer? -- To view, visit https://review.coreboot.org/c/coreboot/+/80924?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c3e5c759e4d9a43c3bce3a0c032086f17592a67 Gerrit-Change-Number: 80924 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sun, 03 Mar 2024 12:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry
by Werner Zeh (Code Review) 03 Mar '24

03 Mar '24

1 0

[S] Change in coreboot[main]: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry
by Werner Zeh (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Subrata Banik. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email ) Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/cse/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80923/comment/aaf86b41_099705a3 : PS1, Line 101: $(eval $(word $(index),$(VERSIONS)) := $(shell printf "%d" 0x$(shell echo $(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c3-4)$(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c1-2))) ) > > > Does this still support version number parts that contains more than two digits? […] OK, I misread the code. Indeed it just takes a 16 bit value (2 bytes) and prints it in decimal. Thanks for the link, looks good to me now. -- To view, visit https://review.coreboot.org/c/coreboot/+/80923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0165d81b0e4b38e0e097956f250bb7484d774145 Gerrit-Change-Number: 80923 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sun, 03 Mar 2024 12:14:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [for test] Test build google/oak
by Elyes Haouas (Code Review) 03 Mar '24

03 Mar '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81017?usp=email ) Change subject: [for test] Test build google/oak ...................................................................... [for test] Test build google/oak Change-Id: Iea8f183d498431f5affd7d5ff0a4d61d28a80c93 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/oak/chromeos.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/81017/1 diff --git a/src/mainboard/google/oak/chromeos.c b/src/mainboard/google/oak/chromeos.c index 739df2e..1458e0f 100644 --- a/src/mainboard/google/oak/chromeos.c +++ b/src/mainboard/google/oak/chromeos.c @@ -1,4 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +// just for build test #include <boardid.h> #include <bootmode.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/81017?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea8f183d498431f5affd7d5ff0a4d61d28a80c93 Gerrit-Change-Number: 81017 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: nb/haswell: Disable iGPU when dGPU is used
by Leah Rowe (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Angel Pons, Arthur Heymans, Nico Huber. Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email ) Change subject: nb/haswell: Disable iGPU when dGPU is used ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Regarding the new patch set: I made it only disable VGA decode. But I have a question: what about nvidia optimus setups? T440p and W541 thinkpads sometimes have this, and in this setup, the Intel GPU should still be used for framebuffer. I have a hunch that this patch might break the display on those machines, when the nvidia gpu is enabled, because it would do vga decode on the nvidia gpu, even though it should only be used for render offloading on those setups. A workaround might be to make the decode-disable only apply if broadwell mrc isn't used, but that isn't a real solution. Another solution would be to additionally make vga-decode-disable (the behaviour in this patch) a toggle in option table - in other words, let the user make it so that coreboot does not disable vga decode, to work around such quirky setups. -- To view, visit https://review.coreboot.org/c/coreboot/+/80717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b Gerrit-Change-Number: 80717 Gerrit-PatchSet: 3 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 03 Mar 2024 11:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: nb/haswell: Disable iGPU when dGPU is used
by Leah Rowe (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Angel Pons, Arthur Heymans, Nico Huber. Hello Angel Pons, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80717?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: nb/haswell: Disable iGPU when dGPU is used ...................................................................... nb/haswell: Disable iGPU when dGPU is used This is usually is handled by Haswell mrc.bin, disabling VGA decode on the iGPU when a dGPU is installed. However, Broadwell mrc.bin does not, so the iGPU and dGPU are both enabled. This patch disables legacy VGA cycles for iGPU, under such conditions. It has been tested on Broadwell mrc.bin when using a graphics card on Dell OptiPlex 9020 SFF (currently under review at this time of writing, submitted by Mate Kukri). This patch has also been tested when Haswell mrc.bin is used, and there are seemingly no breaking changes caused by it. Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b Signed-off-by: Leah Rowe <info(a)minifree.org> --- M src/northbridge/intel/haswell/gma.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/80717/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b Gerrit-Change-Number: 80717 Gerrit-PatchSet: 3 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry
by Subrata Banik (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email ) Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/cse/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80923/comment/febd3f23_3ca099f1 : PS1, Line 101: $(eval $(word $(index),$(VERSIONS)) := $(shell printf "%d" 0x$(shell echo $(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c3-4)$(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c1-2))) ) > > Does this still support version number parts that contains more than two digits? > > Intel tends to use build numbers (last version entry) that are 4 digits long. > > This is as per the ME specification where CSE major/minor/hotfix/build all are 2 byte long. may be https://winraid.level1techs.com/t/intel-cs-me-cs-txe-cs-sps-gsc-pmc-pchc-ph… link has some details about CSE version control for last several generations. -- To view, visit https://review.coreboot.org/c/coreboot/+/80923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0165d81b0e4b38e0e097956f250bb7484d774145 Gerrit-Change-Number: 80923 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sun, 03 Mar 2024 11:18:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry
by Subrata Banik (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email ) Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry ...................................................................... Patch Set 2: (2 comments) File src/soc/intel/common/block/cse/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80923/comment/3a4d3f4d_e0453a6a : PS1, Line 101: $(eval $(word $(index),$(VERSIONS)) := $(shell printf "%d" 0x$(shell echo $(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c3-4)$(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c1-2))) ) > Does this still support version number parts that contains more than two digits? > Intel tends to use build numbers (last version entry) that are 4 digits long. This is as per the ME specification where CSE major/minor/hotfix/build all are 2 byte long. https://review.coreboot.org/c/coreboot/+/80923/comment/ab1c94b5_3834b1f8 : PS1, Line 103: TEMP_FILE > Shouldn't this be TEMP_DATA? Or, if you insist on TEMP_FILE (which I find a better name), then you s […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/80923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0165d81b0e4b38e0e097956f250bb7484d774145 Gerrit-Change-Number: 80923 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sun, 03 Mar 2024 11:13:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry
by Werner Zeh (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Subrata Banik. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email ) Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/common/block/cse/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80923/comment/f6c2c5df_54bd3729 : PS1, Line 101: $(eval $(word $(index),$(VERSIONS)) := $(shell printf "%d" 0x$(shell echo $(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c3-4)$(shell echo $(shell xxd -p $(TEMP_DATA)) | cut -c1-2))) ) Does this still support version number parts that contains more than two digits? Intel tends to use build numbers (last version entry) that are 4 digits long. -- To view, visit https://review.coreboot.org/c/coreboot/+/80923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0165d81b0e4b38e0e097956f250bb7484d774145 Gerrit-Change-Number: 80923 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sun, 03 Mar 2024 11:06:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry
by Werner Zeh (Code Review) 03 Mar '24

03 Mar '24

Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Subrata Banik. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80923?usp=email ) Change subject: soc/intel/cmn/cse: Use CSE RW partition version directly for CBFS entry ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/soc/intel/common/block/cse/Makefile.mk: https://review.coreboot.org/c/coreboot/+/80923/comment/a79ce450_742ce9ee : PS1, Line 103: TEMP_FILE Shouldn't this be TEMP_DATA? Or, if you insist on TEMP_FILE (which I find a better name), then you should change it accordingly. -- To view, visit https://review.coreboot.org/c/coreboot/+/80923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0165d81b0e4b38e0e097956f250bb7484d774145 Gerrit-Change-Number: 80923 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sun, 03 Mar 2024 10:59:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024