Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81019?usp=email )
Change subject: Update chromeec submodule to upstream main
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/81019?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iba329d9dee4835b9c626bc6fda77e6280211f342
Gerrit-Change-Number: 81019
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Sun, 03 Mar 2024 15:23:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Maximilian Brune, Nico Huber.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68842?usp=email )
Change subject: lib/ramdetect: Limit probe size to function argument
......................................................................
Patch Set 10:
(1 comment)
File src/lib/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/68842/comment/ed0781d4_e197a250 :
PS7, Line 50: /* Find the MSB + 1. */
> I don't think finding MSB+1 should be used either. […]
I'd change it to a generic while loop, while keeping the if statement below.
It is not guaranteed that probe_size is a power of 2.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68842?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7f915c6e150629eff235ee94719172467a54db2
Gerrit-Change-Number: 68842
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 03 Mar 2024 14:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans.
Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email )
Change subject: nb/haswell: Disable iGPU when dGPU is used
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> ok, yes, that makes sense. thank you for clearing up my confusion.
perhaps this is something for a future patch, but i think things like that (onboard vga is primary) should be runtime options.
having video init be done only at build time may save space in flash by removing redundant code that the user will not want, but for coreboot distros (heads, libreboot, etc), runtime configuration may be desirable - so that only one image needs to be built, then copied and reconfigured without a full re-build.
anyway, i'm happy with this. thank you again for your help.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80717?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b
Gerrit-Change-Number: 80717
Gerrit-PatchSet: 3
Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 03 Mar 2024 13:35:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans.
Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email )
Change subject: nb/haswell: Disable iGPU when dGPU is used
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> For optimus, ONBOARD_VGA_IS_PRIMARY should be set.
ok, yes, that makes sense. thank you for clearing up my confusion.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80717?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b
Gerrit-Change-Number: 80717
Gerrit-PatchSet: 3
Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 03 Mar 2024 13:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80924?usp=email )
Change subject: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/80924/comment/82bd87e3_97b90e16 :
PS1, Line 236: enabling automatic detection
> Is there an option which lets the user to enable it explicitly or is it available implicit with Meteor Lake and newer?
not sure if you can access this [link](https://chromium-review.googlesource.com/c/chromiumos/overlays/chromi… where for CSE Lite FW update, we select two configs
```
# Management Engine FW update
CONFIG_SOC_INTEL_CSE_RW_UPDATE=y
CONFIG_SOC_INTEL_CSE_RW_VERSION="18.0.5.2107"
```
CONFIG_SOC_INTEL_CSE_RW_VERSION should match with the CSE FW blob otherwise it will cause boot loop with existing method. Now when we can land CB:80923 we don't need to explicitly mention the CSE RW FW version using yet another config. Therefore, we are planning to drop CONFIG_SOC_INTEL_CSE_RW_VERSION from all Meteor Lake device (which is so far the latest Intel SoC).
Here `automatic` refers to the CB:80923 which parse the CSE partition and retrieve CSE FW version without any static entry like CONFIG_SOC_INTEL_CSE_RW_VERSION
--
To view, visit https://review.coreboot.org/c/coreboot/+/80924?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c3e5c759e4d9a43c3bce3a0c032086f17592a67
Gerrit-Change-Number: 80924
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Sun, 03 Mar 2024 12:55:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Leah Rowe.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email )
Change subject: nb/haswell: Disable iGPU when dGPU is used
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
> Regarding the new patch set: I made it only disable VGA decode. […]
For optimus, ONBOARD_VGA_IS_PRIMARY should be set.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80717?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b
Gerrit-Change-Number: 80717
Gerrit-PatchSet: 3
Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Comment-Date: Sun, 03 Mar 2024 12:28:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-MessageType: comment