Attention is currently required from: Arthur Heymans, Michael Büchler, Máté Kukri, Nicholas Chin, Nico Huber, Paul Menzel, ilikenwf, nat ✨.
Hello Angel Pons, Arthur Heymans, Martin L Roth, Michael Büchler, Nicholas Chin, Nico Huber, Patrick Rudolph, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55232?usp=email
to look at the new patch set (#33).
The following approvals got outdated and were removed:
Code-Review+1 by Michael Büchler, Code-Review+1 by Paul Menzel, Code-Review+2 by Nicholas Chin, Verified+1 by build bot (Jenkins)
Change subject: mb/dell: Add OptiPlex 7020/9020 port
......................................................................
mb/dell: Add OptiPlex 7020/9020 port
The OptiPlex 7020 and 9020 use physically identical motherboards.
WARNING: PWN fan control doesn't work via the EC and the fan runs at a
fixed speed. There is likely more EC init to reverse engineer.
Each model comes in the following form factors:
- 7020: SFF, MT
- 9020: USFF (not currently supported), SFF, MT
(7020 SFF) Boots Linux and Windows 10:
- Tested with an i3-4160 and i5-4460
- DRAM init works using the MRC (4G, 4G+4G)
- iGPU init works using libgfxinit (VGA, 2x DP)
- PCIe 16x: tested, ok
- PCIe 4x: tested, ok
- All USB2 and USB3 ports work
- SMSC SCH5555 Super I/O: serial works, PS/2 untested
- Audio: back and front output works, internal speaker works,
mic inputs untested
- Ethernet: tested, works
(9020 MT)
- Tested by Michael Büchler (thanks for the overridetree)
Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com>
---
A src/mainboard/dell/optiplex_9020/Kconfig
A src/mainboard/dell/optiplex_9020/Kconfig.name
A src/mainboard/dell/optiplex_9020/Makefile.inc
A src/mainboard/dell/optiplex_9020/acpi/ec.asl
A src/mainboard/dell/optiplex_9020/acpi/platform.asl
A src/mainboard/dell/optiplex_9020/acpi/superio.asl
A src/mainboard/dell/optiplex_9020/board_info.txt
A src/mainboard/dell/optiplex_9020/bootblock.c
A src/mainboard/dell/optiplex_9020/cmos.default
A src/mainboard/dell/optiplex_9020/cmos.layout
A src/mainboard/dell/optiplex_9020/data.vbt
A src/mainboard/dell/optiplex_9020/devicetree.cb
A src/mainboard/dell/optiplex_9020/dsdt.asl
A src/mainboard/dell/optiplex_9020/gma-mainboard.ads
A src/mainboard/dell/optiplex_9020/gpio.c
A src/mainboard/dell/optiplex_9020/hda_verb.c
A src/mainboard/dell/optiplex_9020/mainboard.c
A src/mainboard/dell/optiplex_9020/overridetree_mt.cb
A src/mainboard/dell/optiplex_9020/romstage.c
19 files changed, 698 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/55232/33
--
To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Gerrit-Change-Number: 55232
Gerrit-PatchSet: 33
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ben Westover <me(a)benthetechguy.net>
Gerrit-CC: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: ilikenwf <mparnell(a)gmail.com>
Gerrit-CC: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: ilikenwf <mparnell(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Michael Büchler, Máté Kukri, Nico Huber, ilikenwf, nat ✨.
Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port
......................................................................
Patch Set 32:
(1 comment)
Patchset:
PS32:
i saw that this was +2'd but there are two issues left to investigate: the PWM issue and the IOMMU issue(on graphics cards)
i don't think this should be merged in coreboot until those are corrected - or added as a warning in documentation, as part of this patch, with steps to mitigate (e.g. for PWM use a better/quieter fan with adapter and cut the pwm lines to run it at full speed and/or control it using resistor to run at quieter but otherwise higher speed - mention how to disable IOMMU in coreboot or linux. etc)
--
To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Gerrit-Change-Number: 55232
Gerrit-PatchSet: 32
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ben Westover <me(a)benthetechguy.net>
Gerrit-CC: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: ilikenwf <mparnell(a)gmail.com>
Gerrit-CC: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: ilikenwf <mparnell(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Sun, 03 Mar 2024 21:45:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Nico Huber, Philipp Hug.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68842?usp=email )
Change subject: lib/ramdetect: Limit probe size to function argument
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68842?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7f915c6e150629eff235ee94719172467a54db2
Gerrit-Change-Number: 68842
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 03 Mar 2024 21:37:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Michael Büchler, Máté Kukri, Nico Huber, ilikenwf, nat ✨.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port
......................................................................
Patch Set 32: Code-Review+2
(4 comments)
File src/mainboard/dell/optiplex_9020/Kconfig:
https://review.coreboot.org/c/coreboot/+/55232/comment/bfa2b966_7369bed6 :
PS32, Line 10: select HAVE_OPTION_TABLE
: select HAVE_CMOS_DEFAULT
Swap these to keep the list in alphabetical order
File src/mainboard/dell/optiplex_9020/board_info.txt:
https://review.coreboot.org/c/coreboot/+/55232/comment/34509dac_5dbbf722 :
PS32, Line 3: 2014
Nit: The 9020 seems to have been released in 2013 and the 7020 in 2014
File src/mainboard/dell/optiplex_9020/cmos.default:
PS32:
Needs an SPDX header, refer to commit e623845df6 (mb/*: Add SPDX headers for cmos.default files)
File src/mainboard/dell/optiplex_9020/romstage.c:
https://review.coreboot.org/c/coreboot/+/55232/comment/91a66a91_46524d38 :
PS32, Line 3: #include <northbridge/intel/haswell/haswell.h>
This doesn't seem to be necessary. Seems to build fine if I remove it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Gerrit-Change-Number: 55232
Gerrit-PatchSet: 32
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ben Westover <me(a)benthetechguy.net>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: ilikenwf <mparnell(a)gmail.com>
Gerrit-CC: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: ilikenwf <mparnell(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Sun, 03 Mar 2024 21:35:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Hendricks, Maximilian Brune, Philipp Hug, ron minnich.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81052?usp=email )
Change subject: Revert "Revert "mb/sifive: Add Hifive Unmatched mainboard""
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81052/comment/5baa4cb8_14ed0916 :
PS1, Line 7: Revert "Revert
Change to "Reland"
https://review.coreboot.org/c/coreboot/+/81052/comment/9c3047c9_e34c6ae7 :
PS1, Line 11: <reland>
The commit that this commit relied on has now been merged.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81052?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fb8c2e0a7fcd5f26f4a004e0949332b108b6fcf
Gerrit-Change-Number: 81052
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Sun, 03 Mar 2024 21:24:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: David Hendricks, Martin L Roth, Maximilian Brune, Philipp Hug, ron minnich.
Hello David Hendricks, Martin L Roth, Maximilian Brune, Philipp Hug, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81052?usp=email
to look at the new patch set (#2).
Change subject: Revert "Revert "mb/sifive: Add Hifive Unmatched mainboard""
......................................................................
Revert "Revert "mb/sifive: Add Hifive Unmatched mainboard""
This reverts commit ec7b48076009cfe82e5ee91050f5fc66c4850193.
Reason for revert: <reland>
Signed-off-by: ron minnich <rminnich(a)gmail.com>
Change-Id: I2fb8c2e0a7fcd5f26f4a004e0949332b108b6fcf
---
A src/mainboard/sifive/hifive-unmatched/Kconfig
A src/mainboard/sifive/hifive-unmatched/Kconfig.name
A src/mainboard/sifive/hifive-unmatched/Makefile.inc
A src/mainboard/sifive/hifive-unmatched/board_info.txt
A src/mainboard/sifive/hifive-unmatched/cbfs_spi.c
A src/mainboard/sifive/hifive-unmatched/devicetree.cb
A src/mainboard/sifive/hifive-unmatched/fixup_fdt.c
A src/mainboard/sifive/hifive-unmatched/fu740-c000.dtsi
A src/mainboard/sifive/hifive-unmatched/hifive-unmatched-a00-mod.dts
A src/mainboard/sifive/hifive-unmatched/hifive-unmatched-a00.dts
A src/mainboard/sifive/hifive-unmatched/mainboard.c
A src/mainboard/sifive/hifive-unmatched/romstage.c
12 files changed, 1,189 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81052/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81052?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fb8c2e0a7fcd5f26f4a004e0949332b108b6fcf
Gerrit-Change-Number: 81052
Gerrit-PatchSet: 2
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Hendricks, Martin L Roth, Maximilian Brune, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81052?usp=email )
Change subject: Revert "Revert "mb/sifive: Add Hifive Unmatched mainboard""
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81052?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fb8c2e0a7fcd5f26f4a004e0949332b108b6fcf
Gerrit-Change-Number: 81052
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Sun, 03 Mar 2024 21:22:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
ron minnich has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/80943?usp=email )
Change subject: Revert "mb/sifive: Add Hifive Unmatched mainboard"
......................................................................
--
To view, visit https://review.coreboot.org/c/coreboot/+/80943?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71c024b13411c4e0c9b4d6358f9cd31c57bbbfe2
Gerrit-Change-Number: 80943
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jan Samek <jan.samek(a)siemens.com>
Gerrit-MessageType: revert