Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Qinghong Zeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81265?usp=email )
Change subject: mb/google/nissa/var/anraggar: Assign GPP_C0 as TouchScreen enable pin
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81265/comment/ff0ebcd1_f880e9a4 :
PS2, Line 7: Assigned
> Assign
Done
https://review.coreboot.org/c/coreboot/+/81265/comment/f474ad6a_f6268f28 :
PS2, Line 9: Assigned
> Assign
Done
https://review.coreboot.org/c/coreboot/+/81265/comment/fa56cab5_e7038554 :
PS2, Line 9: Assigned GPP_C0 and enable only the touchscreen, which can effectively reduce the power consumption of the touchscreen during Suspend.
> Please use 72 characters per line.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81265?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia06209aa8303be4fc0669c5d6e5d7a06e8e9ab99
Gerrit-Change-Number: 81265
Gerrit-PatchSet: 4
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 19 Mar 2024 05:49:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81225?usp=email )
Change subject: amdfwtool: Move the address of tables to the context
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/81225/comment/69f0c33e_2a83b90a :
PS3, Line 1640: ctx.pspdir = NULL;
: ctx.pspdir2 = NULL;
: ctx.pspdir2_b = NULL;
: ctx.biosdir = NULL;
: ctx.biosdir2 = NULL;
: ctx.biosdir2_b = NULL;
: ctx.ish_a_dir = NULL;
: ctx.ish_b_dir = NULL;
> i'd move those directly before the if (cb_config.use_combo && combo_index > 0). […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81225?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98b7d01e32c75b4f13e23d496cd3de3da900678d
Gerrit-Change-Number: 81225
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 03:26:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81252?usp=email )
Change subject: amdfwtool: Add functions to link all the tables
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> would be good to mention in the commit message that integrate_psp_levels and integrate_bios_levels n […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieaf97208e943c79d7b76ea62eea9355138c220b9
Gerrit-Change-Number: 81252
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 03:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81253?usp=email )
Change subject: amdfwtool: Move the header creation into integration function
......................................................................
Patch Set 3:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/81253/comment/193af170_ab1c49a6 :
PS2, Line 963: else if (ctx->pspdir2_b == NULL)
> i'd use else if (cookie == PSPL2_COOKIE && ctx->pspdir2_b == NULL) to properly handle the case of an […]
Done
https://review.coreboot.org/c/coreboot/+/81253/comment/ac542876_268ff627 :
PS2, Line 1260: else if (ctx->biosdir2_b == NULL)
> i'd check for cookie == BHDL2_COOKIE && ctx->biosdir2_b == NULL to also cover the case of an unexpec […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9d78bb8145855203048208fcd67f8b9cd9d3199
Gerrit-Change-Number: 81253
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 03:24:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Zheng Bao.
Hello Felix Held, Fred Reitberger, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81253?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Felix Held, Verified+1 by build bot (Jenkins)
Change subject: amdfwtool: Move the header creation into integration function
......................................................................
amdfwtool: Move the header creation into integration function
Before every integration there is a header creation. We can put them
together. And the parameters for PSP/BIOS tables are useless.
TEST=Identical test on all AMD SOC platform
Change-Id: Ia9d78bb8145855203048208fcd67f8b9cd9d3199
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 33 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/81253/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9d78bb8145855203048208fcd67f8b9cd9d3199
Gerrit-Change-Number: 81253
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Zheng Bao.
Hello Felix Held, Fred Reitberger, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81252?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by Felix Held, Verified+1 by build bot (Jenkins)
Change subject: amdfwtool: Add functions to link all the tables
......................................................................
amdfwtool: Add functions to link all the tables
The purpose of integration function is to pack the FWs into table. We
need to remove other process. Create a dedicate function to link all
the tables together. And this linking function is only called when
both the level 1 and level 2 directory are created. This simplifies
the main function and logic.
TEST=Identical test on all AMD SOC platform
Change-Id: Ieaf97208e943c79d7b76ea62eea9355138c220b9
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 89 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81252/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieaf97208e943c79d7b76ea62eea9355138c220b9
Gerrit-Change-Number: 81252
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Zheng Bao.
Hello Felix Held, Fred Reitberger, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81225?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Felix Held, Verified+1 by build bot (Jenkins)
Change subject: amdfwtool: Move the address of tables to the context
......................................................................
amdfwtool: Move the address of tables to the context
Instead of being local variables. This can be easier to find all
the tables anywhere.
TEST=Identical test on all AMD SOC platform
Change-Id: I98b7d01e32c75b4f13e23d496cd3de3da900678d
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
2 files changed, 92 insertions(+), 62 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/81225/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81225?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98b7d01e32c75b4f13e23d496cd3de3da900678d
Gerrit-Change-Number: 81225
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
ron minnich has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81286?usp=email )
Change subject: arch/riscv: add constants for Base Extension
......................................................................
arch/riscv: add constants for Base Extension
Get used to this rate of change, SBI adds one new function a month,
on average, for the last 7 years.
Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com>
Change-Id: Iaad763464678d1921dfefdbee1e39fba2fe5585a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81286
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
---
M src/arch/riscv/include/sbi.h
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Maximilian Brune: Looks good to me, approved
Stefan Reinauer: Looks good to me, approved
diff --git a/src/arch/riscv/include/sbi.h b/src/arch/riscv/include/sbi.h
index 8c526fc..9f8e4105 100644
--- a/src/arch/riscv/include/sbi.h
+++ b/src/arch/riscv/include/sbi.h
@@ -13,6 +13,19 @@
#define SBI_REMOTE_SFENCE_VMA_ASID 7
#define SBI_SHUTDOWN 8
+// Here begins the complex set of things added by
+// later SBI. Unlike the original design, these
+// require bits of state to be maintained in SBI.
+// Disappointing!
+#define SBI_BASE_EXTENSION 0x10
+# define SBI_GET_SBI_SPEC_VERSION 0
+# define SBI_GET_SBI_IMPL_ID 1
+# define SBI_GET_SBI_IMPL_VERSION 2
+# define SBI_PROBE_EXTENSION 3
+# define SBI_GET_MVENDORID 4
+# define SBI_GET_MARCHID 5
+# define SBI_GET_MIMPID 6
+
#define SBI_ENOSYS 38
#define IPI_SOFT 1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaad763464678d1921dfefdbee1e39fba2fe5585a
Gerrit-Change-Number: 81286
Gerrit-PatchSet: 4
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: merged
Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81286?usp=email )
Change subject: arch/riscv: add constants for Base Extension
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaad763464678d1921dfefdbee1e39fba2fe5585a
Gerrit-Change-Number: 81286
Gerrit-PatchSet: 3
Gerrit-Owner: ron minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 03:01:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Won Chung has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81354?usp=email )
Change subject: mb/google/brya/mithrax: Fix mux_conn index
......................................................................
mb/google/brya/mithrax: Fix mux_conn index
Within ec_acpi.c, USB-C ports are iterated to be matched with
corresponding mux. The iteration happens from 0 to the number of USB-C
ports. Given iteration index i, the port with PLD group_token of (i+1)
is matched with mux_conn[i].
Mithrax devicetree matches conn1 to mux_conn[1] and conn2 to
mux_conn[0]. However, conn1 is for usbX_port2 which has group_token of 1
and conn2 is for usbX_port3 which has group_token of 2. Thus, follow the
convention to add conn1 to mux_conn[0] and conn2 to mux_conn[1].
Otherwise, the kernel subsystem linking between Type C connector and USB
mux will be swapped.
BUG=b:329657774 b:121287022
TEST=todo
Change-Id: I349682a6fe3fe4848e4e86d9c446530a31b35875
---
M src/mainboard/google/brya/variants/mithrax/overridetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/81354/1
diff --git a/src/mainboard/google/brya/variants/mithrax/overridetree.cb b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
index 49dfea8..6075351 100644
--- a/src/mainboard/google/brya/variants/mithrax/overridetree.cb
+++ b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
@@ -297,8 +297,8 @@
end
device ref pch_espi on
chip ec/google/chromeec
- use conn1 as mux_conn[1]
- use conn2 as mux_conn[0]
+ use conn1 as mux_conn[0]
+ use conn2 as mux_conn[1]
device pnp 0c09.0 on end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/81354?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I349682a6fe3fe4848e4e86d9c446530a31b35875
Gerrit-Change-Number: 81354
Gerrit-PatchSet: 1
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newchange