Attention is currently required from: Joel Linn, Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
currently, these fan vectors are being programmed even if they are unset in the mainboard devicetree, as long as the SoC supports it. We might want to have a separate Kconfig to enable the use/programming, and have mainboards select that.
So in env_ctrl.c, guard based on SUPERIO_ITE_ENV_CTRL_USE_FAN_VECTOR, rather than SUPERIO_ITE_ENV_CTRL_HAS_FAN_VECTOR, and have the former depend on the latter
--
To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Gerrit-Change-Number: 81426
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Comment-Date: Fri, 29 Mar 2024 14:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Nico Huber.
Joel Linn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81426/comment/194cc00c_46713f93 :
PS5, Line 12:
: The 3VSBSW# signal can now also be disabled again which is necessary to
: power components down properly in SMM when entering S5.
:
: A function to disable the PME# output was added as well.
> I think these two can be be individual commits, separate from the fan vector control
Done
File src/superio/ite/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/81426/comment/05fa176c_0c2b3ccc :
PS5, Line 61: config SUPERIO_ITE_ENV_CTRL_FAN_VECTOR_RANGED
> does this need `depends on SUPERIO_ITE_ENV_CTRL_FAN_VECTOR` ?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Gerrit-Change-Number: 81426
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2024 14:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Joel Linn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81588?usp=email )
Change subject: superio/ite: Add function to disable 3VSBSW# signal
......................................................................
superio/ite: Add function to disable 3VSBSW# signal
The 3VSBSW# signal can now also be disabled again which is necessary to
power components down properly in SMM when entering S5. In such cases
the signal will be enabled only in the SMM S3 handler.
Change-Id: I8535176908ec39e9916774135e028cbc7c203474
Signed-off-by: Joel Linn <jl(a)conductive.de>
---
M src/superio/ite/Makefile.mk
M src/superio/ite/common/early_serial.c
M src/superio/ite/common/ite.h
3 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81588/1
diff --git a/src/superio/ite/Makefile.mk b/src/superio/ite/Makefile.mk
index b6d0199..d44ade4 100644
--- a/src/superio/ite/Makefile.mk
+++ b/src/superio/ite/Makefile.mk
@@ -7,6 +7,9 @@
## include generic ite environment controller driver
ramstage-$(CONFIG_SUPERIO_ITE_ENV_CTRL) += common/env_ctrl.c
+## include generic ite driver to smm to control S3-relevant functions
+smm-$(CONFIG_SUPERIO_ITE_COMMON_PRE_RAM) += common/early_serial.c
+
subdirs-y += it8528e
subdirs-y += it8613e
subdirs-y += it8623e
diff --git a/src/superio/ite/common/early_serial.c b/src/superio/ite/common/early_serial.c
index 552f110..b8a6ba5 100644
--- a/src/superio/ite/common/early_serial.c
+++ b/src/superio/ite/common/early_serial.c
@@ -75,6 +75,7 @@
*
* LDN 7, reg 0x2a - needed for S3, or memory power will be cut off
* this was documented only in IT8712F_V0.9.2!
+ * Also documented in IT8728F_V0.4.2 and IT8772E_V0.4
*
* Enable 3VSBSW#. (For System Suspend-to-RAM)
* 0: 3VSBSW# will be always inactive.
@@ -85,13 +86,16 @@
* and pass: GPIO_DEV
*/
-void ite_enable_3vsbsw(pnp_devfn_t dev)
+void ite_set_3vsbsw(pnp_devfn_t dev, bool enable)
{
u8 tmp;
pnp_enter_conf_state(dev);
pnp_set_logical_device(dev);
tmp = pnp_read_config(dev, ITE_CONFIG_REG_MFC);
- tmp |= 0x80;
+ if (enable)
+ tmp |= 0x80;
+ else
+ tmp &= ~0x80;
pnp_write_config(dev, ITE_CONFIG_REG_MFC, tmp);
pnp_exit_conf_state(dev);
}
diff --git a/src/superio/ite/common/ite.h b/src/superio/ite/common/ite.h
index 19ade4b..1a147be 100644
--- a/src/superio/ite/common/ite.h
+++ b/src/superio/ite/common/ite.h
@@ -4,6 +4,7 @@
#define SUPERIO_ITE_COMMON_PRE_RAM_H
#include <device/pnp_type.h>
+#include <stdbool.h>
#include <stdint.h>
#define ITE_UART_CLK_PREDIVIDE_48 0x00 /* default */
@@ -14,11 +15,15 @@
/* Some boards need to init wdt+gpio's very early */
void ite_reg_write(pnp_devfn_t dev, u8 reg, u8 value);
-void ite_enable_3vsbsw(pnp_devfn_t dev);
+void ite_set_3vsbsw(pnp_devfn_t dev, bool enable);
void ite_delay_pwrgd3(pnp_devfn_t dev);
void ite_kill_watchdog(pnp_devfn_t dev);
void ite_ac_resume_southbridge(pnp_devfn_t dev);
+/* Alias for backwards compatibility */
+static inline void ite_enable_3vsbsw(pnp_devfn_t dev) { ite_set_3vsbsw(dev, true); }
+static inline void ite_disable_3vsbsw(pnp_devfn_t dev) { ite_set_3vsbsw(dev, false); }
+
void pnp_enter_conf_state(pnp_devfn_t dev);
void pnp_exit_conf_state(pnp_devfn_t dev);
--
To view, visit https://review.coreboot.org/c/coreboot/+/81588?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8535176908ec39e9916774135e028cbc7c203474
Gerrit-Change-Number: 81588
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-MessageType: newchange
Attention is currently required from: Joel Linn, Nico Huber.
Hello Matt DeVillier, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81426?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: superio/ite: Add special fan vectors
......................................................................
superio/ite: Add special fan vectors
A number of ITE SIOs support "special fan control vectors", which
effectively allow non-linear fan speed control. This is for example used
by the vendor firmware of the "HP Pro 3500 Series".
Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Signed-off-by: Joel Linn <jl(a)conductive.de>
---
M src/superio/ite/common/Kconfig
M src/superio/ite/common/env_ctrl.c
M src/superio/ite/common/env_ctrl.h
M src/superio/ite/common/env_ctrl_chip.h
M src/superio/ite/it8728f/Kconfig
M src/superio/ite/it8772f/Kconfig
6 files changed, 87 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/81426/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94
Gerrit-Change-Number: 81426
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Joel Linn, Nico Huber, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81525?usp=email )
Change subject: superio/ite: Add full-speed config option
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81525?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf24ea1c4f41771a18803957456f0aeba0e51b13
Gerrit-Change-Number: 81525
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Comment-Date: Fri, 29 Mar 2024 13:44:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Joel Linn, Nico Huber, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81516?usp=email )
Change subject: superio/ite: Fix incorrect warnings
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81516?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibabe1b1ef55f2acb2074eceb535ec684bffc8155
Gerrit-Change-Number: 81516
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Comment-Date: Fri, 29 Mar 2024 13:44:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment