Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80705?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Windows 11
* Ubuntu 22.04
* Manjaro 22
No known issues.
https://starlabs.systems/pages/byte-specification
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/byte_adl.md
M src/ec/starlabs/merlin/acpi/battery.asl
A src/mainboard/starlabs/byte_adl/Kconfig
A src/mainboard/starlabs/byte_adl/Kconfig.name
A src/mainboard/starlabs/byte_adl/Makefile.inc
A src/mainboard/starlabs/byte_adl/acpi/ec.asl
A src/mainboard/starlabs/byte_adl/acpi/mainboard.asl
A src/mainboard/starlabs/byte_adl/acpi/sleep.asl
A src/mainboard/starlabs/byte_adl/acpi/superio.asl
A src/mainboard/starlabs/byte_adl/board_info.txt
A src/mainboard/starlabs/byte_adl/bootblock.c
A src/mainboard/starlabs/byte_adl/cmos.default
A src/mainboard/starlabs/byte_adl/cmos.layout
A src/mainboard/starlabs/byte_adl/dsdt.asl
A src/mainboard/starlabs/byte_adl/hda_verb.c
A src/mainboard/starlabs/byte_adl/include/variants.h
A src/mainboard/starlabs/byte_adl/mainboard.c
A src/mainboard/starlabs/byte_adl/smbios.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.inc
A src/mainboard/starlabs/byte_adl/variants/mk_ii/board.fmd
A src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/hda_verb.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/vboot.fmd
A src/mainboard/starlabs/byte_adl/vboot.c
29 files changed, 1,366 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80705/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Gwendal Grignou, Nick Vaccaro, Shelley Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email )
Change subject: drivers/vpd: Return NULL for missing "feature_device_info"
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/vpd/vpd_device_feature.c:
https://review.coreboot.org/c/coreboot/+/80805/comment/03d8beea_5a8b8778 :
PS1, Line 10: static char device_info[VPD_FEATURE_DEVICE_INFO_LEN];
> Could |device_info| be in the stack and give as an argument to the function? The function is called only once and there is no logic to cache the data.
in that case the caller (outside drivers/vpd) of the vpd_get_feature_device_info() has to pass the `device_info` buffer and also needs to know the possible size (VPD_FEATURE_DEVICE_INFO_LEN) which may not required to be exposed outside of this file.
I don't think there is any problem of using static variable as we are in ramstage (and there is no memory specific restriction)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8
Gerrit-Change-Number: 80805
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Comment-Date: Thu, 29 Feb 2024 19:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Paul Menzel, Paz Zcharya, Subrata Banik.
Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email )
Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
......................................................................
Patch Set 9: Code-Review-1
(2 comments)
File src/vendorcode/google/chromeos/tpm_factory_config.c:
https://review.coreboot.org/c/coreboot/+/80738/comment/8b13d103_39dce3e4 :
PS9, Line 61: return (factory_config & CHROMEBOOK_PLUS_DEVICE) == CHROMEBOOK_PLUS_DEVICE;
That won't work for future device, since feature_level could be 2. Beside, hard branded device is enough to display the hard branded logo, so
```
return (factory_config & CHROMEBOOK_PLUS_HARD_BRANDED) == CHROMEBOOK_PLUS_HARD_BRANDED;
```
is enough.
https://review.coreboot.org/c/coreboot/+/80738/comment/6546a377_3db07331 :
PS9, Line 80: */
Let document further to explain the `CAE` magic since we are not going to put protobuf library in the near future:
```
/*
* |feature_device_info| contains a base64-encoded protobuf and the first entry is
* |feature_level|, greater than 1 for chromebook X device.
* (see https://chromium.googlesource.com/chromiumos/platform/feature-management/+/…)
*
* The first byte currently hold the feature level.
/
const char decoded_feature_device_info[B64_DECODED_SIZE(VPD_FEATURE_DEVICE_INFO_LEN)];
if (b64_decode(feature_device_info, strlen(feature_device_info), decoded_feature_device_info)) > 0)
return decoded_feature_device_info[0] > 1;
else
return false;
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b
Gerrit-Change-Number: 80738
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paz Zcharya <pazz(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 29 Feb 2024 19:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Shelley Chen, Subrata Banik.
Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/vpd: Return NULL for missing "feature_device_info"
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/drivers/vpd/vpd_device_feature.c:
https://review.coreboot.org/c/coreboot/+/80805/comment/68975aab_36a30248 :
PS1, Line 10: static char device_info[VPD_FEATURE_DEVICE_INFO_LEN];
Could |device_info| be in the stack and give as an argument to the function? The function is called only once and there is no logic to cache the data.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8
Gerrit-Change-Number: 80805
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 19:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80798?usp=email )
Change subject: doc/releases: Add 24.02.1 release section
......................................................................
doc/releases: Add 24.02.1 release section
Change-Id: I4d217c3dba4aa3ec30732b914009a6e9d53371c7
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M Documentation/releases/coreboot-24.02-relnotes.md
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/80798/1
diff --git a/Documentation/releases/coreboot-24.02-relnotes.md b/Documentation/releases/coreboot-24.02-relnotes.md
index eb5349e..e4e7892 100644
--- a/Documentation/releases/coreboot-24.02-relnotes.md
+++ b/Documentation/releases/coreboot-24.02-relnotes.md
@@ -31,6 +31,15 @@
'master' branch have been switched to 'main'.
+Release 24.02.1
+---------------
+
+### lib/rtc: Fix off-by-one error in February day count in leap year
+
+The month argument passed to rtc\_month\_days is 0-based, not 1-based.
+This results in the RTC being reverted to the build date constantly
+on 29th February 2024.
+
Significant or interesting changes
----------------------------------
--
To view, visit https://review.coreboot.org/c/coreboot/+/80798?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4d217c3dba4aa3ec30732b914009a6e9d53371c7
Gerrit-Change-Number: 80798
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: newchange
Attention is currently required from: Jeremy Soller, Paul Menzel.
Hello Jeremy Soller, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80756?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/system76/adl,rpl: Add 50ms timeout for PCIe 3.0 RPs
......................................................................
mb/system76/adl,rpl: Add 50ms timeout for PCIe 3.0 RPs
The FSP may fail to detect PCIe 4.0 devices in PCIe 3.0 slots on S3
resume. This issue has only been experienced on lemp12, and only with
Samsung drives, but implies it could happen on other systems or with
other drives as well. A timeout of 50ms is arbitrarily chosen.
Tested on lemp12 with Samsung 980 PRO (FW: 3B2QGXA7, 5B2QGXA7) and 990
PRO (FW: 4B2QJXD7) drives.
Change-Id: I4f44fc429c52e407b7566d6bb6dd31b2cf85c48d
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/adl/variants/darp8/overridetree.cb
M src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb
M src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb
M src/mainboard/system76/adl/variants/lemp11/overridetree.cb
M src/mainboard/system76/rpl/variants/gaze18/overridetree.cb
M src/mainboard/system76/rpl/variants/lemp12/overridetree.cb
6 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/80756/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80756?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f44fc429c52e407b7566d6bb6dd31b2cf85c48d
Gerrit-Change-Number: 80756
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80823?usp=email )
Change subject: lib/rtc: Fix off-by-one error in February day count in leap year
......................................................................
lib/rtc: Fix off-by-one error in February day count in leap year
The month argument passed to rtc_month_days is 0-based, not 1-based.
This results in the RTC being reverted to the build date constantly
on 29th February 2024.
Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80790
Reviewed-by: Sean Rhodes <sean(a)starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
(cherry picked from commit adf042f6c61e92c181171118768e4309d87146b1)
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80823
---
M src/lib/rtc.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
diff --git a/src/lib/rtc.c b/src/lib/rtc.c
index d151480..3eeac27 100644
--- a/src/lib/rtc.c
+++ b/src/lib/rtc.c
@@ -126,7 +126,7 @@
{
int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
- return month_days[month] + (LEAP_YEAR(year) && month == 2);
+ return month_days[month] + (LEAP_YEAR(year) && month == 1);
}
int rtc_invalid(const struct rtc_time *tm)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 24.02_branch
Gerrit-Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Gerrit-Change-Number: 80823
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: merged
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80823?usp=email )
Change subject: lib/rtc: Fix off-by-one error in February day count in leap year
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 24.02_branch
Gerrit-Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Gerrit-Change-Number: 80823
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 18:38:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80823?usp=email )
Change subject: lib/rtc: Fix off-by-one error in February day count in leap year
......................................................................
lib/rtc: Fix off-by-one error in February day count in leap year
The month argument passed to rtc_month_days is 0-based, not 1-based.
This results in the RTC being reverted to the build date constantly
on 29th February 2024.
Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80790
Reviewed-by: Sean Rhodes <sean(a)starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
(cherry picked from commit adf042f6c61e92c181171118768e4309d87146b1)
---
M src/lib/rtc.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/80823/1
diff --git a/src/lib/rtc.c b/src/lib/rtc.c
index d151480..3eeac27 100644
--- a/src/lib/rtc.c
+++ b/src/lib/rtc.c
@@ -126,7 +126,7 @@
{
int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
- return month_days[month] + (LEAP_YEAR(year) && month == 2);
+ return month_days[month] + (LEAP_YEAR(year) && month == 1);
}
int rtc_invalid(const struct rtc_time *tm)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 24.02_branch
Gerrit-Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Gerrit-Change-Number: 80823
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newchange