[XS] Change in coreboot[24.02_branch]: lib/rtc: Fix off-by-one error in February day count in leap year

[Martin L Roth (Code Review)]

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80823?usp=email )

Change subject: lib/rtc: Fix off-by-one error in February day count in leap year
......................................................................

lib/rtc: Fix off-by-one error in February day count in leap year

The month argument passed to rtc_month_days is 0-based, not 1-based.
This results in the RTC being reverted to the build date constantly
on 29th February 2024.

Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Signed-off-by: Michał Żygowski <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80790
Reviewed-by: Sean Rhodes <[e-mail]>
Reviewed-by: Paul Menzel <[e-mail]>
Reviewed-by: Felix Singer <[e-mail]>
Reviewed-by: Werner Zeh <[e-mail]>
Tested-by: build bot (Jenkins) <[e-mail]>
Reviewed-by: Felix Held <[e-mail]>
Reviewed-by: Michał Kopeć <[e-mail]>
(cherry picked from commit adf042f6c61e92c181171118768e4309d87146b1)
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80823
---
M src/lib/rtc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved




diff --git a/src/lib/rtc.c b/src/lib/rtc.c
index d151480..3eeac27 100644
--- a/src/lib/rtc.c
+++ b/src/lib/rtc.c
@@ -126,7 +126,7 @@
 {
 	int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
 
-	return month_days[month] + (LEAP_YEAR(year) && month == 2);
+	return month_days[month] + (LEAP_YEAR(year) && month == 1);
 }
 
 int rtc_invalid(const struct rtc_time *tm)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: 24.02_branch
Gerrit-Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Gerrit-Change-Number: 80823
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Martin L Roth <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Michał Żygowski <[e-mail]>
Gerrit-MessageType: merged