Attention is currently required from: Jeremy Soller, Paul Menzel.
Hello Jeremy Soller, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80756?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/system76/adl,rpl: Add 50ms timeout for PCIe 3.0 RPs
......................................................................
mb/system76/adl,rpl: Add 50ms timeout for PCIe 3.0 RPs
The FSP may fail to detect PCIe 4.0 devices in PCIe 3.0 slots on S3
resume. This issue has only been experienced on lemp12, and only with
Samsung drives, but implies it could happen on other systems or with
other drives as well. A timeout of 50ms is arbitrarily chosen.
Tested on lemp12 with Samsung 980 PRO (FW: 3B2QGXA7, 5B2QGXA7) and 990
PRO (FW: 4B2QJXD7) drives.
Change-Id: I4f44fc429c52e407b7566d6bb6dd31b2cf85c48d
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/adl/variants/darp8/overridetree.cb
M src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb
M src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb
M src/mainboard/system76/adl/variants/lemp11/overridetree.cb
M src/mainboard/system76/rpl/variants/gaze18/overridetree.cb
M src/mainboard/system76/rpl/variants/lemp12/overridetree.cb
6 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/80756/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80756?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f44fc429c52e407b7566d6bb6dd31b2cf85c48d
Gerrit-Change-Number: 80756
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80823?usp=email )
Change subject: lib/rtc: Fix off-by-one error in February day count in leap year
......................................................................
lib/rtc: Fix off-by-one error in February day count in leap year
The month argument passed to rtc_month_days is 0-based, not 1-based.
This results in the RTC being reverted to the build date constantly
on 29th February 2024.
Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80790
Reviewed-by: Sean Rhodes <sean(a)starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
(cherry picked from commit adf042f6c61e92c181171118768e4309d87146b1)
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80823
---
M src/lib/rtc.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
diff --git a/src/lib/rtc.c b/src/lib/rtc.c
index d151480..3eeac27 100644
--- a/src/lib/rtc.c
+++ b/src/lib/rtc.c
@@ -126,7 +126,7 @@
{
int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
- return month_days[month] + (LEAP_YEAR(year) && month == 2);
+ return month_days[month] + (LEAP_YEAR(year) && month == 1);
}
int rtc_invalid(const struct rtc_time *tm)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 24.02_branch
Gerrit-Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Gerrit-Change-Number: 80823
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: merged
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80823?usp=email )
Change subject: lib/rtc: Fix off-by-one error in February day count in leap year
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 24.02_branch
Gerrit-Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Gerrit-Change-Number: 80823
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 29 Feb 2024 18:38:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80823?usp=email )
Change subject: lib/rtc: Fix off-by-one error in February day count in leap year
......................................................................
lib/rtc: Fix off-by-one error in February day count in leap year
The month argument passed to rtc_month_days is 0-based, not 1-based.
This results in the RTC being reverted to the build date constantly
on 29th February 2024.
Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80790
Reviewed-by: Sean Rhodes <sean(a)starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
(cherry picked from commit adf042f6c61e92c181171118768e4309d87146b1)
---
M src/lib/rtc.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/80823/1
diff --git a/src/lib/rtc.c b/src/lib/rtc.c
index d151480..3eeac27 100644
--- a/src/lib/rtc.c
+++ b/src/lib/rtc.c
@@ -126,7 +126,7 @@
{
int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
- return month_days[month] + (LEAP_YEAR(year) && month == 2);
+ return month_days[month] + (LEAP_YEAR(year) && month == 1);
}
int rtc_invalid(const struct rtc_time *tm)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 24.02_branch
Gerrit-Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Gerrit-Change-Number: 80823
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jeremy Soller, Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80756?usp=email )
Change subject: mb/system76/adl,rpl: Add FSP default timeout for PCIe 3.0 RPs
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80756/comment/c92ebe75_3060cf93 :
PS1, Line 15:
> Changed to use FSP default of 56ms.
I actually misread the FSP UPD. It doesn't set this, so the value is arbitrary. 50ms is a lot, but I'm not going to figure out how low I can make it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80756?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f44fc429c52e407b7566d6bb6dd31b2cf85c48d
Gerrit-Change-Number: 80756
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 29 Feb 2024 18:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Couzens, Maciej Pijanowski, Michał Kopeć, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M920q (Cannon Lake)
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/lenovo/m920q/acpi/ec.asl:
PS4:
```
/* SPDX-License-Identifier: CC-PDDC */
/* Please update the license if adding licensable material. */
```
File src/mainboard/lenovo/m920q/acpi/mainboard.asl:
PS4:
```
/* SPDX-License-Identifier: CC-PDDC */
/* Please update the license if adding licensable material. */
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/80609?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea1dc5745c0ecf687fa18b793f0aab4b0855d6d4
Gerrit-Change-Number: 80609
Gerrit-PatchSet: 4
Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 29 Feb 2024 18:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Gwendal Grignou, Paul Menzel, Paz Zcharya, Subrata Banik.
Hello Gwendal Grignou, Kapil Porwal, Paul Menzel, Paz Zcharya, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80738?usp=email
to look at the new patch set (#9).
Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
......................................................................
vc/google/chromeos: Implement dynamic ChromeOS boot logo selection
* Introduces logic to display context-specific boot splash logos.
* Logo selection considers:
* Chromebook-Plus hardware compliance (using factory_config).
* VPD-based product segmentation (soft-branded vs. regular
chromebook).
* Default Chromebook logo as fallback for regular Chromebook.
This patch fixes the problem where existing logic was unable to pick
correct ChromeOS boot splash logo based on the product segmentation.
Relation between product segment and boot splash screen:
1. Chromebook-Plus Hard-branded device: Renders "cb_plus_logo.bmp" logo
2. Chromebook-Plus Soft-branded device: Renders "cb_plus_logo.bmp" logo
3. Regular Chromebook device: Renders "cb_logo.bmp"
BUG=b:324107408
TEST=Verified logo selection based on compliance and product
requirements.
Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/vendorcode/google/chromeos/chromeos.h
M src/vendorcode/google/chromeos/splash.c
M src/vendorcode/google/chromeos/tpm_factory_config.c
3 files changed, 47 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/80738/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b
Gerrit-Change-Number: 80738
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paz Zcharya <pazz(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-MessageType: newpatchset