coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[L] Change in coreboot[main]: treewide: Change I2C/SMBUS master/slave to controller/target
by Martin L Roth (Code Review) 01 Mar '24

01 Mar '24

Attention is currently required from: Arthur Heymans, Caveh Jalali, Cliff Huang, Felix Singer, Julius Werner, Matt DeVillier, Yidi Lin, Yu-Ping Wu. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77098?usp=email ) Change subject: treewide: Change I2C/SMBUS master/slave to controller/target ...................................................................... Patch Set 4: (3 comments) File src/southbridge/amd/pi/hudson/smbus_spd.c: https://review.coreboot.org/c/coreboot/+/77098/comment/01b6061e_071efb86 : PS3, Line 87: static int readspd(int iobase, int SmbusSlaveAddress, char *buffer, int count) : { : int index, error; : : printk(BIOS_SPEW, "-------------READING SPD-----------\n"); : printk(BIOS_SPEW, "iobase: 0x%08X, SmbusSlave: 0x%08X, count: %d\n", : iobase, SmbusSlaveAddress, count); : : /* read the first byte using offset zero */ : error = readSmbusByteData(iobase, SmbusSlaveAddress, buffer, 0); : : if (error) { : printk(BIOS_ERR, "-------------SPD READ ERROR-----------\n"); : return error; : } : : /* read the remaining bytes using auto-increment for speed */ : for (index = 1; index < count; index++) : { : error = readSmbusByte(iobase, SmbusSlaveAddress, &buffer [index]); : if (error) { : printk(BIOS_ERR, "-------------SPD READ ERROR-----------\n"); : return error; : } : } : printk(BIOS_SPEW, "\n"); : printk(BIOS_SPEW, "-------------FINISHED READING SPD-----------\n"); : : return 0; : } > change `SmbusSlave*` to `SmbusTarget*` ? Done File src/southbridge/intel/bd82x6x/smbus.c: https://review.coreboot.org/c/coreboot/+/77098/comment/defb3bde_9cf319dd : PS3, Line 20: Slave > Change to `Target` ? Done https://review.coreboot.org/c/coreboot/+/77098/comment/daf35a60_c903f29d : PS3, Line 23: SMBUS_SLAVE_ADDR > Change to `SMBUS_TARGET_ADDR` ? This is from the chips' #define. I was asked not to update chip defines. Those should be changed only when the datasheet for the chip has been updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/77098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c141fa4322de9e9ed208589f591560fed609825 Gerrit-Change-Number: 77098 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 29 Feb 2024 23:11:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: treewide: Change I2C/SMBUS master/slave to controller/target
by Martin L Roth (Code Review) 01 Mar '24

01 Mar '24

Attention is currently required from: Arthur Heymans, Caveh Jalali, Cliff Huang, Felix Singer, Julius Werner, Martin L Roth, Matt DeVillier, Yu-Ping Wu. Hello Arthur Heymans, Caveh Jalali, Christian Walter, Cliff Huang, Felix Held, Felix Singer, Forest Mittelberg, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Jeff Daly, Johnny Lin, Jonathan Zhang, Julius Werner, Lance Zhao, Matt DeVillier, Matt DeVillier, Raul Rangel, Sean Rhodes, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio, Xi Chen, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77098?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by Felix Singer, Code-Review+1 by Matt DeVillier, Code-Review+1 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) Change subject: treewide: Change I2C/SMBUS master/slave to controller/target ...................................................................... treewide: Change I2C/SMBUS master/slave to controller/target The I2C and SMBUS specifications have updated their terminology from master/slave to controller/target. As stated in the coreboot language style page, using the word 'slave' should be avoided when possible [1] except when discussing the term as applicable by the current standards. As the SMBUS and I2C standards are no longer using this terminology, the updated terms controller/target should be used in the coreboot I2C/SMBUS code. We'll keep register names for devices are they are in the datasheets. [1] https://doc.coreboot.org/community/language_style.html#discussing-words-to-… Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6c141fa4322de9e9ed208589f591560fed609825 --- M Documentation/technotes/console.md M Documentation/tutorial/part3.md M src/acpi/device.c M src/commonlib/bsd/include/commonlib/bsd/cb_err.h M src/console/Kconfig M src/device/dram/rcd.c M src/device/i2c_bus.c M src/device/software_i2c.c M src/drivers/analogix/anx7625/anx7625.c M src/drivers/i2c/designware/dw_i2c.c M src/drivers/i2c/tpm/tpm.c M src/drivers/i2c/ww_ring/ww_ring.c M src/drivers/intel/gma/edid.c M src/drivers/intel/gma/edid.h M src/drivers/smbus/i2c_smbus_console.c M src/drivers/smbus/sc16is7xx_init.c M src/ec/google/chromeec/ec_i2c.c M src/ec/kontron/kempld/kempld_i2c.c M src/include/device/i2c.h M src/include/device/i2c_bus.h M src/include/device/i2c_simple.h M src/include/device/smbus_host.h M src/include/smbios.h M src/lib/smbios.c M src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb M src/mainboard/google/auron/variants/auron_paine/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/auron_yuna/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/buddy/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/gandof/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/lulu/include/variant/acpi/mainboard.asl M src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl M src/mainboard/google/cyan/acpi/touchscreen_elan.asl M src/mainboard/google/cyan/acpi/touchscreen_melfas.asl M src/mainboard/google/cyan/acpi/touchscreen_synaptics.asl M src/mainboard/google/cyan/acpi/trackpad_atmel.asl M src/mainboard/google/cyan/acpi/trackpad_elan.asl M src/mainboard/google/daisy/exynos5250.h M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/kukui/boardid.c M src/mainboard/google/octopus/variants/baseboard/devicetree.cb M src/mainboard/google/rambi/acpi/mainboard.asl M src/mainboard/google/rambi/acpi/touchscreen_atmel.asl M src/mainboard/google/rambi/acpi/touchscreen_elan.asl M src/mainboard/google/rambi/acpi/touchscreen_wdt.asl M src/mainboard/google/rambi/acpi/trackpad_atmel.asl M src/mainboard/google/rambi/acpi/trackpad_elan.asl M src/mainboard/google/slippy/variants/falco/include/variant/acpi/mainboard.asl M src/mainboard/google/slippy/variants/leon/include/variant/acpi/mainboard.asl M src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl M src/mainboard/google/slippy/variants/wolf/include/variant/acpi/mainboard.asl M src/mainboard/intel/glkrvp/touchpad.asl M src/mainboard/intel/strago/acpi/mainboard.asl M src/northbridge/intel/i945/gma.c M src/soc/amd/stoneyridge/smbus_spd.c M src/soc/cavium/cn81xx/twsi.c M src/soc/cavium/common/bdk-coreboot.c M src/soc/intel/apollolake/chip.h M src/soc/intel/baytrail/scc.c M src/soc/intel/common/block/include/intelblocks/imc.h M src/soc/intel/common/block/smbus/smbus.c M src/soc/mediatek/common/i2c.c M src/soc/nvidia/tegra/i2c.c M src/soc/qualcomm/common/qupv3_i2c.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq806x/i2c.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/rockchip/common/i2c.c M src/soc/samsung/exynos5250/i2c.c M src/soc/samsung/exynos5420/i2c.c M src/southbridge/amd/pi/hudson/smbus_spd.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/common/smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/smbus.c M tests/device/i2c-test.c M util/intelvbttool/intelvbttool.c 76 files changed, 274 insertions(+), 274 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/77098/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/77098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c141fa4322de9e9ed208589f591560fed609825 Gerrit-Change-Number: 77098 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: doc/releases: Add 24.02.1 release section
by Martin L Roth (Code Review) 29 Feb '24

29 Feb '24

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80798?usp=email ) Change subject: doc/releases: Add 24.02.1 release section ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d217c3dba4aa3ec30732b914009a6e9d53371c7 Gerrit-Change-Number: 80798 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 29 Feb 2024 21:45:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: device/pnp_device: Demote unassigned resource printk to NOTICE
by Felix Held (Code Review) 29 Feb '24

29 Feb '24

Attention is currently required from: Matt DeVillier. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80645?usp=email ) Change subject: device/pnp_device: Demote unassigned resource printk to NOTICE ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > CB:80774 should improve things Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3d9f22a06088596e14680190aede2d69880001fa Gerrit-Change-Number: 80645 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 29 Feb 2024 21:41:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: device/pnp_device: fix log levels for unassigned resource messages
by Felix Held (Code Review) 29 Feb '24

29 Feb '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80774?usp=email ) Change subject: device/pnp_device: fix log levels for unassigned resource messages ...................................................................... device/pnp_device: fix log levels for unassigned resource messages Commit a662777b6f57 ("pnp_device: don't treat missing PNP_MSC devicetree entry as error") lowered the log level for every resource without the assigned bit set except for the IRQ0 and IRQ1 PNP device resources. Commit df84fff80fed ("device/pnp_device: Demote unassigned resource printk to NOTICE") lowered the log level for the IRQ0 and IRQ1 PNP device resources to a lower log level than for the other warnings that are less likely a problem. Fix this regression by using the BIOS_NOTICE log level for all PNP resources that don't have the IORESOURCE_ASSIGNED bit set. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I232e60ef7ae672e18cc1837b8e6a0427d01c142b Reviewed-on: https://review.coreboot.org/c/coreboot/+/80774 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/device/pnp_device.c 1 file changed, 3 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Matt DeVillier: Looks good to me, approved Arthur Heymans: Looks good to me, approved diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index c7c6228..431e227 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -118,21 +118,9 @@ static void pnp_set_resource(struct device *dev, struct resource *resource) { if (!(resource->flags & IORESOURCE_ASSIGNED)) { - /* The PNP_MSC Super IO registers have the IRQ flag set. If no - value is assigned in the devicetree, the corresponding - PNP_MSC register doesn't get written, which should be printed - as warning and not as error. */ - if (resource->flags & IORESOURCE_IRQ && - (resource->index != PNP_IDX_IRQ0) && - (resource->index != PNP_IDX_IRQ1)) - printk(BIOS_WARNING, "%s %02lx %s size: " - "0x%010llx not assigned in devicetree\n", dev_path(dev), - resource->index, resource_type(resource), - resource->size); - else - printk(BIOS_NOTICE, "%s %02lx %s size: 0x%010llx " - "not assigned in devicetree\n", dev_path(dev), resource->index, - resource_type(resource), resource->size); + printk(BIOS_NOTICE, "%s %02lx %s size: 0x%010llx not assigned in devicetree\n", + dev_path(dev), resource->index, resource_type(resource), + resource->size); return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/80774?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I232e60ef7ae672e18cc1837b8e6a0427d01c142b Gerrit-Change-Number: 80774 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: amdfwtool: Remove the function's dependency to ctx
by Felix Held (Code Review) 29 Feb '24

29 Feb '24

Attention is currently required from: Bao Zheng, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78304?usp=email ) Change subject: amdfwtool: Remove the function's dependency to ctx ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78304/comment/ad6fd89b_0620ed72 : PS4, Line 9: writebody write_body function https://review.coreboot.org/c/coreboot/+/78304/comment/757e2d6f_c37fcb7c : PS4, Line 11: would be good to also mention that the amdfwtool_cleanup calls are removed from write_body, but since write_body now returns to the main function, amdfwtool_cleanup still ends up getting called -- To view, visit https://review.coreboot.org/c/coreboot/+/78304?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I639828498fa45911f430500735e90ddc198b6af5 Gerrit-Change-Number: 78304 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 29 Feb 2024 21:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: amdfwtool: Move the functions to handle_file.c
by Felix Held (Code Review) 29 Feb '24

29 Feb '24

Attention is currently required from: Bao Zheng, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78305?usp=email ) Change subject: amdfwtool: Move the functions to handle_file.c ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78305?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4cfec13cbc2a86dc352758541cce915a838e0d0f Gerrit-Change-Number: 78305 Gerrit-PatchSet: 5 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 29 Feb 2024 21:30:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: lib: Declare heap in assembly
by Julius Werner (Code Review) 29 Feb '24

29 Feb '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80776?usp=email ) Change subject: lib: Declare heap in assembly ...................................................................... Patch Set 3: (1 comment) File src/lib/program.ld: https://review.coreboot.org/c/coreboot/+/80776/comment/025e7559_ab9a2cb4 : PS3, Line 141: } > > > I think a simpler solution is to just add a `: to_load` here. (We already have that for the `. […] `to_load` is just how we call the program segment, it could be any name. I'm not exactly sure what's happening here but there seems to be some heuristic that sections which are explicitly marked as NOLOAD and don't contain any actual objects aren't automatically added to a suitable program segment like all sections normally are. Adding the segment assignment explicitly works around that. (In general linker scripts seem to rely on a lot of these "magic defaults" for backwards compatibility with how things were "commonly done" in the past, it's probably better to rely less on that and write more stuff explicitly where possible.) -- To view, visit https://review.coreboot.org/c/coreboot/+/80776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I67cb5ce886fda313e0720b0bc7c6e66e4aae45fa Gerrit-Change-Number: 80776 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 29 Feb 2024 21:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: lib/program.ld: Make (NOLOAD) and to_load more explicit
by Julius Werner (Code Review) 29 Feb '24

29 Feb '24

Attention is currently required from: Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80803?usp=email ) Change subject: lib/program.ld: Make (NOLOAD) and to_load more explicit ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic14543ba580abe7a34c69bba714eae8cce504977 Gerrit-Change-Number: 80803 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 29 Feb 2024 21:05:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/vpd: Return NULL for missing "feature_device_info"
by Subrata Banik (Code Review) 29 Feb '24

29 Feb '24

Attention is currently required from: Gwendal Grignou, Nick Vaccaro, Shelley Chen. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email ) Change subject: drivers/vpd: Return NULL for missing "feature_device_info" ...................................................................... Patch Set 1: (1 comment) File src/drivers/vpd/vpd_device_feature.c: https://review.coreboot.org/c/coreboot/+/80805/comment/45356a99_98508781 : PS1, Line 10: static char device_info[VPD_FEATURE_DEVICE_INFO_LEN]; > > Could |device_info| be in the stack and give as an argument to the function? The function is called only once and there is no logic to cache the data. > > in that case the caller (outside drivers/vpd) of the vpd_get_feature_device_info() has to pass the `device_info` buffer and also needs to know the possible size (VPD_FEATURE_DEVICE_INFO_LEN) which may not required to be exposed outside of this file. > > I don't think there is any problem of using static variable as we are in ramstage (and there is no memory specific restriction) more reference here, https://github.com/coreboot/coreboot/blob/main/src/drivers/vpd/vpd_serial.c… I don't see any caller of VPD API are actually passing the argument over stack. -- To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8 Gerrit-Change-Number: 80805 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Comment-Date: Thu, 29 Feb 2024 20:10:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-MessageType: comment

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
307
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024