[S] Change in coreboot[main]: device/pnp_device: fix log levels for unassigned resource messages

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80774?usp=email )

Change subject: device/pnp_device: fix log levels for unassigned resource messages
......................................................................

device/pnp_device: fix log levels for unassigned resource messages

Commit a662777b6f57 ("pnp_device: don't treat missing PNP_MSC devicetree
entry as error") lowered the log level for every resource without the
assigned bit set except for the IRQ0 and IRQ1 PNP device resources.
Commit df84fff80fed ("device/pnp_device: Demote unassigned resource
printk to NOTICE") lowered the log level for the IRQ0 and IRQ1 PNP
device resources to a lower log level than for the other warnings that
are less likely a problem. Fix this regression by using the BIOS_NOTICE
log level for all PNP resources that don't have the IORESOURCE_ASSIGNED
bit set.

Signed-off-by: Felix Held <[e-mail]>
Change-Id: I232e60ef7ae672e18cc1837b8e6a0427d01c142b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80774
Reviewed-by: Matt DeVillier <[e-mail]>
Reviewed-by: Arthur Heymans <[e-mail]>
Reviewed-by: Nico Huber <[e-mail]>
Tested-by: build bot (Jenkins) <[e-mail]>
---
M src/device/pnp_device.c
1 file changed, 3 insertions(+), 15 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, but someone else must approve
  Matt DeVillier: Looks good to me, approved
  Arthur Heymans: Looks good to me, approved




diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c
index c7c6228..431e227 100644
--- a/src/device/pnp_device.c
+++ b/src/device/pnp_device.c
@@ -118,21 +118,9 @@
 static void pnp_set_resource(struct device *dev, struct resource *resource)
 {
 	if (!(resource->flags & IORESOURCE_ASSIGNED)) {
-		/* The PNP_MSC Super IO registers have the IRQ flag set. If no
-		   value is assigned in the devicetree, the corresponding
-		   PNP_MSC register doesn't get written, which should be printed
-		   as warning and not as error. */
-		if (resource->flags & IORESOURCE_IRQ &&
-		    (resource->index != PNP_IDX_IRQ0) &&
-		    (resource->index != PNP_IDX_IRQ1))
-			printk(BIOS_WARNING, "%s %02lx %s size: "
-			       "0x%010llx not assigned in devicetree\n", dev_path(dev),
-			       resource->index, resource_type(resource),
-			       resource->size);
-		else
-			printk(BIOS_NOTICE, "%s %02lx %s size: 0x%010llx "
-			       "not assigned in devicetree\n", dev_path(dev), resource->index,
-			       resource_type(resource), resource->size);
+		printk(BIOS_NOTICE, "%s %02lx %s size: 0x%010llx not assigned in devicetree\n",
+		       dev_path(dev), resource->index, resource_type(resource),
+		       resource->size);
 		return;
 	}
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80774?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I232e60ef7ae672e18cc1837b8e6a0427d01c142b
Gerrit-Change-Number: 80774
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: merged