[XS] Change in coreboot[main]: drivers/vpd: Return NULL for missing "feature_device_info"

[Gwendal Grignou (Code Review)]

Attention is currently required from: Nick Vaccaro, Shelley Chen, Subrata Banik.

Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80805?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: drivers/vpd: Return NULL for missing "feature_device_info"
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/drivers/vpd/vpd_device_feature.c:

https://review.coreboot.org/c/coreboot/+/80805/comment/68975aab_36a30248 :
PS1, Line 10: 	static char device_info[VPD_FEATURE_DEVICE_INFO_LEN];
Could |device_info| be in the stack and give as an argument to the function? The function is called only once and there is no logic to cache the data.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80805?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I76fc220ed792abdfefb0b1a37873b5b828bfdda8
Gerrit-Change-Number: 80805
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Gwendal Grignou <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: Shelley Chen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Shelley Chen <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: Nick Vaccaro <[e-mail]>
Gerrit-Comment-Date: Thu, 29 Feb 2024 19:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment