Attention is currently required from: Nick Vaccaro, Shelley Chen, Subrata Banik.

Patch set 1:Code-Review -1

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

View Change

1 comment:

• File src/drivers/vpd/vpd_device_feature.c:

  • Patch Set #1, Line 10: static char device_info[VPD_FEATURE_DEVICE_INFO_LEN];

    Could |device_info| be in the stack and give as an argument to the function? The function is called only once and there is no logic to cache the data.

To view, visit change 80805. To unsubscribe, or for help writing mail filters, visit settings.