coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[L] Change in coreboot[main]: mb/google/brya/var/xol: Update Kconfig and devicetree
by Subrata Banik (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, SH Kim. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80324?usp=email ) Change subject: mb/google/brya/var/xol: Update Kconfig and devicetree ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I411932eb4872d77993394a290e8afdd1a0038faf Gerrit-Change-Number: 80324 Gerrit-PatchSet: 6 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Feb 2024 02:54:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/brya/var/xol: Update Kconfig and devicetree
by SH Kim (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80324?usp=email ) Change subject: mb/google/brya/var/xol: Update Kconfig and devicetree ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/80324/comment/d844efb7_f192df6a : PS5, Line 480: select INTEL_GMA_HAVE_VBT > Is data.vbt necessary for all variants? Builder indicated there is no data. […] I'd like to remove it until it's clear. -- To view, visit https://review.coreboot.org/c/coreboot/+/80324?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I411932eb4872d77993394a290e8afdd1a0038faf Gerrit-Change-Number: 80324 Gerrit-PatchSet: 6 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 06 Feb 2024 02:49:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/pc80/tpm: probe for TPM family of a device
by Julius Werner (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Christian Walter, Felix Held, Jérémy Compostella, Krystian Hebel, Michał Żygowski, Sergii Dmytruk, Werner Zeh. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76955?usp=email ) Change subject: drivers/pc80/tpm: probe for TPM family of a device ...................................................................... Patch Set 16: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I23b85e6da0e02999704f3ec30412db0bdce2dd8a Gerrit-Change-Number: 76955 Gerrit-PatchSet: 16 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 01:53:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: libpayload: Switch to commonlib ipchksum() algorithm
by Julius Werner (Code Review) 05 Feb '24

05 Feb '24

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80253?usp=email ) Change subject: libpayload: Switch to commonlib ipchksum() algorithm ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Let's just drop the old implementation in FILO? Yeah, I guess FILO was just always defining a function with the same name, and due to the weirdness of library symbol resolution that somehow didn't cause a problem before? I agree you should just delete it. -- To view, visit https://review.coreboot.org/c/coreboot/+/80253?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8d323ce9f8d946758619761b4b22d54bce222b6 Gerrit-Change-Number: 80253 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 06 Feb 2024 01:47:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload/libc/time: Fix possible overflow in multiplication
by Julius Werner (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Yidi Lin. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78888?usp=email ) Change subject: libpayload/libc/time: Fix possible overflow in multiplication ...................................................................... Patch Set 11: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78888/comment/959bc92b_89c0b11e : PS11, Line 11: USECS_PER_SEC and hz can be reduced by dividing them by their GCD. > Assuming their GCD is big enough? Yeah we're kinda assuming that on Arm systems the timer clocks are always in MHz, and for now that seems to match what we have. I guess we could have just written a simple division instead, but using the GCD seems a bit cleaner. https://review.coreboot.org/c/coreboot/+/78888/comment/dbeb725c_3e439b5d : PS11, Line 15: counter should never be that fast. > On Intel it can be that fast (it's usually the processor base […] Wouldn't that mean that we'd have broken things with the `assert(UINT32_MAX / 1000 >= lib_sysinfo.cpu_khz);` we're adding here? I don't think we've heard anyone complain yet. Or do only certain (maybe older) Intel CPUs do it that way? Remember that `udelay()` is implemented with this (at least outside of x86 boards with CONFIG_LP_ENABLE_APIC), so I do think we need to keep the microsecond resolution. We could do something closer to what `update_clock()` does here, but we really have the same problem in coreboot so it doesn't make much sense to fix it differently here than there. In coreboot, the `timer_monotonic_get()` API doesn't really allow you to access the raw timer value and frequency like that, so you couldn't build a global, generic tick counter thing like that. You'd first have to redesign coreboot's whole platform-specific timer interface to be closer to what libpayload does (which I'd be fine with but it's a bit of a bigger deal, touching a bunch of platforms). In practice, I think the solution here now should be good enough for the platforms we have (unless we accidentally broke the RDTSC driver here, then we need to fix that). -- To view, visit https://review.coreboot.org/c/coreboot/+/78888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia55532490651fcf47128b83a8554751f050bcc89 Gerrit-Change-Number: 78888 Gerrit-PatchSet: 11 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 06 Feb 2024 01:39:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: docker/doc.coreboot.org: Install pip modules into virtual env
by Nicholas Chin (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Felix Singer, Martin L Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80311?usp=email ) Change subject: docker/doc.coreboot.org: Install pip modules into virtual env ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80311/comment/27f34299_0507a6f4 : PS1, Line 12: to install modules to an "externally managed environment" [1], which > `'sucessfully' may be misspelled - perhaps 'successfully'?` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/80311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec Gerrit-Change-Number: 80311 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 23:18:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: lib: Move IP checksum to commonlib
by Julius Werner (Code Review) 05 Feb '24

05 Feb '24

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80251?usp=email ) Change subject: lib: Move IP checksum to commonlib ...................................................................... Patch Set 4: (1 comment) File src/commonlib/bsd/include/commonlib/bsd/ipchksum.h: https://review.coreboot.org/c/coreboot/+/80251/comment/42f9bdf6_323a8e84 : PS4, Line 9: uint16_t ipchksum(const void *data, size_t size); : uint16_t ipchksum_add(size_t offset, uint16_t first, uint16_t second); > Before it was: […] Because the checksum is defined as a 16-bit number. I don't know why the previous author (back in 2009 or whenever this was written... it was _really_ old) chose to return it as a masked unsigned long instead, but it seems awkward to me and almost all call sites seem to implicitly convert it back to u16 anyway, so I thought it made more sense to use that in the first place. (Also, the libpayload version already returned an unsigned short so I just combined the two in a way that's closer to that one.) -- To view, visit https://review.coreboot.org/c/coreboot/+/80251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic04c714c00439a17fc04a8a6e730cc2aa19b8e68 Gerrit-Change-Number: 80251 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 23:13:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: Docs: Replace Recommonmark with MyST Parser
by Nicholas Chin (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73158?usp=email ) Change subject: Docs: Replace Recommonmark with MyST Parser ...................................................................... Patch Set 8: (1 comment) Patchset: PS6: > The docker files still need to be set up for MyST Parser Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0837c1722fa56d25c9441ea218e943d8f3d9b804 Gerrit-Change-Number: 73158 Gerrit-PatchSet: 8 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 23:11:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: cpu/x86/smm: Set up page tables in safe SMRAM
by Benjamin Doron (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80336?usp=email ) Change subject: cpu/x86/smm: Set up page tables in safe SMRAM ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Okay, this approach is simpler than CB:79865. -- To view, visit https://review.coreboot.org/c/coreboot/+/80336?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb3086abd577b9abb9966dd910a264a873ace4ed Gerrit-Change-Number: 80336 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Feb 2024 22:35:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/(sipi|smm): Pass on CR3 from ramstage
by Benjamin Doron (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80335?usp=email ) Change subject: cpu/x86/(sipi|smm): Pass on CR3 from ramstage ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Oh, if I had known you were working on this, I wouldn't have done CB:79864. -- To view, visit https://review.coreboot.org/c/coreboot/+/80335?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1250ea6f63c65228178ee66e06d988dadfcc2a37 Gerrit-Change-Number: 80335 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Feb 2024 22:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024