coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[XS] Change in coreboot[main]: lib/ramdetect: Limit probe size to function argument
by Nico Huber (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68842?usp=email ) Change subject: lib/ramdetect: Limit probe size to function argument ...................................................................... Patch Set 7: (2 comments) File src/lib/ramdetect.c: https://review.coreboot.org/c/coreboot/+/68842/comment/4457471b_d9e9723f : PS7, Line 50: /* Find the MSB + 1. */ Wouldn't starting with MSB instead achieve the same? https://review.coreboot.org/c/coreboot/+/68842/comment/d7ddb329_c13c0587 : PS7, Line 54: } while (tmp >>= 1); e.g. `--msb` here. -- To view, visit https://review.coreboot.org/c/coreboot/+/68842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7f915c6e150629eff235ee94719172467a54db2 Gerrit-Change-Number: 68842 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Feb 2024 19:48:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Initialize TCHSCR_RST_L/EN_PP3300_TCHSCR to 0
by Karthik Ramasubramanian (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Ivy Jian, Nick Vaccaro, Shelley Chen. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80300?usp=email ) Change subject: mb/google/brox: Initialize TCHSCR_RST_L/EN_PP3300_TCHSCR to 0 ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb: https://review.coreboot.org/c/coreboot/+/80300/comment/cdee29d1_2bffdb77 : PS2, Line 176: register "generic.detect" = "1" Does this mean linux kernel has to probe for the touchscreen? That is not the direction we want to go. -- To view, visit https://review.coreboot.org/c/coreboot/+/80300?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5bf1901a3a40a38237b950abcb758f96aebcc1cf Gerrit-Change-Number: 80300 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 19:40:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: riscv/mb/qemu: fix qemu invocation comment
by Nico Huber (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Maximilian Brune, Paul Menzel, Philipp Hug. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80262?usp=email ) Change subject: riscv/mb/qemu: fix qemu invocation comment ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: btw. I added a `qemu` make target (in `util/qemu/Makefile.inc`) some time ago. Didn't know a command for riscv or didn't get it working. So that could be updated now. Or should I just push something on top of this chain? -- To view, visit https://review.coreboot.org/c/coreboot/+/80262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I773fb39801f180fead584942dfb385fcde9d2680 Gerrit-Change-Number: 80262 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 19:34:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id
by Arthur Heymans (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Felix Held, Jérémy Compostella, Nico Huber. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80330?usp=email ) Change subject: arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > What I remember from the cleanup times is that today's IOAPICs probably don't > care about their ID. Historically, an ID of 0 would have been wrong, because > that was usually the BSP LAPIC (and they needed a unique ID on the APIC bus, > which is gone). Not sure if anything still cares about the ID, though we have > to put it into ACPI tables (I just saw). We read the ID from hardware for this, > so we should also write it to hw I guess. Both ioapic and lapic id's are configurable iirc. Making sure that there is no overlap, when they are on that legacy apic bus, where numbers matter, should be handled in the chipset code and not via assumptions made in common code. The commit message seems to say, that's already the case. -- To view, visit https://review.coreboot.org/c/coreboot/+/80330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8538f82a6b10f16eeb228669db197dc8e326ffd Gerrit-Change-Number: 80330 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 19:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: sb/intel/i82371eb/isa: make IOAPIC ID const
by Arthur Heymans (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80349?usp=email ) Change subject: sb/intel/i82371eb/isa: make IOAPIC ID const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80349?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1f19cc43b44a938758a43346f4fa75f8ed39ddea Gerrit-Change-Number: 80349 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 19:27:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id
by Matt DeVillier (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Felix Held, Jérémy Compostella. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80330?usp=email ) Change subject: arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8538f82a6b10f16eeb228669db197dc8e326ffd Gerrit-Change-Number: 80330 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 19:01:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: sb/intel/i82371eb/isa: make IOAPIC ID const
by Nico Huber (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80349?usp=email ) Change subject: sb/intel/i82371eb/isa: make IOAPIC ID const ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80349?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1f19cc43b44a938758a43346f4fa75f8ed39ddea Gerrit-Change-Number: 80349 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 18:48:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: riscv/mb/qemu: fix qemu invocation comment
by ron minnich (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Maximilian Brune, Paul Menzel, Philipp Hug. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80262?usp=email ) Change subject: riscv/mb/qemu: fix qemu invocation comment ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80262/comment/c0073dfa_f0918d42 : PS2, Line 8: > Is this because QEMU was improved? (What version?) Or what changed in coreboot, that `util/riscv/mak […] Wow, that's a blast from the past (like as in 2014, when I first got risc-v support in ...). As you can see, back then, qemu could not really support coreboot ROM images, so we had to tell qemu to run the elf, which was created from the old spike stuff. I doubt we need say much, this is just bringing qemu for risc-v into line with all the other platforms. -- To view, visit https://review.coreboot.org/c/coreboot/+/80262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I773fb39801f180fead584942dfb385fcde9d2680 Gerrit-Change-Number: 80262 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 18:39:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/emulation/riscv: Limit DRAM size
by ron minnich (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Maximilian Brune, Philipp Hug. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843?usp=email ) Change subject: mb/emulation/riscv: Limit DRAM size ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: for my simulation I'm going to need more than 16 GiB today. This has a feeling of locking in a QEMU limitation forever. Is there not some better way? 16 GiB is a really low limit. -- To view, visit https://review.coreboot.org/c/coreboot/+/68843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515 Gerrit-Change-Number: 68843 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Feb 2024 18:19:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: lenovo/x230: introduce FHD variant
by Ivan V (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Alexander Couzens, Angel Pons, Charles Moyes, Felix Singer, Heiki Lõhmus, Kilian Neuner, Nico Huber, Paul Menzel, Xue Yao, insurgo(a)riseup.net. Ivan V has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950?usp=email ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 23: (1 comment) File src/mainboard/lenovo/x230/Kconfig.name: https://review.coreboot.org/c/coreboot/+/28950/comment/35bcdd77_a489bfe9 : PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)" > Reporting that eDP 4.0 mod from AliExpress with Sharp LQ125T1JW02 2560x1440 12. […] As @tlaurion's requested in yet another attempt at getting this patch merged, reporting that the latest revision of this patch works perfectly with coreboot 4.22.01 on X230 modded with eDP 4.0 board and 1440p internal display. Tested via Heads' 4.22.01-based test build located here: https://github.com/linuxboot/heads/pull/1604. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 23 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <dh(a)devass.club> Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com> Gerrit-CC: Christian Herzog Gerrit-CC: Heiki Lõhmus <h(a)lohmus.me> Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Ivan V <ivv(a)i1v.org> Gerrit-CC: MartiniMoe Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: Xue Yao <xueyao(a)xyte.ch> Gerrit-CC: clayton craft Gerrit-CC: insurgo(a)riseup.net Gerrit-CC: nullmark <nullmark(a)googlemail.com> Gerrit-CC: slact Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Heiki Lõhmus <h(a)lohmus.me> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Xue Yao <xueyao(a)xyte.ch> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kilian Neuner <cb(a)9-r.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: insurgo(a)riseup.net Gerrit-Comment-Date: Mon, 05 Feb 2024 18:09:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ivan V <ivv(a)i1v.org> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024