coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[S] Change in coreboot[main]: util/docker: Update Dockerfiles for building documentation
by Nicholas Chin (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Felix Singer, Martin L Roth. Hello Felix Singer, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80312?usp=email to look at the new patch set (#2). Change subject: util/docker: Update Dockerfiles for building documentation ...................................................................... util/docker: Update Dockerfiles for building documentation Update all pip packages related to coreboot's documentation to their latest available version, and update the doc.coreboot.org base image to Alpine 3.19.1. Add myst-parser in preparation to switch from Recommonmark to MyST Parser. TEST: The documentation builds and renders properly when built using the updated container. Change-Id: I8df4aadabc49c0201a836333745fe138184595ac Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/docker/coreboot-jenkins-node/Dockerfile M util/docker/doc.coreboot.org/Dockerfile 2 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/80312/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80312?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8df4aadabc49c0201a836333745fe138184595ac Gerrit-Change-Number: 80312 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: util/docker/: Drop recommonmark pip module
by Nicholas Chin (Code Review) 05 Feb '24

05 Feb '24

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80313?usp=email ) Change subject: util/docker/: Drop recommonmark pip module ...................................................................... util/docker/: Drop recommonmark pip module The documentation is now built using MyST Parser, so Recommonmark can be dropped. Change-Id: I7f6810c9429573c0c51d3d72b36e9fc2ae2185f5 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/docker/coreboot-jenkins-node/Dockerfile M util/docker/doc.coreboot.org/Dockerfile 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/80313/1 diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index c032a4d..d10ebc7 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -80,7 +80,6 @@ pip3 install --no-cache-dir \ setuptools==58.2.0 \ jinja2==3.1.3 \ - recommonmark===0.7.1 \ myst-parser===2.0.0 \ sphinx===7.2.6 \ sphinxcontrib-ditaa===1.0.2 \ diff --git a/util/docker/doc.coreboot.org/Dockerfile b/util/docker/doc.coreboot.org/Dockerfile index 5c3a782..415f3c3 100644 --- a/util/docker/doc.coreboot.org/Dockerfile +++ b/util/docker/doc.coreboot.org/Dockerfile @@ -10,7 +10,6 @@ && pip3 install --upgrade --no-cache-dir pip \ && pip3 install --no-cache-dir \ jinja2==3.1.3 \ - recommonmark===0.7.1 \ myst-parser==2.0.0 \ sphinx===7.2.6 \ sphinxcontrib-ditaa===1.0.2 \ -- To view, visit https://review.coreboot.org/c/coreboot/+/80313?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f6810c9429573c0c51d3d72b36e9fc2ae2185f5 Gerrit-Change-Number: 80313 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[main]: Docs: Replace Recommonmark with MyST Parser
by Nicholas Chin (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Hello Angel Pons, Daniel Maslowski, Felix Singer, Jason Glenesk, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73158?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Docs: Replace Recommonmark with MyST Parser ...................................................................... Docs: Replace Recommonmark with MyST Parser Recommonmark has been deprecated since 2021 [1] and the last release was over 3 years ago [2]. As per their announcement, Markedly Structured Text (MyST) Parser [3] is the recommended replacement. For the most part, the existing documentation is compatible with MyST, as both parsers are built around the CommonMark flavor of Markdown. The main difference that affects coreboot is how the Sphinx toctree is generated. Recommonmark has a feature called auto_toc_tree, which converts single level lists of references into a toctree: * [Part 1: Starting from scratch](part1.md) * [Part 2: Submitting a patch to coreboot.org](part2.md) * [Part 3: Writing unit tests](part3.md) * [Managing local additions](managing_local_additions.md) * [Flashing firmware](flashing_firmware/index.md) MyST Parser does not provide a replacement for this feature, meaning the toctree must be defined manually. This is done using MyST's syntax for Sphinx directives: ```{toctree} :maxdepth: 1 Part 1: Starting from scratch <part1.md> Part 2: Submitting a patch to coreboot.org <part2.md> Part 3: Writing unit tests <part3.md> Managing local additions <managing_local_additions.md> Flashing firmware <flashing_firmware/index.md> ``` Internally, auto_toc_tree essentially converts lists of references into the Sphinx toctree structure that the MyST syntax above more directly represents. This was converted using by running all md files through the following Python script, and then manually reverting some false positives: ``` import re import sys in_list = False f = open(sys.argv[1]) lines = f.readlines() f.close() with open(sys.argv[1], "w") as f: for line in lines: match = re.match(r"^[-*+] \[(.*)\]$(.*)$$", line) if match is not None: if not in_list: in_list = True f.write("```{toctree}\n") f.write(":maxdepth: 1\n\n") f.write(match.group(1) + " <" + match.group(2) + ">\n") else: if in_list: f.write("```\n") f.write(line) in_list = False if in_list: f.write("```\n") ``` While this does add a little more work for creating the toctree, this does give more control over exactly what goes into the toctree. For instance, lists of links to external resources currently end up in the toctree, but we may want to limit it to pages within coreboot. This change does break rendering and navigation of the documentation in applications that can render Markdown, such as Okular, Gitiles, or the GitHub mirror. Assuming the docs are mainly intended to be viewed after being rendered to doc.coreboot.org, this is probably not an issue in practice. Another difference is that MyST natively supports Markdown tables, whereas with Recommonmark, tables had to be written in embedded rST [6]. However, MyST also supports embedded rST, so the existing tables can be easily converted as the syntax is nearly identical. These were converted using `find ./ -iname "*.md" | xargs -n 1 sed -i "s/eval_rst/{eval-rst}/"` Makefile.sphinx and conf.py were regenerated from scratch by running `sphinx-quickstart` using the updated version of Sphinx, which removes a lot of old commented out boilerplate. Any relevant changes coreboot had made on top of the previous autogenerated versions of these files were ported over to the newly generated file. From some initial testing the generated webpages appear and function identically to the existing documentation built with Recommonmark. [1] https://github.com/readthedocs/recommonmark/issues/221 [2] https://pypi.org/project/recommonmark/ [3] https://myst-parser.readthedocs.io/en/latest/ [4] https://doc.coreboot.org/getting_started/writing_documentation.html Change-Id: I0837c1722fa56d25c9441ea218e943d8f3d9b804 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/Makefile.sphinx M Documentation/acpi/index.md M Documentation/acronyms.md M Documentation/arch/index.md M Documentation/arch/x86/index.md M Documentation/community/index.md M Documentation/conf.py M Documentation/contributing/index.md M Documentation/drivers/index.md M Documentation/drivers/smmstore.md M Documentation/drivers/smmstorev2.md M Documentation/external_docs.md M Documentation/getting_started/build_system.md M Documentation/getting_started/gpio.md M Documentation/getting_started/index.md M Documentation/getting_started/kconfig.md M Documentation/gfx/display-panel.md M Documentation/index.md M Documentation/infrastructure/builders.md M Documentation/infrastructure/index.md M Documentation/lib/index.md M Documentation/lib/payloads/index.md M Documentation/mainboard/acer/g43t-am3.md M Documentation/mainboard/amd/pademelon/pademelon.md M Documentation/mainboard/asrock/h110m-dvs.md M Documentation/mainboard/asrock/h77pro4-m.md M Documentation/mainboard/asrock/h81m-hds.md M Documentation/mainboard/asus/a88xm-e.md M Documentation/mainboard/asus/f2a85-m.md M Documentation/mainboard/asus/p2b-ls.md M Documentation/mainboard/asus/p3b-f.md M Documentation/mainboard/asus/p5q.md M Documentation/mainboard/asus/p8c_ws.md M Documentation/mainboard/asus/p8h61-m_lx.md M Documentation/mainboard/asus/p8h61-m_pro.md M Documentation/mainboard/asus/p8h77-v.md M Documentation/mainboard/asus/p8z77-m.md M Documentation/mainboard/asus/p8z77-m_pro.md M Documentation/mainboard/asus/p8z77-v.md M Documentation/mainboard/asus/wifigo_v1.md M Documentation/mainboard/cavium/cn8100_sff_evb.md M Documentation/mainboard/clevo/n130wu/index.md M Documentation/mainboard/dell/optiplex_9010.md M Documentation/mainboard/facebook/fbg1701.md M Documentation/mainboard/facebook/monolith.md M Documentation/mainboard/foxconn/d41s.md M Documentation/mainboard/gigabyte/ga-g41m-es2l.md M Documentation/mainboard/gigabyte/ga-h61m-s2pv.md M Documentation/mainboard/hp/2170p.md M Documentation/mainboard/hp/2560p.md M Documentation/mainboard/hp/8760w.md M Documentation/mainboard/hp/compaq_8200_sff.md M Documentation/mainboard/hp/compaq_8300_usdt.md M Documentation/mainboard/hp/elitebook_820_g2.md M Documentation/mainboard/hp/folio_9480m.md M Documentation/mainboard/hp/z220_sff.md M Documentation/mainboard/index.md M Documentation/mainboard/intel/dg43gt.md M Documentation/mainboard/intel/dq67sw.md M Documentation/mainboard/intel/kblrvp11.md M Documentation/mainboard/kontron/mal10.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md M Documentation/mainboard/lenovo/Sandy_Bridge_series.md M Documentation/mainboard/lenovo/codenames.md M Documentation/mainboard/lenovo/ivb_internal_flashing.md M Documentation/mainboard/lenovo/montevina_series.md M Documentation/mainboard/lenovo/t410.md M Documentation/mainboard/libretrend/lt1000.md M Documentation/mainboard/msi/ms7707/ms7707.md M Documentation/mainboard/ocp/deltalake.md M Documentation/mainboard/ocp/tiogapass.md M Documentation/mainboard/opencellular/elgon.md M Documentation/mainboard/pcengines/apu1.md M Documentation/mainboard/pcengines/apu2.md M Documentation/mainboard/portwell/pq7-m107.md M Documentation/mainboard/prodrive/hermes.md M Documentation/mainboard/protectli/fw2b_fw4b.md M Documentation/mainboard/protectli/fw6.md M Documentation/mainboard/protectli/vp2420.md M Documentation/mainboard/protectli/vp46xx.md M Documentation/mainboard/purism/librem_14.md M Documentation/mainboard/purism/librem_mini.md M Documentation/mainboard/starlabs/labtop_cml.md M Documentation/mainboard/starlabs/labtop_kbl.md M Documentation/mainboard/starlabs/lite_glk.md M Documentation/mainboard/starlabs/lite_glkr.md M Documentation/mainboard/starlabs/starbook_adl.md M Documentation/mainboard/starlabs/starbook_tgl.md M Documentation/mainboard/supermicro/x10slm-f.md M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md M Documentation/mainboard/supermicro/x11-lga1151-series/x11ssw-f/x11ssw-f.md M Documentation/mainboard/supermicro/x9sae.md M Documentation/mainboard/system76/addw1.md M Documentation/mainboard/system76/addw2.md M Documentation/mainboard/system76/addw3.md M Documentation/mainboard/system76/bonw14.md M Documentation/mainboard/system76/bonw15.md M Documentation/mainboard/system76/darp6.md M Documentation/mainboard/system76/darp7.md M Documentation/mainboard/system76/darp8.md M Documentation/mainboard/system76/darp9.md M Documentation/mainboard/system76/galp4.md M Documentation/mainboard/system76/galp5.md M Documentation/mainboard/system76/galp6.md M Documentation/mainboard/system76/galp7.md M Documentation/mainboard/system76/gaze15.md M Documentation/mainboard/system76/gaze16.md M Documentation/mainboard/system76/gaze17.md M Documentation/mainboard/system76/gaze18.md M Documentation/mainboard/system76/lemp10.md M Documentation/mainboard/system76/lemp11.md M Documentation/mainboard/system76/lemp12.md M Documentation/mainboard/system76/lemp9.md M Documentation/mainboard/system76/oryp10.md M Documentation/mainboard/system76/oryp11.md M Documentation/mainboard/system76/oryp5.md M Documentation/mainboard/system76/oryp6.md M Documentation/mainboard/system76/oryp7.md M Documentation/mainboard/system76/oryp8.md M Documentation/mainboard/system76/oryp9.md M Documentation/mainboard/system76/serw13.md M Documentation/mainboard/ti/beaglebone-black.md M Documentation/mainboard/up/squared/index.md M Documentation/northbridge/index.md M Documentation/northbridge/intel/haswell/index.md M Documentation/northbridge/intel/haswell/known-issues.md M Documentation/northbridge/intel/index.md M Documentation/northbridge/intel/sandybridge/index.md M Documentation/northbridge/intel/sandybridge/nri.md M Documentation/northbridge/intel/sandybridge/nri_features.md M Documentation/northbridge/intel/sandybridge/nri_freq.md M Documentation/northbridge/intel/sandybridge/nri_read.md M Documentation/northbridge/intel/sandybridge/nri_registers.md M Documentation/releases/boards_supported_on_branches.md M Documentation/releases/checklist.md M Documentation/releases/coreboot-4.17-relnotes.md M Documentation/releases/coreboot-4.19-relnotes.md M Documentation/releases/coreboot-4.20.1-relnotes.md M Documentation/releases/coreboot-4.21-relnotes.md M Documentation/releases/coreboot-4.22-relnotes.md M Documentation/releases/index.md M Documentation/releases/templates.md M Documentation/security/index.md M Documentation/security/memory_clearing.md M Documentation/security/vboot/index.md M Documentation/soc/amd/index.md M Documentation/soc/amd/psp_integration.md M Documentation/soc/cavium/cn81xx/index.md M Documentation/soc/cavium/index.md M Documentation/soc/index.md M Documentation/soc/intel/broadwell/index.md M Documentation/soc/intel/code_development_model/code_development_model.md M Documentation/soc/intel/fit.md M Documentation/soc/intel/fsp/index.md M Documentation/soc/intel/fsp/ppi/mp_service_ppi.md M Documentation/soc/intel/fsp/ppi/ppi.md M Documentation/soc/intel/index.md M Documentation/soc/intel/mp_init/mp_init.md M Documentation/soc/intel/xeon_sp/index.md M Documentation/soc/qualcomm/index.md M Documentation/superio/index.md M Documentation/superio/nuvoton/npcd378.md M Documentation/technotes/asan.md M Documentation/technotes/console.md M Documentation/technotes/index.md M Documentation/tutorial/flashing_firmware/index.md M Documentation/tutorial/index.md M Documentation/tutorial/part3.md M Documentation/util.md M Documentation/util/cbfstool/index.md M Documentation/util/ifdtool/index.md M Documentation/util/ifdtool/layout.md M Documentation/vendorcode/cavium/index.md M Documentation/vendorcode/eltan/index.md M Documentation/vendorcode/index.md 178 files changed, 1,259 insertions(+), 1,019 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/73158/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/73158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0837c1722fa56d25c9441ea218e943d8f3d9b804 Gerrit-Change-Number: 73158 Gerrit-PatchSet: 8 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: util/docker: Update Dockerfiles for building documentation
by Nicholas Chin (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Martin L Roth. Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80312?usp=email ) Change subject: util/docker: Update Dockerfiles for building documentation ...................................................................... util/docker: Update Dockerfiles for building documentation Update all pip packages related to coreboot's documentation to their latest available version, and update the doc.coreboot.org base image to Alpine 3.19.1. Add myst-parser in preparation to switch from Recommonmark to MyST Parser. TEST: The documentation builds and renders properly when build using the updated container. Change-Id: I8df4aadabc49c0201a836333745fe138184595ac Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/docker/coreboot-jenkins-node/Dockerfile M util/docker/doc.coreboot.org/Dockerfile 2 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/80312/1 diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index f1ab4e9..c032a4d 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -79,12 +79,13 @@ pip3 install --upgrade --no-cache-dir pip && \ pip3 install --no-cache-dir \ setuptools==58.2.0 \ - jinja2==3.1.2 \ + jinja2==3.1.3 \ recommonmark===0.7.1 \ - sphinx===6.2.1 \ + myst-parser===2.0.0 \ + sphinx===7.2.6 \ sphinxcontrib-ditaa===1.0.2 \ sphinx_autobuild===2021.3.14 \ - sphinx_rtd_theme===1.2.2 \ + sphinx_rtd_theme===2.0.0 \ && mkdir -p /home/coreboot/.ssh && \ echo "{{SSH_KEY}}" > /home/coreboot/.ssh/authorized_keys && \ chmod 0700 /home/coreboot/.ssh && \ diff --git a/util/docker/doc.coreboot.org/Dockerfile b/util/docker/doc.coreboot.org/Dockerfile index 1039d36..5c3a782 100644 --- a/util/docker/doc.coreboot.org/Dockerfile +++ b/util/docker/doc.coreboot.org/Dockerfile @@ -1,4 +1,4 @@ -FROM alpine:3.18.3 +FROM alpine:3.19.1 COPY makeSphinx.sh /makeSphinx.sh @@ -9,12 +9,13 @@ RUN python3 -m venv ${VIRTUAL_ENV} \ && pip3 install --upgrade --no-cache-dir pip \ && pip3 install --no-cache-dir \ - jinja2==3.1.2 \ - recommonmark===0.7.1\ - sphinx===6.2.1 \ + jinja2==3.1.3 \ + recommonmark===0.7.1 \ + myst-parser==2.0.0 \ + sphinx===7.2.6 \ sphinxcontrib-ditaa===1.0.2 \ sphinx_autobuild===2021.3.14 \ - sphinx_rtd_theme===1.2.2 + sphinx_rtd_theme===2.0.0 ADD https://github.com/stathissideris/ditaa/releases/download/v0.11.0/ditaa-0.1… \ /usr/lib/ditaa-0.11.0-standalone.jar -- To view, visit https://review.coreboot.org/c/coreboot/+/80312?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8df4aadabc49c0201a836333745fe138184595ac Gerrit-Change-Number: 80312 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: docker/doc.coreboot.org: Install pip modules into virtual env
by Nicholas Chin (Code Review) 05 Feb '24

05 Feb '24

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80311?usp=email ) Change subject: docker/doc.coreboot.org: Install pip modules into virtual env ...................................................................... docker/doc.coreboot.org: Install pip modules into virtual env Currently, pip modules are installed system-wide, which may cause conflicts with modules installed using the package manager. Newer versions of Python will also result in an error by default if pip tries to install modules to an "externally managed environment" [1], which would prevent the container from sucessfully building with newer versions of Python. [1] https://peps.python.org/pep-0668/ Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/docker/doc.coreboot.org/Dockerfile M util/docker/doc.coreboot.org/makeSphinx.sh 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/80311/1 diff --git a/util/docker/doc.coreboot.org/Dockerfile b/util/docker/doc.coreboot.org/Dockerfile index df741d8..1039d36 100644 --- a/util/docker/doc.coreboot.org/Dockerfile +++ b/util/docker/doc.coreboot.org/Dockerfile @@ -3,6 +3,10 @@ COPY makeSphinx.sh /makeSphinx.sh RUN apk add --no-cache python3 py3-pip make bash git openjdk8-jre ttf-dejavu fontconfig \ + && chmod 755 /makeSphinx.sh +ENV VIRTUAL_ENV="/python3" +ENV PATH=$VIRTUAL_ENV/bin:$PATH +RUN python3 -m venv ${VIRTUAL_ENV} \ && pip3 install --upgrade --no-cache-dir pip \ && pip3 install --no-cache-dir \ jinja2==3.1.2 \ @@ -10,8 +14,7 @@ sphinx===6.2.1 \ sphinxcontrib-ditaa===1.0.2 \ sphinx_autobuild===2021.3.14 \ - sphinx_rtd_theme===1.2.2 \ - && chmod 755 /makeSphinx.sh + sphinx_rtd_theme===1.2.2 ADD https://github.com/stathissideris/ditaa/releases/download/v0.11.0/ditaa-0.1… \ /usr/lib/ditaa-0.11.0-standalone.jar diff --git a/util/docker/doc.coreboot.org/makeSphinx.sh b/util/docker/doc.coreboot.org/makeSphinx.sh index 96a593c..918eb16 100755 --- a/util/docker/doc.coreboot.org/makeSphinx.sh +++ b/util/docker/doc.coreboot.org/makeSphinx.sh @@ -1,5 +1,7 @@ #!/usr/bin/env bash +source $VIRTUAL_ENV/bin/activate + if [ "$1" == "livehtml" ]; then echo "Starting live documentation build" cd /data-in/Documentation && make livesphinx BUILDDIR=/tmp/build -- To view, visit https://review.coreboot.org/c/coreboot/+/80311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec Gerrit-Change-Number: 80311 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/emulation/riscv: Limit DRAM size
by Nico Huber (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Maximilian Brune, Philipp Hug, ron minnich. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843?usp=email ) Change subject: mb/emulation/riscv: Limit DRAM size ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > We could probably read the DRAM regions from dtb or fw_cfg. Looking at current […] OTOH, looking ahead in the queue, we could probably save us the trouble with the `ramdetect.c` probing. -- To view, visit https://review.coreboot.org/c/coreboot/+/68843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515 Gerrit-Change-Number: 68843 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:34:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/emulation/riscv: Limit DRAM size
by Nico Huber (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Maximilian Brune, Philipp Hug, ron minnich. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68843?usp=email ) Change subject: mb/emulation/riscv: Limit DRAM size ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > for my simulation I'm going to need more than 16 GiB today. […] We could probably read the DRAM regions from dtb or fw_cfg. Looking at current QEMU code the riscv `virt' machine seems to support both. Though, I couldn't figure out the details. Support for the latter currently lives in the x86 board ports, but could probably be moved into drivers/. As this would need additional programming no matter what we do with the limit for the current code, I don't think it matters for this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/68843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib8555de361d1129d3d1995f056518c576f055515 Gerrit-Change-Number: 68843 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/amd/noncar: Increase bootblock size
by Paul Menzel (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80348?usp=email ) Change subject: soc/amd/noncar: Increase bootblock size ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80348/comment/ee2234a2_ea3e874d : PS3, Line 7: Increase bootblock size If you could add the size, that’d be great: … to … kB -- To view, visit https://review.coreboot.org/c/coreboot/+/80348?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I23f176d63d3c303b13331a77ad5ac6c7a19073d3 Gerrit-Change-Number: 80348 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Locate PCU by PCI device ID
by Felix Held (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80093?usp=email ) Change subject: soc/intel/xeon_sp: Locate PCU by PCI device ID ...................................................................... Patch Set 11: (1 comment) File src/soc/intel/xeon_sp/skx/soc_util.c: https://review.coreboot.org/c/coreboot/+/80093/comment/c0ac6c6c_4e213a8e : PS11, Line 115: #if ENV_RAMSTAGE i wonder why this #if is needed here while it's not needed for the other 2 socs that this patch changes -- To view, visit https://review.coreboot.org/c/coreboot/+/80093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I06694715cba76b101165f1cef66d161b0f896b26 Gerrit-Change-Number: 80093 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp: Drop unused MACROs
by Felix Held (Code Review) 05 Feb '24

05 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80096?usp=email ) Change subject: soc/intel/xeon_sp: Drop unused MACROs ...................................................................... Patch Set 11: (1 comment) File src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h: https://review.coreboot.org/c/coreboot/+/80096/comment/7428c8dd_e17aad32 : PS8, Line 79: #define PCU_DEV_CR3(bus) _PCU_DEV(bus, PCU_CR3_FUN) > that line should probably also be removed Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4067a1940f6cb3ee6d40c784877d7906495251a4 Gerrit-Change-Number: 80096 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 05 Feb 2024 19:52:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024