coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ...................................................................... Patch Set 30: (2 comments) File src/soc/mediatek/common/mt6363_sdmadc.c: https://review.coreboot.org/c/coreboot/+/85128/comment/767317c6_783603c2?us… : PS30, Line 64: int Sorry, I just found a few problems when reviewing CB:85666. Is this supposed to be u32 (or u16)? Either way, it should not be a signed type. https://review.coreboot.org/c/coreboot/+/85128/comment/b1a86fb0_0a5f6974?us… : PS30, Line 107: regval * chan->hw_info.ratio[0] * chan->hw_info.ref_volt Is the multiplication likely to overflow (if so we need to cast to u64)? Could you check the maximum possible values of `chan->hw_info.res`, `chan->hw_info.ratio[0]` and `chan->hw_info.ref_volt`? -- To view, visit https://review.coreboot.org/c/coreboot/+/85128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a Gerrit-Change-Number: 85128 Gerrit-PatchSet: 30 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 07:06:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/rauru: Implement SKU ID
by Jarried Lin (Code Review) 20 Dec '24

20 Dec '24

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email ) Change subject: mb/google/rauru: Implement SKU ID ...................................................................... Patch Set 7: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece Gerrit-Change-Number: 85666 Gerrit-PatchSet: 7 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:52:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/mediatek: Add support for MediaTek firmware support package
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85665?usp=email ) Change subject: soc/mediatek: Add support for MediaTek firmware support package ...................................................................... Patch Set 2: Code-Review+1 (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85665/comment/3313d302_99610e69?us… : PS2, Line 10: firmeware firmware https://review.coreboot.org/c/coreboot/+/85665/comment/1455753a_bdd1e006?us… : PS2, Line 11: includes include File src/soc/mediatek/common/mtk_fsp.c: https://review.coreboot.org/c/coreboot/+/85665/comment/f7c217d1_f4fc7e7b?us… : PS2, Line 19: void `enum fsp_phase phase` https://review.coreboot.org/c/coreboot/+/85665/comment/5d93ed68_08654e01?us… : PS2, Line 36: mtk_fsp_init(); I think we should return an error here. If `mtk_fsp_init` is in the API, the caller should call it before calling other functions. https://review.coreboot.org/c/coreboot/+/85665/comment/5cc95da8_495b4f11?us… : PS2, Line 89: mtk_fsp_init(); I think we should return an error here. If `mtk_fsp_init` is in the API, the caller should call it before calling other functions. https://review.coreboot.org/c/coreboot/+/85665/comment/3c314463_a40218d8?us… : PS2, Line 92: prog_set_entry(&fsp, prog_entry(&fsp), intf); `prog_set_arg(&fsp, intf)`. Otherwise you're just setting `prog->entry` to `prog->entry`. https://review.coreboot.org/c/coreboot/+/85665/comment/5464368d_198e1a1c?us… : PS2, Line 100: d #x -- To view, visit https://review.coreboot.org/c/coreboot/+/85665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idef3518f9763fe5f74adb459c137db164563e483 Gerrit-Change-Number: 85665 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Disable modem power
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85663?usp=email ) Change subject: mb/google/rauru: Disable modem power ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/rauru/romstage.c: https://review.coreboot.org/c/coreboot/+/85663/comment/4a8883cb_73bfea63?us… : PS1, Line 7: #include <soc/md_power_ctrl.h> sort -- To view, visit https://review.coreboot.org/c/coreboot/+/85663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I71bda7055afc902525501ddf7074f9b2c5550d4a Gerrit-Change-Number: 85663 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:28:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add disable modem power driver
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85651?usp=email ) Change subject: soc/mediatek/mt8196: Add disable modem power driver ...................................................................... Patch Set 3: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85651/comment/8d550187_c1a2f334?us… : PS3, Line 7: disable modem power driver modem power driver to disable unused power File src/soc/mediatek/mt8196/include/soc/md_power_ctrl.h: https://review.coreboot.org/c/coreboot/+/85651/comment/715ad173_8daad33e?us… : PS3, Line 6: /* : * md_power_down() - Power down modem : */ `/* Power down modem. */` https://review.coreboot.org/c/coreboot/+/85651/comment/7849b714_22a9c652?us… : PS3, Line 9: md > modem Also rename the file to modem_power_ctrl.*. File src/soc/mediatek/mt8196/md_power_ctrl.c: https://review.coreboot.org/c/coreboot/+/85651/comment/1d579c43_ba13bfc2?us… : PS3, Line 28: mtk_apifrbus_ao_io_reg_bus As this is used only in this file, can we have a shorter name? https://review.coreboot.org/c/coreboot/+/85651/comment/3984858b_1fe0e54a?us… : PS3, Line 31: struct mtk_spm_regs { : u32 reserved0[896]; : u32 md1_pwr_con; : u32 reserved1[20]; : u32 adsp_top_pwr_con; : u32 adsp_infra_pwr_con; : u32 adsp_ao_pwr_con; : u32 reserved2[11]; : u32 spu_hwrot_pwr_con; : u32 reserved3[27]; : u32 md_buck_iso_con; : u32 reserved4[5]; : u32 pwr_status; : u32 pwr_status_2nd; : }; : : static struct mtk_spm_regs *const mtk_spm = (void *)SPM_BASE; This is already defined in spm.h. Please rebase onto CB:85599. https://review.coreboot.org/c/coreboot/+/85651/comment/74ed6362_e3c301dd?us… : PS3, Line 50: OTHER_SRAM_CKISO = BIT(0), : PWR_RST_B = BIT(0), Are these both for the `md1_pwr_con` register? https://review.coreboot.org/c/coreboot/+/85651/comment/2c8a9a89_030cd488?us… : PS3, Line 52: OTHER_SRAM_ISOINT_B = BIT(1), : PWR_ISO = BIT(1), Same here. Why do we have two definitions for the same bit? https://review.coreboot.org/c/coreboot/+/85651/comment/814c3d5d_da2b69a5?us… : PS3, Line 90: struct pmif *pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); : : /* Vsram_vosel = 0x24d, read Vsram value */ : reg = VSRAM_VOSEL; : pmif_arb->read(pmif_arb, SPMI_SLAVE_4, reg, &val); : : /* Vmodem_vosel = 0x24e, write Vmodem 0.75V */ : reg = VMODEM_VOSEL; : pmif_arb->write(pmif_arb, SPMI_SLAVE_4, reg, SPMI_SLAVE_4_750MV); : pmif_arb->read(pmif_arb, SPMI_SLAVE_4, reg, &val); > Add `mt6363_write8` to `common/mt6363.c`. […] One minor side effect is that `pmif_check_init_done` will be called multiple times. As future improvement, we may store `bool is_init_done` in `struct pmif` to prevent multiple calls. -- To view, visit https://review.coreboot.org/c/coreboot/+/85651?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia8808e3500727753e4537017b46ac8ab39d59468 Gerrit-Change-Number: 85651 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:28:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add SPM loader
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Alicja Michalska, Ccong Chen, Hung-Te Lin, Jarried Lin, Wenzhen Yu. Yu-Ping Wu has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8196: Add SPM loader ...................................................................... Patch Set 14: Code-Review+2 (1 comment) File src/soc/mediatek/mt8196/include/soc/spm.h: https://review.coreboot.org/c/coreboot/+/85599/comment/0a14e291_8f4cc949?us… : PS14, Line 1133: check_member(mtk_spm_regs, spm_twam_timer_out, 0xFFC); Add `check_member(mtk_spm_regs, md1_pwr_con, 0xE00);` (for CB:85651) -- To view, visit https://review.coreboot.org/c/coreboot/+/85599?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie09346f46cb734c74776b760485e7f35d4357e5e Gerrit-Change-Number: 85599 Gerrit-PatchSet: 14 Gerrit-Owner: Ccong Chen <ot_ccong.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Wenzhen Yu <wenzhen.yu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Wenzhen Yu <wenzhen.yu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Ccong Chen <ot_ccong.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:14:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/alderlake: Add function to force disable memory channels
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Christian Walter, Dinesh Gehlot, Eric Lai, Jamie Chen, Jayvik Desai, Jeremy Soller, Kapil Porwal, Lean Sheng Tan, Michał Kopeć, Michał Żygowski, Nick Vaccaro, Paul Menzel, Piotr Król, Sean Rhodes, Tim Crawford. Subrata Banik has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85529?usp=email ) Change subject: soc/intel/alderlake: Add function to force disable memory channels ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/alderlake/meminit.c: https://review.coreboot.org/c/coreboot/+/85529/comment/081f3f29_03cb9e0b?us… : PS8, Line 259: printk(BIOS_ERR, "Cannot disable the first channel.\n"); (Mc0Ch0) -- To view, visit https://review.coreboot.org/c/coreboot/+/85529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibfeca4509cb3d88bc1bac2ac2d480e665d895bc5 Gerrit-Change-Number: 85529 Gerrit-PatchSet: 8 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Keep GSPIx interface default PCI
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Pranava Y N. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85686?usp=email ) Change subject: mb/google/fatcat: Keep GSPIx interface default PCI ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why are we keeping this default to PCI instead of disabled? I think it's a good idea to keep the GSPIx interface enabled by default in the devicetree. That way, we can configure it from the respective overrides, and we won't accidentally miss anything if we forget to add an override tree entry. -- To view, visit https://review.coreboot.org/c/coreboot/+/85686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3348f78614e61259333ccf2babf20eaf4666a0e Gerrit-Change-Number: 85686 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8189: Initialize watchdog
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu. Yu-Ping Wu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85678?usp=email ) Change subject: soc/mediatek/mt8189: Initialize watchdog ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I496fce91e52393db31fd1fb5a1c68d91b2ed073e Gerrit-Change-Number: 85678 Gerrit-PatchSet: 3 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:01:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/common: Update timer macro name
by Yu-Ping Wu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu. Yu-Ping Wu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85681?usp=email ) Change subject: soc/mediatek/common: Update timer macro name ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85681/comment/f12f8e4a_c52c460d?us… : PS1, Line 7: Update timer macro name > Replace GPT_MHZ with TIMER_MHZ for readability Or `Rename GPT_MHZ to TIMER_MHZ for readability` https://review.coreboot.org/c/coreboot/+/85681/comment/4cef5c35_50b9829b?us… : PS1, Line 11: The new ICs(e.g. mt8196, mt8189) will no longer use GPT, and in order : to improve code readability, so replace GPT_MHZ of existing Soc's : with macro name TIMER_MHZ. > The new ICs(e.g. mt8196, mt8189) is no longer using GPT. […] nit: space before `(` -- To view, visit https://review.coreboot.org/c/coreboot/+/85681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02f18bfa5b5912f28e322d40cd46823a0095bbf4 Gerrit-Change-Number: 85681 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 06:00:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024