Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao.
Hello Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84534?usp=email
to look at the new patch set (#12).
Change subject: amdfwtool: Add function to check A/B recovery capability
......................................................................
amdfwtool: Add function to check A/B recovery capability
For the A/B recovery, the partition A should be identical with
partition B. It may have some exception, so it is just a reminder.
Change-Id: I491d106bac94698419cbb5ec269e51421250e3a6
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
2 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84534/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/84534?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I491d106bac94698419cbb5ec269e51421250e3a6
Gerrit-Change-Number: 84534
Gerrit-PatchSet: 12
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru.
Hello Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, build bot (Jenkins), ritul guru,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85466?usp=email
to look at the new patch set (#5).
Change subject: amdfwtool: Set address mode of BIOS binary as context defines
......................................................................
amdfwtool: Set address mode of BIOS binary as context defines
Other types of FWs in the BIOS table are defined by context. So the
BIOS binary should follow that.
TEST=Binary identical test on platforms before mendocino
Tested on Skyrim
Change-Id: I9c2f2983d03c913b28fbd87aa0925a32a4649d62
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/85466/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/85466?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c2f2983d03c913b28fbd87aa0925a32a4649d62
Gerrit-Change-Number: 85466
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Marshall Dawson, Zheng Bao.
Hello Felix Held, Marshall Dawson, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85468?usp=email
to look at the new patch set (#10).
Change subject: cbfstool: Add hash to more than one region
......................................................................
cbfstool: Add hash to more than one region
COREBOOTB is for partition B for A/B recovery. It also has bootblock,
which has hash data.
Change-Id: I8f9a5baa2699468380b942b3bdc104cab78adf5f
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/cbfstool/cbfstool.c
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/85468/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/85468?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8f9a5baa2699468380b942b3bdc104cab78adf5f
Gerrit-Change-Number: 85468
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao.
Hello Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85467?usp=email
to look at the new patch set (#6).
Change subject: amdfwtool: Split the A/B level 2 with PSP level 1
......................................................................
amdfwtool: Split the A/B level 2 with PSP level 1
For later A/B recovery support, we put the A and B into seperated
regions. The ROMSIG and PSP L2 table are in another region. Then, We
split one amdfw.rom into three parts.
TODO: Identical test
Change-Id: Ie9230e333dc5b1eca5beee1d3a57e815764c3cf3
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
M util/amdfwtool/handle_file.c
M util/amdfwtool/opts.c
4 files changed, 64 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/85467/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/85467?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9230e333dc5b1eca5beee1d3a57e815764c3cf3
Gerrit-Change-Number: 85467
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Marshall Dawson, Matt DeVillier, Zheng Bao.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Marshall Dawson, Matt DeVillier, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85628?usp=email
to look at the new patch set (#8).
Change subject: cbfstool: Do not compress the BIOS binary if A/B recovery
......................................................................
cbfstool: Do not compress the BIOS binary if A/B recovery
The hash data in bootblock will be used for CBFS verification. If
bootblock is compressed, the hash is not in plain data.
Change-Id: I10db7ad44d2a92c143f46d9ee6fc7824b2ff0cc6
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/soc/amd/cezanne/Makefile.mk
M util/cbfstool/amdcompress.c
2 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/85628/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/85628?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10db7ad44d2a92c143f46d9ee6fc7824b2ff0cc6
Gerrit-Change-Number: 85628
Gerrit-PatchSet: 8
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao.
Hello Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85629?usp=email
to look at the new patch set (#6).
Change subject: cbfs: Add COREBOOTB as backup region for A/B recovery
......................................................................
cbfs: Add COREBOOTB as backup region for A/B recovery
When the CBFS verification fails, reboot from the B partition, which
is in region COREBOOTB.
Change-Id: I019af6fbeca46e0e35d739a028655051fb466b48
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/lib/cbfs.c
M util/cbfstool/platform_fixups.c
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/85629/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/85629?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I019af6fbeca46e0e35d739a028655051fb466b48
Gerrit-Change-Number: 85629
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Knox Chiou.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85666/comment/93057c0e_bed95a48?us… :
PS7, Line 9: Geralt
Rauru
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/f1e3df26_ed3593e4?us… :
PS7, Line 65: (get_adc_index(SKU_ID_HIGH_CHANNEL) << 4
We don't use VIN2 for neither Rauru nor Navi
https://review.coreboot.org/c/coreboot/+/85666/comment/f62387fc_b352e767?us… :
PS7, Line 66: get_adc_index(SKU_ID_LOW_CHANNEL))
@knoxchiou@google.com any suggestion for unprovisioned SKU ID ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece
Gerrit-Change-Number: 85666
Gerrit-PatchSet: 7
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Fri, 20 Dec 2024 07:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian.
Hello Kapil Porwal, Karthik Ramasubramanian, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85622?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by Kapil Porwal, Verified+1 by build bot (Jenkins)
Change subject: commonlib: Refactor CSE sync eventLog
......................................................................
commonlib: Refactor CSE sync eventLog
This patch enhances the readability of the CSE sync event
ELOG_TYPE_FW_CSE_SYNC by updating the event naming from "early and late
bootstage" to "pre and post memory."
BUG=b:379585294
TEST=boot verified on google/rex0 and google/rex64
without change:
```
rex-rev3 ~ # elogtool list
rex64-rev3 ~ # /media/usb/elogtool list
3 | 2024-01-01 22:25:59-0800 | Firmware CSE sync | Late CSE Sync
```
with change:
```
rex64-rev3 ~ # elogtool list
3 | 2024-12-17 02:22:36-0800 | Firmware CSE sync | Post RAM CSE Sync
```
Change-Id: Ia5db3ffb43b2ceac821de72ef9e88ed62e617d41
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/commonlib/bsd/include/commonlib/bsd/elog.h
M src/soc/intel/common/block/cse/cse_lite.c
M util/cbfstool/eventlog.c
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/85622/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85622?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5db3ffb43b2ceac821de72ef9e88ed62e617d41
Gerrit-Change-Number: 85622
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID
......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/23e04753_ab31fedc?us… :
PS7, Line 38: printk(BIOS_DEBUG, "AUXADC: channel=%u\n", channel);
: printk(BIOS_DEBUG, "AUXADC: VIN1=%d VIN2=%d\n", AUXADC_CHAN_VIN1, AUXADC_CHAN_VIN2);
These 2 logs don't seem needed.
https://review.coreboot.org/c/coreboot/+/85666/comment/3d19221a_0e3f7135?us… :
PS7, Line 41: printk(BIOS_DEBUG, "AUXADC: value=%d\n", value);
Don't need this either. We already print `value` in the other log below.
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/182d9f74_874d3733?us… :
PS7, Line 59: configure_audio();
Need `mt6363_init_pmif_arb`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85666?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece
Gerrit-Change-Number: 85666
Gerrit-PatchSet: 7
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 20 Dec 2024 07:10:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No