coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and ...
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85512?usp=email ) Change subject: mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel ...................................................................... mb/google/nissa/var/gothrax: Add probe and GPIO config for HDMI and touchpanel 1. Reuse DB_A (now DB_A_HDMI_LTE) as the HDMI switch. 2. Turn off the Type-C port C1 when using HDMI because both of them use the same interface in hardware. 3. Use TOUCH_PANEL_I2C_GENERIC (formerly TOUCH_PANEL_DISABLE) to support other screen models as we cannot have different fields to support individual touch screen models. BUG=b:365445053 TEST=emerge-nissa coreboot and run in DUT Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9 Signed-off-by: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85512 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Kyle Lin <kylelinck(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/variants/gothrax/fw_config.c M src/mainboard/google/brya/variants/gothrax/gpio.c M src/mainboard/google/brya/variants/gothrax/overridetree.cb M src/mainboard/google/brya/variants/gothrax/variant.c 4 files changed, 35 insertions(+), 23 deletions(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Kyle Lin: Looks good to me, but someone else must approve Kapil Porwal: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/gothrax/fw_config.c b/src/mainboard/google/brya/variants/gothrax/fw_config.c index 54f6095..4eed44c 100644 --- a/src/mainboard/google/brya/variants/gothrax/fw_config.c +++ b/src/mainboard/google/brya/variants/gothrax/fw_config.c @@ -28,7 +28,8 @@ void fw_config_gpio_padbased_override(struct pad_config *padbased_table) { - if (!fw_config_probe(FW_CONFIG(DB_USB, DB_C_A_LTE))) { + if (!(fw_config_probe(FW_CONFIG(DB_USB, DB_C_A_LTE)) || + fw_config_probe(FW_CONFIG(DB_USB, DB_A_HDMI_LTE)))) { printk(BIOS_INFO, "Disable LTE-related GPIO pins on gothrax.\n"); gpio_padbased_override(padbased_table, lte_disable_pads_gothrax, ARRAY_SIZE(lte_disable_pads_gothrax)); diff --git a/src/mainboard/google/brya/variants/gothrax/gpio.c b/src/mainboard/google/brya/variants/gothrax/gpio.c index 077c850..ae236fb 100644 --- a/src/mainboard/google/brya/variants/gothrax/gpio.c +++ b/src/mainboard/google/brya/variants/gothrax/gpio.c @@ -81,13 +81,6 @@ PAD_CFG_GPO(GPP_H20, 1, DEEP), }; -static const struct pad_config romstage_gpio_table_nontp[] = { - /* H12 : UART0_RTS# ==> SD_PERST_L */ - PAD_CFG_GPO(GPP_H12, 1, DEEP), - /* H20 : IMGCLKOUT1 ==> WLAN_PERST_L */ - PAD_CFG_GPO(GPP_H20, 1, DEEP), -}; - const struct pad_config *variant_gpio_override_table(size_t *num) { *num = ARRAY_SIZE(override_gpio_table); @@ -102,11 +95,6 @@ const struct pad_config *variant_romstage_gpio_table(size_t *num) { - if (fw_config_probe(FW_CONFIG(TOUCH_PANEL, TOUCH_PANEL_DISABLE))) { - *num = ARRAY_SIZE(romstage_gpio_table_nontp); - return romstage_gpio_table_nontp; - } else { - *num = ARRAY_SIZE(romstage_gpio_table); - return romstage_gpio_table; - } + *num = ARRAY_SIZE(romstage_gpio_table); + return romstage_gpio_table; } diff --git a/src/mainboard/google/brya/variants/gothrax/overridetree.cb b/src/mainboard/google/brya/variants/gothrax/overridetree.cb index 49078fe..2e81e89 100644 --- a/src/mainboard/google/brya/variants/gothrax/overridetree.cb +++ b/src/mainboard/google/brya/variants/gothrax/overridetree.cb @@ -3,7 +3,7 @@ option DB_NONE 0 option DB_C_A 1 option DB_C_A_LTE 2 - option DB_A 3 + option DB_A_HDMI_LTE 3 end field THERMAL_SOLUTION 2 option THERMAL_SOLUTION_PASSIVE 0 @@ -25,8 +25,8 @@ option WFC_ABSENT 1 end field TOUCH_PANEL 9 - option TOUCH_PANEL_ENABLE 0 - option TOUCH_PANEL_DISABLE 1 + option TOUCH_PANEL_I2C_HID 0 + option TOUCH_PANEL_I2C_GENERIC 1 end end @@ -231,7 +231,7 @@ register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 0x10 on - probe TOUCH_PANEL TOUCH_PANEL_ENABLE + probe TOUCH_PANEL TOUCH_PANEL_I2C_HID end end chip drivers/i2c/hid @@ -249,7 +249,23 @@ register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 0x41 on - probe TOUCH_PANEL TOUCH_PANEL_ENABLE + probe TOUCH_PANEL TOUCH_PANEL_I2C_HID + end + end + chip drivers/i2c/generic + register "hid" = ""ELAN0001"" + register "desc" = ""ELAN Touchscreen"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" + register "detect" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" + register "reset_delay_ms" = "150" + register "reset_off_delay_ms" = "1" + register "enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" + register "enable_delay_ms" = "6" + register "has_power_resource" = "1" + device i2c 10 on + probe TOUCH_PANEL TOUCH_PANEL_I2C_GENERIC end end end @@ -317,6 +333,7 @@ register "input_analog_gain" = "3" device i2c 28 on probe DB_USB DB_C_A_LTE + probe DB_USB DB_A_HDMI_LTE end end end @@ -396,7 +413,10 @@ chip drivers/intel/pmc_mux/conn use usb2_port2 as usb2_port use tcss_usb3_port2 as usb3_port - device generic 1 alias conn1 on end + device generic 1 alias conn1 on + probe DB_USB DB_C_A + probe DB_USB DB_C_A_LTE + end end end end @@ -469,6 +489,7 @@ register "type" = "UPC_TYPE_INTERNAL" device ref usb2_port5 on probe DB_USB DB_C_A_LTE + probe DB_USB DB_A_HDMI_LTE end end chip drivers/usb/acpi @@ -516,6 +537,7 @@ register "type" = "UPC_TYPE_INTERNAL" device ref usb3_port3 on probe DB_USB DB_C_A_LTE + probe DB_USB DB_A_HDMI_LTE end end end diff --git a/src/mainboard/google/brya/variants/gothrax/variant.c b/src/mainboard/google/brya/variants/gothrax/variant.c index a1fdc23..8b8822b 100644 --- a/src/mainboard/google/brya/variants/gothrax/variant.c +++ b/src/mainboard/google/brya/variants/gothrax/variant.c @@ -7,7 +7,8 @@ void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config) { - if (!fw_config_probe(FW_CONFIG(DB_USB, DB_C_A_LTE))) { + if (!(fw_config_probe(FW_CONFIG(DB_USB, DB_C_A_LTE)) || + fw_config_probe(FW_CONFIG(DB_USB, DB_A_HDMI_LTE)))) { printk(BIOS_INFO, "Disable usb2_port5 and usb3_port3 of WWAN.\n"); config->usb2_ports[4].enable = 0; @@ -33,7 +34,7 @@ config->usb2_ports[6].pre_emp_bit = USB2_HALF_BIT_PRE_EMP; } - if (fw_config_probe(FW_CONFIG(DB_USB, DB_A))) { + if (fw_config_probe(FW_CONFIG(DB_USB, DB_A_HDMI_LTE))) { printk(BIOS_INFO, "Disable typec aux_bias_pads in the SOC.\n"); config->typec_aux_bias_pads[1].pad_auxp_dc = 0x00; config->typec_aux_bias_pads[1].pad_auxn_dc = 0x00; -- To view, visit https://review.coreboot.org/c/coreboot/+/85512?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1900658f7c2e09180287a4e61f02e04be203b6e9 Gerrit-Change-Number: 85512 Gerrit-PatchSet: 7 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jiping He <jiping.he(a)ecs.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: docs/security/vboot: Update supported boards
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85682?usp=email ) Change subject: docs/security/vboot: Update supported boards ...................................................................... docs/security/vboot: Update supported boards Change-Id: I9785a0b06f4cb97970be6aadc47bf3f7c37c9f20 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85682 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M Documentation/security/vboot/list_vboot.md 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index a38eb24..bf6fcc0 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -84,6 +84,7 @@ - Redrix - Redrix4ES - Riven +- Rull - Skolas - Skolas4ES - Taeko @@ -94,6 +95,7 @@ - Tivviks - Trulo - Uldren +- Uldrenite - Vell - Volmar - Xivu @@ -106,7 +108,9 @@ - Yavista - Sundance - Pujjoga +- Pujjogatwin - Orisa +- Telith - Butterfly (HP Pavilion Chromebook 14) - Cherry - Dojo @@ -139,6 +143,11 @@ - Drallion - Eve (Google Pixelbook) - Fatcat +- Fatcat_ish +- Fatcatite +- Fatcatnuvo +- Felino +- Francka - Fizz - Karma - Endeavour @@ -242,6 +251,8 @@ - Puff - Scout - Wyvern (CTL Chromebox CBx2) +- Hylia +- Navi - Rauru - Reef/Electro (Acer Chromebook Spin 11 R751T) - Pyro (Lenovo Thinkpad (Yoga) 11e Chromebook) @@ -261,6 +272,7 @@ - Rex 64 - Screebo - Screebo4ES +- Kanix - Arcada (Latitude 5300 2-in-1 Chromebook Enterprise) - Sarien (Dell Latitude 5400 Chromebook Enterprise) - Crystaldrift @@ -268,6 +280,7 @@ - Markarth (Acer Chromebook Plus 514) - Skyrim - Winterhold (Dell Latitude 3445 Chromebook) +- Skywalker - Falco (HP Chromebook 14) - Leon (Toshiba Chromebook) - Peppy (Acer C720/C720P Chromebook) @@ -326,6 +339,9 @@ - Woomax (ASUS Chromebook Flip CM5) ## HP +- Compaq 8200 Elite SFF +- Compaq 8200 Elite USDT +- Compaq 8300 Elite SFF - Compaq Elite 8300 USDT - Z220 CMT Workstation - Z220 SFF Workstation @@ -423,6 +439,7 @@ - MC APL7 ## Star Labs +- Star Labs Byte Mk II (N200) - Star Labs Lite Mk III (N5000) - Star Labs Lite Mk IV (N5030) - Star Labs LabTop Mk III (i7-8550u) @@ -430,6 +447,7 @@ - Star Labs StarBook Mk V (i3-1115G4 and i7-1165G7) - Star Labs StarBook Mk VI (i3-1220P and i7-1260P) - Star Labs StarBook Mk VI (i3-1315U and i7-1360P) +- Star Labs StarFighter Mk I (i3-1315U, i7-13700H and i9-13900H) - Star Labs Lite Mk V (N200) ## Supermicro -- To view, visit https://review.coreboot.org/c/coreboot/+/85682?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9785a0b06f4cb97970be6aadc47bf3f7c37c9f20 Gerrit-Change-Number: 85682 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: docs/security/vboot: Update supported boards
by Matt DeVillier (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Felix Singer. Matt DeVillier has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85682?usp=email ) Change subject: docs/security/vboot: Update supported boards ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85682?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9785a0b06f4cb97970be6aadc47bf3f7c37c9f20 Gerrit-Change-Number: 85682 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 04:15:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: docs: Add 24.12 release notes
by Matt DeVillier (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth. Matt DeVillier has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85683?usp=email ) Change subject: docs: Add 24.12 release notes ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Gerrit-Change-Number: 85683 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 04:12:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/ifdtool: Fix memory leaks
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Matt Turner, Stefan Reinauer. Subrata Banik has posted comments on this change by Matt Turner. ( https://review.coreboot.org/c/coreboot/+/85684?usp=email ) Change subject: util/ifdtool: Fix memory leaks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife6114db99278c9a3fb8271410486b057ef822f6 Gerrit-Change-Number: 85684 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Turner <mattst88(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt Turner <mattst88(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 20 Dec 2024 04:10:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: docs: Add 24.12 release notes
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Hello Angel Pons, Jason Glenesk, Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85683?usp=email to look at the new patch set (#6). Change subject: docs: Add 24.12 release notes ...................................................................... docs: Add 24.12 release notes Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A Documentation/releases/coreboot-24.12-relnotes.md 1 file changed, 337 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/85683/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Gerrit-Change-Number: 85683 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: docs: Add 24.12 release notes
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Hello Angel Pons, Jason Glenesk, Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85683?usp=email to look at the new patch set (#5). Change subject: docs: Add 24.12 release notes ...................................................................... docs: Add 24.12 release notes Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A Documentation/releases/coreboot-24.12-relnotes.md 1 file changed, 337 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/85683/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Gerrit-Change-Number: 85683 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Enable FPS
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Pranava Y N. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85687?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Enable FPS ...................................................................... mb/google/fatcat/var/fatcat: Enable FPS Lists of changes: - GPIO programmimg FPMCU_PWREN -> GPP_E19 -> OUTPUT SOC_INT_L -> GPP_D1 -> INPUT FPMCU_FW_UPDATE -> GPP_E20 -> NF1 FPS_RST_N -> GPP_C15 -> OUTPUT GPP_F16_GSPI0A_CLK -> GPP_F16 -> SPI CLK -> NF8 GPP_F15_GSPI0A_MISO -> GPP_F15 -> SPI MISO -> NF8 GPP_F14_GPSI0A_MOSI -> GPP_F14 -> SPI MOSI -> NF8 GPP_F18_GSPI0A_CS0 -> GPP_F18 -> SPI CS -> NF8 - ACPI Entry - Keep ISH (0x12.0) enable for GSPI0A to be operational BUG=b:377595986 TEST=TBD Change-Id: Ifced5c779407b4ffcc69a7ed1297704def09b554 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/fatcat/variants/fatcat/gpio.c M src/mainboard/google/fatcat/variants/fatcat/overridetree.cb 2 files changed, 42 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/85687/1 diff --git a/src/mainboard/google/fatcat/variants/fatcat/gpio.c b/src/mainboard/google/fatcat/variants/fatcat/gpio.c index 47a5c3a..0a524b7 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/gpio.c +++ b/src/mainboard/google/fatcat/variants/fatcat/gpio.c @@ -130,8 +130,8 @@ PAD_CFG_NF(GPP_C13, NONE, DEEP, NF1), /* GPP_C14: CLKREQ5_X1_GEN4_M2_WWAN_N */ PAD_CFG_NF(GPP_C14, NONE, DEEP, NF1), - /* GPP_C15: CRD1_CLK_EN */ - PAD_CFG_GPO(GPP_C15, 1, PLTRST), + /* GPP_C15: FPS_RST_N */ + PAD_CFG_GPO_LOCK(GPP_C15, 1, LOCK_CONFIG), /* GPP_C16: TBT_LSX0_TXD */ PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* GPP_C17: TBT_LSX0_RXD */ @@ -151,8 +151,8 @@ /* GPP_D00: IMGCLKOUT_1 */ PAD_CFG_NF(GPP_D00, NONE, DEEP, NF1), - /* GPP_D01: MOD_TCSS1_TYP_A_VBUS_EN */ - PAD_CFG_GPO(GPP_D01, 1, DEEP), + /* GPP_D01 : [] ==> FPS_SOC_INT_L */ + PAD_CFG_GPI_IRQ_WAKE(GPP_D01, NONE, PWROK, LEVEL, INVERT), /* GPP_D02: Not used */ PAD_NC(GPP_D02, NONE), /* GPP_D03: M.2_WWAN_PERST_GPIO_N */ @@ -234,10 +234,10 @@ PAD_CFG_NF(GPP_E17, NONE, DEEP, NF3), /* GPP_E18: THC0_SPI1_INT_N_TCH_PNL1 */ PAD_CFG_NF(GPP_E18, NONE, DEEP, NF3), - /* GPP_E19: PEG_SLOT_DGPU_SEL_N */ - PAD_CFG_GPO(GPP_E19, 1, PLTRST), - /* GPP_E20: PEG_SLOT_DGPU_PWR_OK */ - PAD_CFG_GPI(GPP_E20, NONE, PLTRST), + /* GPP_E19: FPMCU_PWREN */ + PAD_CFG_GPO(GPP_E19, 1, DEEP), + /* GPP_E20: FPMCU_FW_UPDATE */ + PAD_CFG_GPO_LOCK(GPP_E20, 0, LOCK_CONFIG), /* GPP_E21: I2C_PMC_PD_INT_N */ PAD_CFG_NF(GPP_E21, NONE, DEEP, NF1), /* GPP_E22: THC0_SPI1_DSYNC */ @@ -277,16 +277,16 @@ PAD_CFG_NF(GPP_F12, NONE, DEEP, NF8), /* GPP_F13: THC_I2C1_SDA_TCH_PAD */ PAD_CFG_NF(GPP_F13, NONE, DEEP, NF8), - /* GPP_F14: Not used */ - PAD_NC(GPP_F14, NONE), - /* GPP_F15: Not used */ - PAD_NC(GPP_F15, NONE), - /* GPP_F16: Not used */ - PAD_NC(GPP_F16, NONE), + /* GPP_F14: GPP_F14_GPSI0A_MOSI */ + PAD_CFG_NF(GPP_F14, NONE, DEEP, NF8), + /* GPP_F15: GPP_F15_GSPI0A_MISO */ + PAD_CFG_NF(GPP_F15, NONE, DEEP, NF8), + /* GPP_F16: GPP_F16_GPSI0A_CLK */ + PAD_CFG_NF(GPP_F16, NONE, DEEP, NF8), /* GPP_F17: Not used */ PAD_CFG_GPI_INT(GPP_F17, NONE, PLTRST, EDGE_BOTH), - /* GPP_F18: TCH_PAD_INT_N */ - PAD_CFG_GPI_APIC(GPP_F18, NONE, PLTRST, EDGE_SINGLE, INVERT), + /* GPP_F18: GPP_F18_GSPI0A_CS0 */ + PAD_CFG_NF(GPP_F18, NONE, DEEP, NF8), /* GPP_F19: GPP_PRIVACY_LED_CAM2 */ PAD_CFG_GPO(GPP_F19, 0, PLTRST), /* GPP_F20: GPP_PRIVACY_LED_CAM1_CVS_HST_WAKE */ @@ -413,6 +413,8 @@ PAD_CFG_NF(GPP_C00, NONE, DEEP, NF1), /* GPP_C01: GPP_C1_SMBDATA */ PAD_CFG_NF(GPP_C01, NONE, DEEP, NF1), + /* GPP_C15: FPS_RST_N */ + PAD_CFG_GPO(GPP_C15, 0, DEEP), }; const struct pad_config *variant_gpio_table(size_t *num) diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb index 44ea511..9bcdacd 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb @@ -107,6 +107,12 @@ [PchSerialIoIndexI2C5] = PchSerialIoPci, }" + register "serial_io_gspi_mode" = "{ + [PchSerialIoIndexGSPI0] = PchSerialIoDisabled, + [PchSerialIoIndexGSPI1] = PchSerialIoDisabled, + [PchSerialIoIndexGSPI0A] = PchSerialIoPci, + }" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -357,6 +363,7 @@ device ref ish on probe ISH ISH_ENABLE + probe FP FP_PRESENT chip drivers/intel/ish register "add_acpi_dma_property" = "true" device generic 0 on end @@ -777,5 +784,22 @@ end end end + device ref gspi0a on + chip drivers/spi/acpi + register "name" = ""CRFP"" + register "hid" = "ACPI_DT_NAMESPACE_HID" + register "uid" = "1" + register "compat_string" = ""google,cros-ec-spi"" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_D01_IRQ)" + register "wake" = "GPE0_DW1_01" + register "has_power_resource" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C15)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E19)" + register "enable_delay_ms" = "3" + device spi 0 on + probe FP FP_PRESENT + end + end # FPMCU + end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/85687?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifced5c779407b4ffcc69a7ed1297704def09b554 Gerrit-Change-Number: 85687 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Keep GSPIx interface default PCI
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Pranava Y N. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85686?usp=email ) Change subject: mb/google/fatcat: Keep GSPIx interface default PCI ...................................................................... mb/google/fatcat: Keep GSPIx interface default PCI BUG=b:377595986 TEST=Able to see 0x12.6 device is visible using `lspci`. Change-Id: Ia3348f78614e61259333ccf2babf20eaf4666a0e Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85686/1 diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb b/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb index f3a0a65..b9dcbbd 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb +++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb @@ -51,6 +51,12 @@ [PchSerialIoIndexUART2] = PchSerialIoDisabled, }" + register "serial_io_gspi_mode" = "{ + [PchSerialIoIndexGSPI0] = PchSerialIoPci, + [PchSerialIoIndexGSPI1] = PchSerialIoPci, + [PchSerialIoIndexGSPI0A] = PchSerialIoPci, + }" + register "pch_hda_dsp_enable" = "true" register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T" register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ" -- To view, visit https://review.coreboot.org/c/coreboot/+/85686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3348f78614e61259333ccf2babf20eaf4666a0e Gerrit-Change-Number: 85686 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Rename GSPI2 to GSPI0A
by Subrata Banik (Code Review) 20 Dec '24

20 Dec '24

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85685?usp=email ) Change subject: soc/intel/pantherlake: Rename GSPI2 to GSPI0A ...................................................................... soc/intel/pantherlake: Rename GSPI2 to GSPI0A Rename GSPI2 to GSPI0A to align with the latest Intel documentation and platform specifications (doc: 815002) BUG=b:377595986 TEST=Able to see 0x12.6 device is visible using `lspci`. Change-Id: I9b87d38e44c07a053104b53df38ee1ce14a86c7f Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/pantherlake/chipset.cb M src/soc/intel/pantherlake/include/soc/serialio.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/85685/1 diff --git a/src/soc/intel/pantherlake/chipset.cb b/src/soc/intel/pantherlake/chipset.cb index 67e0785..0f7967b 100644 --- a/src/soc/intel/pantherlake/chipset.cb +++ b/src/soc/intel/pantherlake/chipset.cb @@ -90,7 +90,7 @@ device pci 10.1 alias thc1 off end device pci 12.0 alias ish off end device pci 12.1 alias p2sb2 hidden end - device pci 12.6 alias gspi2 off end + device pci 12.6 alias gspi0a off end device pci 13.0 alias heci_1 off end device pci 13.1 alias heci_2 off end device pci 13.2 alias heci_3 off end diff --git a/src/soc/intel/pantherlake/include/soc/serialio.h b/src/soc/intel/pantherlake/include/soc/serialio.h index def5565..1c15001 100644 --- a/src/soc/intel/pantherlake/include/soc/serialio.h +++ b/src/soc/intel/pantherlake/include/soc/serialio.h @@ -23,7 +23,7 @@ enum { PchSerialIoIndexGSPI0, PchSerialIoIndexGSPI1, - PchSerialIoIndexGSPI2, + PchSerialIoIndexGSPI0A, }; enum { -- To view, visit https://review.coreboot.org/c/coreboot/+/85685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b87d38e44c07a053104b53df38ee1ce14a86c7f Gerrit-Change-Number: 85685 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024