coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[L] Change in coreboot[main]: docs: Add 24.12 release notes
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Hello Angel Pons, Jason Glenesk, Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85683?usp=email to look at the new patch set (#4). Change subject: docs: Add 24.12 release notes ...................................................................... docs: Add 24.12 release notes Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A Documentation/releases/coreboot-24.12-relnotes.md 1 file changed, 336 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/85683/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Gerrit-Change-Number: 85683 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/ifdtool: Fix memory leaks
by Matt Turner (Code Review) 20 Dec '24

20 Dec '24

Matt Turner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85684?usp=email ) Change subject: util/ifdtool: Fix memory leaks ...................................................................... util/ifdtool: Fix memory leaks This allows building coreboot with AddressSanitizer on ChromeOS. Otherwise these memory leaks are detected which cause the build to fail. Change-Id: Ife6114db99278c9a3fb8271410486b057ef822f6 Signed-off-by: Matt Turner <mattst88(a)gmail.com> --- M util/ifdtool/ifdtool.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/85684/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index ace05e2..94105ef 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -2246,8 +2246,7 @@ int mode_layout = 0, mode_newlayout = 0, mode_density = 0, mode_setstrap = 0; int mode_read = 0, mode_altmedisable = 0, altmedisable = 0, mode_fmap_template = 0; int mode_gpr0_disable = 0, mode_gpr0_enable = 0, mode_gpr0_status = 0; - char *region_type_string = NULL, *region_fname = NULL; - const char *layout_fname = NULL; + char *region_type_string = NULL, *region_fname = NULL, *layout_fname = NULL; char *new_filename = NULL; int region_type = -1, inputfreq = 0; unsigned int value = 0; @@ -2682,6 +2681,8 @@ write_image(new_filename, image, size); } + free(region_type_string); + free(layout_fname); free(new_filename); free(image); -- To view, visit https://review.coreboot.org/c/coreboot/+/85684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife6114db99278c9a3fb8271410486b057ef822f6 Gerrit-Change-Number: 85684 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Turner <mattst88(a)gmail.com>

1 0

[L] Change in coreboot[main]: docs: Add 24.12 release notes
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Hello Angel Pons, Jason Glenesk, Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85683?usp=email to look at the new patch set (#3). Change subject: docs: Add 24.12 release notes ...................................................................... docs: Add 24.12 release notes Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A Documentation/releases/coreboot-24.12-relnotes.md 1 file changed, 325 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/85683/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Gerrit-Change-Number: 85683 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: docs: Add 24.12 release notes
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Hello Angel Pons, Jason Glenesk, Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85683?usp=email to look at the new patch set (#2). Change subject: docs: Add 24.12 release notes ...................................................................... docs: Add 24.12 release notes Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A Documentation/releases/coreboot-24.12-relnotes.md 1 file changed, 324 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/85683/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Gerrit-Change-Number: 85683 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: docs: Add 24.12 release notes
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85683?usp=email ) Change subject: docs: Add 24.12 release notes ...................................................................... docs: Add 24.12 release notes Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A Documentation/releases/coreboot-24.12-relnotes.md 1 file changed, 321 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/85683/1 diff --git a/Documentation/releases/coreboot-24.12-relnotes.md b/Documentation/releases/coreboot-24.12-relnotes.md new file mode 100644 index 0000000..c5e274b --- /dev/null +++ b/Documentation/releases/coreboot-24.12-relnotes.md @@ -0,0 +1,321 @@ +Upcoming release - coreboot 24.12 +================================= + +The 24.12 release is scheduled for the end of December, 2024. + + +Significant or interesting changes +---------------------------------- + +### drivers/option: Add forms in cbtables + +Introduce a mechanism so that coreboot can provide a list of options to +post-coreboot code. The options are grouped together into forms and +have a meaning name and optional help text. This can be used to let +payloads know which options should be displayed in a setup menu, +for instance. Although this system was written to be used with edk2, +it has been designed with flexibility in mind so that other payloads +can also make use of this mechanism. The system currently lacks a way +to describe where to find option values. + +This information is stored in a set of data structures specifically +created for this purpose. This format is known as CFR, which means +"coreboot forms representation" or "cursed forms representation". +Although the "forms representation" is borrowed from UEFI, CFR can +be used in non-UEFI scenarios as well. + +The data structures are implemented as an extension of cbtables records +to support nesting. It should not break backwards compatibility because +the CFR root record (LB_TAG_CFR_ROOT) size includes all of its children +records. The concept of record nesting is borrowed from the records for +CMOS options. It is not possible to reuse the CMOS records because they +are too closely coupled with CMOS options; using these structures would +needlessly restrict more capable backends to what can be done with CMOS +options, which is undesired. + +Because CFR supports variable-length components, directly transforming +options into CFR structures is not a trivial process. Furthermore, CFR +structures need to be written in one go. Because of this, abstractions +exist to generate CFR structures from a set of "setup menu" structures +that are coreboot-specific and could be integrated with the devicetree +at some point. Note that `struct sm_object` is a tagged union. This is +used to have lists of options in an array, as building linked lists of +options at runtime is extremely impractical because options would have +to be added at the end of the linked list to maintain option order. To +avoid mistakes defining `struct sm_object` values, helper macros exist +for supported option types. The macros also provide some type checking +as they initialise specific union members. + +It should be possible to extend CFR support for more sophisticated +options like fan curve points. + + +### Makefile.mk: Skip unnecessary recompiles when static.{c,h} are updated + +The generated static.c file output by sconfig is currently added as a +prerequisite for all objects to ensure that static.h exists before +compiling anything that might need it. However, this forces every single +object out of date when the compiled devicetree is updated, even though +not every file actually needs static.h. + +Only static.h actually needs to exist before compilation of other +objects, since static.c is an independent compilation unit that doesn't +need to exist before other objects can be built. Thus, change the +prerequisite from static.c to static.h, and add a rule for static.h that +depends on static.c. The recipe is a simple `true` since sconfig +generates static.c and static.h at the same time. To prevent unnecessary +recompiles, make static.h an order-only prerequisite [1] using the new +generated files argument for create_cc_template to ensure that the +header exists before any object might need it, but without forcing a +recompile of all objects by default whenever it is updated. + +On a clean build, all objects will be compiled since they do not exist, +and these will occur after static.h is generated due to the default +order-only prerequisite. On subsequent incremental compiles, sources +that do need static.h will be appropriately marked out of date due to +the generated .d dependency files from the compiler, which list static.h +as a normal prerequisite for each objects that do include it, which +overrides the default order-only prerequisite. The dependency files +generated for all other objects will not include static.h, and thus the +objects will not be updated since the default order-only dependency does +not force them out of date. + +After updating the devicetree of qemu-i440fx after a clean build, +comparing the build log with `make --debug=why` with the generated +dependency files indicates that only objects that actually depend on +static.h were rebuilt, instead of every object. Running a timeless +incremental build after making a change in the devicetree yielded +identical roms when performed with this patch and main, with the only +difference being the number of objects that needed to be rebuilt. Also +tested with the E6430. + +[1] https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html + + +### sconfig: Move config_of_soc from device.h to static.h + +Many sources include device.h and thus static.h, but many only need the +function declarations and type definitions, not the compiled devicetree +from sconfig. This causes many unnecessary recompiles whenever the +devicetree is updated due to the dependency. Address this by moving the +config_of_soc macro directly into the generated static.h header, as it +seems to be the only line in device.h that actually requires static.h. +For now, static.h remains included in device.h so that the build is not +affected. Subsequent commits will include static.h directly into sources +that actually need it, after which it can be dropped from device.h. + +Some statistics for C objects: + +Dell Latitude E6400 (GM45/ICH9): +669 total objects +181 depend on static.h +2 require static.h + +Dell Latitude E6430 (Ivy Bridge/Panther Point): +693 total objects +199 depend on static.h +3 require static.h + +Lenovo ThinkCentre M700 / M900 Tiny (Kaby Lake): +794 total objects +298 depend on static.h +23 objects require static.h + +MSI PRO Z690-A (WIFI) DDR4 (Alder Lake): +959 total objects +319 depend on static.h +25 require static.h + +The number of objects was determined by grepping the build log for +calls to CC, the number of objects that depend on static.h was +determined by grepping for calls to CC after touching static.h, and the +number of objects that actually require the static.h related lines from +device.h was determined by grepping for objects that failed to build +after removing the static.h lines from device.h and running make with +the --keep-going flag. + + +### Makefile: Fix no-op incremental build + +If make is ran a second time after an initial clean compile, the entire +rom will be rebuilt. Subsequent calls to make will not rebuild the rom. +This initial rebuild was due to build/util/kconfig/conf being newer than +config.h, and the subsequent rebuild of the header marked everything +else as out of date. The reason conf was newer than config.h is because +it was being treated as an intermediate file [1]. In the rule for +config.h, conf is a prerequisite, but since it is treated as an +intermediate, its rule will not be run if config.h exists and all the +prerequisites of conf (i.e. its source files) are also up to date. + +On a clean build after a make menuconfig, config.h exists, satisfying +these conditions. In this case, config.h is treated as being up to date +even though conf does not exist. However, if another target does not +exist and also has conf as a prerequisite, conf will then be built so +that the target can be built. This caused conf to be newer than +config.h, but by default GNU Make deletes intermediate files after a +build which would prevent conf from affecting config.h on subsequent +rebuilds. + +However, commit dd6efce934fb ("Makefile: Add .SECONDARY") adds the +.SECONDARY special target, which prevents intermediate files from being +deleted after the build [2]. Thus, conf persists to the first no-op +build, making config.h out of date. Since config.h is updated during +this first rebuild, conf is no longer newer than it, and thus subsequent +no-op builds behave as expected. + +Fix this by preventing conf from being treated as an intermediate file +by adding it as a prerequisite of the .NOTINTERMEDIATE special target, +which causes conf to always be rebuilt if it does not exist. Thus, on +the initial clean compile, config.h will be updated after building conf +as a prerequisite, preventing config.h from being marked out of date on +a subsequent rebuild. + +[1] https://www.gnu.org/software/make/manual/html_node/Chained-Rules.html +[2] https://www.gnu.org/software/make/manual/html_node/Special-Targets.html + + +### drivers/efi/uefi_capsules.c: coalesce and store UEFI capsules + +How it approximately works: + +(During a normal system run): +1. OS puts a capsule into RAM and calls UpdateCapsule() function of EFI +runtime +2. If applying the update requires a reboot, EFI implementation creates +a new CapsuleUpdateData* EFI variable pointing at the beginning of +capsules description (not data, but description of the data) and does +a warm reboot leaving capsule data and its description in RAM to be +picked by firmware on the next boot process + +(After DEV_INIT:) +3. Capsules are discovered by checking for CapsuleUpdateData* variables +4. Capsule description in memory and capsule data is validated for +Sanity +5. Capsule data is coalesced into a continuous piece of memory + +(On BS_WRITE_TABLES via dasharo_add_capsules_to_bootmem() hook:) +6. Buffer with coalesced capsules is marked as reserved + +(On BS_WRITE_TABLES via lb_uefi_capsules() hook:) + +7. coreboot table entry is added for each of the discovered capsules + +(In UEFI payload:) +8. CapsuleUpdateData* get removed +9. coreboot table is checked for any update capsules which are then applied + + + +Additional coreboot changes +--------------------------- + +* Add Serial Flash Discoverable Parameters (SFDP) Support +* Add Replay Protected Monotonic Counter (RPMC) Support +* arch/arm64: Add Clang as supported compiler +* Add initial experimental Link-time Optimization (LTO) support +* util/scripts: Add script to capture commands from build +* Transform more devicetree options into booleans +* Make more mainboards using the AZALIA_PIN_DESC macro +* More effort for reworking the audio jacks setup +* libgfxinit: Add option to configure screen rotation +* Additional functions supposed in ACPI interface for Intel WiFi and BT devices + + + +Changes to external resources +----------------------------- + +### Toolchain updates + +* binutils from 2.42 to 2.43.1 +* GCC from 14.1.0 to 14.2.0 +* CMake from 3.29.3 to 3.30.2 +* LLVM from 18.1.6 to 18.1.8 + +### Git submodule pointers +* 3rdparty/arm-trusted-firmware: Update from commit id c5b8de86c8 to 15e5c6c91d (693 commits) +* 3rdparty/blobs: Update from commit id a8db7dfe82 to 14f8fcc1b4 (15 commits) +* 3rdparty/fsp: Update from commit id 800c85770b to 851f7105d8 (24 commits) +* 3rdparty/intel-microcode: Update from commit id 5278dfcf98 to 8ac9378a84 (4 commits) +* 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER + + + +### External payloads + +* U-Boot: Upgrade from 2024.04 to 2024.07 +* payloads/edk2: Update default branch for MrChromebox repo to 2024-08 + + +Platform Updates +---------------- + +### Added 39 mainboards: + +* Arm Neoverse N2 +* ASROCK IMB-1222 +* Dell Inc. Latitude E5420 +* Dell Inc. Latitude E5520 +* Dell Inc. Latitude E5530 +* Dell Inc. Latitude E6220 +* Dell Inc. Latitude E6230 +* Dell Inc. Latitude E6320 +* Dell Inc. Latitude E6330 +* Dell Inc. Latitude E6420 +* Dell Inc. Latitude E6520 +* Dell Inc. Latitude E6530 +* Dell Inc. OptiPlex 3050 Micro +* Erying Polestar G613 Pro (TGL-H) +* GIGABYTE GA-H77M-D3H +* Google -> Fatcat_ish +* Google -> Fatcatite +* Google -> Fatcatnuvo +* Google -> Felino +* Google -> Francka +* Google -> Hylia +* Google -> Kanix +* Google -> Navi +* Google -> Pujjogatwin +* Google -> Rull +* Google -> Skywalker +* Google -> Telith +* Google -> Uldrenite +* Hardkernel ODROID-H4 / H4+ / H4 Ultra +* HP Compaq 8200 Elite USDT +* HP Compaq 8300 Elite SFF +* Intel Frost Creek +* LattePanda LattePanda Mu +* Lenovo ThinkCentre M920 Tiny +* MiTAC Computing Whitestone 2 +* Star Labs Star Labs Byte Mk II (N200) +* Star Labs Star Labs StarFighter Mk I (i3-1315U, i7-13700H and i9-13900H) +* Topton X2F_N100 +* VIA EPIA-EX (work in progress) + + +### Updated CPUs/SoCs +* Via C7 +* Intel Pantherlake +* Intel Snowridge +* Intel Xeon SP +* MediaTek MT8196 + + + +Statistics from the 24.08 to the 24.12 release +-------------------------------------------- +* Total commits: 970 +* Total authors: 126 +* New authors: 20 + + + +coreboot Links and Contact Information +-------------------------------------- + +* Main Web site: https://www.coreboot.org +* Downloads: https://coreboot.org/downloads.html +* Source control: https://review.coreboot.org +* Documentation: https://doc.coreboot.org +* Issue tracker: https://ticket.coreboot.org/projects/coreboot +* Donations: https://coreboot.org/donate.html -- To view, visit https://review.coreboot.org/c/coreboot/+/85683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifeb88a1bb4f05183ac9274de9b26970b6155017d Gerrit-Change-Number: 85683 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: docs/security/vboot: Update supported boards
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85682?usp=email ) Change subject: docs/security/vboot: Update supported boards ...................................................................... docs/security/vboot: Update supported boards Change-Id: I9785a0b06f4cb97970be6aadc47bf3f7c37c9f20 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/security/vboot/list_vboot.md 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/85682/1 diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index a38eb24..bf6fcc0 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -84,6 +84,7 @@ - Redrix - Redrix4ES - Riven +- Rull - Skolas - Skolas4ES - Taeko @@ -94,6 +95,7 @@ - Tivviks - Trulo - Uldren +- Uldrenite - Vell - Volmar - Xivu @@ -106,7 +108,9 @@ - Yavista - Sundance - Pujjoga +- Pujjogatwin - Orisa +- Telith - Butterfly (HP Pavilion Chromebook 14) - Cherry - Dojo @@ -139,6 +143,11 @@ - Drallion - Eve (Google Pixelbook) - Fatcat +- Fatcat_ish +- Fatcatite +- Fatcatnuvo +- Felino +- Francka - Fizz - Karma - Endeavour @@ -242,6 +251,8 @@ - Puff - Scout - Wyvern (CTL Chromebox CBx2) +- Hylia +- Navi - Rauru - Reef/Electro (Acer Chromebook Spin 11 R751T) - Pyro (Lenovo Thinkpad (Yoga) 11e Chromebook) @@ -261,6 +272,7 @@ - Rex 64 - Screebo - Screebo4ES +- Kanix - Arcada (Latitude 5300 2-in-1 Chromebook Enterprise) - Sarien (Dell Latitude 5400 Chromebook Enterprise) - Crystaldrift @@ -268,6 +280,7 @@ - Markarth (Acer Chromebook Plus 514) - Skyrim - Winterhold (Dell Latitude 3445 Chromebook) +- Skywalker - Falco (HP Chromebook 14) - Leon (Toshiba Chromebook) - Peppy (Acer C720/C720P Chromebook) @@ -326,6 +339,9 @@ - Woomax (ASUS Chromebook Flip CM5) ## HP +- Compaq 8200 Elite SFF +- Compaq 8200 Elite USDT +- Compaq 8300 Elite SFF - Compaq Elite 8300 USDT - Z220 CMT Workstation - Z220 SFF Workstation @@ -423,6 +439,7 @@ - MC APL7 ## Star Labs +- Star Labs Byte Mk II (N200) - Star Labs Lite Mk III (N5000) - Star Labs Lite Mk IV (N5030) - Star Labs LabTop Mk III (i7-8550u) @@ -430,6 +447,7 @@ - Star Labs StarBook Mk V (i3-1115G4 and i7-1165G7) - Star Labs StarBook Mk VI (i3-1220P and i7-1260P) - Star Labs StarBook Mk VI (i3-1315U and i7-1360P) +- Star Labs StarFighter Mk I (i3-1315U, i7-13700H and i9-13900H) - Star Labs Lite Mk V (N200) ## Supermicro -- To view, visit https://review.coreboot.org/c/coreboot/+/85682?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9785a0b06f4cb97970be6aadc47bf3f7c37c9f20 Gerrit-Change-Number: 85682 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8189: Initialize watchdog
by Yidi Lin (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu, Yu-Ping Wu. Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85678?usp=email ) Change subject: soc/mediatek/mt8189: Initialize watchdog ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I496fce91e52393db31fd1fb5a1c68d91b2ed073e Gerrit-Change-Number: 85678 Gerrit-PatchSet: 3 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 03:42:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8189: Initialize watchdog
by Vince Liu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85678?usp=email ) Change subject: soc/mediatek/mt8189: Initialize watchdog ...................................................................... Patch Set 3: (1 comment) File src/soc/mediatek/mt8189/bootblock.c: https://review.coreboot.org/c/coreboot/+/85678/comment/f2b8ed9a_882d38ae?us… : PS2, Line 4: #include <soc/wdt.h> > sort Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I496fce91e52393db31fd1fb5a1c68d91b2ed073e Gerrit-Change-Number: 85678 Gerrit-PatchSet: 3 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 03:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/common: Update timer macro name
by Vince Liu (Code Review) 20 Dec '24

20 Dec '24

Vince Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85681?usp=email ) Change subject: soc/mediatek/common: Update timer macro name ...................................................................... soc/mediatek/common: Update timer macro name Update timer macro name for common. The new ICs(e.g. mt8196, mt8189) will no longer use GPT, and in order to improve code readability, so replace GPT_MHZ of existing Soc's with macro name TIMER_MHZ. BUG=b:379008996 BRANCH=none TEST=Build pass, Macro name is correct. Change-Id: I02f18bfa5b5912f28e322d40cd46823a0095bbf4 Signed-off-by: Ke Zheng <ot_ke.zheng(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/common/include/soc/timer_v1.h M src/soc/mediatek/common/include/soc/timer_v2.h M src/soc/mediatek/common/timer.c M src/soc/mediatek/mt8173/timer.c M src/soc/mediatek/mt8196/timer.c 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/85681/1 diff --git a/src/soc/mediatek/common/include/soc/timer_v1.h b/src/soc/mediatek/common/include/soc/timer_v1.h index 8d64b5d..d71d270 100644 --- a/src/soc/mediatek/common/include/soc/timer_v1.h +++ b/src/soc/mediatek/common/include/soc/timer_v1.h @@ -7,7 +7,7 @@ #include <soc/timer_common.h> #include <types.h> -#define GPT_MHZ 13 +#define TIMER_MHZ 13 struct mtk_gpt_regs { u32 reserved1[24]; diff --git a/src/soc/mediatek/common/include/soc/timer_v2.h b/src/soc/mediatek/common/include/soc/timer_v2.h index 2305928..d4f854c 100644 --- a/src/soc/mediatek/common/include/soc/timer_v2.h +++ b/src/soc/mediatek/common/include/soc/timer_v2.h @@ -7,7 +7,7 @@ #include <soc/timer_common.h> #include <types.h> -#define GPT_MHZ 13 +#define TIMER_MHZ 13 enum { TIE_0_EN = 1 << 3, diff --git a/src/soc/mediatek/common/timer.c b/src/soc/mediatek/common/timer.c index 5feed34..5412a9e 100644 --- a/src/soc/mediatek/common/timer.c +++ b/src/soc/mediatek/common/timer.c @@ -27,7 +27,7 @@ void timer_monotonic_get(struct mono_time *mt) { - mono_time_set_usecs(mt, timer_raw_value() / GPT_MHZ); + mono_time_set_usecs(mt, timer_raw_value() / TIMER_MHZ); } void init_timer(void) diff --git a/src/soc/mediatek/mt8173/timer.c b/src/soc/mediatek/mt8173/timer.c index 0a9de6b..fc71877 100644 --- a/src/soc/mediatek/mt8173/timer.c +++ b/src/soc/mediatek/mt8173/timer.c @@ -18,5 +18,5 @@ */ write32(&mt8173_mcucfg->xgpt_idx, 0); /* Set clock mode to 13Mhz and enable XGPT */ - write32(&mt8173_mcucfg->xgpt_ctl, (0x1 | ((26 / GPT_MHZ) << 8))); + write32(&mt8173_mcucfg->xgpt_ctl, (0x1 | ((26 / TIMER_MHZ) << 8))); } diff --git a/src/soc/mediatek/mt8196/timer.c b/src/soc/mediatek/mt8196/timer.c index bf3f3ce..5db5c4a 100644 --- a/src/soc/mediatek/mt8196/timer.c +++ b/src/soc/mediatek/mt8196/timer.c @@ -9,5 +9,5 @@ { timer_prepare(); - raw_write_cntfrq_el0(GPT_MHZ * MHz); + raw_write_cntfrq_el0(TIMER_MHZ * MHz); } -- To view, visit https://review.coreboot.org/c/coreboot/+/85681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02f18bfa5b5912f28e322d40cd46823a0095bbf4 Gerrit-Change-Number: 85681 Gerrit-PatchSet: 1 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8189: Initialize watchdog
by Vince Liu (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Hung-Te Lin, Vince Liu, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85678?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8189: Initialize watchdog ...................................................................... soc/mediatek/mt8189: Initialize watchdog Add watchdog support for MT8189. BUG=b:379008996 BRANCH=none TEST=build pass and WDT makes DUT reboot when MTK_WDT_MODE_ENABLE is set. Change-Id: I496fce91e52393db31fd1fb5a1c68d91b2ed073e Signed-off-by: Vince Liu <vince-wl.liu(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8189/Makefile.mk M src/soc/mediatek/mt8189/bootblock.c A src/soc/mediatek/mt8189/include/soc/wdt.h A src/soc/mediatek/mt8189/wdt.c 4 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/85678/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I496fce91e52393db31fd1fb5a1c68d91b2ed073e Gerrit-Change-Number: 85678 Gerrit-PatchSet: 3 Gerrit-Owner: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Vince Liu <vince-wl.liu(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024